77097 2012-01-26 05:48:35 -0800 [GTK][WK2] Primary clipboard should be updated with the current selection in X11 platforms 2012-01-26 07:04:10 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo xan.lopez oldest_to_newest 543080 0 cgarcia 2012-01-26 05:48:35 -0800 This doesn't work in WebKit2 543084 1 124110 cgarcia 2012-01-26 05:52:26 -0800 Created attachment 124110 Patch It uses the same approach than wk1. 543121 2 124110 mrobinson 2012-01-26 06:57:14 -0800 Comment on attachment 124110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124110&action=review > Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:139 > + // Collapse the selection without clearing it Missing a period here. 543124 3 cgarcia 2012-01-26 07:04:10 -0800 Committed r106000: <http://trac.webkit.org/changeset/106000> 124110 2012-01-26 05:52:26 -0800 2012-01-26 06:57:14 -0800 Patch wk2-primary-clipboard.diff text/plain 4543 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyZDZmZTlmLi40MmFkYTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDEtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdW1dLMl0gUHJpbWFyeSBjbGlwYm9hcmQgc2hvdWxkIGJlIHVwZGF0 ZWQgd2l0aCB0aGUgY3VycmVudCBzZWxlY3Rpb24gaW4gWDExIHBsYXRmb3JtcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcwOTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRWRpdG9y Q2xpZW50OjpyZXNwb25kVG9DaGFuZ2VkU2VsZWN0aW9uKTogQ2FsbAorICAgICAgICBzZXRTZWxl Y3Rpb25QcmltYXJ5Q2xpcGJvYXJkSWZOZWVkZWQoKSB0byB1cGRhdGUgcHJpbWFyeSBjbGlwYm9h cmQKKyAgICAgICAgaW4gWDExIHBsYXRmb3Jtcy4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvZ3RrL1dlYkVkaXRvckNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmNv bGxhcHNlU2VsZWN0aW9uKTogQ2FsbGJhY2sgY2FsbGVkIHdoZW4gY2xlYXJpbmcKKyAgICAgICAg Y2xpcGJvYXJkIGNvbnRlbnRzLgorICAgICAgICAoV2ViS2l0OjpXZWJFZGl0b3JDbGllbnQ6OnNl dFNlbGVjdGlvblByaW1hcnlDbGlwYm9hcmRJZk5lZWRlZCk6CisgICAgICAgIFVwZGF5ZSBwcmlt YXJ5IGNsaXBib2FyZCB3aXRoIHRoZSBjdXJyZW50IHNlbGVjdGlvbi4KKwogMjAxMi0wMS0yNSAg TWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGluIHRvIGFuIGFs dGVybmF0ZSBsb2NhdGlvbiB3aGVuIFVTRV9TVEFHSU5HX0lOU1RBTExfUEFUSCBpcyBzZXQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVk aXRvckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkVkaXRvckNsaWVudC5jcHAKaW5kZXggZWZiNzViZS4uZjIyYjI2MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRp dG9yQ2xpZW50LmNwcApAQCAtMTk1LDkgKzE5NSwxMSBAQCB2b2lkIFdlYkVkaXRvckNsaWVudDo6 cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbihGcmFtZSogZnJhbWUpCiAgICAgdW5zaWduZWQgc3Rh cnQ7CiAgICAgdW5zaWduZWQgZW5kOwogICAgIG1fcGFnZS0+c2VuZChNZXNzYWdlczo6V2ViUGFn ZVByb3h5OjpEaWRDaGFuZ2VDb21wb3NpdGlvblNlbGVjdGlvbihmcmFtZS0+ZWRpdG9yKCktPmdl dENvbXBvc2l0aW9uU2VsZWN0aW9uKHN0YXJ0LCBlbmQpKSk7CisjZWxpZiBQTEFURk9STShHVEsp CisgICAgc2V0U2VsZWN0aW9uUHJpbWFyeUNsaXBib2FyZElmTmVlZGVkKGZyYW1lKTsKICNlbmRp ZgogfQotICAgIAorCiB2b2lkIFdlYkVkaXRvckNsaWVudDo6ZGlkRW5kRWRpdGluZygpCiB7CiAg ICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYlZpZXdEaWRFbmRFZGl0aW5nTm90aWZp Y2F0aW9uLCAoIldlYlZpZXdEaWRFbmRFZGl0aW5nTm90aWZpY2F0aW9uIikpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGll bnQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9y Q2xpZW50LmgKaW5kZXggNjY2NDI3NS4uOGYyNjIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5oCkBA IC0xMjEsNiArMTIxLDcgQEAgcHJpdmF0ZToKICNpZiBQTEFURk9STShHVEspCiAgICAgYm9vbCBl eGVjdXRlUGVuZGluZ0VkaXRvckNvbW1hbmRzKFdlYkNvcmU6OkZyYW1lKiwgVmVjdG9yPFdURjo6 U3RyaW5nPiwgYm9vbCkgT1ZFUlJJREU7CiAgICAgdm9pZCBnZXRFZGl0b3JDb21tYW5kc0Zvcktl eUV2ZW50KGNvbnN0IFdlYkNvcmU6OktleWJvYXJkRXZlbnQqLCBWZWN0b3I8V1RGOjpTdHJpbmc+ JikgT1ZFUlJJREU7CisgICAgdm9pZCBzZXRTZWxlY3Rpb25QcmltYXJ5Q2xpcGJvYXJkSWZOZWVk ZWQoV2ViQ29yZTo6RnJhbWUqKSBPVkVSUklERTsKICNlbmRpZgogCiAgICAgVGV4dENoZWNrZXJD bGllbnQqIHRleHRDaGVja2VyKCkgIE9WRVJSSURFIHsgcmV0dXJuIHRoaXM7IH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkVkaXRv ckNsaWVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L2d0ay9XZWJFZGl0b3JDbGllbnRHdGsuY3BwCmluZGV4IDk2NGEzOTUuLjhlMWMzOGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZ3RrL1dlYkVk aXRvckNsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9ndGsvV2ViRWRpdG9yQ2xpZW50R3RrLmNwcApAQCAtMjUsNyArMjUsOSBAQAogI2lu Y2x1ZGUgIldlYlBhZ2UuaCIKICNpbmNsdWRlICJXZWJQYWdlUHJveHlNZXNzYWdlcy5oIgogI2lu Y2x1ZGUgIldlYlByb2Nlc3MuaCIKKyNpbmNsdWRlIDxXZWJDb3JlL0RhdGFPYmplY3RHdGsuaD4K ICNpbmNsdWRlIDxXZWJDb3JlL0tleWJvYXJkRXZlbnQuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1Bh c3RlYm9hcmRIZWxwZXIuaD4KICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CiAK IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwpAQCAtMTI3LDQgKzEyOSwzOCBAQCB2b2lkIFdlYkVk aXRvckNsaWVudDo6aGFuZGxlSW5wdXRNZXRob2RLZXlkb3duKEtleWJvYXJkRXZlbnQqKQogICAg IG5vdEltcGxlbWVudGVkKCk7CiB9CiAKKyNpZiBQTEFURk9STShYMTEpCitzdGF0aWMgRnJhbWUq IGZyYW1lU2V0dGluZ0NsaXBib2FyZDsKK3N0YXRpYyB2b2lkIGNvbGxhcHNlU2VsZWN0aW9uKEd0 a0NsaXBib2FyZCogY2xpcGJvYXJkLCBGcmFtZSogZnJhbWUpCit7CisgICAgaWYgKGZyYW1lU2V0 dGluZ0NsaXBib2FyZCAmJiBmcmFtZVNldHRpbmdDbGlwYm9hcmQgPT0gZnJhbWUpCisgICAgICAg IHJldHVybjsKKworICAgIC8vIENvbGxhcHNlIHRoZSBzZWxlY3Rpb24gd2l0aG91dCBjbGVhcmlu ZyBpdAorICAgIEFTU0VSVChmcmFtZSk7CisgICAgZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRCYXNl KGZyYW1lLT5zZWxlY3Rpb24oKS0+ZXh0ZW50KCksIGZyYW1lLT5zZWxlY3Rpb24oKS0+YWZmaW5p dHkoKSk7Cit9CisjZW5kaWYKKwordm9pZCBXZWJFZGl0b3JDbGllbnQ6OnNldFNlbGVjdGlvblBy aW1hcnlDbGlwYm9hcmRJZk5lZWRlZChGcmFtZSogZnJhbWUpCit7CisjaWYgUExBVEZPUk0oWDEx KQorICAgIEd0a0NsaXBib2FyZCogY2xpcGJvYXJkID0gUGFzdGVib2FyZEhlbHBlcjo6ZGVmYXVs dFBhc3RlYm9hcmRIZWxwZXIoKS0+Z2V0UHJpbWFyeVNlbGVjdGlvbkNsaXBib2FyZChmcmFtZSk7 CisgICAgRGF0YU9iamVjdEd0ayogZGF0YU9iamVjdCA9IERhdGFPYmplY3RHdGs6OmZvckNsaXBi b2FyZChjbGlwYm9hcmQpOworCisgICAgaWYgKCFmcmFtZS0+c2VsZWN0aW9uKCktPmlzUmFuZ2Uo KSkKKyAgICAgICAgcmV0dXJuOworCisgICAgZGF0YU9iamVjdC0+Y2xlYXJBbGwoKTsKKyAgICBk YXRhT2JqZWN0LT5zZXRSYW5nZShmcmFtZS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdl KCkpOworCisgICAgZnJhbWVTZXR0aW5nQ2xpcGJvYXJkID0gZnJhbWU7CisgICAgR0Nsb3N1cmUq IGNhbGxiYWNrID0gZ19jY2xvc3VyZV9uZXcoR19DQUxMQkFDSyhjb2xsYXBzZVNlbGVjdGlvbiks IGZyYW1lLCAwKTsKKyAgICBnX2Nsb3N1cmVfc2V0X21hcnNoYWwoY2FsbGJhY2ssIGdfY2Nsb3N1 cmVfbWFyc2hhbF9WT0lEX19WT0lEKTsKKyAgICBQYXN0ZWJvYXJkSGVscGVyOjpkZWZhdWx0UGFz dGVib2FyZEhlbHBlcigpLT53cml0ZUNsaXBib2FyZENvbnRlbnRzKGNsaXBib2FyZCwgUGFzdGVi b2FyZEhlbHBlcjo6RG9Ob3RJbmNsdWRlU21hcnRQYXN0ZSwgY2FsbGJhY2spOworICAgIGZyYW1l U2V0dGluZ0NsaXBib2FyZCA9IDA7CisjZW5kaWYKK30KKworCiB9Cg==