77093 2012-01-26 04:34:27 -0800 [EFL] Added missing NETSCAPE_PLUGIN_API macro 2012-01-26 05:53:32 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned g.czajkowski gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 543062 0 t.morawski 2012-01-26 04:34:27 -0800 The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro. 543063 1 124104 t.morawski 2012-01-26 04:35:26 -0800 Created attachment 124104 Added missing macro 543074 2 rakuco 2012-01-26 05:17:43 -0800 Looks good. 543077 3 g.czajkowski 2012-01-26 05:27:06 -0800 LGTM too. 543087 4 124104 webkit.review.bot 2012-01-26 05:53:28 -0800 Comment on attachment 124104 Added missing macro Clearing flags on attachment: 124104 Committed r105996: <http://trac.webkit.org/changeset/105996> 543089 5 webkit.review.bot 2012-01-26 05:53:32 -0800 All reviewed patches have been landed. Closing bug. 124104 2012-01-26 04:35:26 -0800 2012-01-26 05:53:28 -0800 Added missing macro macro.patch text/plain 1338 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkODdlMDRjLi5iNmQ0ZDBhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDEtMjQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgbWlzc2luZyBORVRTQ0FQRV9QTFVH SU5fQVBJIG1hY3JvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzcwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgZXdrX3ZpZXdfanNfd2luZG93X29iamVjdF9jbGVhciBmdW5jdGlvbiBzaG91bGQg YmUgaW5zaWRlIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKSBtYWNyby4KKworICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisKIDIwMTItMDEtMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5n LmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBVc2Ugc3RhdGljIGNvbnN0IGluc3Rl ZCBvZiAjZGVmaW5lIG1hY3JvLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggZjMz ODViZC4uYTY4YmJhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0zNTM0LDYg KzM1MzQsNyBAQCB2b2lkIGV3a192aWV3X2Rvd25sb2FkX3JlcXVlc3QoRXZhc19PYmplY3QqIGV3 a1ZpZXcsIEV3a19Eb3dubG9hZCogZG93bmxvYWQpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2Fs bGJhY2tfY2FsbChld2tWaWV3LCAiZG93bmxvYWQscmVxdWVzdCIsIGRvd25sb2FkKTsKIH0KIAor I2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogLyoqCiAgKiBAaW50ZXJuYWwKICAqIFJl cG9ydHMgdGhlIEpTIHdpbmRvdyBvYmplY3Qgd2FzIGNsZWFyZWQuCkBAIC0zNTQ1LDYgKzM1NDYs NyBAQCB2b2lkIGV3a192aWV3X2pzX3dpbmRvd19vYmplY3RfY2xlYXIoRXZhc19PYmplY3QqIGV3 a1ZpZXcsIEV2YXNfT2JqZWN0KiBmcmFtZSkKIHsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxs YmFja19jYWxsKGV3a1ZpZXcsICJqcyx3aW5kb3dvYmplY3QsY2xlYXIiLCBmcmFtZSk7CiB9Cisj ZW5kaWYKIAogLyoqCiAgKiBAaW50ZXJuYWwK