77085 2012-01-26 02:56:16 -0800 [GStreamer] 0.11 build support 2012-01-31 00:03:50 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77005 1 pnormand webkit-unassigned slomo oldest_to_newest 543008 0 pnormand 2012-01-26 02:56:16 -0800 We need a new --with-gstreamer configure option and a macro to ease porting the existing code. 543014 1 124089 pnormand 2012-01-26 03:02:21 -0800 Created attachment 124089 0.11 build support 544956 2 slomo 2012-01-30 02:24:01 -0800 Looks good 545174 3 124089 mrobinson 2012-01-30 09:48:34 -0800 Comment on attachment 124089 0.11 build support View in context: https://bugs.webkit.org/attachment.cgi?id=124089&action=review Looks good, but fix the indentation and line breaking of the case statement. > configure.ac:272 > +# determine the (optional) GStreamer version to use You can just omit this. > configure.ac:277 > + [case "$with_gstreamer" in > + 0.10|0.11) ;; Your line breaks and indentation are a bit weird here. 545822 4 pnormand 2012-01-31 00:03:50 -0800 Committed r106340: <http://trac.webkit.org/changeset/106340> 124089 2012-01-26 03:02:21 -0800 2012-01-30 09:48:34 -0800 0.11 build support 011-build-support.patch text/plain 4499 pnormand RnJvbSBhZWRhOTM4NjI1Y2VmNzMxYzc4ZGI5OTgzNzNiNGY1M2RkODMxMzhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI2IEphbiAyMDEyIDEyOjAxOjQ3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g MC4xMSBidWlsZCBzdXBwb3J0CgotLS0KIENoYW5nZUxvZyAgICB8ICAgIDkgKysrKysrKysrCiBj b25maWd1cmUuYWMgfCAgIDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygrKSwgMTAgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDE2ZjM2 ZGUuLjkzYTdhYTQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMS0yNSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gMC4xMSBidWlsZCBzdXBwb3J0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzA4NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29uZmlndXJlLmFjOiBO ZXcgLS13aXRoLWdzdHJlYW1lciBvcHRpb24sIGRlZmF1bHRpbmcgdG8gMC4xMC4KKwogMjAxMi0w MS0yNSAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAg ICAgICA8c3R5bGUgc2NvcGVkPjogSW1wbGVtZW50IHJlZ2lzdGVyaW5nIG9mIDxzdHlsZSBzY29w ZWQ+IHdpdGggdGhlIHNjb3BpbmcgZWxlbWVudApkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIv Y29uZmlndXJlLmFjCmluZGV4IGIwMjU2ZjMuLjcwZTQ2NTcgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3Vy ZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTI2OSw2ICsyNjksMzkgQEAgaWYgdGVzdCAiJHdp dGhfaGlsZG9uIiA9ICJ5ZXMiOyB0aGVuCiAgICAgQUNfU1VCU1QoW0hJTERPTl9MSUJTXSkKIGZp CiAKKyMgZGV0ZXJtaW5lIHRoZSAob3B0aW9uYWwpIEdTdHJlYW1lciB2ZXJzaW9uIHRvIHVzZQor QUNfTVNHX0NIRUNLSU5HKFt0aGUgR1N0cmVhbWVyIHZlcnNpb24gdG8gdXNlXSkKK0FDX0FSR19X SVRIKFtnc3RyZWFtZXJdLAorICAgICAgICBbQVNfSEVMUF9TVFJJTkcoWy0td2l0aC1nc3RyZWFt ZXI9MC4xMHwwLjExXSwgW3RoZSBHU3RyZWFtZXIgdmVyc2lvbiB0byB1c2UgKGRlZmF1bHQ6IDAu MTApXSldLAorICAgICAgICBbY2FzZSAiJHdpdGhfZ3N0cmVhbWVyIiBpbgorICAgICAgICAwLjEw fDAuMTEpIDs7CisgICAgICAgICopIEFDX01TR19FUlJPUihbaW52YWxpZCBHU3RyZWFtZXIgdmVy c2lvbiBzcGVjaWZpZWRdKSA7OworICAgICAgICBlc2FjXSwKKyAgICAgICAgW3dpdGhfZ3N0cmVh bWVyPTAuMTBdKQorQUNfTVNHX1JFU1VMVChbJHdpdGhfZ3N0cmVhbWVyXSkKKworR1NUUkVBTUVS XzBfMTBfUkVRVUlSRURfVkVSU0lPTj0wLjEwCitHU1RSRUFNRVJfMF8xMF9QTFVHSU5TX0JBU0Vf UkVRVUlSRURfVkVSU0lPTj0wLjEwLjMwCitHU1RSRUFNRVJfMF8xMV9SRVFVSVJFRF9WRVJTSU9O PTAuMTEKK0dTVFJFQU1FUl8wXzExX1BMVUdJTlNfQkFTRV9SRVFVSVJFRF9WRVJTSU9OPTAuMTEu MC4yCisKK2Nhc2UgIiR3aXRoX2dzdHJlYW1lciIgaW4KKyAgICAgMC4xMCkgR1NUUkVBTUVSX1JF UVVJUkVEX1ZFUlNJT049R1NUUkVBTUVSXzBfMTBfUkVRVUlSRURfVkVSU0lPTgorICAgICAgICAg IEdTVFJFQU1FUl9QTFVHSU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTj1HU1RSRUFNRVJfMF8xMF9Q TFVHSU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTgorICAgICAgICAgIEdTVF9BUElfVkVSU0lPTj0w LjEwCisgICAgICAgICAgOzsKKyAgICAgMC4xMSkgR1NUUkVBTUVSX1JFUVVJUkVEX1ZFUlNJT049 R1NUUkVBTUVSXzBfMTFfUkVRVUlSRURfVkVSU0lPTgorICAgICAgICAgIEdTVFJFQU1FUl9QTFVH SU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTj1HU1RSRUFNRVJfMF8xMV9QTFVHSU5TX0JBU0VfUkVR VUlSRURfVkVSU0lPTgorICAgICAgICAgIEdTVF9BUElfVkVSU0lPTj0wLjExCisgICAgICAgICAg OzsKK2VzYWMKKworQUNfU1VCU1QoW0dTVF9BUElfVkVSU0lPTl0pCitpZiB0ZXN0ICIkR1NUX0FQ SV9WRVJTSU9OIiA9ICIwLjExIjsgdGhlbgorQUNfREVGSU5FKFtHU1RfVVNFX1VOU1RBQkxFX0FQ SV0sIFsxXSwgW1VzaW5nIHVuc3RhYmxlIEdTdHJlYW1lciBBUEldKQorQUNfREVGSU5FKFtHU1Rf QVBJX1ZFUlNJT05fMV0sWzFdLCBbVXNpbmcgR1N0cmVhbWVyIDAuMTFdKQorZmkKKwogIyBtaW5p bXVtIGJhc2UgZGVwZW5kZW5jaWVzCiBMSUJTT1VQX1JFUVVJUkVEX1ZFUlNJT049Mi4zNy4yLjEK IENBSVJPX1JFUVVJUkVEX1ZFUlNJT049MS4xMApAQCAtMjgyLDggKzMxNSw2IEBAIFBBTkdPX1JF UVVJUkVEX1ZFUlNJT049MS4xMgogIyBvcHRpb25hbCBtb2R1bGVzCiBMSUJYU0xUX1JFUVVJUkVE X1ZFUlNJT049MS4xLjcKIFNRTElURV9SRVFVSVJFRF9WRVJTSU9OPTMuMAotR1NUUkVBTUVSX1JF UVVJUkVEX1ZFUlNJT049MC4xMAotR1NUUkVBTUVSX1BMVUdJTlNfQkFTRV9SRVFVSVJFRF9WRVJT SU9OPTAuMTAuMzAKIEVOQ0hBTlRfUkVRVUlSRURfVkVSU0lPTj0wLjIyCiBMSUJGRlRXX1JFUVVJ UkVEX1ZFUlNJT049My4yLjIKIENMVVRURVJfUkVRVUlSRURfVkVSU0lPTj0xLjguMgpAQCAtMTAy NCwxNCArMTA1NSwxNCBAQCBmaQogIyBjaGVjayBpZiBnc3RyZWFtZXIgaXMgYXZhaWxhYmxlCiBp ZiB0ZXN0ICIkZW5hYmxlX3ZpZGVvIiA9ICJ5ZXMiIHx8IHRlc3QgIiRlbmFibGVfd2ViX2F1ZGlv IiA9ICJ5ZXMiOyB0aGVuCiAgICBQS0dfQ0hFQ0tfTU9EVUxFUyhbR1NUUkVBTUVSXSwKLSAgICAg ICAgICAgICAgICAgICAgIFtnc3RyZWFtZXItMC4xMCA+PSAkR1NUUkVBTUVSX1JFUVVJUkVEX1ZF UlNJT04KLSAgICAgICAgICAgICAgICAgICAgIGdzdHJlYW1lci1hcHAtMC4xMAotICAgICAgICAg ICAgICAgICAgICAgZ3N0cmVhbWVyLWF1ZGlvLTAuMTAKLSAgICAgICAgICAgICAgICAgICAgIGdz dHJlYW1lci1iYXNlLTAuMTAKLSAgICAgICAgICAgICAgICAgICAgIGdzdHJlYW1lci1pbnRlcmZh Y2VzLTAuMTAKLSAgICAgICAgICAgICAgICAgICAgIGdzdHJlYW1lci1wYnV0aWxzLTAuMTAKLSAg ICAgICAgICAgICAgICAgICAgIGdzdHJlYW1lci1wbHVnaW5zLWJhc2UtMC4xMCA+PSAkR1NUUkVB TUVSX1BMVUdJTlNfQkFTRV9SRVFVSVJFRF9WRVJTSU9OCi0gICAgICAgICAgICAgICAgICAgICBn c3RyZWFtZXItdmlkZW8tMC4xMF0sCisgICAgICAgICAgICAgICAgICAgICBbZ3N0cmVhbWVyLSRH U1RfQVBJX1ZFUlNJT04gPj0gJEdTVFJFQU1FUl9SRVFVSVJFRF9WRVJTSU9OCisgICAgICAgICAg ICAgICAgICAgICBnc3RyZWFtZXItYXBwLSRHU1RfQVBJX1ZFUlNJT04KKyAgICAgICAgICAgICAg ICAgICAgIGdzdHJlYW1lci1hdWRpby0kR1NUX0FQSV9WRVJTSU9OCisgICAgICAgICAgICAgICAg ICAgICBnc3RyZWFtZXItYmFzZS0kR1NUX0FQSV9WRVJTSU9OCisgICAgICAgICAgICAgICAgICAg ICBnc3RyZWFtZXItaW50ZXJmYWNlcy0kR1NUX0FQSV9WRVJTSU9OCisgICAgICAgICAgICAgICAg ICAgICBnc3RyZWFtZXItcGJ1dGlscy0kR1NUX0FQSV9WRVJTSU9OCisgICAgICAgICAgICAgICAg ICAgICBnc3RyZWFtZXItcGx1Z2lucy1iYXNlLSRHU1RfQVBJX1ZFUlNJT04gPj0gJEdTVFJFQU1F Ul9QTFVHSU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTgorICAgICAgICAgICAgICAgICAgICAgZ3N0 cmVhbWVyLXZpZGVvLSRHU1RfQVBJX1ZFUlNJT05dLAogICAgICAgICAgICAgICAgICAgICAgW2hh dmVfZ3N0cmVhbWVyPXllc10pCiAKICAgIEFDX1NVQlNUKFtHU1RSRUFNRVJfQ0ZMQUdTXSkKQEAg LTEzMTcsNiArMTM0OCw3IEBAIEdUSysgY29uZmlndXJhdGlvbjoKICBHVEsrIHZlcnNpb24gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICR3aXRoX2d0awogIEdE SyB0YXJnZXQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDog JHdpdGhfdGFyZ2V0CiAgSGlsZG9uIFVJIGV4dGVuc2lvbnMgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOiAkd2l0aF9oaWxkb24KKyBHU3RyZWFtZXIgdmVyc2lvbiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICR3aXRoX2dzdHJlYW1lcgogIEludHJv c3BlY3Rpb24gc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVu YWJsZV9pbnRyb3NwZWN0aW9uCiAgR2VuZXJhdGUgZG9jdW1lbnRhdGlvbiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2d0a19kb2MKICIKLS0gCjEuNy44LjM=