77079 2012-01-26 01:37:02 -0800 REGRESSION (r104746): iframes load PDFs as media documents 2012-02-09 09:31:27 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.cs.tut.fi/~jkorpela/html/iframe-pdf.html InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned ap manyoso mrowe webkit-bug-importer webkit.review.bot oldest_to_newest 542956 0 mitz 2012-01-26 01:37:02 -0800 To reproduce: navigate to the URL. Click inside a PDF and choose File > Print. Result: The iframes start out with a black background and movie playback controls, then change to PDF views. When printing, the print preview shows only the visible portion of the PDF, instead of the entire document. 542959 1 webkit-bug-importer 2012-01-26 01:38:01 -0800 <rdar://problem/10757933> 544360 2 ap 2012-01-27 14:21:27 -0800 Adam, is this something you intend to look into? 546059 3 manyoso 2012-01-31 08:02:02 -0800 (In reply to comment #2) > Adam, is this something you intend to look into? Speaking to me? 546062 4 manyoso 2012-01-31 08:06:34 -0800 (In reply to comment #3) > (In reply to comment #2) > > Adam, is this something you intend to look into? > > Speaking to me? https://bugs.webkit.org/show_bug.cgi?id=76088 I don't see how, but can someone look and see if ^^ regressed it? 546078 5 mitz 2012-01-31 08:21:08 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Adam, is this something you intend to look into? > > > > Speaking to me? > > https://bugs.webkit.org/show_bug.cgi?id=76088 > > I don't see how, but can someone look and see if ^^ regressed it? The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9. 546130 6 manyoso 2012-01-31 09:06:53 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Adam, is this something you intend to look into? > > > > > > Speaking to me? > > > > https://bugs.webkit.org/show_bug.cgi?id=76088 > > > > I don't see how, but can someone look and see if ^^ regressed it? > > The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9. Sorry Mitz, someone pointed this bug to me with no context, but it immediately struck a chord and I replied before reading the additional comment on 76088. I will indeed have a look. 552726 7 mrowe 2012-02-08 18:19:20 -0800 Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch. 552729 8 126214 mrowe 2012-02-08 18:22:43 -0800 Created attachment 126214 Patch to revert r104746. 553208 9 manyoso 2012-02-09 08:58:23 -0800 (In reply to comment #7) > Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch. I've looked and can't find the bug in the logic so revert is in order for now. Sorry guys. I'll continue to look. 553209 10 manyoso 2012-02-09 09:00:48 -0800 (In reply to comment #9) > (In reply to comment #7) > > Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch. > > I've looked and can't find the bug in the logic so revert is in order for now. Sorry guys. I'll continue to look. Probably be a lot easier to spot if I could build the Mac port to reproduce the regression. I recently acquired a macbook pro so I'll work on that. 553215 11 126214 ap 2012-02-09 09:13:59 -0800 Comment on attachment 126214 Patch to revert r104746. Thanks Adam! 553225 12 126214 webkit.review.bot 2012-02-09 09:31:22 -0800 Comment on attachment 126214 Patch to revert r104746. Clearing flags on attachment: 126214 Committed r107256: <http://trac.webkit.org/changeset/107256> 553226 13 webkit.review.bot 2012-02-09 09:31:27 -0800 All reviewed patches have been landed. Closing bug. 126214 2012-02-08 18:22:43 -0800 2012-02-09 09:31:22 -0800 Patch to revert r104746. 0001-REGRESSION-r104746-iframes-load-PDFs-as-media-docume.patch text/plain 4749 mrowe RnJvbSAzYThkMmU4MjVmZDVjMTkyYzhmZjA4MGNlNTkyZmM2NzQ3MTQxOGNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogV2Vk LCA4IEZlYiAyMDEyIDE4OjIxOjQ4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gUkVHUkVTU0lPTiAo cjEwNDc0Nik6IGlmcmFtZXMgbG9hZCBQREZzIGFzIG1lZGlhIGRvY3VtZW50cwogPGh0dHA6Ly93 ZWJraXQub3JnL2IvNzcwNzk+IC8gPHJkYXI6Ly9wcm9ibGVtLzEwNzU3OTMzPgoKUm9sbCBvdXQg cjEwNDc0NiBzaW5jZSBpdCBjb21wbGV0ZWx5IGJyb2tlIHN1cHBvcnQgZm9yIGxvYWRpbmcgUERG IGRvY3VtZW50cyBpbiBzdWJmcmFtZXMuCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiog ZG9tL0RPTUltcGxlbWVudGF0aW9uLmNwcDoKKFdlYkNvcmU6OkRPTUltcGxlbWVudGF0aW9uOjpj cmVhdGVEb2N1bWVudCk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICB8ICAgMTIgKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9kb20vRE9NSW1wbGVtZW50YXRp b24uY3BwIHwgICAzOSArKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAyNyBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjAy ZWI3OC4uMjk0NmM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA4ICBN YXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEwNDc0 Nik6IGlmcmFtZXMgbG9hZCBQREZzIGFzIG1lZGlhIGRvY3VtZW50cworICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi83NzA3OT4gLyA8cmRhcjovL3Byb2JsZW0vMTA3NTc5MzM+CisKKyAgICAg ICAgUm9sbCBvdXQgcjEwNDc0NiBzaW5jZSBpdCBjb21wbGV0ZWx5IGJyb2tlIHN1cHBvcnQgZm9y IGxvYWRpbmcgUERGIGRvY3VtZW50cyBpbiBzdWJmcmFtZXMuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRE9NSW1wbGVtZW50YXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RE9NSW1wbGVtZW50YXRpb246OmNyZWF0ZURvY3VtZW50KToK KwogMjAxMi0wMi0wNyAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBBZGQgSlNDIHN1cHBvcnQgZm9yIGRlbGl2ZXJpbmcgbXV0YXRpb25zIHdoZW4gdGhlIG91dGVy bW9zdCBzY3JpcHQgY29udGV4dCBleGl0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0RPTUltcGxlbWVudGF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01JbXBsZW1lbnRh dGlvbi5jcHAKaW5kZXggMzMxMDQwOS4uYWU2ZDM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL0RPTUltcGxlbWVudGF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9N SW1wbGVtZW50YXRpb24uY3BwCkBAIC0zNjQsNDYgKzM2NCwzNyBAQCBQYXNzUmVmUHRyPERvY3Vt ZW50PiBET01JbXBsZW1lbnRhdGlvbjo6Y3JlYXRlRG9jdW1lbnQoY29uc3QgU3RyaW5nJiB0eXBl LCBGcmFtZQogICAgIC8vIFBsdWdpbnMgY2Fubm90IHRha2UgSFRNTCBhbmQgWEhUTUwgZnJvbSB1 cywgYW5kIHdlIGRvbid0IGV2ZW4gbmVlZCB0byBpbml0aWFsaXplIHRoZSBwbHVnaW4gZGF0YWJh c2UgZm9yIHRob3NlLgogICAgIGlmICh0eXBlID09ICJ0ZXh0L2h0bWwiKQogICAgICAgICByZXR1 cm4gSFRNTERvY3VtZW50OjpjcmVhdGUoZnJhbWUsIHVybCk7Ci0KLSAgICAvLyBQbHVnaW5zIGNh bm5vdCB0YWtlIHRleHQvcGxhaW4gZnJvbSB1cyBlaXRoZXIuCi0gICAgaWYgKHR5cGUgPT0gInRl eHQvcGxhaW4iKQotICAgICAgICByZXR1cm4gVGV4dERvY3VtZW50OjpjcmVhdGUoZnJhbWUsIHVy bCk7Ci0KICAgICBpZiAodHlwZSA9PSAiYXBwbGljYXRpb24veGh0bWwreG1sIikKICAgICAgICAg cmV0dXJuIERvY3VtZW50OjpjcmVhdGVYSFRNTChmcmFtZSwgdXJsKTsKIAogI2lmIEVOQUJMRShG VFBESVIpCi0gICAgLy8gUGx1Z2lucyBjYW5ub3QgdGFrZSBGVFAgZnJvbSB1cyBlaXRoZXIuCisg ICAgLy8gUGx1Z2lucyBjYW5ub3QgdGFrZSBGVFAgZnJvbSB1cyBlaXRoZXIKICAgICBpZiAodHlw ZSA9PSAiYXBwbGljYXRpb24veC1mdHAtZGlyZWN0b3J5IikKICAgICAgICAgcmV0dXJuIEZUUERp cmVjdG9yeURvY3VtZW50OjpjcmVhdGUoZnJhbWUsIHVybCk7CiAjZW5kaWYKIAotICAgIC8vIFBE RiBpcyB0aGUgb25seSBpbWFnZSB0eXBlIGZvciB3aGljaCBhIHBsdWdpbiBjYW4gb3ZlcnJpZGUg YnVpbHQtaW4gc3VwcG9ydC4KLSAgICBpZiAoSW1hZ2U6OnN1cHBvcnRzVHlwZSh0eXBlKSAmJiB0 eXBlICE9ICJhcHBsaWNhdGlvbi9wZGYiICYmIHR5cGUgIT0gInRleHQvcGRmIikKLSAgICAgICAg cmV0dXJuIEltYWdlRG9jdW1lbnQ6OmNyZWF0ZShmcmFtZSwgdXJsKTsKLQotI2lmIEVOQUJMRShW SURFTykKLSAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIHRoZSB0eXBlIGNhbiBiZSBwbGF5ZWQgYnkg b3VyIE1lZGlhUGxheWVyLCBpZiBzbyBjcmVhdGUgYSBNZWRpYURvY3VtZW50IGFzCi0gICAgIC8v IHRoaXMgY2FuIG5vdCBiZSB0YWtlbiBieSBwbHVnaW5zIGVpdGhlci4KLSAgICAgaWYgKE1lZGlh UGxheWVyOjpzdXBwb3J0c1R5cGUoQ29udGVudFR5cGUodHlwZSkpKQotICAgICAgICAgcmV0dXJu IE1lZGlhRG9jdW1lbnQ6OmNyZWF0ZShmcmFtZSwgdXJsKTsKLSNlbmRpZgotCi0gICAgLy8gVGhl IHBsdWdpbiBkYXRhYmFzZSBpcyBpbml0aWFsaXplZCBhdCB0aGlzIHBvaW50IGlmIHBsdWdpbnMg YXJlIGVuYWJsZWQKLSAgICAvLyB3aGljaCBpcyBub24temVybyBvdmVyaGVhZC4KICAgICBQbHVn aW5EYXRhKiBwbHVnaW5EYXRhID0gMDsKICAgICBpZiAoZnJhbWUgJiYgZnJhbWUtPnBhZ2UoKSAm JiBmcmFtZS0+bG9hZGVyKCktPnN1YmZyYW1lTG9hZGVyKCktPmFsbG93UGx1Z2lucyhOb3RBYm91 dFRvSW5zdGFudGlhdGVQbHVnaW4pKQogICAgICAgICBwbHVnaW5EYXRhID0gZnJhbWUtPnBhZ2Uo KS0+cGx1Z2luRGF0YSgpOwogCi0gICAgLy8gQXQgdGhpcyBwb2ludCBhbnl0aGluZyB0aGF0IGNh biBiZSBzdXBwb3J0ZWQgY2FuIGJlIG92ZXJyaWRkZW4gYnkgcGx1Z2lucy4KLSAgICBpZiAocGx1 Z2luRGF0YSAmJiBwbHVnaW5EYXRhLT5zdXBwb3J0c01pbWVUeXBlKHR5cGUpKQorICAgIC8vIFBE RiBpcyBvbmUgaW1hZ2UgdHlwZSBmb3Igd2hpY2ggYSBwbHVnaW4gY2FuIG92ZXJyaWRlIGJ1aWx0 LWluIHN1cHBvcnQuCisgICAgLy8gV2UgZG8gbm90IHdhbnQgUXVpY2tUaW1lIHRvIHRha2Ugb3Zl ciBhbGwgaW1hZ2UgdHlwZXMsIG9idmlvdXNseS4KKyAgICBpZiAoKHR5cGUgPT0gImFwcGxpY2F0 aW9uL3BkZiIgfHwgdHlwZSA9PSAidGV4dC9wZGYiKSAmJiBwbHVnaW5EYXRhICYmIHBsdWdpbkRh dGEtPnN1cHBvcnRzTWltZVR5cGUodHlwZSkpCiAgICAgICAgIHJldHVybiBQbHVnaW5Eb2N1bWVu dDo6Y3JlYXRlKGZyYW1lLCB1cmwpOwotCi0gICAgLy8gSGFuZGxlIFBERiBmb3IgaW5zdGFuY2Ug aWYgaXQgd2FzIG5vdCBoYW5kbGVkIGJ5IGEgcGx1Z2luLgogICAgIGlmIChJbWFnZTo6c3VwcG9y dHNUeXBlKHR5cGUpKQogICAgICAgICByZXR1cm4gSW1hZ2VEb2N1bWVudDo6Y3JlYXRlKGZyYW1l LCB1cmwpOwogCi0gICAgLy8gSGFuZGxlIGEgdGV4dCBkb2N1bWVudCB3YXMgbm90IGhhbmRsZWQg YnkgYSBwbHVnaW4uCisjaWYgRU5BQkxFKFZJREVPKQorICAgICAvLyBDaGVjayB0byBzZWUgaWYg dGhlIHR5cGUgY2FuIGJlIHBsYXllZCBieSBvdXIgTWVkaWFQbGF5ZXIsIGlmIHNvIGNyZWF0ZSBh IE1lZGlhRG9jdW1lbnQKKyAgICAgaWYgKE1lZGlhUGxheWVyOjpzdXBwb3J0c1R5cGUoQ29udGVu dFR5cGUodHlwZSkpKQorICAgICAgICAgcmV0dXJuIE1lZGlhRG9jdW1lbnQ6OmNyZWF0ZShmcmFt ZSwgdXJsKTsKKyNlbmRpZgorCisgICAgLy8gRXZlcnl0aGluZyBlbHNlIGV4Y2VwdCB0ZXh0L3Bs YWluIGNhbiBiZSBvdmVycmlkZGVuIGJ5IHBsdWdpbnMuIEluIHBhcnRpY3VsYXIsIEFkb2JlIFNW RyBWaWV3ZXIgc2hvdWxkIGJlIHVzZWQgZm9yIFNWRywgaWYgaW5zdGFsbGVkLgorICAgIC8vIERp c2FsbG93aW5nIHBsdWctaW5zIHRvIHVzZSB0ZXh0L3BsYWluIHByZXZlbnRzIHBsdWctaW5zIGZy b20gaGlqYWNraW5nIGEgZnVuZGFtZW50YWwgdHlwZSB0aGF0IHRoZSBicm93c2VyIGlzIGV4cGVj dGVkIHRvIGhhbmRsZSwKKyAgICAvLyBhbmQgYWxzbyBzZXJ2ZXMgYXMgYW4gb3B0aW1pemF0aW9u IHRvIHByZXZlbnQgbG9hZGluZyB0aGUgcGx1Zy1pbiBkYXRhYmFzZSBpbiB0aGUgY29tbW9uIGNh c2UuCisgICAgaWYgKHR5cGUgIT0gInRleHQvcGxhaW4iICYmIHBsdWdpbkRhdGEgJiYgcGx1Z2lu RGF0YS0+c3VwcG9ydHNNaW1lVHlwZSh0eXBlKSkgCisgICAgICAgIHJldHVybiBQbHVnaW5Eb2N1 bWVudDo6Y3JlYXRlKGZyYW1lLCB1cmwpOwogICAgIGlmIChpc1RleHRNSU1FVHlwZSh0eXBlKSkK ICAgICAgICAgcmV0dXJuIFRleHREb2N1bWVudDo6Y3JlYXRlKGZyYW1lLCB1cmwpOwogCi0tIAox LjcuOC4zNTIuZzg3NmE2ZgoK