77073 2012-01-26 00:10:44 -0800 REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types 2012-01-26 00:17:59 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC All RESOLVED FIXED Regression P1 Blocker --- 76738 1 aestes aestes oldest_to_newest 542911 0 aestes 2012-01-26 00:10:44 -0800 r105555 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined. This should have been changed to OS(WINDOWS). This causes the preprocessor to strip out Win32 data type overrides for deleteOwnedPtr, causing allocations made by Win32 to be deleted by fastmalloc. 542915 1 124069 aestes 2012-01-26 00:14:35 -0800 Created attachment 124069 Patch 542920 2 aestes 2012-01-26 00:17:59 -0800 Committed r105970: <http://trac.webkit.org/changeset/105970> 124069 2012-01-26 00:14:35 -0800 2012-01-26 00:16:34 -0800 Patch bug-77073-20120126001434.patch text/plain 1724 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MjlhMzJmMWIyMzY3MzE3MTY2Y2U3MDI0OTIzNTkyMTAwOWM0NzgxLi4yMjc0ZmI3OWIyMTQxMjYw OTRlMzBiOTM5YmU2ODIyOTlkNDVmZjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMS0yNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjEwNTU1NSk6IEluY29ycmVjdCB1c2Ugb2YgT1MoKSBtYWNy byBicmVha3MgT3duUHRyIHdoZW4gdXNlZCB3aXRoIFdpbjMyIGRhdGEgdHlwZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MDczCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICByMTA1NTU1IGNo YW5nZWQgUExBVEZPUk0oV0lOKSB0byBPUyhXSU4pLCBidXQgV1RGX09TX1dJTiBpc24ndCBkZWZp bmVkLgorICAgICAgICBUaGlzIHNob3VsZCBoYXZlIGJlZW4gY2hhbmdlZCB0byBPUyhXSU5ET1dT KS4gVGhpcyBjYXVzZXMgdGhlCisgICAgICAgIHByZXByb2Nlc3NvciB0byBzdHJpcCBvdXQgV2lu MzIgZGF0YSB0eXBlIG92ZXJyaWRlcyBmb3IgZGVsZXRlT3duZWRQdHIsCisgICAgICAgIGNhdXNp bmcgYWxsb2NhdGlvbnMgbWFkZSBieSBXaW4zMiB0byBiZSBkZWxldGVkIGJ5IGZhc3RtYWxsb2Mu CisKKyAgICAgICAgKiB3dGYvT3duUHRyQ29tbW9uLmg6CisgICAgICAgIChXVEYpOiBVc2UgT1Mo V0lORE9XUykgaW5zdGVhZCBvZiBPUyhXSU4pLgorCiAyMDEyLTAxLTI1ICBNYXJrIFJvd2UgIDxt cm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQXR0ZW1wdGVkIE1hYyBidWlsZCBmaXggYWZ0ZXIg cjEwNTkzOS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29t bW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5oCmluZGV4IGI4 Yjc4YTI5NjdiZGNmOTRkYzJhOWQ0NGRiOTdkODkxYTU3Y2E3MzAuLjMxNWRiODk1NDYwMTQ2ZTcw Yzg2YTkwZDY0NDIxMDA4YzRmYzgwOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvT3duUHRyQ29tbW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25Q dHJDb21tb24uaApAQCAtMjgsNyArMjgsNyBAQAogI2lmbmRlZiBXVEZfT3duUHRyQ29tbW9uX2gK ICNkZWZpbmUgV1RGX093blB0ckNvbW1vbl9oCiAKLSNpZiBPUyhXSU4pCisjaWYgT1MoV0lORE9X UykKIHR5cGVkZWYgc3RydWN0IEhCSVRNQVBfXyogSEJJVE1BUDsKIHR5cGVkZWYgc3RydWN0IEhC UlVTSF9fKiBIQlJVU0g7CiB0eXBlZGVmIHN0cnVjdCBIRENfXyogSERDOwpAQCAtNTQsNyArNTQs NyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgICAgIGRlbGV0ZSBwdHI7CiAgICAgfQogCi0j aWYgT1MoV0lOKQorI2lmIE9TKFdJTkRPV1MpCiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihIQklU TUFQKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEhCUlVTSCk7CiAgICAgdm9pZCBkZWxldGVP d25lZFB0cihIREMpOwo=