77071 2012-01-25 21:54:42 -0800 Revert code changes from r105800 2012-01-26 11:24:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dcheng dcheng webkit.review.bot yael oldest_to_newest 542874 0 dcheng 2012-01-25 21:54:42 -0800 Revert code changes from r105800 542875 1 124062 dcheng 2012-01-25 21:55:37 -0800 Created attachment 124062 Patch 543174 2 124062 jberlin 2012-01-26 08:54:06 -0800 Comment on attachment 124062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review So the test you added in http://trac.webkit.org/changeset/105800 would have passed without the code change? Unofficial r=me (not a reviewer yet). > Source/WebCore/ChangeLog:6 > + The strings are already lowercased before they make their way to this function, so there's Might be nice to say where they get lowercased. > Source/WebCore/dom/Clipboard.cpp:215 > + Looks like extra space snuck in here. 543180 3 124124 dcheng 2012-01-26 09:01:54 -0800 Created attachment 124124 Patch 543182 4 124062 dcheng 2012-01-26 09:03:09 -0800 Comment on attachment 124062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review Yes, the test passes without this change. There was another change in the original CL as well and when I moved that change to another patch, I didn't check if the remaining code changes were still needed. >> Source/WebCore/ChangeLog:6 >> + The strings are already lowercased before they make their way to this function, so there's > > Might be nice to say where they get lowercased. Done. >> Source/WebCore/dom/Clipboard.cpp:215 >> + > > Looks like extra space snuck in here. This was in the original change, but I went ahead and cleaned it up. 543315 5 124124 webkit.review.bot 2012-01-26 11:23:59 -0800 Comment on attachment 124124 Patch Clearing flags on attachment: 124124 Committed r106018: <http://trac.webkit.org/changeset/106018> 543316 6 webkit.review.bot 2012-01-26 11:24:04 -0800 All reviewed patches have been landed. Closing bug. 124062 2012-01-25 21:55:37 -0800 2012-01-26 09:03:08 -0800 Patch bug-77071-20120125215536.patch text/plain 1694 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI2NzY3MGZjMjU3YjEx ODczOTc1M2RlNDNhOTk3NDQ5MWMyMjRhMC4uOWI0YTI0ZTlmMTc1Nzk4MTFiN2UwOWQzZTQzY2Zj YWM4OGM3MGY0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTAxLTI1ICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmVydCBjb2RlIGNo YW5nZXMgZnJvbSByMTA1ODAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NzA3MQorCisgICAgICAgIFRoZSBzdHJpbmdzIGFyZSBhbHJlYWR5IGxvd2Vy Y2FzZWQgYmVmb3JlIHRoZXkgbWFrZSB0aGVpciB3YXkgdG8gdGhpcyBmdW5jdGlvbiwgc28gdGhl cmUncworICAgICAgICBubyBuZWVkIHRvIGNhbGwgbG93ZXIoKSBhZ2Fpbi4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5n IHRlc3RzLgorCisgICAgICAgICogZG9tL0NsaXBib2FyZC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDbGlwYm9hcmQ6Omhhc0Ryb3Bab25lVHlwZSk6CisKKzIwMTItMDEtMjUgIERhbmllbCBDaGVu ZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBGaXggQ2xpcGJv YXJkQ2hyb21pdW06OnZhbGlkYXRlRmlsZW5hbWUgdG8gYWN0dWFsbHkgb3BlcmF0ZSBvbiBleHRl bnNpb25zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 Njk5NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuY3BwCmluZGV4IDg5YTU1ZWUyOTYxOWZmZjYxOWNh MTUwYmMzMjY4ZGZhZWMzZGU4OWMuLmU3OWEyNjhhMDFjYTBjMGQ2OTY2MTFlNDZiOTFmOTRkNmMy OTVmNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuY3BwCkBAIC0yMTEsMTAgKzIxMSwxMCBAQCBT dHJpbmcgY29udmVydERyYWdPcGVyYXRpb25Ub0Ryb3Bab25lT3BlcmF0aW9uKERyYWdPcGVyYXRp b24gb3BlcmF0aW9uKQogYm9vbCBDbGlwYm9hcmQ6Omhhc0Ryb3Bab25lVHlwZShjb25zdCBTdHJp bmcmIGtleXdvcmQpCiB7CiAgICAgaWYgKGtleXdvcmQuc3RhcnRzV2l0aCgiZmlsZToiKSkKLSAg ICAgICAgcmV0dXJuIGhhc0ZpbGVPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNSkubG93ZXIoKSk7 Ci0KKyAgICAgICAgcmV0dXJuIGhhc0ZpbGVPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNSkpOwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICBpZiAoa2V5d29yZC5zdGFydHNXaXRo KCJzdHJpbmc6IikpCi0gICAgICAgIHJldHVybiBoYXNTdHJpbmdPZlR5cGUoa2V5d29yZC5zdWJz dHJpbmcoNykubG93ZXIoKSk7CisgICAgICAgIHJldHVybiBoYXNTdHJpbmdPZlR5cGUoa2V5d29y ZC5zdWJzdHJpbmcoNykpOwogCiAgICAgcmV0dXJuIGZhbHNlOwogfQo= 124124 2012-01-26 09:01:54 -0800 2012-01-26 11:23:59 -0800 Patch bug-77071-20120126090153.patch text/plain 1653 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI2NzY3MGZjMjU3YjEx ODczOTc1M2RlNDNhOTk3NDQ5MWMyMjRhMC4uYjdkYTU0ZjZmM2YyNDAzNmMyN2QzNGVjZGIxNmE3 Y2E2ZWIxMGI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTAxLTI1ICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmVydCBjb2RlIGNo YW5nZXMgZnJvbSByMTA1ODAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NzA3MQorCisgICAgICAgIFRoZSBzdHJpbmdzIGFyZSBhbHJlYWR5IGxvd2Vy Y2FzZWQgaW4gRXZlbnRIYW5kbGVyLmNwcDpmaW5kRHJvcFpvbmUoKSBzbyB0aGVyZSdzCisgICAg ICAgIG5vIG5lZWQgdG8gY2FsbCBsb3dlcigpIGFnYWluLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisK KyAgICAgICAgKiBkb20vQ2xpcGJvYXJkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2Fy ZDo6aGFzRHJvcFpvbmVUeXBlKToKKworMjAxMi0wMS0yNSAgRGFuaWVsIENoZW5nICA8ZGNoZW5n QGNocm9taXVtLm9yZz4KKwogICAgICAgICBbY2hyb21pdW1dIEZpeCBDbGlwYm9hcmRDaHJvbWl1 bTo6dmFsaWRhdGVGaWxlbmFtZSB0byBhY3R1YWxseSBvcGVyYXRlIG9uIGV4dGVuc2lvbnMKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2OTk2CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL0NsaXBib2FyZC5jcHAKaW5kZXggODlhNTVlZTI5NjE5ZmZmNjE5Y2ExNTBiYzMyNjhk ZmFlYzNkZTg5Yy4uMDI3OTkyNTE1MmVlMmIxMWUxZDE5MTAyYjU5MDMyOWJlMzJkM2FkNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKQEAgLTIxMSwxMCArMjExLDEwIEBAIFN0cmluZyBjb252 ZXJ0RHJhZ09wZXJhdGlvblRvRHJvcFpvbmVPcGVyYXRpb24oRHJhZ09wZXJhdGlvbiBvcGVyYXRp b24pCiBib29sIENsaXBib2FyZDo6aGFzRHJvcFpvbmVUeXBlKGNvbnN0IFN0cmluZyYga2V5d29y ZCkKIHsKICAgICBpZiAoa2V5d29yZC5zdGFydHNXaXRoKCJmaWxlOiIpKQotICAgICAgICByZXR1 cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg1KS5sb3dlcigpKTsKKyAgICAgICAg cmV0dXJuIGhhc0ZpbGVPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNSkpOwogCiAgICAgaWYgKGtl eXdvcmQuc3RhcnRzV2l0aCgic3RyaW5nOiIpKQotICAgICAgICByZXR1cm4gaGFzU3RyaW5nT2ZU eXBlKGtleXdvcmQuc3Vic3RyaW5nKDcpLmxvd2VyKCkpOworICAgICAgICByZXR1cm4gaGFzU3Ry aW5nT2ZUeXBlKGtleXdvcmQuc3Vic3RyaW5nKDcpKTsKIAogICAgIHJldHVybiBmYWxzZTsKIH0K