77063 2012-01-25 17:11:26 -0800 [Qt][WK2] Child layers appear in wrong position when scrolling 2012-01-30 07:20:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 noam webkit-unassigned abecsi gustavo hausmann hyatt jturcotte kenneth simon.fraser webkit.review.bot xan.lopez zoltan oldest_to_newest 542792 0 noam 2012-01-25 17:11:26 -0800 Since adding the fixedVisibleContentRect to WebKit2, child layers are displaced when scrolling or zooming. This is easily testable by running the http://webkit.org/blog-files/3d-transforms/morphing-cubes.html in touch mode. 542795 1 124037 noam 2012-01-25 17:13:37 -0800 Created attachment 124037 Patch 543003 2 124037 kenneth 2012-01-26 02:53:55 -0800 Comment on attachment 124037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124037&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:795 > Frame* frame = m_page->mainFrame(); > + m_fixedVisibleContentRect = rect; > > frame->view()->setFixedVisibleContentRect(rect); > } can't you receive it from the FrameView instead? or is that a performance issue? 543052 3 jturcotte 2012-01-26 04:22:29 -0800 The scrolling of the layers seems to be done by a scroll layer. It would probably be better to prevent the use of this layer instead, RenderLayerCompositor::requiresScrollLayer seems to do exactly that. 543092 4 124037 noam 2012-01-26 05:59:29 -0800 Comment on attachment 124037 Patch Will try another approach based on comments. 543244 5 124137 noam 2012-01-26 10:29:10 -0800 Created attachment 124137 Patch 543246 6 124138 noam 2012-01-26 10:30:30 -0800 Created attachment 124138 Patch 543452 7 124138 gustavo 2012-01-26 13:54:51 -0800 Comment on attachment 124138 Patch Attachment 124138 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11163476 543646 8 124212 noam 2012-01-26 16:39:54 -0800 Created attachment 124212 Patch 543836 9 124212 simon.fraser 2012-01-26 22:22:46 -0800 Comment on attachment 124212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124212&action=review > Source/WebCore/platform/ScrollView.h:127 > + virtual void delegatesScrollingDidChange() { } Why is this public? 543846 10 noam 2012-01-26 22:34:19 -0800 (In reply to comment #9) > (From update of attachment 124212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124212&action=review > > > Source/WebCore/platform/ScrollView.h:127 > > + virtual void delegatesScrollingDidChange() { } > > Why is this public? Oversight :) Will make protected when committing. 544011 11 124302 noam 2012-01-27 06:09:16 -0800 Created attachment 124302 Patch 544067 12 124302 webkit.review.bot 2012-01-27 07:35:57 -0800 Comment on attachment 124302 Patch Clearing flags on attachment: 124302 Committed r106121: <http://trac.webkit.org/changeset/106121> 544068 13 webkit.review.bot 2012-01-27 07:36:03 -0800 All reviewed patches have been landed. Closing bug. 545052 14 abecsi 2012-01-30 05:49:41 -0800 Since this change MiniBrowser does not print the new tiles after the kinetic animation finishes. If I remove: // This applies when the application UI handles scrolling, in which case RenderLayerCompositor doesn't need to manage it. if (m_renderView->frameView()->delegatesScrolling()) return false; from WebCore/rendering/RenderLayerCompositor.cpp: RenderLayerCompositor::requiresScrollLayer, it works again. This might be because !m_renderView->frameView()->platformWidget() is actually true. Since I'm not familiar with this code, I do not know if this is actually a revealed bug somewhere else, or is that return not needed. 545066 15 noam 2012-01-30 06:22:46 -0800 (In reply to comment #14) > Since this change MiniBrowser does not print the new tiles after the kinetic animation finishes. > > If I remove: > > // This applies when the application UI handles scrolling, in which case RenderLayerCompositor doesn't need to manage it. > if (m_renderView->frameView()->delegatesScrolling()) > return false; > > from WebCore/rendering/RenderLayerCompositor.cpp: RenderLayerCompositor::requiresScrollLayer, it works again. > This might be because !m_renderView->frameView()->platformWidget() is actually true. !m_renderView->frameView()->platformWidget() is always true in WebKit2. > > Since I'm not familiar with this code, I do not know if this is actually a revealed bug somewhere else, or is that return not needed. We delegate scrolling in WebKit2, so we shouldn't have the compositor control these layers... I will investigate, but I have less experience with the scrolling code, so if someone else wants to have a look be my guest. 545083 16 abecsi 2012-01-30 07:20:00 -0800 (In reply to comment #15) Jocelyn helped finding the cause of this issue, I opened a bug for it: https://bugs.webkit.org/show_bug.cgi?id=77338 124037 2012-01-25 17:13:37 -0800 2012-01-26 10:29:10 -0800 Patch patch.diff text/plain 3231 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyZDZmZTlmLi4wMGMzNDJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDEtMjUgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdW1dLMl0gQ2hpbGQgbGF5ZXJzIGFwcGVhciBpbiB3cm9uZyBwb3Np dGlvbiB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb21wZW5zYXRlIGZvciB0aGUgZml4ZWRWaXNpYmxlQ29udGVudFJlY3Qgd2hl biBwb3NpdGlvbmluZyBjaGlsZCBsYXllcnMgaW4KKyAgICAgICAgTGF5ZXJUcmVlSG9zdFF0Lgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlOjpzZXRGaXhlZFZpc2libGVDb250ZW50UmVjdCk6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Zml4 ZWRWaXNpYmxlQ29udGVudFJlY3QpOgorICAgICAgICAoV2ViUGFnZSk6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL3F0L0xheWVyVHJlZUhvc3RRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkxheWVyVHJlZUhvc3RRdDo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKToKKwogMjAxMi0wMS0y NSAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGluIHRvIGFu IGFsdGVybmF0ZSBsb2NhdGlvbiB3aGVuIFVTRV9TVEFHSU5HX0lOU1RBTExfUEFUSCBpcyBzZXQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXgg ZDAzNmU1Ni4uY2NkYWYwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcApAQCAtNzg5LDYgKzc4OSw3IEBAIHZvaWQgV2ViUGFnZTo6c2V0Rml4ZWRW aXNpYmxlQ29udGVudFJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBBU1NFUlQobV91c2VG aXhlZExheW91dCk7CiAKICAgICBGcmFtZSogZnJhbWUgPSBtX3BhZ2UtPm1haW5GcmFtZSgpOwor ICAgIG1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3QgPSByZWN0OwogCiAgICAgZnJhbWUtPnZpZXco KS0+c2V0Rml4ZWRWaXNpYmxlQ29udGVudFJlY3QocmVjdCk7CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAppbmRleCAyMTZiNjA4Li4xMjQ4MjgyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTMzMSw2ICsz MzEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRSZXNpemVzVG9Db250ZW50c1VzaW5nTGF5b3V0 U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7CiAgICAgdm9pZCByZXNpemVUb0NvbnRlbnRz SWZOZWVkZWQoKTsKICAgICB2b2lkIHNldFZpZXdwb3J0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRT aXplJik7CisgICAgV2ViQ29yZTo6SW50UmVjdCBmaXhlZFZpc2libGVDb250ZW50UmVjdCgpIGNv bnN0IHsgcmV0dXJuIG1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3Q7IH0KICAgICBXZWJDb3JlOjpJ bnRTaXplIHZpZXdwb3J0U2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlld3BvcnRTaXplOyB9CiAj ZW5kaWYKIApAQCAtNzEzLDYgKzcxNCw3IEBAIHByaXZhdGU6CiAjaWYgVVNFKFRJTEVEX0JBQ0tJ TkdfU1RPUkUpCiAgICAgV2ViQ29yZTo6SW50U2l6ZSBtX3Jlc2l6ZXNUb0NvbnRlbnRzTGF5b3V0 U2l6ZTsKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fdmlld3BvcnRTaXplOworICAgIFdlYkNvcmU6 OkludFJlY3QgbV9maXhlZFZpc2libGVDb250ZW50UmVjdDsKICNlbmRpZgogCiAgICAgRmluZENv bnRyb2xsZXIgbV9maW5kQ29udHJvbGxlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9xdC9MYXllclRyZWVIb3N0UXQuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL3F0L0xheWVyVHJlZUhvc3RRdC5jcHAKaW5kZXggMzI1MGYzZi4u M2ZiZjUxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL3F0 L0xheWVyVHJlZUhvc3RRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL3F0L0xheWVyVHJlZUhvc3RRdC5jcHAKQEAgLTIxNyw2ICsyMTcsOSBAQCBib29sIExheWVy VHJlZUhvc3RRdDo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKCkKIHsKICAgICByZWNyZWF0ZUJh Y2tpbmdTdG9yZUlmTmVlZGVkKCk7CiAKKyAgICAvLyBDb21wZW5zYXRlIGZvciB0aGUgZml4ZWQg dmlzaWJsZSBjb250ZW50IHJlY3QsIHdoaWNoIGRvZXNuJ3QgcHJvcG9nYXRlIHRvIHRoZSBsYXll ciB0cmVlIGJ5IGRlZmF1bHQuCisgICAgSW50UmVjdCB2aXNpYmxlQ29udGVudFJlY3QgPSBtX3dl YlBhZ2UtPmZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KCk7CisgICAgbV9ub25Db21wb3NpdGVkQ29u dGVudExheWVyLT5zZXRDaGlsZHJlblRyYW5zZm9ybShUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpLnRy YW5zbGF0ZSh2aXNpYmxlQ29udGVudFJlY3QueCgpLCB2aXNpYmxlQ29udGVudFJlY3QueSgpKSk7 CiAgICAgYm9vbCBkaWRTeW5jID0gbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS0+ dmlldygpLT5zeW5jQ29tcG9zaXRpbmdTdGF0ZUluY2x1ZGluZ1N1YmZyYW1lcygpOwogICAgIG1f bm9uQ29tcG9zaXRlZENvbnRlbnRMYXllci0+c3luY0NvbXBvc2l0aW5nU3RhdGVGb3JUaGlzTGF5 ZXJPbmx5KCk7CiAgICAgaWYgKG1fcGFnZU92ZXJsYXlMYXllcikK 124137 2012-01-26 10:29:10 -0800 2012-01-26 10:30:30 -0800 Patch patch.diff text/plain 4512 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxN2ZhNjIxLi4zNDQ3NWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMDEtMjYgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdW1dLMl0gQ2hpbGQgbGF5ZXJzIGFwcGVhciBpbiB3cm9uZyBwb3Np dGlvbiB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwNjMKKworICAgICAgICBXaGVuIHVzaW5nIHRoZSBkZWxlZ2F0ZXNTY3Jv bGxpbmcgbW9kZSBpbiBGcmFtZVZpZXcsIHRoZSBjb21wb3NpdG9yIGRvZXNuJ3QgbmVlZAorICAg ICAgICB0byBjb250cm9sIHRoZSBzcGVjaWFsIGNsaXAvc2Nyb2xsIGxheWVycy4gQWxzbywgd2hl biB3ZSBjaGFuZ2UgdGhhdCBtb2RlLCB3ZSBuZWVkIHRvIGxldAorICAgICAgICB0aGUgY29tcG9z aXRvciByZXNldCBpdHMgYmFja2luZy1zdG9yZXMgYW5kIHJlYnVpbGQgdGhlbSB3aXRob3V0IHNj cm9sbGluZy9jbGlwcGluZy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGlzIHRlc3RlZCBieSBjb21wb3NpdGluZyB0ZXN0cywgd2hlbiBydW4g d2l0aCBRdCBpbiB0b3VjaCBtb2RlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2Up OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAg ICAgKEZyYW1lVmlldyk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpzZXREZWxlZ2F0ZXNTY3JvbGxpbmcpOgorICAgICAg ICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6 OmRlbGVnYXRlc1Njcm9sbGluZ0RpZENoYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBv c2l0b3I6OnJlcXVpcmVzU2Nyb2xsTGF5ZXIpOgorCiAyMDEyLTAxLTI2ICBOaWtvbGFzIFppbW1l cm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFNWRyArIDxvYmplY3Q+IHRl c3RzIGFyZSBmbGFrZXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA2NWI0ODNmLi4x YTNmY2VkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xNzAyLDYgKzE3MDIsMTIg QEAgdm9pZCBGcmFtZVZpZXc6OnNldFNjcm9sbFBvc2l0aW9uKGNvbnN0IEludFBvaW50JiBzY3Jv bGxQb2ludCkKICAgICBTY3JvbGxWaWV3OjpzZXRTY3JvbGxQb3NpdGlvbihzY3JvbGxQb2ludCk7 CiB9CiAKK3ZvaWQgRnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2UoKQorewor ICAgIC8vIFdoZW4gd2Ugc3dpdGNoIHRvIGRlbGdhdGVzU2Nyb2xsaW5nIG1vZGUsIHdlIHNob3Vs ZCBkZXN0cm95IHRoZSBzY3JvbGxpbmcvY2xpcHBpbmcgbGF5ZXJzIGluIFJlbmRlckxheWVyQ29t cG9zaXRvci4KKyAgICBjbGVhckJhY2tpbmdTdG9yZXMoKTsKK30KKwogdm9pZCBGcmFtZVZpZXc6 OnNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIHZpc2libGVDb250ZW50 UmVjdCkKIHsKICAgICBJbnRTaXplIG9mZnNldCA9IHNjcm9sbE9mZnNldCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmgKaW5kZXggMTc2MWEwNi4uY2E2ZDNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5oCkBAIC04OSw2ICs4OSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkSG9y aXpvbnRhbFNjcm9sbGJhcihTY3JvbGxiYXIqKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFJlbW92 ZUhvcml6b250YWxTY3JvbGxiYXIoU2Nyb2xsYmFyKik7CiAKKyAgICB2aXJ0dWFsIHZvaWQgZGVs ZWdhdGVzU2Nyb2xsaW5nRGlkQ2hhbmdlKCk7CisKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVu dHNTaXplKGNvbnN0IEludFNpemUmKTsKIAogICAgIHZvaWQgbGF5b3V0KGJvb2wgYWxsb3dTdWJ0 cmVlID0gdHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxW aWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDUy Y2NjNWQuLmMzNDdjMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBA IC0yMTksNyArMjE5LDExIEBAIHZvaWQgU2Nyb2xsVmlldzo6c2V0Q2xpcHNSZXBhaW50cyhib29s IGNsaXBzUmVwYWludHMpCiAKIHZvaWQgU2Nyb2xsVmlldzo6c2V0RGVsZWdhdGVzU2Nyb2xsaW5n KGJvb2wgZGVsZWdhdGVzU2Nyb2xsaW5nKQogeworICAgIGlmIChtX2RlbGVnYXRlc1Njcm9sbGlu ZyA9PSBkZWxlZ2F0ZXNTY3JvbGxpbmcpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fZGVsZWdh dGVzU2Nyb2xsaW5nID0gZGVsZWdhdGVzU2Nyb2xsaW5nOworICAgIGRlbGVnYXRlc1Njcm9sbGlu Z0RpZENoYW5nZSgpOwogfQogCiAjaWYgIVBMQVRGT1JNKEdUSykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuaAppbmRleCA1ZDM0YTkyLi5hNmMyNzNlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vU2Nyb2xsVmlldy5oCkBAIC0xMjQsNiArMTI0LDcgQEAgcHVibGljOgogICAgIC8vIGFyZSBk ZWxlZ2F0ZWQgdG8gdGhlIFVJIGFwcGxpY2F0aW9uLgogICAgIGJvb2wgZGVsZWdhdGVzU2Nyb2xs aW5nKCkgY29uc3QgeyByZXR1cm4gbV9kZWxlZ2F0ZXNTY3JvbGxpbmc7IH0KICAgICB2b2lkIHNl dERlbGVnYXRlc1Njcm9sbGluZyhib29sKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGVsZWdhdGVzU2Ny b2xsaW5nRGlkQ2hhbmdlKCkgeyB9CiAKICAgICAvLyBPdmVycmlkZGVuIGJ5IEZyYW1lVmlldyB0 byBjcmVhdGUgY3VzdG9tIENTUyBzY3JvbGxiYXJzIGlmIGFwcGxpY2FibGUuCiAgICAgdmlydHVh bCBQYXNzUmVmUHRyPFNjcm9sbGJhcj4gY3JlYXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0 aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKaW5kZXggZTMwZWEzZC4uMzc0NTZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTE1ODMsNiArMTU4Mywx MCBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6bmVlZHNDb250ZW50c0NvbXBvc2l0aW5n TGF5ZXIoY29uc3QgUmVuZGVyTGF5ZXIqIGxheQogCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6cmVxdWlyZXNTY3JvbGxMYXllcihSb290TGF5ZXJBdHRhY2htZW50IGF0dGFjaG1lbnQpIGNv bnN0CiB7CisgICAgLy8gVGhpcyBhcHBsaWVzIHdoZW4gdGhlIGFwcGxpY2F0aW9uIFVJIGhhbmRs ZXMgc2Nyb2xsaW5nLCBpbiB3aGljaCBjYXNlIFJlbmRlckxheWVyQ29tcG9zaXRvciBkb2Vzbid0 IG5lZWQgdG8gbWFuYWdlIGl0LgorICAgIGlmIChtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5k ZWxlZ2F0ZXNTY3JvbGxpbmcoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgLy8gV2Ug bmVlZCB0byBoYW5kbGUgb3VyIG93biBzY3JvbGxpbmcgaWYgd2UncmU6CiAgICAgcmV0dXJuICFt X3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5wbGF0Zm9ybVdpZGdldCgpIC8vIHZpZXdsZXNzIChp LmUuIG5vbi1NYWMsIG9yIE1hYyBpbiBXZWJLaXQyKQogICAgICAgICB8fCBhdHRhY2htZW50ID09 IFJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nRnJhbWU7IC8vIGEgY29tcG9zaXRlZCBmcmFt ZSBvbiBNYWMK 124138 2012-01-26 10:30:30 -0800 2012-01-26 16:40:10 -0800 Patch patch.diff text/plain 4512 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxN2ZhNjIxLi41YTQ0NGJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMDEtMjYgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdW1dLMl0gQ2hpbGQgbGF5ZXJzIGFwcGVhciBpbiB3cm9uZyBwb3Np dGlvbiB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIHVzaW5nIHRoZSBkZWxlZ2F0ZXNTY3JvbGxpbmcgbW9kZSBpbiBGcmFt ZVZpZXcsIHRoZSBjb21wb3NpdG9yIGRvZXNuJ3QgbmVlZAorICAgICAgICB0byBjb250cm9sIHRo ZSBzcGVjaWFsIGNsaXAvc2Nyb2xsIGxheWVycy4gQWxzbywgd2hlbiB3ZSBjaGFuZ2UgdGhhdCBt b2RlLCB3ZSBuZWVkIHRvIGxldAorICAgICAgICB0aGUgY29tcG9zaXRvciByZXNldCBpdHMgYmFj a2luZy1zdG9yZXMgYW5kIHJlYnVpbGQgdGhlbSB3aXRob3V0IHNjcm9sbGluZy9jbGlwcGluZy4K KworICAgICAgICBUaGlzIGlzIHRlc3RlZCBieSBjb21wb3NpdGluZyB0ZXN0cywgd2hlbiBydW4g d2l0aCBRdCBpbiB0b3VjaCBtb2RlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2Up OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAg ICAgKEZyYW1lVmlldyk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpzZXREZWxlZ2F0ZXNTY3JvbGxpbmcpOgorICAgICAg ICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6 OmRlbGVnYXRlc1Njcm9sbGluZ0RpZENoYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBv c2l0b3I6OnJlcXVpcmVzU2Nyb2xsTGF5ZXIpOgorCiAyMDEyLTAxLTI2ICBOaWtvbGFzIFppbW1l cm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFNWRyArIDxvYmplY3Q+IHRl c3RzIGFyZSBmbGFrZXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA2NWI0ODNmLi4x YTNmY2VkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xNzAyLDYgKzE3MDIsMTIg QEAgdm9pZCBGcmFtZVZpZXc6OnNldFNjcm9sbFBvc2l0aW9uKGNvbnN0IEludFBvaW50JiBzY3Jv bGxQb2ludCkKICAgICBTY3JvbGxWaWV3OjpzZXRTY3JvbGxQb3NpdGlvbihzY3JvbGxQb2ludCk7 CiB9CiAKK3ZvaWQgRnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2UoKQorewor ICAgIC8vIFdoZW4gd2Ugc3dpdGNoIHRvIGRlbGdhdGVzU2Nyb2xsaW5nIG1vZGUsIHdlIHNob3Vs ZCBkZXN0cm95IHRoZSBzY3JvbGxpbmcvY2xpcHBpbmcgbGF5ZXJzIGluIFJlbmRlckxheWVyQ29t cG9zaXRvci4KKyAgICBjbGVhckJhY2tpbmdTdG9yZXMoKTsKK30KKwogdm9pZCBGcmFtZVZpZXc6 OnNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIHZpc2libGVDb250ZW50 UmVjdCkKIHsKICAgICBJbnRTaXplIG9mZnNldCA9IHNjcm9sbE9mZnNldCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmgKaW5kZXggMTc2MWEwNi4uY2E2ZDNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5oCkBAIC04OSw2ICs4OSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkSG9y aXpvbnRhbFNjcm9sbGJhcihTY3JvbGxiYXIqKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFJlbW92 ZUhvcml6b250YWxTY3JvbGxiYXIoU2Nyb2xsYmFyKik7CiAKKyAgICB2aXJ0dWFsIHZvaWQgZGVs ZWdhdGVzU2Nyb2xsaW5nRGlkQ2hhbmdlKCk7CisKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVu dHNTaXplKGNvbnN0IEludFNpemUmKTsKIAogICAgIHZvaWQgbGF5b3V0KGJvb2wgYWxsb3dTdWJ0 cmVlID0gdHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxW aWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDUy Y2NjNWQuLmMzNDdjMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBA IC0yMTksNyArMjE5LDExIEBAIHZvaWQgU2Nyb2xsVmlldzo6c2V0Q2xpcHNSZXBhaW50cyhib29s IGNsaXBzUmVwYWludHMpCiAKIHZvaWQgU2Nyb2xsVmlldzo6c2V0RGVsZWdhdGVzU2Nyb2xsaW5n KGJvb2wgZGVsZWdhdGVzU2Nyb2xsaW5nKQogeworICAgIGlmIChtX2RlbGVnYXRlc1Njcm9sbGlu ZyA9PSBkZWxlZ2F0ZXNTY3JvbGxpbmcpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fZGVsZWdh dGVzU2Nyb2xsaW5nID0gZGVsZWdhdGVzU2Nyb2xsaW5nOworICAgIGRlbGVnYXRlc1Njcm9sbGlu Z0RpZENoYW5nZSgpOwogfQogCiAjaWYgIVBMQVRGT1JNKEdUSykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuaAppbmRleCA1ZDM0YTkyLi5hNmMyNzNlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vU2Nyb2xsVmlldy5oCkBAIC0xMjQsNiArMTI0LDcgQEAgcHVibGljOgogICAgIC8vIGFyZSBk ZWxlZ2F0ZWQgdG8gdGhlIFVJIGFwcGxpY2F0aW9uLgogICAgIGJvb2wgZGVsZWdhdGVzU2Nyb2xs aW5nKCkgY29uc3QgeyByZXR1cm4gbV9kZWxlZ2F0ZXNTY3JvbGxpbmc7IH0KICAgICB2b2lkIHNl dERlbGVnYXRlc1Njcm9sbGluZyhib29sKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGVsZWdhdGVzU2Ny b2xsaW5nRGlkQ2hhbmdlKCkgeyB9CiAKICAgICAvLyBPdmVycmlkZGVuIGJ5IEZyYW1lVmlldyB0 byBjcmVhdGUgY3VzdG9tIENTUyBzY3JvbGxiYXJzIGlmIGFwcGxpY2FibGUuCiAgICAgdmlydHVh bCBQYXNzUmVmUHRyPFNjcm9sbGJhcj4gY3JlYXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0 aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKaW5kZXggZTMwZWEzZC4uMzc0NTZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTE1ODMsNiArMTU4Mywx MCBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6bmVlZHNDb250ZW50c0NvbXBvc2l0aW5n TGF5ZXIoY29uc3QgUmVuZGVyTGF5ZXIqIGxheQogCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6cmVxdWlyZXNTY3JvbGxMYXllcihSb290TGF5ZXJBdHRhY2htZW50IGF0dGFjaG1lbnQpIGNv bnN0CiB7CisgICAgLy8gVGhpcyBhcHBsaWVzIHdoZW4gdGhlIGFwcGxpY2F0aW9uIFVJIGhhbmRs ZXMgc2Nyb2xsaW5nLCBpbiB3aGljaCBjYXNlIFJlbmRlckxheWVyQ29tcG9zaXRvciBkb2Vzbid0 IG5lZWQgdG8gbWFuYWdlIGl0LgorICAgIGlmIChtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5k ZWxlZ2F0ZXNTY3JvbGxpbmcoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgLy8gV2Ug bmVlZCB0byBoYW5kbGUgb3VyIG93biBzY3JvbGxpbmcgaWYgd2UncmU6CiAgICAgcmV0dXJuICFt X3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5wbGF0Zm9ybVdpZGdldCgpIC8vIHZpZXdsZXNzIChp LmUuIG5vbi1NYWMsIG9yIE1hYyBpbiBXZWJLaXQyKQogICAgICAgICB8fCBhdHRhY2htZW50ID09 IFJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nRnJhbWU7IC8vIGEgY29tcG9zaXRlZCBmcmFt ZSBvbiBNYWMK 124212 2012-01-26 16:39:54 -0800 2012-01-27 06:09:16 -0800 Patch patch.diff text/plain 4554 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxN2ZhNjIxLi41YTQ0NGJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMDEtMjYgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdW1dLMl0gQ2hpbGQgbGF5ZXJzIGFwcGVhciBpbiB3cm9uZyBwb3Np dGlvbiB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIHVzaW5nIHRoZSBkZWxlZ2F0ZXNTY3JvbGxpbmcgbW9kZSBpbiBGcmFt ZVZpZXcsIHRoZSBjb21wb3NpdG9yIGRvZXNuJ3QgbmVlZAorICAgICAgICB0byBjb250cm9sIHRo ZSBzcGVjaWFsIGNsaXAvc2Nyb2xsIGxheWVycy4gQWxzbywgd2hlbiB3ZSBjaGFuZ2UgdGhhdCBt b2RlLCB3ZSBuZWVkIHRvIGxldAorICAgICAgICB0aGUgY29tcG9zaXRvciByZXNldCBpdHMgYmFj a2luZy1zdG9yZXMgYW5kIHJlYnVpbGQgdGhlbSB3aXRob3V0IHNjcm9sbGluZy9jbGlwcGluZy4K KworICAgICAgICBUaGlzIGlzIHRlc3RlZCBieSBjb21wb3NpdGluZyB0ZXN0cywgd2hlbiBydW4g d2l0aCBRdCBpbiB0b3VjaCBtb2RlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2Up OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAg ICAgKEZyYW1lVmlldyk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpzZXREZWxlZ2F0ZXNTY3JvbGxpbmcpOgorICAgICAg ICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6 OmRlbGVnYXRlc1Njcm9sbGluZ0RpZENoYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBv c2l0b3I6OnJlcXVpcmVzU2Nyb2xsTGF5ZXIpOgorCiAyMDEyLTAxLTI2ICBOaWtvbGFzIFppbW1l cm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFNWRyArIDxvYmplY3Q+IHRl c3RzIGFyZSBmbGFrZXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA2NWI0ODNmLi4w ZjBkMDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xNzAyLDYgKzE3MDIsMTQg QEAgdm9pZCBGcmFtZVZpZXc6OnNldFNjcm9sbFBvc2l0aW9uKGNvbnN0IEludFBvaW50JiBzY3Jv bGxQb2ludCkKICAgICBTY3JvbGxWaWV3OjpzZXRTY3JvbGxQb3NpdGlvbihzY3JvbGxQb2ludCk7 CiB9CiAKK3ZvaWQgRnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2UoKQorewor I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICAvLyBXaGVuIHdlIHN3aXRjaCB0 byBkZWxnYXRlc1Njcm9sbGluZyBtb2RlLCB3ZSBzaG91bGQgZGVzdHJveSB0aGUgc2Nyb2xsaW5n L2NsaXBwaW5nIGxheWVycyBpbiBSZW5kZXJMYXllckNvbXBvc2l0b3IuCisgICAgY2xlYXJCYWNr aW5nU3RvcmVzKCk7CisjZW5kaWYKK30KKwogdm9pZCBGcmFtZVZpZXc6OnNldEZpeGVkVmlzaWJs ZUNvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIHZpc2libGVDb250ZW50UmVjdCkKIHsKICAgICBJ bnRTaXplIG9mZnNldCA9IHNjcm9sbE9mZnNldCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5k ZXggMTc2MWEwNi4uY2E2ZDNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC04OSw2ICs4 OSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkSG9yaXpvbnRhbFNjcm9sbGJh cihTY3JvbGxiYXIqKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFJlbW92ZUhvcml6b250YWxTY3Jv bGxiYXIoU2Nyb2xsYmFyKik7CiAKKyAgICB2aXJ0dWFsIHZvaWQgZGVsZWdhdGVzU2Nyb2xsaW5n RGlkQ2hhbmdlKCk7CisKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVudHNTaXplKGNvbnN0IElu dFNpemUmKTsKIAogICAgIHZvaWQgbGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlID0gdHJ1ZSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDUyY2NjNWQuLmMzNDdjMmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0yMTksNyArMjE5LDEx IEBAIHZvaWQgU2Nyb2xsVmlldzo6c2V0Q2xpcHNSZXBhaW50cyhib29sIGNsaXBzUmVwYWludHMp CiAKIHZvaWQgU2Nyb2xsVmlldzo6c2V0RGVsZWdhdGVzU2Nyb2xsaW5nKGJvb2wgZGVsZWdhdGVz U2Nyb2xsaW5nKQogeworICAgIGlmIChtX2RlbGVnYXRlc1Njcm9sbGluZyA9PSBkZWxlZ2F0ZXNT Y3JvbGxpbmcpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fZGVsZWdhdGVzU2Nyb2xsaW5nID0g ZGVsZWdhdGVzU2Nyb2xsaW5nOworICAgIGRlbGVnYXRlc1Njcm9sbGluZ0RpZENoYW5nZSgpOwog fQogCiAjaWYgIVBMQVRGT1JNKEdUSykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaApp bmRleCA1ZDM0YTkyLi5hNmMyNzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5o CkBAIC0xMjQsNiArMTI0LDcgQEAgcHVibGljOgogICAgIC8vIGFyZSBkZWxlZ2F0ZWQgdG8gdGhl IFVJIGFwcGxpY2F0aW9uLgogICAgIGJvb2wgZGVsZWdhdGVzU2Nyb2xsaW5nKCkgY29uc3QgeyBy ZXR1cm4gbV9kZWxlZ2F0ZXNTY3JvbGxpbmc7IH0KICAgICB2b2lkIHNldERlbGVnYXRlc1Njcm9s bGluZyhib29sKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGVsZWdhdGVzU2Nyb2xsaW5nRGlkQ2hhbmdl KCkgeyB9CiAKICAgICAvLyBPdmVycmlkZGVuIGJ5IEZyYW1lVmlldyB0byBjcmVhdGUgY3VzdG9t IENTUyBzY3JvbGxiYXJzIGlmIGFwcGxpY2FibGUuCiAgICAgdmlydHVhbCBQYXNzUmVmUHRyPFNj cm9sbGJhcj4gY3JlYXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0aW9uKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXgg ZTMwZWEzZC4uMzc0NTZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTE1ODMsNiArMTU4MywxMCBAQCBib29sIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6bmVlZHNDb250ZW50c0NvbXBvc2l0aW5nTGF5ZXIoY29uc3QgUmVu ZGVyTGF5ZXIqIGxheQogCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNTY3Jv bGxMYXllcihSb290TGF5ZXJBdHRhY2htZW50IGF0dGFjaG1lbnQpIGNvbnN0CiB7CisgICAgLy8g VGhpcyBhcHBsaWVzIHdoZW4gdGhlIGFwcGxpY2F0aW9uIFVJIGhhbmRsZXMgc2Nyb2xsaW5nLCBp biB3aGljaCBjYXNlIFJlbmRlckxheWVyQ29tcG9zaXRvciBkb2Vzbid0IG5lZWQgdG8gbWFuYWdl IGl0LgorICAgIGlmIChtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5kZWxlZ2F0ZXNTY3JvbGxp bmcoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgLy8gV2UgbmVlZCB0byBoYW5kbGUg b3VyIG93biBzY3JvbGxpbmcgaWYgd2UncmU6CiAgICAgcmV0dXJuICFtX3JlbmRlclZpZXctPmZy YW1lVmlldygpLT5wbGF0Zm9ybVdpZGdldCgpIC8vIHZpZXdsZXNzIChpLmUuIG5vbi1NYWMsIG9y IE1hYyBpbiBXZWJLaXQyKQogICAgICAgICB8fCBhdHRhY2htZW50ID09IFJvb3RMYXllckF0dGFj aGVkVmlhRW5jbG9zaW5nRnJhbWU7IC8vIGEgY29tcG9zaXRlZCBmcmFtZSBvbiBNYWMK 124302 2012-01-27 06:09:16 -0800 2012-01-27 07:35:57 -0800 Patch patch.diff text/plain 4631 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MjQ2ZmJlLi4wMGRlYTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMDEtMjYgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdW1dLMl0gQ2hpbGQgbGF5ZXJzIGFwcGVhciBpbiB3cm9uZyBwb3Np dGlvbiB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisK KyAgICAgICAgV2hlbiB1c2luZyB0aGUgZGVsZWdhdGVzU2Nyb2xsaW5nIG1vZGUgaW4gRnJhbWVW aWV3LCB0aGUgY29tcG9zaXRvciBkb2Vzbid0IG5lZWQKKyAgICAgICAgdG8gY29udHJvbCB0aGUg c3BlY2lhbCBjbGlwL3Njcm9sbCBsYXllcnMuIEFsc28sIHdoZW4gd2UgY2hhbmdlIHRoYXQgbW9k ZSwgd2UgbmVlZCB0byBsZXQKKyAgICAgICAgdGhlIGNvbXBvc2l0b3IgcmVzZXQgaXRzIGJhY2tp bmctc3RvcmVzIGFuZCByZWJ1aWxkIHRoZW0gd2l0aG91dCBzY3JvbGxpbmcvY2xpcHBpbmcuCisK KyAgICAgICAgVGhpcyBpcyB0ZXN0ZWQgYnkgY29tcG9zaXRpbmcgdGVzdHMsIHdoZW4gcnVuIHdp dGggUXQgaW4gdG91Y2ggbW9kZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6ZGVsZWdhdGVzU2Nyb2xsaW5nRGlkQ2hhbmdlKToK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisgICAgICAg IChGcmFtZVZpZXcpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6c2V0RGVsZWdhdGVzU2Nyb2xsaW5nKToKKyAgICAgICAg KiBwbGF0Zm9ybS9TY3JvbGxWaWV3Lmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojpk ZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpyZXF1aXJlc1Njcm9sbExheWVyKToKKwogMjAxMi0wMS0yNSAgTm8nYW0gUm9zZW50aGFs ICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtUZXhtYXBdIERpdmlkZSBU ZXh0dXJlTWFwcGVyTm9kZS5jcHAgdG8gMyBmaWxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAppbmRleCAyMTk0OGYzLi4wYjNmMzM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBA IC0xNzE1LDYgKzE3MTUsMTQgQEAgdm9pZCBGcmFtZVZpZXc6OnNldFNjcm9sbFBvc2l0aW9uKGNv bnN0IEludFBvaW50JiBzY3JvbGxQb2ludCkKICAgICBTY3JvbGxWaWV3OjpzZXRTY3JvbGxQb3Np dGlvbihzY3JvbGxQb2ludCk7CiB9CiAKK3ZvaWQgRnJhbWVWaWV3OjpkZWxlZ2F0ZXNTY3JvbGxp bmdEaWRDaGFuZ2UoKQoreworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICAv LyBXaGVuIHdlIHN3aXRjaCB0byBkZWxnYXRlc1Njcm9sbGluZyBtb2RlLCB3ZSBzaG91bGQgZGVz dHJveSB0aGUgc2Nyb2xsaW5nL2NsaXBwaW5nIGxheWVycyBpbiBSZW5kZXJMYXllckNvbXBvc2l0 b3IuCisgICAgY2xlYXJCYWNraW5nU3RvcmVzKCk7CisjZW5kaWYKK30KKwogdm9pZCBGcmFtZVZp ZXc6OnNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIHZpc2libGVDb250 ZW50UmVjdCkKIHsKICAgICBJbnRTaXplIG9mZnNldCA9IHNjcm9sbE9mZnNldCgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmgKaW5kZXggMTJhYTA3YS4uNDRmNmJlZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5oCkBAIC0zNDYsNiArMzQ2LDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgY29u dGVudHNSZXNpemVkKCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHZpc2libGVDb250ZW50 c1Jlc2l6ZWQoKTsKIAorICAgIHZpcnR1YWwgdm9pZCBkZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFu Z2UoKTsKKwogICAgIC8vIE92ZXJyaWRlIFNjcm9sbFZpZXcgbWV0aG9kcyB0byBkbyBwb2ludCBj b252ZXJzaW9uIHZpYSByZW5kZXJlcnMsIGluIG9yZGVyIHRvCiAgICAgLy8gdGFrZSB0cmFuc2Zv cm1zIGludG8gYWNjb3VudC4KICAgICB2aXJ0dWFsIEludFJlY3QgY29udmVydFRvQ29udGFpbmlu Z1ZpZXcoY29uc3QgSW50UmVjdCYpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxW aWV3LmNwcAppbmRleCA1MmNjYzVkLi5jMzQ3YzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcApAQCAtMjE5LDcgKzIxOSwxMSBAQCB2b2lkIFNjcm9sbFZpZXc6OnNldENs aXBzUmVwYWludHMoYm9vbCBjbGlwc1JlcGFpbnRzKQogCiB2b2lkIFNjcm9sbFZpZXc6OnNldERl bGVnYXRlc1Njcm9sbGluZyhib29sIGRlbGVnYXRlc1Njcm9sbGluZykKIHsKKyAgICBpZiAobV9k ZWxlZ2F0ZXNTY3JvbGxpbmcgPT0gZGVsZWdhdGVzU2Nyb2xsaW5nKQorICAgICAgICByZXR1cm47 CisKICAgICBtX2RlbGVnYXRlc1Njcm9sbGluZyA9IGRlbGVnYXRlc1Njcm9sbGluZzsKKyAgICBk ZWxlZ2F0ZXNTY3JvbGxpbmdEaWRDaGFuZ2UoKTsKIH0KIAogI2lmICFQTEFURk9STShHVEspCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgKaW5kZXggNWQzNGE5Mi4uYmE1ODZhNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaApAQCAtMzAxLDYgKzMwMSw3IEBAIHByb3Rl Y3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRPdmVyaGFuZ0FyZWFzKEdyYXBoaWNzQ29udGV4 dCosIGNvbnN0IEludFJlY3QmIGhvcml6b250YWxPdmVyaGFuZ0FyZWEsIGNvbnN0IEludFJlY3Qm IHZlcnRpY2FsT3ZlcmhhbmdBcmVhLCBjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3QpOwogCiAgICAg dmlydHVhbCB2b2lkIHZpc2libGVDb250ZW50c1Jlc2l6ZWQoKSA9IDA7CisgICAgdmlydHVhbCB2 b2lkIGRlbGVnYXRlc1Njcm9sbGluZ0RpZENoYW5nZSgpIHsgfQogCiAgICAgSW50UmVjdCBmaXhl ZFZpc2libGVDb250ZW50UmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fZml4ZWRWaXNpYmxlQ29udGVu dFJlY3Q7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcAppbmRleCA3MGNhMzNlLi4zYWVhMDQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTU4Miw2ICsx NTgyLDEwIEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpuZWVkc0NvbnRlbnRzQ29tcG9z aXRpbmdMYXllcihjb25zdCBSZW5kZXJMYXllciogbGF5CiAKIGJvb2wgUmVuZGVyTGF5ZXJDb21w b3NpdG9yOjpyZXF1aXJlc1Njcm9sbExheWVyKFJvb3RMYXllckF0dGFjaG1lbnQgYXR0YWNobWVu dCkgY29uc3QKIHsKKyAgICAvLyBUaGlzIGFwcGxpZXMgd2hlbiB0aGUgYXBwbGljYXRpb24gVUkg aGFuZGxlcyBzY3JvbGxpbmcsIGluIHdoaWNoIGNhc2UgUmVuZGVyTGF5ZXJDb21wb3NpdG9yIGRv ZXNuJ3QgbmVlZCB0byBtYW5hZ2UgaXQuCisgICAgaWYgKG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3 KCktPmRlbGVnYXRlc1Njcm9sbGluZygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAv LyBXZSBuZWVkIHRvIGhhbmRsZSBvdXIgb3duIHNjcm9sbGluZyBpZiB3ZSdyZToKICAgICByZXR1 cm4gIW1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCktPnBsYXRmb3JtV2lkZ2V0KCkgLy8gdmlld2xl c3MgKGkuZS4gbm9uLU1hYywgb3IgTWFjIGluIFdlYktpdDIpCiAgICAgICAgIHx8IGF0dGFjaG1l bnQgPT0gUm9vdExheWVyQXR0YWNoZWRWaWFFbmNsb3NpbmdGcmFtZTsgLy8gYSBjb21wb3NpdGVk IGZyYW1lIG9uIE1hYwo=