77058 2012-01-25 16:38:10 -0800 test-webkitpy: executive_unittest fails if PYTHONPATH isn't set 2012-01-26 10:27:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth mrowe ojan webkit.review.bot oldest_to_newest 542756 0 dpranke 2012-01-25 16:38:10 -0800 test-webkitpy: executive_unittest fails if PYTHONPATH isn't set 542757 1 124032 dpranke 2012-01-25 16:38:28 -0800 Created attachment 124032 Patch 542761 2 124034 dpranke 2012-01-25 16:41:23 -0800 Created attachment 124034 fix ChangeLog 542765 3 124034 eric 2012-01-25 16:45:14 -0800 Comment on attachment 124034 fix ChangeLog This seems ugly. Is this the best way to go? 542767 4 dpranke 2012-01-25 16:48:00 -0800 Without the PYTHONPATH settings, the script'll choke on the "from webkit... import lines" since it doesn't know where webkitpy is. We could probably change those to just "import executive" and have it work, but that's not normal python style. I'm open to other suggestions. 542770 5 dpranke 2012-01-25 16:50:37 -0800 Actually, if you think about it, it might be a good thing for the unit tests for executive to be ensuring what the PYTHONPATH is set to, regardless. 542811 6 124034 eric 2012-01-25 17:33:24 -0800 Comment on attachment 124034 fix ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=124034&action=review I don't really like this, but I also don't think it matters that much. Please add a comment about why we're doing this. Specifically to allow this unittest to call itself. > Tools/Scripts/test-webkitpy:45 > + webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) Why is this needed? __file__ should always be absolute, no? 542815 7 dpranke 2012-01-25 17:41:25 -0800 (In reply to comment #6) > (From update of attachment 124034 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124034&action=review > > I don't really like this, but I also don't think it matters that much. Please add a comment about why we're doing this. Specifically to allow this unittest to call itself. > Will do. > > Tools/Scripts/test-webkitpy:45 > > + webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) > > Why is this needed? __file__ should always be absolute, no? No, it isn't. Try running ./test-webkitpy and you'll see :(. 542818 8 dpranke 2012-01-25 17:47:53 -0800 Committed r105954: <http://trac.webkit.org/changeset/105954> 542961 9 abarth 2012-01-26 01:40:49 -0800 This didn't fix the problem. 543242 10 dpranke 2012-01-26 10:27:11 -0800 (In reply to comment #9) > This didn't fix the problem. Hm. Consider me completely befuddled, then. I will look into it. 124032 2012-01-25 16:38:28 -0800 2012-01-25 16:41:21 -0800 Patch bug-77058-20120125163826.patch text/plain 2561 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGNlYzNmNjIzN2QyYzEyNTYxMWQyMzlhOTI0OWIxODkx YWExODg1My4uN2ZjNjkwOTI4MjAzMGUxY2MxM2NiMmI0NTBkNTU1MzY1M2E5YzNlYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTAxLTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHk6IGV4ZWN1dGl2ZV91bml0dGVzdCBmYWlscyBpZiBQWVRIT05Q QVRIIGlzbid0IHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzcwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvdGVzdC13ZWJraXRweToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5OgorICAgICAgICAoc2NyaXB0X2Rp cik6CisgICAgICAgIChFeGVjdXRpdmVUZXN0LnNldFVwKToKKyAgICAgICAgKEV4ZWN1dGl2ZVRl c3QpOgorICAgICAgICAoRXhlY3V0aXZlVGVzdC50ZWFyRG93bik6CisKKzIwMTItMDEtMjUgIERp cmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgcnVuLXdlYmtpdC10 ZXN0cyAtLWxpbnQtdGVzdC1maWxlcyBzaG91bGQgbGludCBhbGwgdGhlIHBvcnRzIGJ5IGRlZmF1 bHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NzQ5 CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweSBiL1Rvb2xzL1Njcmlw dHMvdGVzdC13ZWJraXRweQppbmRleCA1NWFkOTdiNTVkNDUxYjY1NDAxZTZhZTcwNzM0MTc2MTBj ZjBhMjFmLi40Mjk4ZmVhZTIzNzNhN2I4YTM3YzQwZmI5YzhkMDU3NDY1YmQ5NTZhIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkKKysrIGIvVG9vbHMvU2NyaXB0cy90ZXN0 LXdlYmtpdHB5CkBAIC00Miw3ICs0Miw3IEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcigidGVz dC13ZWJraXRweSIpCiAKIAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKLSAgICB3ZWJraXRf cm9vdCA9IG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKF9f ZmlsZV9fKSkpCisgICAgd2Via2l0X3Jvb3QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJu YW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmFic3BhdGgoX19maWxlX18pKSkpCiAKICAgICAj IEZJWE1FOiBXZSBzaG91bGQgcHJvYmFibHkgdGVzdCBlYWNoIHBhY2thZ2Ugc2VwYXJhdGVseSB0 byBhdm9pZCBuYW1pbmcgY29uZmxpY3RzLgogICAgIGRpcnMgPSBbCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5w eQppbmRleCA0MjU2MDlkYTZjZTliMGEwNzM5YjgzYjFmMjFiZTIyYjNhZDg0NzA2Li45NWQ2NDQ0 NTEzMzk0YmViMjcyYjBiNjljODJjZjBiZjZiNjVlNDEyIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkK QEAgLTY3LDcgKzY3LDIxIEBAIGRlZiBjb21tYW5kX2xpbmUoY21kLCAqYXJncyk6CiAgICAgcmV0 dXJuIFtzeXMuZXhlY3V0YWJsZSwgX19maWxlX18sICctLScgKyBjbWRdICsgbGlzdChhcmdzKQog CiAKK2RlZiBzY3JpcHRfZGlyKCk6CisgICAgcmV0dXJuIG9zLnBhdGguZGlybmFtZShvcy5wYXRo LmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmFic3BhdGgo X19maWxlX18pKSkpKQorCisKIGNsYXNzIEV4ZWN1dGl2ZVRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgorICAgIGRlZiBzZXRVcChzZWxmKToKKyAgICAgICAgc2VsZi5vcmlnX3B5dGhvbnBhdGggPSBv cy5lbnZpcm9uLmdldCgnUFlUSE9OUEFUSCcpCisgICAgICAgIG9zLmVudmlyb25bJ1BZVEhPTlBB VEgnXSA9IHNjcmlwdF9kaXIoKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAgICBp ZiBzZWxmLm9yaWdfcHl0aG9ucGF0aCBpcyBub3QgTm9uZToKKyAgICAgICAgICAgIG9zLmVudmly b25bJ1BZVEhPTlBBVEgnXSA9IHNlbGYub3JpZ19weXRob25wYXRoCisgICAgICAgIGVsc2U6Cisg ICAgICAgICAgICBkZWwgb3MuZW52aXJvblsnUFlUSE9OUEFUSCddCisKICAgICBkZWYgYXNzZXJ0 X2ludGVycHJldGVyX2Zvcl9jb250ZW50KHNlbGYsIGludGVwcmV0ZXIsIGNvbnRlbnQpOgogICAg ICAgICBmcyA9IE1vY2tGaWxlU3lzdGVtKCkKICAgICAgICAgZmlsZV9wYXRoID0gTm9uZQo= 124034 2012-01-25 16:41:23 -0800 2012-01-25 17:33:24 -0800 fix ChangeLog bug-77058-20120125164122.patch text/plain 2928 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGNlYzNmNjIzN2QyYzEyNTYxMWQyMzlhOTI0OWIxODkx YWExODg1My4uYTllYzc1YmE3YjZjYzdkZWMwM2E3NTlmN2JhMTNhMTdkODE0YTI3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3 IEBACiAyMDEyLTAxLTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHk6IGV4ZWN1dGl2ZV91bml0dGVzdCBmYWlscyBpZiBQWVRIT05Q QVRIIGlzbid0IHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzcwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICByMTA1OTM1IGJyb2tlIGV4ZWN1dGl2ZV91bml0dGVzdCBieSBjaGFuZ2luZyB3aGljaCBz Y3JpcHQgd2UKKyAgICAgICAgd2VyZSBydW5uaW5nIGFuZCBub3QgZW5zdXJpbmcgdGhhdCB0aGUg UFlUSE9OUEFUSCB3YXMgc2V0IHVwCisgICAgICAgIHByb3Blcmx5LgorCisgICAgICAgIFRoaXMg Y2hhbmdlIGFsc28gZml4ZXMgYSByZWdyZXNzaW9uIGludHJvZHVjZWQgcmVjZW50bHkgd2hlcmUK KyAgICAgICAgdGVzdC13ZWJraXRweSB3YXNuJ3QgZmlndXJpbmcgb3V0IHRoZSBwYXRoIHRvIFRv b2xzL1NjcmlwdHMKKyAgICAgICAgcmlnaHQsIGVpdGhlciAoc28gcnVubmluZyAuL3Rlc3Qtd2Vi a2l0cHkgd291bGQgZmFpbCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3Rlc3Qtd2Via2l0cHk6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVz dC5weToKKyAgICAgICAgKHNjcmlwdF9kaXIpOgorICAgICAgICAoRXhlY3V0aXZlVGVzdC5zZXRV cCk6CisgICAgICAgIChFeGVjdXRpdmVUZXN0KToKKyAgICAgICAgKEV4ZWN1dGl2ZVRlc3QudGVh ckRvd24pOgorCisyMDEyLTAxLTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgLS1saW50LXRlc3QtZmlsZXMgc2hvdWxkIGxp bnQgYWxsIHRoZSBwb3J0cyBieSBkZWZhdWx0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Njc0OQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Rl c3Qtd2Via2l0cHkgYi9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkKaW5kZXggNTVhZDk3YjU1 ZDQ1MWI2NTQwMWU2YWU3MDczNDE3NjEwY2YwYTIxZi4uNDI5OGZlYWUyMzczYTdiOGEzN2M0MGZi OWM4ZDA1NzQ2NWJkOTU2YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweQpAQCAtNDIsNyArNDIsNyBAQCBfbG9n ID0gbG9nZ2luZy5nZXRMb2dnZXIoInRlc3Qtd2Via2l0cHkiKQogCiAKIGlmIF9fbmFtZV9fID09 ICJfX21haW5fXyI6Ci0gICAgd2Via2l0X3Jvb3QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5k aXJuYW1lKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXykpKQorICAgIHdlYmtpdF9yb290ID0gb3Mu cGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5hYnNw YXRoKF9fZmlsZV9fKSkpKQogCiAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIHByb2JhYmx5IHRlc3Qg ZWFjaCBwYWNrYWdlIHNlcGFyYXRlbHkgdG8gYXZvaWQgbmFtaW5nIGNvbmZsaWN0cy4KICAgICBk aXJzID0gWwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2V4ZWN1dGl2ZV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkKaW5kZXggNDI1NjA5ZGE2Y2U5YjBhMDczOWI4M2Ix ZjIxYmUyMmIzYWQ4NDcwNi4uOTVkNjQ0NDUxMzM5NGJlYjI3MmIwYjY5YzgyY2YwYmY2YjY1ZTQx MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1 dGl2ZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5CkBAIC02Nyw3ICs2NywyMSBAQCBkZWYgY29tbWFuZF9s aW5lKGNtZCwgKmFyZ3MpOgogICAgIHJldHVybiBbc3lzLmV4ZWN1dGFibGUsIF9fZmlsZV9fLCAn LS0nICsgY21kXSArIGxpc3QoYXJncykKIAogCitkZWYgc2NyaXB0X2RpcigpOgorICAgIHJldHVy biBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRo LmRpcm5hbWUob3MucGF0aC5hYnNwYXRoKF9fZmlsZV9fKSkpKSkKKworCiBjbGFzcyBFeGVjdXRp dmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAg IHNlbGYub3JpZ19weXRob25wYXRoID0gb3MuZW52aXJvbi5nZXQoJ1BZVEhPTlBBVEgnKQorICAg ICAgICBvcy5lbnZpcm9uWydQWVRIT05QQVRIJ10gPSBzY3JpcHRfZGlyKCkKKworICAgIGRlZiB0 ZWFyRG93bihzZWxmKToKKyAgICAgICAgaWYgc2VsZi5vcmlnX3B5dGhvbnBhdGggaXMgbm90IE5v bmU6CisgICAgICAgICAgICBvcy5lbnZpcm9uWydQWVRIT05QQVRIJ10gPSBzZWxmLm9yaWdfcHl0 aG9ucGF0aAorICAgICAgICBlbHNlOgorICAgICAgICAgICAgZGVsIG9zLmVudmlyb25bJ1BZVEhP TlBBVEgnXQorCiAgICAgZGVmIGFzc2VydF9pbnRlcnByZXRlcl9mb3JfY29udGVudChzZWxmLCBp bnRlcHJldGVyLCBjb250ZW50KToKICAgICAgICAgZnMgPSBNb2NrRmlsZVN5c3RlbSgpCiAgICAg ICAgIGZpbGVfcGF0aCA9IE5vbmUK