77022 2012-01-25 10:01:51 -0800 Remote web inspector reentrancy fixes 2012-02-08 07:11:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 leo webkit-unassigned jesus jturcotte kenneth webkit.review.bot oldest_to_newest 542392 0 leo 2012-01-25 10:01:51 -0800 Remote web inspector reentrancy fixes 542393 1 123965 leo 2012-01-25 10:02:26 -0800 Created attachment 123965 Patch 542395 2 leo 2012-01-25 10:03:47 -0800 The direct connection caused the tcp socket to no longer accept incoming events when waiting on a breakpoint. 542405 3 jturcotte 2012-01-25 10:10:51 -0800 It looks fine to me. Kenneth, could you have a look too? 542488 4 123965 joepeck 2012-01-25 11:35:22 -0800 Comment on attachment 123965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123965&action=review > Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:364 > #if ENABLE(INSPECTOR) A separate issue, but maybe the whole file/class should be in this enable. The InspectorServer would be pretty useless without ENABLE(INSPECTOR) =) r=me, this patch looks good to me. 552054 5 jesus 2012-02-08 05:47:59 -0800 cq+ as requested by Leo Franchi on IRC. 552098 6 123965 webkit.review.bot 2012-02-08 07:11:53 -0800 Comment on attachment 123965 Patch Clearing flags on attachment: 123965 Committed r107085: <http://trac.webkit.org/changeset/107085> 552099 7 webkit.review.bot 2012-02-08 07:11:57 -0800 All reviewed patches have been landed. Closing bug. 123965 2012-01-25 10:02:26 -0800 2012-02-08 07:11:53 -0800 Patch bug-77022-20120125130225.patch text/plain 2442 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDhhNTBmNjU2Zjc1 MDA5YzBlNWJjM2YwNzNjMWI2YWE4MTBhNDBmZGUuLmYyMDg1MDg4ZTdjMTE0ZjM5ODQ4MDlkMjE1 NTY0YzJlMjUwZWE2YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDEt MjUgIExlbyBGcmFuY2hpICA8bGZyYW5jaGlAa2RlLm9yZz4KKworICAgICAgICBSZW1vdGUgd2Vi IGluc3BlY3RvciByZWVudHJhbmN5IGZpeGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NzAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yU2VydmVyUXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU2VydmVyUmVxdWVzdEhhbmRsZXJRdDo6dGNw UmVhZHlSZWFkKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclNlcnZlclJlcXVlc3RIYW5k bGVyUXQ6OndlYlNvY2tldFJlYWR5UmVhZCk6CisKIDIwMTItMDEtMTcgIFZpYXRjaGVzbGF2IE9z dGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hlc2xhdkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0 XSBEZWJ1ZyBidWlsZCBmYWlscyB3aXRoIGRlYnVnIHF0NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JTZXJ2ZXJRdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvclNlcnZlclF0LmNwcAppbmRleCBmZGMxNGY1 MzM2MjhkMDM5OGJmYmEzNTk1MTVhNjEyY2MwMjc5YjZlLi4yNmM1MmZmODkyMGNlMWM4YmIyNjZh OWI0MmFmNWJiMzQ2NTUzZjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVT dXBwb3J0L0luc3BlY3RvclNlcnZlclF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L0luc3BlY3RvclNlcnZlclF0LmNwcApAQCAtMjA5LDcgKzIwOSw3IEBAIHZvaWQg SW5zcGVjdG9yU2VydmVyUmVxdWVzdEhhbmRsZXJRdDo6dGNwUmVhZHlSZWFkKCkKICAgICAgICAg ICAgIC8vIHN3aXRjaCB0byB3ZWJzb2NrZXQtc3R5bGUgV2ViU29ja2V0U2VydmljZSBtZXNzYWdp bmcKICAgICAgICAgICAgIGlmIChtX3RjcENvbm5lY3Rpb24pIHsKICAgICAgICAgICAgICAgICBt X3RjcENvbm5lY3Rpb24tPmRpc2Nvbm5lY3QoU0lHTkFMKHJlYWR5UmVhZCgpKSk7Ci0gICAgICAg ICAgICAgICAgY29ubmVjdChtX3RjcENvbm5lY3Rpb24sIFNJR05BTChyZWFkeVJlYWQoKSksIFNM T1Qod2ViU29ja2V0UmVhZHlSZWFkKCkpKTsKKyAgICAgICAgICAgICAgICBjb25uZWN0KG1fdGNw Q29ubmVjdGlvbiwgU0lHTkFMKHJlYWR5UmVhZCgpKSwgU0xPVCh3ZWJTb2NrZXRSZWFkeVJlYWQo KSksIFF0OjpRdWV1ZWRDb25uZWN0aW9uKTsKIAogICAgICAgICAgICAgICAgIFFCeXRlQXJyYXkg a2V5MyA9IG1fdGNwQ29ubmVjdGlvbi0+cmVhZCg4KTsKIApAQCAtMzU3LDYgKzM1NywxMCBAQCB2 b2lkIEluc3BlY3RvclNlcnZlclJlcXVlc3RIYW5kbGVyUXQ6OndlYlNvY2tldFJlYWR5UmVhZCgp CiAKICAgICAgICAgUUJ5dGVBcnJheSBwYXlsb2FkID0gbV9kYXRhLm1pZCgxLCBsZW5ndGgpOwog CisgICAgICAgIC8vIFJlbW92ZSB0aGlzIFdlYlNvY2tldCBtZXNzYWdlIGZyb20gbV9kYXRhIChw YXlsb2FkLCBzdGFydC1vZi1mcmFtZSBieXRlLCBlbmQtb2YtZnJhbWUgYnl0ZSkuCisgICAgICAg IC8vIFRydW5jYXRlIGRhdGEgYmVmb3JlIGRlbGl2ZXJpbmcgbWVzc2FnZSBpbiBjYXNlIG9mIHJl LWVudHJhbmN5LgorICAgICAgICBtX2RhdGEgPSBtX2RhdGEubWlkKGxlbmd0aCArIDIpOworICAg ICAgICAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgICAgICBpZiAobV9pbnNwZWN0b3JDbGll bnQpIHsKICAgICAgICAgICBJbnNwZWN0b3JDb250cm9sbGVyKiBpbnNwZWN0b3JDb250cm9sbGVy ID0gbV9pbnNwZWN0b3JDbGllbnQtPm1faW5zcGVjdGVkV2ViUGFnZS0+ZC0+cGFnZS0+aW5zcGVj dG9yQ29udHJvbGxlcigpOwpAQCAtMzY0LDggKzM2OCw2IEBAIHZvaWQgSW5zcGVjdG9yU2VydmVy UmVxdWVzdEhhbmRsZXJRdDo6d2ViU29ja2V0UmVhZHlSZWFkKCkKICAgICAgICAgfQogI2VuZGlm CiAKLSAgICAgICAgLy8gUmVtb3ZlIHRoaXMgV2ViU29ja2V0IG1lc3NhZ2UgZnJvbSBtX2RhdGEg KHBheWxvYWQsIHN0YXJ0LW9mLWZyYW1lIGJ5dGUsIGVuZC1vZi1mcmFtZSBieXRlKS4KLSAgICAg ICAgbV9kYXRhID0gbV9kYXRhLm1pZChsZW5ndGggKyAyKTsKICAgICB9CiB9CiAK