77009 2012-01-25 07:20:38 -0800 [Qt] The Qt MiniBrowser crashes when given multiple URL's 2012-01-26 07:28:48 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf abarth dglazkov vestbo webkit.review.bot oldest_to_newest 542243 0 ahf 2012-01-25 07:20:38 -0800 SSIA. Patch coming up. 542245 1 123933 ahf 2012-01-25 07:24:48 -0800 Created attachment 123933 Patch 542287 2 123933 webkit.review.bot 2012-01-25 08:16:18 -0800 Comment on attachment 123933 Patch Attachment 123933 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11343566 New failing tests: media/audio-garbage-collect.html 542460 3 abarth 2012-01-25 11:06:31 -0800 > media/audio-garbage-collect.html I'm sorry for the noise. I tried to mark this test as flaky, but I seem not to have succeeded. I'll try again. 542941 4 123933 hausmann 2012-01-26 01:05:22 -0800 Comment on attachment 123933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123933&action=review > Tools/ChangeLog:9 > + [Qt] The Qt MiniBrowser crashes when given multiple URL's > + https://bugs.webkit.org/show_bug.cgi?id=77009 > + > + Reviewed by NOBODY (OOPS!). > + > + * MiniBrowser/qt/BrowserWindow.cpp: > + (BrowserWindow::BrowserWindow): A word or two about _why_ it crashes would be nice :) 543099 5 124113 ahf 2012-01-26 06:19:20 -0800 Created attachment 124113 Patch 543146 6 124113 webkit.review.bot 2012-01-26 07:28:44 -0800 Comment on attachment 124113 Patch Clearing flags on attachment: 124113 Committed r106003: <http://trac.webkit.org/changeset/106003> 543147 7 webkit.review.bot 2012-01-26 07:28:48 -0800 All reviewed patches have been landed. Closing bug. 123933 2012-01-25 07:24:48 -0800 2012-01-26 06:19:13 -0800 Patch bug-77009-20120125163132.patch text/plain 2260 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzlmNTg5MjExZjg1MDFhYjRmYjdmZTY4MjkxNGE4Zjk2 ZWIwZDdkOS4uYTQzMmFjODZjZWRiMWQ0YTcwZDE2NzEzNDkxYzM2ZmIzYTE1Y2RmYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTI1ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r aWEuY29tPgorCisgICAgICAgIFtRdF0gVGhlIFF0IE1pbmlCcm93c2VyIGNyYXNoZXMgd2hlbiBn aXZlbiBtdWx0aXBsZSBVUkwncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwOgorICAgICAgICAo QnJvd3NlcldpbmRvdzo6QnJvd3NlcldpbmRvdyk6CisgICAgICAgIChCcm93c2VyV2luZG93Ojpu ZXdXaW5kb3cpOgorICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaDoKKwog MjAxMi0wMS0yNCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAK ICAgICAgICAgU29tZSBxbWFrZSBidWlsZCBmaWxlcyBtdXN0IGluY2x1ZGUgUXQ1J3MgInF1aWNr IiBtb2R1bGUuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93 LmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IDljY2I4 YTI2MzZiM2Y3MmVhMjkxMGZiNTEyMDcxNzZlMjE4ZmM0YWYuLmRlMDQ4ODk0OTgzYjEwNDNlNzE2 NGU1ZjBhMzVmMDY5YjVmZTgwODAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jy b3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cu Y3BwCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSA8UVBvaW50Rj4KIAogQnJvd3NlcldpbmRv dzo6QnJvd3NlcldpbmRvdyhXaW5kb3dPcHRpb25zKiBvcHRpb25zKQorICAgIDogbV93aW5kb3dP cHRpb25zKG9wdGlvbnMpCiB7CiAgICAgc2V0V2luZG93VGl0bGUoIk1pbmlCcm93c2VyIik7CiAg ICAgc2V0V2luZG93RmxhZ3MoUXQ6OldpbmRvdyB8IFF0OjpXaW5kb3dUaXRsZUhpbnQgfCBRdDo6 V2luZG93TWluTWF4QnV0dG9uc0hpbnQgfCBRdDo6V2luZG93Q2xvc2VCdXR0b25IaW50KTsKQEAg LTg4LDcgKzg5LDcgQEAgdm9pZCBCcm93c2VyV2luZG93Ojpmb2N1c0FkZHJlc3NCYXIoKQogCiBC cm93c2VyV2luZG93KiBCcm93c2VyV2luZG93OjpuZXdXaW5kb3coY29uc3QgUVN0cmluZyYgdXJs KQogewotICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93c2VyV2luZG93KCk7Cisg ICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJyb3dzZXJXaW5kb3cobV93aW5kb3dPcHRp b25zKTsKICAgICB3aW5kb3ctPmxvYWQodXJsKTsKICAgICByZXR1cm4gd2luZG93OwogfQpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oIGIvVG9vbHMvTWlu aUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oCmluZGV4IDk1OTNlMTAxNDg3N2Y4MjIwMjgzNzcx YTllOTYwYzc3MmJmMjRjNTIuLmQ2Y2EwYTZhNjA3NWFhODM1NzZhZGQ4YTUyYjZmOGI5Y2I3ZGY2 NzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgKQEAgLTM5LDcgKzM5LDcgQEAg Y2xhc3MgQnJvd3NlcldpbmRvdyA6IHB1YmxpYyBRUXVpY2tWaWV3IHsKICAgICBRX09CSkVDVAog CiBwdWJsaWM6Ci0gICAgQnJvd3NlcldpbmRvdyhXaW5kb3dPcHRpb25zKiA9IDApOworICAgIEJy b3dzZXJXaW5kb3coV2luZG93T3B0aW9ucyopOwogICAgIH5Ccm93c2VyV2luZG93KCk7CiAgICAg dm9pZCBsb2FkKGNvbnN0IFFTdHJpbmcmIHVybCk7CiAgICAgdm9pZCByZWxvYWQoKTsKQEAgLTU2 LDYgKzU2LDcgQEAgcHJvdGVjdGVkIHNsb3RzOgogCiBwcml2YXRlOgogICAgIHZvaWQgdXBkYXRl VXNlckFnZW50TGlzdCgpOworICAgIFdpbmRvd09wdGlvbnMqIG1fd2luZG93T3B0aW9uczsKICAg ICBRU3RyaW5nTGlzdCBtX3VzZXJBZ2VudExpc3Q7CiB9OwogCg== 124113 2012-01-26 06:19:20 -0800 2012-01-26 07:28:44 -0800 Patch bug-77009-20120126152606.patch text/plain 2460 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzlmNTg5MjExZjg1MDFhYjRmYjdmZTY4MjkxNGE4Zjk2 ZWIwZDdkOS4uN2I3YTA4MDVjZDg0ZmNkNmE2MTNhYzEwZDNmZTY0OGYzNmYxMGQ1NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAxLTI1ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r aWEuY29tPgorCisgICAgICAgIFtRdF0gVGhlIFF0IE1pbmlCcm93c2VyIGNyYXNoZXMgd2hlbiBn aXZlbiBtdWx0aXBsZSBVUkwncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGEgY3Jhc2ggaW4gQnJvd3NlcldpbmRvdzo6bmV3 V2luZG93KCkgd2hlcmUgYQorICAgICAgICBCcm93c2VyV2luZG93LW9iamVjdCBpcyBjb25zdHJ1 Y3RlZCB3aXRoIGEgMCBwb2ludGVyIGFzIHRoZQorICAgICAgICBXaW5kb3dPcHRpb25zIHBhcmFt ZXRlciB3aGljaCBsZWFkcyB0byBhIGNyYXNoLgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQv QnJvd3NlcldpbmRvdy5jcHA6CisgICAgICAgIChCcm93c2VyV2luZG93OjpCcm93c2VyV2luZG93 KToKKyAgICAgICAgKEJyb3dzZXJXaW5kb3c6Om5ld1dpbmRvdyk6CisgICAgICAgICogTWluaUJy b3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oOgorCiAyMDEyLTAxLTI0ICBTaW1vbiBIYXVzbWFubiAg PHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBTb21lIHFtYWtlIGJ1aWxkIGZp bGVzIG11c3QgaW5jbHVkZSBRdDUncyAicXVpY2siIG1vZHVsZS4KZGlmZiAtLWdpdCBhL1Rvb2xz L01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQv QnJvd3NlcldpbmRvdy5jcHAKaW5kZXggOWNjYjhhMjYzNmIzZjcyZWEyOTEwZmI1MTIwNzE3NmUy MThmYzRhZi4uZGUwNDg4OTQ5ODNiMTA0M2U3MTY0ZTVmMGEzNWYwNjliNWZlODA4MCAxMDA2NDQK LS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKKysrIGIvVG9vbHMv TWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKQEAgLTM3LDYgKzM3LDcgQEAKICNpbmNs dWRlIDxRUG9pbnRGPgogCiBCcm93c2VyV2luZG93OjpCcm93c2VyV2luZG93KFdpbmRvd09wdGlv bnMqIG9wdGlvbnMpCisgICAgOiBtX3dpbmRvd09wdGlvbnMob3B0aW9ucykKIHsKICAgICBzZXRX aW5kb3dUaXRsZSgiTWluaUJyb3dzZXIiKTsKICAgICBzZXRXaW5kb3dGbGFncyhRdDo6V2luZG93 IHwgUXQ6OldpbmRvd1RpdGxlSGludCB8IFF0OjpXaW5kb3dNaW5NYXhCdXR0b25zSGludCB8IFF0 OjpXaW5kb3dDbG9zZUJ1dHRvbkhpbnQpOwpAQCAtODgsNyArODksNyBAQCB2b2lkIEJyb3dzZXJX aW5kb3c6OmZvY3VzQWRkcmVzc0JhcigpCiAKIEJyb3dzZXJXaW5kb3cqIEJyb3dzZXJXaW5kb3c6 Om5ld1dpbmRvdyhjb25zdCBRU3RyaW5nJiB1cmwpCiB7Ci0gICAgQnJvd3NlcldpbmRvdyogd2lu ZG93ID0gbmV3IEJyb3dzZXJXaW5kb3coKTsKKyAgICBCcm93c2VyV2luZG93KiB3aW5kb3cgPSBu ZXcgQnJvd3NlcldpbmRvdyhtX3dpbmRvd09wdGlvbnMpOwogICAgIHdpbmRvdy0+bG9hZCh1cmwp OwogICAgIHJldHVybiB3aW5kb3c7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyV2luZG93LmggYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgK aW5kZXggOTU5M2UxMDE0ODc3ZjgyMjAyODM3NzFhOWU5NjBjNzcyYmYyNGM1Mi4uZDZjYTBhNmE2 MDc1YWE4MzU3NmFkZDhhNTJiNmY4YjljYjdkZjY3MCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJy b3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dz ZXJXaW5kb3cuaApAQCAtMzksNyArMzksNyBAQCBjbGFzcyBCcm93c2VyV2luZG93IDogcHVibGlj IFFRdWlja1ZpZXcgewogICAgIFFfT0JKRUNUCiAKIHB1YmxpYzoKLSAgICBCcm93c2VyV2luZG93 KFdpbmRvd09wdGlvbnMqID0gMCk7CisgICAgQnJvd3NlcldpbmRvdyhXaW5kb3dPcHRpb25zKik7 CiAgICAgfkJyb3dzZXJXaW5kb3coKTsKICAgICB2b2lkIGxvYWQoY29uc3QgUVN0cmluZyYgdXJs KTsKICAgICB2b2lkIHJlbG9hZCgpOwpAQCAtNTYsNiArNTYsNyBAQCBwcm90ZWN0ZWQgc2xvdHM6 CiAKIHByaXZhdGU6CiAgICAgdm9pZCB1cGRhdGVVc2VyQWdlbnRMaXN0KCk7CisgICAgV2luZG93 T3B0aW9ucyogbV93aW5kb3dPcHRpb25zOwogICAgIFFTdHJpbmdMaXN0IG1fdXNlckFnZW50TGlz dDsKIH07CiAK