77003 2012-01-25 03:41:28 -0800 Make publicURLManagerMap thread safe 2012-02-07 00:55:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 kaustubh.ra webkit-unassigned abarth arv dslomov kaustubh.ra levin levin+threading ojan webkit.review.bot oldest_to_newest 542157 0 kaustubh.ra 2012-01-25 03:41:28 -0800 With reference to bug - https://bugs.webkit.org/show_bug.cgi?id=74386 there are few missing fixes needed to be done. They are as follows - 1. Replace back removed "NoStaticTables" from DOMURL.idl. needed to allow this to be used with workers. 2. The methods publicURLManagerMap and publicURLManager aren't threadsafe so they has potential race conditions since it can be called on Web Worker threads as well as the main thread. Make them thread-safe. 542160 1 123915 kaustubh.ra 2012-01-25 03:45:10 -0800 Created attachment 123915 Patch Added AtomicallyInitializedStatic to make publicURLmanager thread safe. Replaced NoStaticTables. 542400 2 123915 levin 2012-01-25 10:07:54 -0800 Comment on attachment 123915 Patch Per https://bugs.webkit.org/show_bug.cgi?id=74386#c34 550693 3 kaustubh.ra 2012-02-07 00:55:57 -0800 This issue is collected in https://bugs.webkit.org/show_bug.cgi?id=74386 by rolling out the patch and fixing the patch itself. 123915 2012-01-25 03:45:10 -0800 2012-01-25 10:07:54 -0800 Patch 77003.patch text/plain 2335 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTI1ICBLYXVzdHVi aCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAgICAgIE1ha2UgcHVi bGljVVJMTWFuYWdlck1hcCB0aHJlYWQgc2FmZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcwMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvRE9NVVJMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnB1YmxpY1VSTE1hbmFnZXJNYXApOiBNYWtlIHB1YmxpY1VSTE1hbmFnZXJNYXAgdGhyZWFkLXNh ZmUuCisgICAgICAgICogaHRtbC9ET01VUkwuaWRsOiBSZXBsYWNlIGJhY2sgTm9TdGF0aWNUYWJs ZXMuCisKIDIwMTItMDEtMjUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgog CiAgICAgICAgIFVzZSBtYXhpbXVtIGltYWdlIGRpbWVuc2lvbiBkZWZpbml0aW9uIGZyb20gbGli d2VicApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9ET01VUkwuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVVJMLmNwcAkocmV2aXNpb24gMTA1ODU2KQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9ET01VUkwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3 IEBACiAjaW5jbHVkZSAiS1VSTC5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5j bHVkZSA8d3RmL01haW5UaHJlYWQuaD4KKyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAKICNp ZiBFTkFCTEUoQkxPQikKICNpbmNsdWRlICJCbG9iLmgiCkBAIC01MSw3ICs1Miw3IEBACiB0eXBl ZGVmIEhhc2hNYXA8U2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIE93blB0cjxQdWJsaWNVUkxNYW5h Z2VyPiA+IFB1YmxpY1VSTE1hbmFnZXJNYXA7CiBzdGF0aWMgUHVibGljVVJMTWFuYWdlck1hcCYg cHVibGljVVJMTWFuYWdlck1hcCgpOwogCi1jbGFzcyBQdWJsaWNVUkxNYW5hZ2VyIDogcHVibGlj IENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyIHsKK2NsYXNzIFB1YmxpY1VSTE1hbmFnZXIgOiBw dWJsaWMgQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIsIHB1YmxpYyBSZWZDb3VudGVkPFB1Ymxp Y1VSTE1hbmFnZXI+IHsKIHB1YmxpYzoKICAgICBleHBsaWNpdCBQdWJsaWNVUkxNYW5hZ2VyKFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpCiAgICAgICAgIDog Q29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkgeyB9CkBA IC04Nyw4ICs4OCw4IEBACiAKIHN0YXRpYyBQdWJsaWNVUkxNYW5hZ2VyTWFwJiBwdWJsaWNVUkxN YW5hZ2VyTWFwKCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFB1YmxpY1VSTE1hbmFnZXJN YXAsIHN0YXRpY1B1YmxpY1VSTE1hbmFnZXJzLCAoKSk7Ci0gICAgcmV0dXJuIHN0YXRpY1B1Ymxp Y1VSTE1hbmFnZXJzOworICAgIEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYyhQdWJsaWNVUkxN YW5hZ2VyTWFwKiwgc3RhdGljUHVibGljVVJMTWFuYWdlcnMgPSBuZXcgUHVibGljVVJMTWFuYWdl ck1hcCk7CisgICAgcmV0dXJuICpzdGF0aWNQdWJsaWNVUkxNYW5hZ2VyczsKIH0KIAogc3RhdGlj IFB1YmxpY1VSTE1hbmFnZXImIHB1YmxpY1VSTE1hbmFnZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9N VVJMLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0RPTVVSTC5pZGwJKHJl dmlzaW9uIDEwNTg1NikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVVJMLmlkbAkod29ya2lu ZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQAogCiBtb2R1bGUgaHRtbCB7CiAgICAgaW50ZXJmYWNl IFsKKyAgICAgICAgTm9TdGF0aWNUYWJsZXMsCiAgICAgICAgIENvbmRpdGlvbmFsPUJMT0IsCiAg ICAgICAgIEdlbmVyYXRlTmF0aXZlQ29udmVydGVyLAogICAgICAgICBHZW5lcmF0ZVRvSlMsCg==