76988 2012-01-25 01:08:12 -0800 AltGraph is supposed to be true if Alt and Ctrl are pressed 2024-01-29 16:51:13 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 76198 93017 38241 40999 1 eric eric abarth ahmad.saleem792 ap masayuki rniwa oldest_to_newest 542065 0 eric 2012-01-25 01:08:12 -0800 AltGraph is supposed to be true if Alt and Ctrl are pressed It's unclear if we want this. But I suspect some German sites might like us to support the AltGraph key, even in this synthesized manner. :) http://samples.msdn.microsoft.com/ietestcenter/domevents/KeyboardEvent.modifiers.html http://www.w3.org/TR/DOM-Level-3-Events/#key-AltGraph 542074 1 123899 eric 2012-01-25 01:31:43 -0800 Created attachment 123899 speculative fix 542306 2 ap 2012-01-25 08:43:53 -0800 Is this always the case in IE, or only for keyboard layout that actually have AltGr? 542595 3 eric 2012-01-25 13:53:16 -0800 This bug is about keyboards which don't have an AltGraph key, or specifically operating systems which chose to synthesize AltGraph by the pressing of Alt + Cntl together. The question is if the Web should generally support such a behavior for synthesizing AltGraph, regardless of what the underlying operating system does. Bug 38241 and bug 40999 are more about the cases of supporting AltGraph where it's a real key and not synthesized in this manner. 542650 4 ap 2012-01-25 14:46:01 -0800 What I'm saying is that even the synthesized behavior can be layout dependent. AltGr isn't useful on its own, it is just a modifier that lets you type certain characters easier, and that depends on layout. Anyway, I'd guess that any site that cares about AltGr also expects Windows and language-specific layout, and won't work well in a different environment. 2008083 5 ahmad.saleem792 2024-01-26 17:09:05 -0800 altGraphKey is now gone from WebKit as well as of this commit: https://github.com/WebKit/WebKit/commit/f1f9f0045afe3ae23d359d72658b600e4a623ac5 Nothing to do here. 2008377 6 masayuki 2024-01-28 22:14:32 -0800 (In reply to Ahmad Saleem from comment #5) > altGraphKey is now gone from WebKit as well as of this commit: > > https://github.com/WebKit/WebKit/commit/ > f1f9f0045afe3ae23d359d72658b600e4a623ac5 > > Nothing to do here. `.altGraphKey` is not available in `UIEvent` nor `EventModifierInit`. However, there are `modifierAltGraph` in `EventModifierInit` and `getModifierState("AltGraph")` in `UIEvent`. The latter returns `true` if the event is initialized with `modifierAltGraph = true` or represents a keyboard input which introduces a character which is different from the character without `AltGr` key on the keyboard layout. See https://bugzilla.mozilla.org/show_bug.cgi?id=900750#c24 for the detail about the user input case. 2008734 7 ahmad.saleem792 2024-01-29 16:51:13 -0800 Reopening to see what still needs to be done. 123899 2012-01-25 01:31:43 -0800 2012-01-25 01:31:43 -0800 speculative fix bug-76988-20120125013142.patch text/plain 2041 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJmZTVmMTc1ZTcwMDBh MGE5N2YyM2I4NGYyYTgwYWQxMmJlZjUyNS4uOGU4ZDkxYzg3YTkyMzA1ODY0YmI1N2ZjNDIwNDE2 NjNmMDczMmU1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTI1ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBBbHRHcmFwaCBpcyBzdXBwb3Nl ZCB0byBiZSB0cnVlIGlmIEFsdCBhbmQgQ3RybCBhcmUgcHJlc3NlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY5ODgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKwor ICAgICAgICAqIGRvbS9LZXlib2FyZEV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleWJv YXJkRXZlbnQ6OktleWJvYXJkRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6S2V5Ym9hcmRFdmVu dDo6Z2V0TW9kaWZpZXJTdGF0ZSk6CisKIDIwMTItMDEtMjQgIE1hcmlvIFNhbmNoZXogUHJhZGEg IDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZv ciBHVEsgYWZ0ZXIgcjEwNTY5OC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXli b2FyZEV2ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcAppbmRl eCBkZGQwN2E4ZGNiMjQ2YTI2NzA5ZTRlYjhkNzI5NTJjYzliYTNkMjBlLi5lYzNiOTkzOWZjMjVh OGY5ODNmYmY3ZWI1ZWQ5YmQxZWJiMmViOWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vS2V5Ym9hcmRFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZl bnQuY3BwCkBAIC02NSw3ICs2NSw5IEBAIEtleWJvYXJkRXZlbnQ6OktleWJvYXJkRXZlbnQoY29u c3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBrZXksIEFic3RyYWN0VmlldyogdmllCiAgICAgLCBt X2tleUV2ZW50KGFkb3B0UHRyKG5ldyBQbGF0Zm9ybUtleWJvYXJkRXZlbnQoa2V5KSkpCiAgICAg LCBtX2tleUlkZW50aWZpZXIoa2V5LmtleUlkZW50aWZpZXIoKSkKICAgICAsIG1fa2V5TG9jYXRp b24oa2V5LmlzS2V5cGFkKCkgPyBET01fS0VZX0xPQ0FUSU9OX05VTVBBRCA6IERPTV9LRVlfTE9D QVRJT05fU1RBTkRBUkQpIC8vIEZJWE1FOiBkaWZmZXJlbnRpYXRlIHJpZ2h0L2xlZnQsIHRvbwot ICAgICwgbV9hbHRHcmFwaEtleShmYWxzZSkKKyAgICAvLyBBbHRHcmFwaCBpcyB0aGUgY29tYmlu YXRpb24gb2YgQWx0IGFuZCBDdHJsIGF0IHRoZSBzYW1lIHRpbWU6CisgICAgLy8gaHR0cDovL3d3 dy53My5vcmcvVFIvRE9NLUxldmVsLTMtRXZlbnRzLyNrZXktQWx0R3JhcGgKKyAgICAsIG1fYWx0 R3JhcGhLZXkoa2V5LmN0cmxLZXkoKSAmJiBrZXkuYWx0S2V5KCkpCiB7CiB9CiAKQEAgLTExMSw2 ICsxMTMsMTAgQEAgYm9vbCBLZXlib2FyZEV2ZW50OjpnZXRNb2RpZmllclN0YXRlKGNvbnN0IFN0 cmluZyYga2V5SWRlbnRpZmllcikgY29uc3QKICAgICAgICAgcmV0dXJuIGFsdEtleSgpOwogICAg IGlmIChrZXlJZGVudGlmaWVyID09ICJNZXRhIikKICAgICAgICAgcmV0dXJuIG1ldGFLZXkoKTsK KyAgICBpZiAoa2V5SWRlbnRpZmllciA9PSAiQWx0R3JhcGgiKQorICAgICAgICByZXR1cm4gY3Ry bEtleSgpICYmIGFsdEtleSgpOworICAgIC8vIEZJWE1FOiBEbyB3ZSBuZWVkIHRvIHN1cHBvcnQg Q2Fwc0xvY2ssIE51bUxvY2ssIFNjcm9sbCBTeW1ib2xMb2NrLCBGbiBvciBXaW4/CisgICAgLy8g aHR0cDovL3d3dy53My5vcmcvVFIvRE9NLUxldmVsLTMtRXZlbnRzLyNldmVudHMtS2V5Ym9hcmRF dmVudC1nZXRNb2RpZmllclN0YXRlCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCg==