76982 2012-01-24 22:41:45 -0800 File extension for webp files is .webp 2012-01-26 15:44:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon abarth pascal.massimino webkit.review.bot oldest_to_newest 542022 0 noel.gordon 2012-01-24 22:41:45 -0800 File extension for webp files is .webp 542023 1 123886 noel.gordon 2012-01-24 22:42:50 -0800 Created attachment 123886 Patch 542035 2 123886 abarth 2012-01-24 23:28:09 -0800 Comment on attachment 123886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123886&action=review > Source/WebCore/ChangeLog:8 > + No new tests. No change in behavior. This doesn't change behavior? Is this change observable somehow? 542036 3 123886 abarth 2012-01-24 23:29:09 -0800 Comment on attachment 123886 Patch I'm marking this r+ in case there isn't a way to test this (referring to our earlier conversation about timezones causing 24hr latency on questions). However, if there is a way to test this change, we should include a test. That might require digging a bit to understand what this function is used for. 542042 4 noel.gordon 2012-01-24 23:42:17 -0800 > This doesn't change behavior? Is this change observable somehow? Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change. 542044 5 abarth 2012-01-24 23:43:45 -0800 > Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change. We'll need to look at the callers of this function to understand what they're using this information for and craft a test that exercises them. If no one uses this information for anything observable, we should remove the function. 542635 6 noel.gordon 2012-01-25 14:33:02 -0800 Thanks Adam. I'm OOO today and will dig around as you suggested Friday my time. 543513 7 noel.gordon 2012-01-26 14:54:20 -0800 filenameExtension() was added to BitmapImage{.h.cpp} in http://trac.webkit.org/changeset/39185 to resolve bug 20685. A manual test was added at that time. I can't access the bug, the code change hints at some security issue with drag drop. 543525 8 abarth 2012-01-26 15:00:33 -0800 We can problem unprotect that bug as this point, but this isn't really testable in an automated way. Thanks for tracking it down. 543590 9 123886 webkit.review.bot 2012-01-26 15:44:37 -0800 Comment on attachment 123886 Patch Clearing flags on attachment: 123886 Committed r106055: <http://trac.webkit.org/changeset/106055> 543591 10 webkit.review.bot 2012-01-26 15:44:42 -0800 All reviewed patches have been landed. Closing bug. 123886 2012-01-24 22:42:50 -0800 2012-01-26 15:44:37 -0800 Patch bug-76982-20120125174247.patch text/plain 1506 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1ODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMwYjE1MGI0OWRjMjA0 MzMzZmUzOGFiZjVkY2U2MzNkZjY1YjQ2My4uMTg4ZDE4Zjc4NTA3MTFlNmI3YjIzMmQ4YjMyYzI1 YTA1ZDFkMWIzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTI0ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBGaWxlIGV4dGVuc2lv biBmb3Igd2VicCBmaWxlcyBpcyAud2VicAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzY5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKwor ICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5o OgorICAgICAgICAoV2ViQ29yZTo6V0VCUEltYWdlRGVjb2Rlcjo6ZmlsZW5hbWVFeHRlbnNpb24p OgorCiAyMDEyLTAxLTI0ICBLZW4gQnVjaGFuYW4gIDxrZW5yYkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ3Jhc2ggaW4gdXBkYXRlRmlyc3RMZXR0ZXIoKSBmcm9tIHVubmVjZXNzYXJ5IGFub255 bW91cyBibG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVj b2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuaAppbmRleCAzY2NhYjI1MTYwZWIx YjMxMmNmN2YxNDQzYTdjMjc1MWQyZmZhMDIzLi42MWVhMTM5NTM0YzY4MTRhZGQ1MjI0N2YzZTBk OGE2NzczMGUyNzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuaApAQCAtNDIsNyArNDIs NyBAQCBwdWJsaWM6CiAgICAgV0VCUEltYWdlRGVjb2RlcihJbWFnZVNvdXJjZTo6QWxwaGFPcHRp b24sIEltYWdlU291cmNlOjpHYW1tYUFuZENvbG9yUHJvZmlsZU9wdGlvbik7CiAgICAgdmlydHVh bCB+V0VCUEltYWdlRGVjb2RlcigpOwogCi0gICAgdmlydHVhbCBTdHJpbmcgZmlsZW5hbWVFeHRl bnNpb24oKSBjb25zdCB7IHJldHVybiAidnA4IjsgfQorICAgIHZpcnR1YWwgU3RyaW5nIGZpbGVu YW1lRXh0ZW5zaW9uKCkgY29uc3QgeyByZXR1cm4gIndlYnAiOyB9CiAgICAgdmlydHVhbCBib29s IGlzU2l6ZUF2YWlsYWJsZSgpOwogICAgIHZpcnR1YWwgSW1hZ2VGcmFtZSogZnJhbWVCdWZmZXJB dEluZGV4KHNpemVfdCBpbmRleCk7CiAK