76979 2012-01-24 21:30:54 -0800 webkit-unit-test bustage doesn't turn the EWS red 2012-06-19 00:38:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth jamesr oldest_to_newest 541993 0 webkit.review.bot 2012-01-24 21:30:54 -0800 webkit-unit-test bustage doesn't turn the EWS red Requested by abarth on #webkit. 542098 1 abarth 2012-01-25 02:14:33 -0800 I understand what's causing this issue. When the webkit-unit-tests fail, we think that run-webkit-tests crashed and that the results are unreliable. Therefore, we retry the patch rather than failing it. 542100 2 abarth 2012-01-25 02:16:07 -0800 Right now there's a problem that the unit tests are red and therefore are blocking the EWS from processing patches. I'm going to disable them temporarily. 542102 3 abarth 2012-01-25 02:17:02 -0800 The solution to both problems is to understand what set of unit tests failed on a given run rather than just a binary "did pass all tests". 542104 4 abarth 2012-01-25 02:18:50 -0800 Disabled in http://trac.webkit.org/changeset/105857. 542109 5 jamesr 2012-01-25 02:24:41 -0800 Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place. 542112 6 abarth 2012-01-25 02:28:43 -0800 > Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place. We can do that as well. This is a systemic problem. The unit tests aren't properly integrated with the EWS. 652160 7 abarth 2012-06-19 00:38:20 -0700 jamesr fixenated this bug.