76962 2012-01-24 16:40:45 -0800 garden-o-matic pixel zoomer should let you look at every pixel of the image 2012-01-24 17:04:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov leviw ojan webkit.review.bot oldest_to_newest 541840 0 abarth 2012-01-24 16:40:45 -0800 garden-o-matic pixel zoomer should let you look at every pixel of the image 541841 1 123841 abarth 2012-01-24 16:43:00 -0800 Created attachment 123841 Patch 541845 2 123841 leviw 2012-01-24 16:45:43 -0800 Comment on attachment 123841 Patch LGTM, but you'll need a real reviewer ;) 541849 3 123841 ojan 2012-01-24 16:49:41 -0800 Comment on attachment 123841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123841&action=review Extra points if you fix the pixel zoomer in results.html as well. :) > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:107 > + image.style.left = -(pixelzoomer._percentX * kZoomedResultWidth) + containerBounds.width/2 + 'px'; > + image.style.top = -(pixelzoomer._percentY * kZoomedResultHeight) + containerBounds.height/2 + 'px'; Nit: Need spaces around the /. I'd also wrap the whole equation in parens to make it clear which part is math and which part is string concat. 541854 4 abarth 2012-01-24 16:56:28 -0800 Committed r105834: <http://trac.webkit.org/changeset/105834> 541863 5 abarth 2012-01-24 17:04:28 -0800 Oops. I missed your comments before landing. Will fix. 123841 2012-01-24 16:43:00 -0800 2012-01-24 16:49:40 -0800 Patch bug-76962-20120124164308.patch text/plain 3650 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNTgzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAxLTI0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgZ2FyZGVuLW8tbWF0aWMgcGl4ZWwgem9vbWVyIHNob3VsZCBsZXQgeW91IGxvb2sg YXQgZXZlcnkgcGl4ZWwgb2YgdGhlIGltYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Njk2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIHlvdSBjb3VsZG4ndCBnZXQgdXAgdG8gdGhl IHJpZ2h0IGFuZCBib3R0b20gcGl4ZWxzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv cGl4ZWx6b29tZXIuanM6CisKIDIwMTItMDEtMjQgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWJIVE1MVmlldyBzaG91bGQgaW1wbGVtZW50IHR5cGluZ0F0 dHJpYnV0ZXMgbWV0aG9kcyB0byB3b3JrIGNvcnJlY3RseSB3aXRoIHRoZSBJbnNwZWN0b3IgYmFy IGluIE1haWwuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9waXhlbHpvb21lci5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9waXhlbHpvb21lci5qcwkocmV2 aXNpb24gMTA1Nzk2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvcGl4ZWx6b29tZXIuanMJ KHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDEyIEBAIHZhciBwaXhlbHpvb21lciA9IHBpeGVs em9vbWVyIHx8IHt9OwogdmFyIGtab29tRmFjdG9yID0gNjsKIHZhciBrRGVsYXlUaW1lb3V0TVMg PSA0MDA7CiAKK3ZhciBrUmVzdWx0V2lkdGggPSA4MDA7Cit2YXIga1Jlc3VsdEhlaWdodCA9IDYw MDsKKwordmFyIGtab29tZWRSZXN1bHRXaWR0aCA9IGtSZXN1bHRXaWR0aCAqIGtab29tRmFjdG9y OwordmFyIGtab29tZWRSZXN1bHRIZWlnaHQgPSBrUmVzdWx0SGVpZ2h0ICoga1pvb21GYWN0b3I7 CisKIGZ1bmN0aW9uIG1hdGNoZXNTZWxlY3Rvcihub2RlLCBzZWxlY3RvcikKIHsKICAgICBpZiAo bm9kZS53ZWJraXRNYXRjaGVzU2VsZWN0b3IpCkBAIC02OCw2ICs3NCw5IEBAIGZ1bmN0aW9uIHpv b21JbWFnZUNvbnRhaW5lcih1cmwpCiAKICAgICB2YXIgaW1hZ2UgPSBuZXcgSW1hZ2UoKTsKICAg ICBpbWFnZS5zcmMgPSB1cmw7CisgICAgaW1hZ2Uuc3R5bGUud2lkdGggPSBrWm9vbWVkUmVzdWx0 V2lkdGggKyAncHgnOworICAgIGltYWdlLnN0eWxlLmhlaWdodCA9IGtab29tZWRSZXN1bHRIZWln aHQgKyAncHgnOworICAgIGltYWdlLnN0eWxlLmJvcmRlciA9ICcxcHggc29saWQgYmxhY2snOwog ICAgIGltYWdlQ29udGFpbmVyLmFwcGVuZENoaWxkKGltYWdlKTsKICAgICBjb250YWluZXIuYXBw ZW5kQ2hpbGQoaW1hZ2VDb250YWluZXIpOwogCkBAIC05MiwyMSArMTAxLDEwIEBAIGZ1bmN0aW9u IGNyZWF0ZUNvbnRhaW5lcihlKQogCiBmdW5jdGlvbiBkcmF3KGltYWdlQ29udGFpbmVyKQogewot ICAgIHZhciBjb250YWluZXJXaWR0aCA9IGltYWdlQ29udGFpbmVyLm9mZnNldFdpZHRoOwotICAg IHZhciBjb250YWluZXJIZWlnaHQgPSBpbWFnZUNvbnRhaW5lci5vZmZzZXRIZWlnaHQ7Ci0KLSAg ICB2YXIgc2NhbGVkTWlkZGxlWCA9IHBpeGVsem9vbWVyLl9jdXJyZW50WCAqIGtab29tRmFjdG9y OwotICAgIHZhciBzY2FsZWRNaWRkbGVZID0gcGl4ZWx6b29tZXIuX2N1cnJlbnRZICoga1pvb21G YWN0b3I7Ci0KLSAgICB2YXIgbGVmdCA9IHNjYWxlZE1pZGRsZVggLSBjb250YWluZXJXaWR0aCAv IDI7Ci0gICAgdmFyIHRvcCA9IHNjYWxlZE1pZGRsZVkgLSBjb250YWluZXJIZWlnaHQgLyAyOwot CiAgICAgdmFyIGltYWdlID0gaW1hZ2VDb250YWluZXIucXVlcnlTZWxlY3RvcignaW1nJyk7Ci0g ICAgaW1hZ2Uuc3R5bGUud2lkdGggPSAoODAwICoga1pvb21GYWN0b3IpICsgJ3B4JzsKLSAgICBp bWFnZS5zdHlsZS5oZWlnaHQgPSAoNjAwICoga1pvb21GYWN0b3IpICsgJ3B4JzsKLQotICAgIGlt YWdlLnN0eWxlLnRvcCA9IC10b3AgKyAncHgnOwotICAgIGltYWdlLnN0eWxlLmxlZnQgPSAtbGVm dCArICdweCc7CisgICAgdmFyIGNvbnRhaW5lckJvdW5kcyA9IGltYWdlQ29udGFpbmVyLmdldEJv dW5kaW5nQ2xpZW50UmVjdCgpOworICAgIGltYWdlLnN0eWxlLmxlZnQgPSAtKHBpeGVsem9vbWVy Ll9wZXJjZW50WCAqIGtab29tZWRSZXN1bHRXaWR0aCkgKyBjb250YWluZXJCb3VuZHMud2lkdGgv MiArICdweCc7CisgICAgaW1hZ2Uuc3R5bGUudG9wID0gLShwaXhlbHpvb21lci5fcGVyY2VudFkg KiBrWm9vbWVkUmVzdWx0SGVpZ2h0KSArIGNvbnRhaW5lckJvdW5kcy5oZWlnaHQvMiArICdweCc7 CiB9CiAKIGZ1bmN0aW9uIGRyYXdBbGwoKQpAQCAtMTMyLDcgKzEzMCw3IEBAIGZ1bmN0aW9uIGhh bmRsZU1vdXNlTW92ZShlKQogICAgICAgICByZXR1cm47CiAKICAgICB2YXIgY29udGFpbmVyID0g ZG9jdW1lbnQucXVlcnlTZWxlY3RvcignLnBpeGVsLXpvb20tY29udGFpbmVyJyk7Ci0gICAgCisK ICAgICB2YXIgcmVzdWx0Q29udGFpbmVyID0gKGUudGFyZ2V0LmNsYXNzTmFtZSA9PSAncmVzdWx0 LWNvbnRhaW5lcicpID8KICAgICAgICAgZS50YXJnZXQgOiBwYXJlbnRPZlR5cGUoZS50YXJnZXQs ICcucmVzdWx0LWNvbnRhaW5lcicpOwogICAgIGlmICghcmVzdWx0Q29udGFpbmVyIHx8ICFyZXN1 bHRDb250YWluZXIucXVlcnlTZWxlY3RvcignaW1nJykpIHsKQEAgLTE0MSw4ICsxMzksOCBAQCBm dW5jdGlvbiBoYW5kbGVNb3VzZU1vdmUoZSkKICAgICB9CiAKICAgICB2YXIgdGFyZ2V0TG9jYXRp b24gPSBlLnRhcmdldC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKLSAgICBwaXhlbHpvb21lci5f Y3VycmVudFggPSBlLmNsaWVudFggLSB0YXJnZXRMb2NhdGlvbi5sZWZ0OwotICAgIHBpeGVsem9v bWVyLl9jdXJyZW50WSA9IGUuY2xpZW50WSAtIHRhcmdldExvY2F0aW9uLnRvcDsKKyAgICBwaXhl bHpvb21lci5fcGVyY2VudFggPSAoZS5jbGllbnRYIC0gdGFyZ2V0TG9jYXRpb24ubGVmdCkgLyB0 YXJnZXRMb2NhdGlvbi53aWR0aDsKKyAgICBwaXhlbHpvb21lci5fcGVyY2VudFkgPSAoZS5jbGll bnRZIC0gdGFyZ2V0TG9jYXRpb24udG9wKSAvIHRhcmdldExvY2F0aW9uLmhlaWdodDsKIAogICAg IGlmICghY29udGFpbmVyKSB7CiAgICAgICAgIGlmIChwaXhlbHpvb21lci5zaG93T25EZWxheSkg ewo=