76960 2012-01-24 16:35:44 -0800 Initializing the browser property of the Bugzilla class takes too long 2012-01-24 18:14:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dpranke eric webkit.review.bot oldest_to_newest 541834 0 ojan 2012-01-24 16:35:44 -0800 Initializing the browser property of the Bugzilla class takes too long 541836 1 123839 ojan 2012-01-24 16:36:39 -0800 Created attachment 123839 Patch 541838 2 123839 abarth 2012-01-24 16:39:34 -0800 Comment on attachment 123839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123839&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270 > + def _get_browser(self): Can we just make this memoized? 541843 3 ojan 2012-01-24 16:45:06 -0800 (In reply to comment #2) > (From update of attachment 123839 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123839&action=review > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270 > > + def _get_browser(self): > > Can we just make this memoized? No, the tests rely on being able to set .browser. So, we need a setter, which means we can't. 541903 4 123839 webkit.review.bot 2012-01-24 17:44:23 -0800 Comment on attachment 123839 Patch Rejecting attachment 123839 from commit-queue. New failing tests: media/audio-garbage-collect.html Full output: http://queues.webkit.org/results/11342147 541937 5 123839 webkit.review.bot 2012-01-24 18:14:08 -0800 Comment on attachment 123839 Patch Clearing flags on attachment: 123839 Committed r105842: <http://trac.webkit.org/changeset/105842> 541938 6 webkit.review.bot 2012-01-24 18:14:13 -0800 All reviewed patches have been landed. Closing bug. 123839 2012-01-24 16:36:39 -0800 2012-01-24 18:14:08 -0800 Patch bug-76960-20120124163638.patch text/plain 2192 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmM5ZWQ4Y2E3NzQ3MGFmYWMxMjFmNDE1MzY5ZjNhZmVi ODMyYWU3YS4uODQ0M2QyYTljMDk1ODVhYzc0MDRkZDNlYWFjZDQ4Y2MxNTczM2U4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAxLTI0ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgSW5pdGlhbGl6aW5nIHRoZSBicm93c2VyIHByb3BlcnR5IG9mIHRoZSBCdWd6aWxsYSBjbGFz cyB0YWtlcyB0b28gbG9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzY5NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBMYXppbHkgaW5pdGlhbGl6ZSBpdC4gVGhpcyBzYXZlcyB+MTUwbXMgb24gYSBuby1v cCBydW4td2Via2l0LXRlc3RzIGNhbGwKKyAgICAgICAgb24gbXkgTWFjIFByby4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weToKKyAg ICAgICAgKEJ1Z3ppbGxhLl9faW5pdF9fKToKKyAgICAgICAgKEJ1Z3ppbGxhLl9nZXRfYnJvd3Nl cik6CisgICAgICAgIChCdWd6aWxsYSk6CisgICAgICAgIChCdWd6aWxsYS5fc2V0X2Jyb3dzZXIp OgorCiAyMDEyLTAxLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgY2hlY2std2Via2l0LXN0eWxlIG9mIHRoZSBjaHJvbWl1bSB0ZXN0X2V4cGVjdGF0aW9ucy50 eHQgZmlsZSB0YWtlcyB0b28gbG9uZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CmluZGV4IDQzOThmODhiNTQ2YWM0MjZj NDgyZTI0OTk2YjllYmNiZWEwOTg1YzYuLmEzMmU4NmUxMzNlMzYyOTRjMGMwMTVhN2MwZTMyYTlj MzZhMjE1NmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWd6aWxsYS9idWd6aWxsYS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVnemlsbGEvYnVnemlsbGEucHkKQEAgLTI2NSwxMSArMjY1LDIwIEBAIGNsYXNzIEJ1Z3pp bGxhKG9iamVjdCk6CiAgICAgICAgIHNlbGYuY29tbWl0dGVycyA9IGNvbW1pdHRlcnMKICAgICAg ICAgc2VsZi5jYWNoZWRfcXVpcHMgPSBbXQogICAgICAgICBzZWxmLmVkaXRfdXNlcl9wYXJzZXIg PSBFZGl0VXNlcnNQYXJzZXIoKQorICAgICAgICBzZWxmLl9icm93c2VyID0gTm9uZQogCi0gICAg ICAgIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFsbGVkLm1lY2hhbml6ZSBpbXBv cnQgQnJvd3NlcgotICAgICAgICBzZWxmLmJyb3dzZXIgPSBCcm93c2VyKCkKLSAgICAgICAgIyBJ Z25vcmUgYnVncy53ZWJraXQub3JnL3JvYm90cy50eHQgdW50aWwgd2UgZml4IGl0IHRvIGFsbG93 IHRoaXMgc2NyaXB0LgotICAgICAgICBzZWxmLmJyb3dzZXIuc2V0X2hhbmRsZV9yb2JvdHMoRmFs c2UpCisgICAgZGVmIF9nZXRfYnJvd3NlcihzZWxmKToKKyAgICAgICAgaWYgbm90IHNlbGYuX2Jy b3dzZXI6CisgICAgICAgICAgICBmcm9tIHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxl ZC5tZWNoYW5pemUgaW1wb3J0IEJyb3dzZXIKKyAgICAgICAgICAgIHNlbGYuX2Jyb3dzZXIgPSBC cm93c2VyKCkKKyAgICAgICAgICAgICMgSWdub3JlIGJ1Z3Mud2Via2l0Lm9yZy9yb2JvdHMudHh0 IHVudGlsIHdlIGZpeCBpdCB0byBhbGxvdyB0aGlzIHNjcmlwdC4KKyAgICAgICAgICAgIHNlbGYu X2Jyb3dzZXIuc2V0X2hhbmRsZV9yb2JvdHMoRmFsc2UpCisgICAgICAgIHJldHVybiBzZWxmLl9i cm93c2VyCisKKyAgICBkZWYgX3NldF9icm93c2VyKHNlbGYsIHZhbHVlKToKKyAgICAgICAgc2Vs Zi5fYnJvd3NlciA9IHZhbHVlCisKKyAgICBicm93c2VyID0gcHJvcGVydHkoX2dldF9icm93c2Vy LCBfc2V0X2Jyb3dzZXIpCiAKICAgICBkZWYgZmV0Y2hfdXNlcihzZWxmLCB1c2VyX2lkKToKICAg ICAgICAgc2VsZi5hdXRoZW50aWNhdGUoKQo=