76943 2012-01-24 13:58:34 -0800 REGRESSION(r105238): Remove the assert text hack as it served its purpose. (Requested by dave_levin on #webkit). 2012-01-24 14:04:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76503 1 webkit.review.bot webkit.review.bot abarth levin oldest_to_newest 541657 0 webkit.review.bot 2012-01-24 13:58:34 -0800 http://trac.webkit.org/changeset/105238 broke the build: Remove the assert text hack as it served its purpose. (Requested by dave_levin on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 541659 1 123802 webkit.review.bot 2012-01-24 13:59:04 -0800 Created attachment 123802 ROLLOUT of r105238 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 541670 2 123802 webkit.review.bot 2012-01-24 14:04:30 -0800 Comment on attachment 123802 ROLLOUT of r105238 Clearing flags on attachment: 123802 Committed r105804: <http://trac.webkit.org/changeset/105804> 541671 3 webkit.review.bot 2012-01-24 14:04:35 -0800 All reviewed patches have been landed. Closing bug. 123802 2012-01-24 13:59:04 -0800 2012-01-24 14:04:30 -0800 ROLLOUT of r105238 bug-76943-20120124220016.patch text/plain 5138 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1ODAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU3NDkyYjZkZWM2Y2Qz ODYwOTJmMjczODhmYzEwZTUwOTBhMDI2Zi4uMGFhYjliMmZkM2U1YWMwZTU4YTk1ZGVjOWVlMjFm ZjJkYzgwYjQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI0ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTA1MjM4LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMDUyMzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc2OTQzCisKKyAgICAgICAgUmVtb3ZlIHRoZSBhc3NlcnQgdGV4dCBoYWNrIGFz IGl0IHNlcnZlZCBpdHMgcHVycG9zZS4KKyAgICAgICAgKFJlcXVlc3RlZCBieSBkYXZlX2xldmlu IG9uICN3ZWJraXQpLgorCisgICAgICAgICogZG9tL0FjdGl2ZURPTU9iamVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcjo6Q29udGV4dERlc3RydWN0 aW9uT2JzZXJ2ZXIpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dERlc3RydWN0aW9uT2JzZXJ2 ZXI6On5Db250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcik6CisgICAgICAgIChXZWJDb3JlOjpBY3Rp dmVET01PYmplY3Q6OkFjdGl2ZURPTU9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpBY3RpdmVE T01PYmplY3Q6On5BY3RpdmVET01PYmplY3QpOgorICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2VT eW5jLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlU3luYzo6b3BlbkRhdGFiYXNlU3lu Yyk6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVN5bmM6On5EYXRhYmFzZVN5bmMpOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YWJhc2VTeW5jOjpjaGFuZ2VWZXJzaW9uKToKKyAgICAgICAgKFdl YkNvcmU6OkRhdGFiYXNlU3luYzo6cnVuVHJhbnNhY3Rpb24pOgorCiAyMDEyLTAxLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbUmVmYWN0b3Jpbmdd IEluIENvZGVHZW5lcmF0b3JHT2JqZWN0LnBtLCBtZXJnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0FjdGl2ZURPTU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQWN0aXZl RE9NT2JqZWN0LmNwcAppbmRleCAxOTg3YTE5NjE3YmQ4Mzc5NzE0ZTg4ZDJjZDQyZjMzOWJiZWQ3 N2E3Li4zOWE0YzRjNmI5MWVkNjIzMzkwMGE1Y2JmNzY2MmM4YTRmYWI1N2Q2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vQWN0aXZlRE9NT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vQWN0aXZlRE9NT2JqZWN0LmNwcApAQCAtMzksNyArMzksNyBAQCBDb250ZXh0RGVz dHJ1Y3Rpb25PYnNlcnZlcjo6Q29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCogcwogICAgIGlmICghbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KQogICAgICAg ICByZXR1cm47CiAKLSAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0NvbnRl eHRUaHJlYWQoKSAmJiAxKTsKKyAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5p c0NvbnRleHRUaHJlYWQoKSk7CiAgICAgbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5kaWRDcmVh dGVEZXN0cnVjdGlvbk9ic2VydmVyKHRoaXMpOwogfQogCkBAIC00OCw3ICs0OCw3IEBAIENvbnRl eHREZXN0cnVjdGlvbk9ic2VydmVyOjp+Q29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIoKQogICAg IGlmICghbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KQogICAgICAgICByZXR1cm47CiAKLSAgICBB U1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0NvbnRleHRUaHJlYWQoKSAmJiAyKTsK KyAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0NvbnRleHRUaHJlYWQoKSk7 CiAgICAgbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT53aWxsRGVzdHJveURlc3RydWN0aW9uT2Jz ZXJ2ZXIodGhpcyk7CiB9CiAKQEAgLTY0LDcgKzY0LDcgQEAgQWN0aXZlRE9NT2JqZWN0OjpBY3Rp dmVET01PYmplY3QoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCwKICAgICBpZiAoIW1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgQVNTRVJUKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNDb250ZXh0VGhyZWFkKCkg JiYgMyk7CisgICAgQVNTRVJUKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNDb250ZXh0VGhy ZWFkKCkpOwogICAgIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+ZGlkQ3JlYXRlQWN0aXZlRE9N T2JqZWN0KHRoaXMsIHVwY2FzdFBvaW50ZXIpOwogfQogCkBAIC03Myw3ICs3Myw3IEBAIEFjdGl2 ZURPTU9iamVjdDo6fkFjdGl2ZURPTU9iamVjdCgpCiAgICAgaWYgKCFtX3NjcmlwdEV4ZWN1dGlv bkNvbnRleHQpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFTU0VSVChtX3NjcmlwdEV4ZWN1dGlv bkNvbnRleHQtPmlzQ29udGV4dFRocmVhZCgpICYmIDQpOworICAgIEFTU0VSVChtX3NjcmlwdEV4 ZWN1dGlvbkNvbnRleHQtPmlzQ29udGV4dFRocmVhZCgpKTsKICAgICBtX3NjcmlwdEV4ZWN1dGlv bkNvbnRleHQtPndpbGxEZXN0cm95QWN0aXZlRE9NT2JqZWN0KHRoaXMpOwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlU3luYy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9zdG9yYWdlL0RhdGFiYXNlU3luYy5jcHAKaW5kZXggMDBkM2M1N2NkMGI4NzYxZDZjNmMy YzY0ODliMjkzZDc2YzY0MjQ0YS4uMWQ4MTI5ZGMyZDg5ODFjOWYyYTgzNzI5NDc5MmU0YTVhMzY2 NGJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZVN5bmMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VTeW5jLmNwcApAQCAtNTAsNyAr NTAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBQYXNzUmVmUHRyPERhdGFiYXNlU3luYz4gRGF0 YWJhc2VTeW5jOjpvcGVuRGF0YWJhc2VTeW5jKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRl eHQsIGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBleHBlY3RlZFZlcnNpb24sIGNv bnN0IFN0cmluZyYgZGlzcGxheU5hbWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZXN0aW1hdGVkU2l6ZSwgUGFz c1JlZlB0cjxEYXRhYmFzZUNhbGxiYWNrPiBjcmVhdGlvbkNhbGxiYWNrLCBFeGNlcHRpb25Db2Rl JiBlYykKIHsKLSAgICBBU1NFUlQoY29udGV4dC0+aXNDb250ZXh0VGhyZWFkKCkgJiYgMjApOwor ICAgIEFTU0VSVChjb250ZXh0LT5pc0NvbnRleHRUaHJlYWQoKSk7CiAKICAgICBpZiAoIURhdGFi YXNlVHJhY2tlcjo6dHJhY2tlcigpLmNhbkVzdGFibGlzaERhdGFiYXNlKGNvbnRleHQsIG5hbWUs IGRpc3BsYXlOYW1lLCBlc3RpbWF0ZWRTaXplKSkgewogICAgICAgICBMT0coU3RvcmFnZUFQSSwg IkRhdGFiYXNlICVzIGZvciBvcmlnaW4gJXMgbm90IGFsbG93ZWQgdG8gYmUgZXN0YWJsaXNoZWQi LCBuYW1lLmFzY2lpKCkuZGF0YSgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT50b1N0cmlu ZygpLmFzY2lpKCkuZGF0YSgpKTsKQEAgLTg0LDcgKzg0LDcgQEAgRGF0YWJhc2VTeW5jOjpEYXRh YmFzZVN5bmMoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgY29uc3QgU3RyaW5nJiBu YW1lLAogCiBEYXRhYmFzZVN5bmM6On5EYXRhYmFzZVN5bmMoKQogewotICAgIEFTU0VSVChtX3Nj cmlwdEV4ZWN1dGlvbkNvbnRleHQtPmlzQ29udGV4dFRocmVhZCgpICYmIDIxKTsKKyAgICBBU1NF UlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0NvbnRleHRUaHJlYWQoKSk7CiAKICAgICBp ZiAob3BlbmVkKCkpIHsKICAgICAgICAgRGF0YWJhc2VUcmFja2VyOjp0cmFja2VyKCkucmVtb3Zl T3BlbkRhdGFiYXNlKHRoaXMpOwpAQCAtOTQsNyArOTQsNyBAQCBEYXRhYmFzZVN5bmM6On5EYXRh YmFzZVN5bmMoKQogCiB2b2lkIERhdGFiYXNlU3luYzo6Y2hhbmdlVmVyc2lvbihjb25zdCBTdHJp bmcmIG9sZFZlcnNpb24sIGNvbnN0IFN0cmluZyYgbmV3VmVyc2lvbiwgUGFzc1JlZlB0cjxTUUxU cmFuc2FjdGlvblN5bmNDYWxsYmFjaz4gY2hhbmdlVmVyc2lvbkNhbGxiYWNrLCBFeGNlcHRpb25D b2RlJiBlYykKIHsKLSAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0NvbnRl eHRUaHJlYWQoKSAmJiAyMik7CisgICAgQVNTRVJUKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+ aXNDb250ZXh0VGhyZWFkKCkpOwogCiAgICAgaWYgKHNxbGl0ZURhdGFiYXNlKCkudHJhbnNhY3Rp b25JblByb2dyZXNzKCkpIHsKICAgICAgICAgcmVwb3J0Q2hhbmdlVmVyc2lvblJlc3VsdCgxLCBT UUxFeGNlcHRpb246OkRBVEFCQVNFX0VSUiwgMCk7CkBAIC0xNjAsNyArMTYwLDcgQEAgdm9pZCBE YXRhYmFzZVN5bmM6OnJlYWRUcmFuc2FjdGlvbihQYXNzUmVmUHRyPFNRTFRyYW5zYWN0aW9uU3lu Y0NhbGxiYWNrPiBjYWxsYmEKIAogdm9pZCBEYXRhYmFzZVN5bmM6OnJ1blRyYW5zYWN0aW9uKFBh c3NSZWZQdHI8U1FMVHJhbnNhY3Rpb25TeW5jQ2FsbGJhY2s+IGNhbGxiYWNrLCBib29sIHJlYWRP bmx5LCBFeGNlcHRpb25Db2RlJiBlYykKIHsKLSAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25D b250ZXh0LT5pc0NvbnRleHRUaHJlYWQoKSAmJiAyMyk7CisgICAgQVNTRVJUKG1fc2NyaXB0RXhl Y3V0aW9uQ29udGV4dC0+aXNDb250ZXh0VGhyZWFkKCkpOwogCiAgICAgaWYgKHNxbGl0ZURhdGFi YXNlKCkudHJhbnNhY3Rpb25JblByb2dyZXNzKCkpIHsKICAgICAgICAgc2V0TGFzdEVycm9yTWVz c2FnZSgidW5hYmxlIHRvIHN0YXJ0IGEgdHJhbnNhY3Rpb24gZnJvbSB3aXRoaW4gYSB0cmFuc2Fj dGlvbiIpOwo=