76940 2012-01-24 13:24:57 -0800 Change dispatchIntent API to pure virtual in FrameLoaderClient. 2012-01-24 14:36:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75123 1 gbillock gbillock abarth webkit.review.bot oldest_to_newest 541615 0 gbillock 2012-01-24 13:24:57 -0800 Change dispatchIntent API to pure virtual in FrameLoaderClient. 541616 1 123792 gbillock 2012-01-24 13:26:31 -0800 Created attachment 123792 Patch 541621 2 123792 abarth 2012-01-24 13:28:17 -0800 Comment on attachment 123792 Patch Ok. I'm not sure I fully understand why, but this change is fine. 541632 3 gbillock 2012-01-24 13:39:04 -0800 (In reply to comment #2) > (From update of attachment 123792 [details]) > Ok. I'm not sure I fully understand why, but this change is fine. It looks like all our other compilers have no problems with this. The Windows error message is that PassRefPtr.h needs the WebCore::IntentRequest object to be fully defined in order to do ->deref() on the type. As a guess, the compiler is trying to do codegen for the empty method when others don't need to? (The errors are from includes in Document.cpp and DOMImplementation.cpp, which don't call that method. I don't develop on Windows, so I'm depending on others' expertise here... 541704 4 123792 webkit.review.bot 2012-01-24 14:36:15 -0800 Comment on attachment 123792 Patch Clearing flags on attachment: 123792 Committed r105812: <http://trac.webkit.org/changeset/105812> 541705 5 webkit.review.bot 2012-01-24 14:36:20 -0800 All reviewed patches have been landed. Closing bug. 123792 2012-01-24 13:26:31 -0800 2012-01-24 14:36:15 -0800 Patch bug-76940-20120124132630.patch text/plain 2338 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ3OGUzMDU3NjgxNTY2 YTQyZWYwYjQ4Nzk3ZTBiNGNmZTU1ZjgzNC4uZjA3YTU3YzljZDRkMTVhYjgyYTk0OGYwMGYyZjkx ZWU3NjQ5ODc4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTI0ICBHcmVn IEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIENoYW5nZSBkaXNwYXRj aEludGVudCBBUEkgdG8gcHVyZSB2aXJ0dWFsIGluIEZyYW1lTG9hZGVyQ2xpZW50LgorCisgICAg ICAgIFRoZSBXaW5kb3dzIGNvbXBpbGVyIG5lZWRzIHRoaXMgdG8gZGVhbCB3aXRoIHRoZSBmb3J3 YXJkIGRlY2xhcmF0aW9uCisgICAgICAgIG9mIFdlYkNvcmU6OkludGVudFJlcXVlc3QuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Njk0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL0VtcHR5 Q2xpZW50cy5oOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6ZGlz cGF0Y2hJbnRlbnQpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oOgorCiAy MDEyLTAxLTIzICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAg ICAgICAgIFNWRyBhbmltYXRpb24gcmVwYWludCBpc3N1ZSB3aXRoIGltYWdlIGFuZCBkeW5hbWlj IGNsaXBQYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRz LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKaW5kZXggOGQxZmU3ZDBi ZmYxODJiYzI4MTA1NTYzOWJhYTQ3ZjkyZWRiYjEwOS4uZDRhMGY1NDZiNjIyY2RiNjliMjIyZjdm ZDdjMDdjOTA1ZjAyZjk2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0VtcHR5 Q2xpZW50cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9FbXB0eUNsaWVudHMuaApAQCAt NDIsNiArNDIsNyBAQAogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAi RnJhbWVOZXR3b3JraW5nQ29udGV4dC5oIgogI2luY2x1ZGUgIkluc3BlY3RvckNsaWVudC5oIgor I2luY2x1ZGUgIkludGVudFJlcXVlc3QuaCIKICNpbmNsdWRlICJQb3B1cE1lbnUuaCIKICNpbmNs dWRlICJSZXNvdXJjZUVycm9yLmgiCiAjaW5jbHVkZSAiU2VhcmNoUG9wdXBNZW51LmgiCkBAIC00 MDcsNiArNDA4LDEwIEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgdmlydHVhbCBQYXNzUmVmUHRy PEZyYW1lTmV0d29ya2luZ0NvbnRleHQ+IGNyZWF0ZU5ldHdvcmtpbmdDb250ZXh0KCkgeyByZXR1 cm4gUGFzc1JlZlB0cjxGcmFtZU5ldHdvcmtpbmdDb250ZXh0PigpOyB9CisKKyNpZiBFTkFCTEUo V0VCX0lOVEVOVFMpCisgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoSW50ZW50KFBhc3NSZWZQdHI8 SW50ZW50UmVxdWVzdD4pIHsgfQorI2VuZGlmCiB9OwogCiBjbGFzcyBFbXB0eVRleHRDaGVja2Vy Q2xpZW50IDogcHVibGljIFRleHRDaGVja2VyQ2xpZW50IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyQ2xpZW50LmgKaW5kZXggMzVjNjg5YjIyYTY1MDljZmUwMWQzMWExNjExZThk NGNlZDIzMmNiZC4uNDNjMjFmYTMwYjI4NzgxNWU2ZjdmMzQ5NDM3ZTk0ZDk1NDNiYmZlMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50LmgKQEAgLTMyOCw3ICszMjgs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgYm9vbCB3aWxsQ2hlY2tB bmREaXNwYXRjaE1lc3NhZ2VFdmVudChTZWN1cml0eU9yaWdpbiogLyp0YXJnZXQqLywgTWVzc2Fn ZUV2ZW50KikgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAogI2lmIEVOQUJMRShXRUJfSU5URU5U UykKLSAgICAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoSW50ZW50KFBhc3NSZWZQdHI8SW50ZW50 UmVxdWVzdD4gaW50ZW50UmVxdWVzdCkgeyB9CisgICAgICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRj aEludGVudChQYXNzUmVmUHRyPEludGVudFJlcXVlc3Q+KSA9IDA7CiAjZW5kaWYKICAgICB9Owog Cg==