76938 2012-01-24 13:15:50 -0800 Update pixel table test expectations for mac to match new DRT scrollbars 2012-02-08 13:24:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae abarth eric jchaffraix leviw simon.fraser oldest_to_newest 541602 0 eae 2012-01-24 13:15:50 -0800 Update pixel test expectations for the mozilla table tests in response to the mock scrollbars introduced in bug 67217. 541617 1 123793 eae 2012-01-24 13:27:12 -0800 Created attachment 123793 Patch 541625 2 123795 eae 2012-01-24 13:31:52 -0800 Created attachment 123795 Patch 542366 3 eae 2012-01-25 09:41:34 -0800 Simon, could you take a quick look at this to make sure it's right? Thanks! 544701 4 jchaffraix 2012-01-28 15:21:13 -0800 The baselines look good to me but I don't know enough of the mac port to know if all are needed or if some sharing could happen. 551284 5 eric 2012-02-07 13:12:14 -0800 We have scripts which handle sharing. webkit-patch optimize-baselines or something like that. 551332 6 eric 2012-02-07 13:47:30 -0800 rs=me. I can't actually get the review page to load. 551341 7 jchaffraix 2012-02-07 13:52:40 -0800 FYI, I did look at them sometimes ago (the page is super long to load): the new baselines did make sense (just some scrollbars differences). I just wasn't sure about the 'why didn't we already had those baselines?' part but forgot to point it out here. 551857 8 simon.fraser 2012-02-08 00:39:10 -0800 Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures? 552313 9 eae 2012-02-08 11:15:26 -0800 (In reply to comment #8) > Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures? I checked each result to make sure that the only change was to the scrollbars. 552407 10 eae 2012-02-08 12:42:30 -0800 Committed r107122: <http://trac.webkit.org/changeset/107122> 123793 2012-01-24 13:27:12 -0800 2012-01-24 13:28:41 -0800 Patch 76938.patch text/plain 0 eae 123795 2012-01-24 13:31:52 -0800 2012-02-08 13:24:18 -0800 Patch 76938.patch text/plain 0 eae