<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>7693</bug_id>
          
          <creation_ts>2006-03-09 21:52:02 -0800</creation_ts>
          <short_desc>WebKit relies on unpredictable timing for onload events</short_desc>
          <delta_ts>2006-03-17 12:30:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>5122</blocked>
    
    <blocked>5487</blocked>
    
    <blocked>6560</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Peebles">pumpkingod</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>35672</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Peebles">pumpkingod</who>
    <bug_when>2006-03-09 21:52:02 -0800</bug_when>
    <thetext>Yeah, I&apos;m not too sure about it myself yet, but I&apos;ve been struggling for hours with seemingly random test case regressions that shouldn&apos;t be caused by my patch, and this bug seems to be the cause.

Basically, if you introduce a delay into DRT&apos;s code, and it doesn&apos;t like it, the RenderTree will be output before javascript requesting text only output can run, which will obviously make test cases fail. 

I&apos;ve reproduced this on a clean source tree by simply loading DumpRenderTree up in a debugger, running it with LayoutTests/dom/html/level2/html/HTMLBodyElement07.html, and pausing execution at some point while it runs, and then resuming it. That causes it to consistently output the full render tree for me, even though that specific test case requests a text only output.

I won&apos;t be able to submit my patch to 5122 until this is fixed :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35675</commentid>
    <comment_count>1</comment_count>
    <who name="Daniel Peebles">pumpkingod</who>
    <bug_when>2006-03-09 22:02:38 -0800</bug_when>
    <thetext>In fact, it even happens when just running it in the debugger with no breakpoints or pauses. It seems pretty random</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35676</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-03-09 22:14:30 -0800</bug_when>
    <thetext>Sounds like the same as this random failure I got from BuildBot yesterday: &lt;http://build.webkit.org/results/post-commit-powerpc-mac-os-x/990/results.html&gt;. </thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35678</commentid>
    <comment_count>3</comment_count>
      <attachid>6975</attachid>
    <who name="Daniel Peebles">pumpkingod</who>
    <bug_when>2006-03-09 22:46:03 -0800</bug_when>
    <thetext>Created attachment 6975
A test case for the bug

To reproduce the bug, try putting this in your WebKit folder, and type

bash Bug.bash &gt; results

This is simultaneously running the same test 20 times to make sure it gets nice and slow, and outputting it to the results file. If you check the results when it&apos;s done, you&apos;ll find that several of the results give the full render tree of the unmodified (by the javascript onload event) page, and others show a text only representation of the modified page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35693</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Peebles">pumpkingod</who>
    <bug_when>2006-03-10 01:01:59 -0800</bug_when>
    <thetext>It&apos;s apparently not specific to DumpRenderTree, but that&apos;s just where I ran into it. I&apos;ll look deeper into it tomorrow</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35714</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-03-10 05:09:02 -0800</bug_when>
    <thetext>The root cause for the undeterministic behavior is that &lt;object&gt; (and perhaps other) subframes are created and loaded by the render tree, triggered either by the layout timer or by event dispatch or by other mechanisms.

Frame::checkCompleted(), which emits the load DOM event, waits for the subframes to load, but obviously only if they have already been created. This warrants a bug by itself, since it means that the document load event may arbitrarily be emitted before subframes have loaded.

What&apos;s causing the problem here, though, is that in the case that the subframe gets created and its main resource fails to load, the order of calls in -[WebDataSource _receivedMainResourceError:complete:] is such that the WebFrame reports completion (which invokes DRT&apos;s waiting delegate and causes it to dump) before the WebCore Frame checks for completion (which fires the onload handler, calling dumpAsText, waitUntilDone etc. when it&apos;s too late).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>35715</commentid>
    <comment_count>6</comment_count>
      <attachid>6986</attachid>
    <who name="">mitz</who>
    <bug_when>2006-03-10 06:36:16 -0800</bug_when>
    <thetext>Created attachment 6986
Reduction

This file reliably reproduces the bug. When you invoke DRT on it, the lines appear in the reverse order, since the dump is triggered before the load event.

If you delete the &lt;script&gt;&lt;/script&gt; on the fifth line, the lines appear in the correct order, since the subframe loading isn&apos;t triggered.

The order of the calls in -[WebDataSource _receivedMainResourceError:complete:] was changed in r10901 to fix &lt;rdar://problem/3853672&gt; (Malformed HTML using crashes Safari in NSFireTimer), so part of this bug is probably a regression.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36490</commentid>
    <comment_count>7</comment_count>
      <attachid>7096</attachid>
    <who name="">mitz</who>
    <bug_when>2006-03-15 16:30:59 -0800</bug_when>
    <thetext>Created attachment 7096
Emit load events before notifying the WebFrame load delegate

Retaining the bridge and checking the cancelled flag in -[WebLoader didFailWithError:] are sufficient to prevent the &lt;rdar://problem/3853672&gt; crash (or an assertion failure).

The updated acid2 results should finally fix bug 5487.

This patch obviously doesn&apos;t address the other issue I mentioned in comment #5.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36493</commentid>
    <comment_count>8</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-03-15 17:01:52 -0800</bug_when>
    <thetext>I am pretty sure now (also based on the date bug 5487 was reported) that this is a regression from the fix for &lt;rdar://problem/3853672&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36494</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-03-15 17:08:18 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; The root cause for the undeterministic behavior is that &lt;object&gt; (and perhaps
&gt; other) subframes are created and loaded by the render tree, triggered either by
&gt; the layout timer or by event dispatch or by other mechanisms.
&gt; 
&gt; Frame::checkCompleted(), which emits the load DOM event, waits for the
&gt; subframes to load, but obviously only if they have already been created. This
&gt; warrants a bug by itself, since it means that the document load event may
&gt; arbitrarily be emitted before subframes have loaded.

Either Maciej or Hyatt (can&apos;t remember which) mentioned to me the other day that we probably should be loading subframes based on the DOM tree, not the render tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36533</commentid>
    <comment_count>10</comment_count>
      <attachid>7096</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-03-16 01:00:22 -0800</bug_when>
    <thetext>Comment on attachment 7096
Emit load events before notifying the WebFrame load delegate

OK. Seems like we can do this -- taking a risk sounds good. Shouldn&apos;t have braces around that return in WebLoader.m.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36771</commentid>
    <comment_count>11</comment_count>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2006-03-17 12:30:19 -0800</bug_when>
    <thetext>I comitted this patch</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>6975</attachid>
            <date>2006-03-09 22:46:03 -0800</date>
            <delta_ts>2006-03-09 22:46:03 -0800</delta_ts>
            <desc>A test case for the bug</desc>
            <filename>Bug.bash</filename>
            <type>text/plain</type>
            <size>171</size>
            <attacher name="Daniel Peebles">pumpkingod</attacher>
            
              <data encoding="base64">IyEvYmluL2Jhc2gKClRFU1RTPTIwCgphPTAKCndoaWxlIFsgJGEgLWx0ICIkVEVTVFMiIF0KZG8K
CWE9JCgoJGErMSkpCgoJLi9XZWJLaXRCdWlsZC9EZWJ1Zy9EdW1wUmVuZGVyVHJlZSBMYXlvdXRU
ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MQm9keUVsZW1lbnQwNy5odG1sICYKCmRvbmUK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>6986</attachid>
            <date>2006-03-10 06:36:16 -0800</date>
            <delta_ts>2006-03-10 06:36:16 -0800</delta_ts>
            <desc>Reduction</desc>
            <filename>loadEvents.html</filename>
            <type>text/html</type>
            <size>249</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">PHNjcmlwdD5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk8L3NjcmlwdD4KPEJPRFkg
b25sb2FkPSJkZWJ1ZygnVGhpcyBzaG91bGQgYmUgdGhlIGZpcnN0IGxpbmUnKSI+Ci0tJmd0IFRo
aXMgc2hvdWxkIGJlIHRoZSBzZWNvbmQgbGluZQogICAgPE9CSkVDVCBEQVRBPSJhRmlsZVRoYXRE
b2VzTm90RXhpc3QuZ2lmIiBDT0RFVFlQRT0iaW1hZ2UvZ2lmIj48L09CSkVDVD4KICAgIDxzY3Jp
cHQ+PC9zY3JpcHQ+CjwvQk9EWT4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>7096</attachid>
            <date>2006-03-15 16:30:59 -0800</date>
            <delta_ts>2006-03-16 01:00:22 -0800</delta_ts>
            <desc>Emit load events before notifying the WebFrame load delegate</desc>
            <filename>7693_r1.patch</filename>
            <type>text/plain</type>
            <size>6072</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDEzMzE1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMDMtIyMgIE1pdHogUGV0dGVsICA8b3Bl
bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgLSBUZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp
bi5vcmcvc2hvd19idWcuY2dpP2lkPTc2OTMKKyAgICAgICAgICBXZWJLaXQgcmVsaWVzIG9uIHVu
cHJlZGljdGFibGUgdGltaW5nIGZvciBvbmxvYWQgZXZlbnRzCisKKyAgICAgICAgKiBmYXN0L2Nz
cy9hY2lkMi1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgcmVzdWx0cy4KKyAgICAgICAgKiBmYXN0L2V2
ZW50cy9vbmxvYWQtd2Via2l0LWJlZm9yZS13ZWJjb3JlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg
ICAgICAgICogZmFzdC9ldmVudHMvb25sb2FkLXdlYmtpdC1iZWZvcmUtd2ViY29yZS5odG1sOiBB
ZGRlZC4KKwogMjAwNi0wMy0xNSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAg
ICAgICAgUnViYmVyIHN0YW1wZWQgYnkgR2VvZmYKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3Nz
L2FjaWQyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9h
Y2lkMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEzMzA4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9j
c3MvYWNpZDItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC00OCwxMSArNDgsMTIgQEAg
bGF5ZXIgYXQgKDEzMiwxNDQpIHNpemUgNDh4MTUKIGxheWVyIGF0ICgxMDgsMjY4Nikgc2l6ZSA5
NngxMgogICBSZW5kZXJCbG9jayAocG9zaXRpb25lZCkge0JMT0NLUVVPVEV9IGF0ICg3Miw0OCkg
c2l6ZSA5NngxMiBbYm9yZGVyOiBub25lICgyNHB4IHNvbGlkICMwMDAwMDApIG5vbmUgKDI0cHgg
c29saWQgIzAwMDAwMCldCiAgICAgUmVuZGVyQmxvY2sgKGZsb2F0aW5nKSB7QUREUkVTU30gYXQg
KDI0LDApIHNpemUgNDh4MTIgW2JnY29sb3I9I0ZGRkYwMF0KLWxheWVyIGF0ICg4NCwyNzEwKSBz
aXplIDE0NHgzMAorbGF5ZXIgYXQgKDg0LDI3MTApIHNpemUgMTQ0eDI0CiAgIFJlbmRlckJsb2Nr
IChwb3NpdGlvbmVkKSB7RElWfSBhdCAoNDgsNzIpIHNpemUgMTQ0eDI0IFtiZ2NvbG9yPSNGRjAw
MDBdCiAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSAxNDR4MAotICAgICAgUmVu
ZGVySW5saW5lIHtPQkpFQ1R9IGF0ICgwLDApIHNpemUgOTB4MTQKLSAgICAgICAgUmVuZGVyUGFy
dE9iamVjdCB7T0JKRUNUfSBhdCAoNTQsMCkgc2l6ZSA5MHgzMAorICAgICAgUmVuZGVySW5saW5l
IHtPQkpFQ1R9IGF0ICgwLDApIHNpemUgMTMxeDE0CisgICAgICAgIFJlbmRlcklubGluZSB7T0JK
RUNUfSBhdCAoMCwwKSBzaXplIDEzMXgxNAorICAgICAgICAgIFJlbmRlckltYWdlIHtPQkpFQ1R9
IGF0ICgxMywwKSBzaXplIDEzMXgyNCBbYm9yZGVyOiAoMTJweCBzb2xpZCAjMDAwMDAwKSBub25l
XQogICAgIFJlbmRlckJsb2NrIChmbG9hdGluZykge0RJVn0gYXQgKDAsMCkgc2l6ZSAxNDR4MjQg
W2JvcmRlcjogKDEycHggc29saWQgI0ZGMDAwMCkgbm9uZSAoMTJweCBzb2xpZCAjMDAwMDAwKV0K
ICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwwKSBzaXplIDE0NHgyNCBbYm9yZGVyOiAoMjRw
eCBzb2xpZCAjRkZGRjAwKV0KIGxheWVyIGF0ICg4NCwyNzgyKSBzaXplIDE0NHgyNApJbmRleDog
TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvb25sb2FkLXdlYmtpdC1iZWZvcmUtd2ViY29yZS1leHBl
Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvb25sb2FkLXdl
YmtpdC1iZWZvcmUtd2ViY29yZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU
ZXN0cy9mYXN0L2V2ZW50cy9vbmxvYWQtd2Via2l0LWJlZm9yZS13ZWJjb3JlLWV4cGVjdGVkLnR4
dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitBTEVSVDogVGhpcyBzaG91bGQgYmUgdGhl
IGZpcnN0IGxpbmUuCitUaGlzIHNob3VsZCBiZSB0aGUgc2Vjb25kIGxpbmUuIFRoZSBmaXJzdCBs
aW5lIHNob3VsZCBiZSBhbiBBTEVSVC4gIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv
b25sb2FkLXdlYmtpdC1iZWZvcmUtd2ViY29yZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl
c3RzL2Zhc3QvZXZlbnRzL29ubG9hZC13ZWJraXQtYmVmb3JlLXdlYmNvcmUuaHRtbAkocmV2aXNp
b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL29ubG9hZC13ZWJraXQtYmVmb3JlLXdl
YmNvcmUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPHNjcmlwdD5sYXlvdXRU
ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk8L3NjcmlwdD4KKzxCT0RZIG9ubG9hZD0iYWxlcnQo
J1RoaXMgc2hvdWxkIGJlIHRoZSBmaXJzdCBsaW5lLicpIj4KK1RoaXMgc2hvdWxkIGJlIHRoZSBz
ZWNvbmQgbGluZS4gVGhlIGZpcnN0IGxpbmUgc2hvdWxkIGJlIGFuIEFMRVJULgorICAgIDxpZnJh
bWUgc3JjPSJyZXNvdXJjZXMvYUZpbGVUaGF0RG9lc05vdEV4aXN0Ij48L2lmcmFtZT4KKyAgICA8
IS0tCisgICAgICAgIFRoaXMgdGVzdHMgZm9yIGEgcmVncmVzc2lvbiBhZ2FpbnN0CisgICAgICAg
IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY5MworICAg
ICAgICBXZWJLaXQgcmVsaWVzIG9uIHVucHJlZGljdGFibGUgdGltaW5nIGZvciBvbmxvYWQgZXZl
bnRzCisgICAgICAgIAorICAgICAgICBUaGUgYm9keSBsb2FkIGV2ZW50IHNob3VsZCBiZSBkaXNw
YXRjaGVkIGJlZm9yZSB0aGUKKyAgICAgICAgV2ViRnJhbWUgbG9hZCBkZWxlZ2F0ZSBpcyBzZW50
IHRoZSB3ZWJWaWV3OmRpZEZpbmlzaExvYWRGb3JGcmFtZTogbWVzc2FnZS4KKyAgICAtLT4KKzwv
Qk9EWT4KSW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5n
ZUxvZwkocmV2aXNpb24gMTMzMTUpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDMgKzEsMjEgQEAKKzIwMDYtMDMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5v
cmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgVGVzdDogZmFzdC9ldmVudHMvb25sb2FkLXdl
YmtpdC1iZWZvcmUtd2ViY29yZS5odG1sCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3No
b3dfYnVnLmNnaT9pZD03NjkzCisgICAgICAgICAgV2ViS2l0IHJlbGllcyBvbiB1bnByZWRpY3Rh
YmxlIHRpbWluZyBmb3Igb25sb2FkIGV2ZW50cworCisgICAgICAgICogV2ViVmlldy9XZWJEYXRh
U291cmNlLm06CisgICAgICAgICgtW1dlYkRhdGFTb3VyY2UgX3JlY2VpdmVkTWFpblJlc291cmNl
RXJyb3I6Y29tcGxldGU6XSk6IENoZWNrIGZvciBjb21wbGV0aW9uIG9uIHRoZSBXZWJDb3JlCisg
ICAgICAgIHNpZGUgYmVmb3JlIGNoZWNraW5nIG9uIHRoZSBXZWJLaXQgc2lkZSwgdG8gZW5zdXJl
IHRoYXQgdGhlIG9ubG9hZCBldmVudCBpcyBlbWl0dGVkIGJlZm9yZQorICAgICAgICB0aGUgV2Vi
RnJhbWUgbG9hZCBkZWxlZ2F0ZSBpcyBzZW50IHRoZSB3ZWJWaWV3OmRpZEZpbmlzaExvYWRGb3JG
cmFtZTogbWVzc2FnZS4KKyAgICAgICAgRm9yIER1bXBSZW5kZXJUcmVlLCB0aGlzIGVuc3VyZXMg
dGhhdCB0aGUgcmVuZGVyIHRyZWUgaXMgZHVtcGVkIGFmdGVyIHRoZSBvbmxvYWQgaGFuZGxlciBp
cyBydW4uCisgICAgICAgICogV2ViVmlldy9XZWJMb2FkZXIubToKKyAgICAgICAgKC1bV2ViTG9h
ZGVyIGRpZEZhaWxXaXRoRXJyb3I6XSk6IElmIGxvYWQgaGFzIGFscmVhZHkgYmVlbiBjYW5jZWxs
ZWQgKHdoaWNoIGNvdWxkIGhhcHBlbiBpZiB0aGUgcGFyZW50J3MKKyAgICAgICAgb25sb2FkIGhh
bmRsZXIgY2F1c2VkIHRoZSBmcmFtZSB0byBkZXRhY2gpLCBkbyBub3RoaW5nLgorCiAyMDA2LTAz
LTEzICBUaW0gT21lcm5pY2sgIDx0aW1vQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBNYWNpZWouCkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJEYXRhU291cmNlLm0KPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gV2ViS2l0L1dlYlZpZXcvV2ViRGF0YVNvdXJjZS5tCShyZXZpc2lvbiAxMzMwOCkKKysr
IFdlYktpdC9XZWJWaWV3L1dlYkRhdGFTb3VyY2UubQkod29ya2luZyBjb3B5KQpAQCAtNjY2LDEx
ICs2NjYsNiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWRkVHlwZXNGcm9tQ2xhc3MoTlNNCiAgICAg
Ly8gUmV0YWluIHRoZSBicmlkZ2UgYmVjYXVzZSB0aGUgc3RvcCBtYXkgcmVsZWFzZSB0aGUgbGFz
dCByZWZlcmVuY2UgdG8gaXQuCiAgICAgW2JyaWRnZSByZXRhaW5dOwogCi0gICAgW1tzZWxmIHdl
YkZyYW1lXSBfcmVjZWl2ZWRNYWluUmVzb3VyY2VFcnJvcjplcnJvcl07Ci0gICAgW1tzZWxmIF93
ZWJWaWV3XSBfbWFpblJlY2VpdmVkRXJyb3I6ZXJyb3IKLSAgICAgICAgICAgICAgICAgICAgICAg
ICBmcm9tRGF0YVNvdXJjZTpzZWxmCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29t
cGxldGU6aXNDb21wbGV0ZV07Ci0KICAgICBpZiAoaXNDb21wbGV0ZSkgewogICAgICAgICAvLyBG
SVhNRTogRG9uJ3Qgd2FudCB0byBkbyB0aGlzIGlmIGFuIGVudGlyZWx5IG5ldyBsb2FkIGlzIGdv
aW5nLCBzbyBzaG91bGQgY2hlY2sKICAgICAgICAgLy8gdGhhdCBib3RoIGRhdGEgc291cmNlcyBv
biB0aGUgZnJhbWUgYXJlIGVpdGhlciBzZWxmIG9yIG5pbC4KQEAgLTY4Miw2ICs2NzcsMTEgQEAg
c3RhdGljIGlubGluZSB2b2lkIGFkZFR5cGVzRnJvbUNsYXNzKE5TTQogICAgIH0KIAogICAgIFti
cmlkZ2UgcmVsZWFzZV07CisKKyAgICBbW3NlbGYgd2ViRnJhbWVdIF9yZWNlaXZlZE1haW5SZXNv
dXJjZUVycm9yOmVycm9yXTsKKyAgICBbW3NlbGYgX3dlYlZpZXddIF9tYWluUmVjZWl2ZWRFcnJv
cjplcnJvcgorICAgICAgICAgICAgICAgICAgICAgICAgIGZyb21EYXRhU291cmNlOnNlbGYKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wbGV0ZTppc0NvbXBsZXRlXTsKIH0KIAog
LSAodm9pZClfdXBkYXRlSWNvbkRhdGFiYXNlV2l0aFVSTDooTlNVUkwgKilpY29uVVJMCkluZGV4
OiBXZWJLaXQvV2ViVmlldy9XZWJMb2FkZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViVmll
dy9XZWJMb2FkZXIubQkocmV2aXNpb24gMTMzMDgpCisrKyBXZWJLaXQvV2ViVmlldy9XZWJMb2Fk
ZXIubQkod29ya2luZyBjb3B5KQpAQCAtNTc5LDYgKzU3OSwxMCBAQCBzdGF0aWMgQk9PTCBOU1VS
TENvbm5lY3Rpb25TdXBwb3J0c0J1ZmZlCiAKIC0gKHZvaWQpZGlkRmFpbFdpdGhFcnJvcjooTlNF
cnJvciAqKWVycm9yCiB7CisgICAgaWYgKGNhbmNlbGxlZEZsYWcpIHsKKyAgICAgICAgcmV0dXJu
OworICAgIH0KKyAgICAKICAgICBBU1NFUlQoIXJlYWNoZWRUZXJtaW5hbFN0YXRlKTsKIAogICAg
IC8vIHJldGFpbi9yZWxlYXNlIHNlbGYgaW4gdGhpcyBkZWxlZ2F0ZSBtZXRob2Qgc2luY2UgdGhl
IGFkZGl0aW9uYWwgcHJvY2Vzc2luZyBjYW4gZG8K
</data>
<flag name="review"
          id="1854"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>