76928 2012-01-24 11:26:57 -0800 Accelerated drawing should force compositing mode 2012-01-24 15:21:48 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 541509 0 bdakin 2012-01-24 11:26:57 -0800 Accelerated drawing should force compositing mode. Patch forthcoming. <rdar://problem/10697417> 541510 1 123776 bdakin 2012-01-24 11:29:05 -0800 Created attachment 123776 Patch 541654 2 123776 simon.fraser 2012-01-24 13:56:23 -0800 Comment on attachment 123776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123776&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1856 > + if (settings->acceleratedDrawingEnabled()) > + settings->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing()); > + else > + settings->setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()) && LayerTreeHost::supportsAcceleratedCompositing()); This should probably be #if PLATFORM(MAC), and I think it deserves a comment or reference to a radar. 541678 3 bdakin 2012-01-24 14:11:11 -0800 Thanks Simon! I made it Mac-only, and I added a comment as well. Committed change: http://trac.webkit.org/changeset/105806 123776 2012-01-24 11:29:05 -0800 2012-01-24 13:56:23 -0800 Patch for-review.txt text/plain 2684 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTc2MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTI0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzY5MjgKKyAgICAgICAgQWNjZWxlcmF0ZWQgZHJhd2luZyBzaG91 bGQgZm9yY2UgY29tcG9zaXRpbmcgbW9kZQorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDY5NzQxNz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMpOgorCiAyMDEy LTAxLTI0ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBRdC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDEwNTYzMikKKysr IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTg0MCw3ICsxODQwLDYgQEAgdm9pZCBXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNl cyhjb25zdCBXZQogICAgIHNldHRpbmdzLT5zZXRTaG93c1Rvb2xUaXBPdmVyVHJ1bmNhdGVkVGV4 dChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OnNob3dzVG9vbFRp cE92ZXJUcnVuY2F0ZWRUZXh0S2V5KCkpKTsKIAogICAgIHNldHRpbmdzLT5zZXRBY2NlbGVyYXRl ZENvbXBvc2l0aW5nRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5j ZXNLZXk6OmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkS2V5KCkpICYmIExheWVyVHJlZUhv c3Q6OnN1cHBvcnRzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKTsKLSAgICBzZXR0aW5ncy0+c2V0 Rm9yY2VDb21wb3NpdGluZ01vZGUoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVu Y2VzS2V5Ojpmb3JjZUNvbXBvc2l0aW5nTW9kZUtleSgpKSAmJiBMYXllclRyZWVIb3N0OjpzdXBw b3J0c0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSk7CiAgICAgc2V0dGluZ3MtPnNldEFjY2VsZXJh dGVkRHJhd2luZ0VuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2Vz S2V5OjphY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkS2V5KCkpICYmIExheWVyVHJlZUhvc3Q6OnN1 cHBvcnRzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKTsKICAgICBzZXR0aW5ncy0+c2V0Q2FudmFz VXNlc0FjY2VsZXJhdGVkRHJhd2luZyhzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVy ZW5jZXNLZXk6OmNhbnZhc1VzZXNBY2NlbGVyYXRlZERyYXdpbmdLZXkoKSkgJiYgTGF5ZXJUcmVl SG9zdDo6c3VwcG9ydHNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkpOwogICAgIHNldHRpbmdzLT5z ZXRTaG93RGVidWdCb3JkZXJzKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNl c0tleTo6Y29tcG9zaXRpbmdCb3JkZXJzVmlzaWJsZUtleSgpKSk7CkBAIC0xODUxLDYgKzE4NTAs MTEgQEAgdm9pZCBXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyhjb25zdCBXZQogICAgIHNldHRp bmdzLT5zZXRNZWRpYVBsYXliYWNrQWxsb3dzSW5saW5lKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktl eShXZWJQcmVmZXJlbmNlc0tleTo6bWVkaWFQbGF5YmFja0FsbG93c0lubGluZUtleSgpKSk7CiAg ICAgc2V0dGluZ3MtPnNldE1vY2tTY3JvbGxiYXJzRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVG b3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6Om1vY2tTY3JvbGxiYXJzRW5hYmxlZEtleSgpKSk7CiAK KyAgICBpZiAoc2V0dGluZ3MtPmFjY2VsZXJhdGVkRHJhd2luZ0VuYWJsZWQoKSkKKyAgICAgICAg c2V0dGluZ3MtPnNldEZvcmNlQ29tcG9zaXRpbmdNb2RlKExheWVyVHJlZUhvc3Q6OnN1cHBvcnRz QWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKTsKKyAgICBlbHNlCisgICAgICAgIHNldHRpbmdzLT5z ZXRGb3JjZUNvbXBvc2l0aW5nTW9kZShzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVy ZW5jZXNLZXk6OmZvcmNlQ29tcG9zaXRpbmdNb2RlS2V5KCkpICYmIExheWVyVHJlZUhvc3Q6OnN1 cHBvcnRzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKTsKKwogI2lmIEVOQUJMRShTUUxfREFUQUJB U0UpCiAgICAgQWJzdHJhY3REYXRhYmFzZTo6c2V0SXNBdmFpbGFibGUoc3RvcmUuZ2V0Qm9vbFZh bHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpkYXRhYmFzZXNFbmFibGVkS2V5KCkpKTsKICNl bmRpZgo=