76927 2012-01-24 11:03:39 -0800 [Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView. 2012-02-14 02:36:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76937 1 reveman reveman jamesr piman webkit.review.bot oldest_to_newest 541488 0 reveman 2012-01-24 11:03:39 -0800 perTilePainting and partialTextureUpdates are currently not initialized properly in WebLayerTreeView::Settings::operator CCSettings(). 541492 1 123774 reveman 2012-01-24 11:08:16 -0800 Created attachment 123774 Patch 541506 2 123774 jamesr 2012-01-24 11:24:36 -0800 Comment on attachment 123774 Patch Test? 541600 3 reveman 2012-01-24 13:10:45 -0800 This is not as bad as I thought. All settings are initialized properly, there's just some inconsistency about which ones gets set in WebLayerTreeView.cpp. I'd like to fix the inconsistency with this patch prior to landing: https://bugs.webkit.org/show_bug.cgi?id=76937 555708 4 126854 reveman 2012-02-13 16:06:31 -0800 Created attachment 126854 Patch Rebase 555914 5 126854 jamesr 2012-02-13 20:39:05 -0800 Comment on attachment 126854 Patch Wait, CCSettings already has a constructor that sets all of these values to their defaults. Why do we bother manually resetting these to their defaults again in WLTV? 555927 6 reveman 2012-02-13 21:13:12 -0800 (In reply to comment #5) > (From update of attachment 126854 [details]) > Wait, CCSettings already has a constructor that sets all of these values to their defaults. Why do we bother manually resetting these to their defaults again in WLTV? I don't know. Maybe to be explicit about what settings are not yet exposed here? This patch just makes sure we're consistent. I'm happy to have it just remove all this unnecessary initialization instead. Would you prefer that? 555933 7 126903 reveman 2012-02-13 21:28:46 -0800 Created attachment 126903 Patch Instead remove unnecessary initialization 555939 8 jamesr 2012-02-13 21:37:57 -0800 Yeah, I think so - it makes more sense to me if WLTV only has to know about the values that it cares about and can leave everything else alone. 555940 9 126903 jamesr 2012-02-13 21:38:45 -0800 Comment on attachment 126903 Patch I prefer this version. I'm somewhat curious if Antoine has any specific opinion. I definitely don't want to have to update two files every time we add a new setting to CCSettings unless we want to also expose it via the WLTV API. 555949 10 piman 2012-02-13 22:09:01 -0800 Just FYI, I think showFPSCounter & showPlatformLayerTree have been accidentally disabled with a merge gone wrong, they used to work (although triggering a harmless assert in debug). I just haven't gone back and check that they actually work... In general, we don't need to expose anything in WLTV::Settings unless we want to use it, and we can rely on the CCSettings constructor to properly initialize things. 556144 11 126903 webkit.review.bot 2012-02-14 02:36:14 -0800 Comment on attachment 126903 Patch Clearing flags on attachment: 126903 Committed r107695: <http://trac.webkit.org/changeset/107695> 556145 12 webkit.review.bot 2012-02-14 02:36:21 -0800 All reviewed patches have been landed. Closing bug. 123774 2012-01-24 11:08:16 -0800 2012-02-13 16:06:28 -0800 Patch bug-76927-20120124140814.patch text/plain 1715 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFkY2RlODk2MDZkOTU5ZmE4YjA1ZmUyZWY2MWVmMTBhNmU2M2I4YTcuLmQzMjA3ODYyNGJjY2U1 YjNlNDQ1YTJhYWYxMDc4OGQ3YzUxYTZlMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDEtMjQgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluaXRpYWxpemUgQ0NTZXR0aW5ncyBwcm9w ZXJseSBpbiBXZWJMYXllclRyZWVWaWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzY5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZXQgcGVyVGlsZVBhaW50aW5nIHRvIGZhbHNlIGFuZCBwYXJ0aWFs VGV4dHVyZVVwZGF0ZXMgdG8gdHJ1ZS4KKworICAgICAgICAqIHNyYy9XZWJMYXllclRyZWVWaWV3 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlVmlldzo6U2V0dGluZ3M6Om9wZXJh dG9yIENDU2V0dGluZ3MpOgorCiAyMDEyLTAxLTIwICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5A Z29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQYWdlQWdlbnQub3BlbigpIGRv c2VuJ3QgYmVsb25nIHRvIHRoZSBwcm90b2NvbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAKaW5kZXggYjI4OGI1NjNiZTY1NGNhYTZhZTExNmU3 NjVmN2ZmNTAzYmJkZTgyMC4uM2QzYjI5ZGQxYTIxNTE0NTlmYmFhYWU1ZTllNDU1YTgzZDc3NTYz MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmll dy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5j cHAKQEAgLTQ1LDkgKzQ1LDExIEBAIFdlYkxheWVyVHJlZVZpZXc6OlNldHRpbmdzOjpvcGVyYXRv ciBDQ1NldHRpbmdzKCkgY29uc3QKICAgICBzZXR0aW5ncy5yZWZyZXNoUmF0ZSA9IHJlZnJlc2hS YXRlOwogICAgIHNldHRpbmdzLnBhcnRpYWxTd2FwRW5hYmxlZCA9IHBhcnRpYWxTd2FwRW5hYmxl ZDsKIAotICAgIC8vIEZJWE1FOiBzaG93RlBTQ291bnRlciAvIHNob3dQbGF0Zm9ybUxheWVyVHJl ZSBhcmVuJ3Qgc3VwcG9ydGVkIGN1cnJlbnRseS4KKyAgICAvLyBGSVhNRTogc2hvd0ZQU0NvdW50 ZXIgLyBzaG93UGxhdGZvcm1MYXllclRyZWUgLyBwZXJUaWxlUGFpbnRpbmcgLyBwYXJ0aWFsVGV4 dHVyZVVwZGF0ZXMgYXJlbid0IHN1cHBvcnRlZCBjdXJyZW50bHkuCiAgICAgc2V0dGluZ3Muc2hv d0ZQU0NvdW50ZXIgPSBmYWxzZTsKICAgICBzZXR0aW5ncy5zaG93UGxhdGZvcm1MYXllclRyZWUg PSBmYWxzZTsKKyAgICBzZXR0aW5ncy5wZXJUaWxlUGFpbnRpbmcgPSBmYWxzZTsKKyAgICBzZXR0 aW5ncy5wYXJ0aWFsVGV4dHVyZVVwZGF0ZXMgPSB0cnVlOwogICAgIHJldHVybiBzZXR0aW5nczsK IH0KIAo= 126854 2012-02-13 16:06:31 -0800 2012-02-13 21:39:56 -0800 Patch bug-76927-20120213190629.patch text/plain 1951 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI4ZTIxY2JkMDQ4MDQyY2Y5MzU0YmJhZjJkZmE5MDYwODZlMDA5NzguLjdmNGRlZTQzZTQ4N2Zh NjU4OWYyZDRjZTUwNTNmNzIwOWJlYTk3MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMTMgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluY29uc2lzdGVudCBpbml0aWFsaXphdGlv biBvZiBDQ1NldHRpbmdzIGluIFdlYkxheWVyVHJlZVZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjkyNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCBwZXJUaWxlUGFpbnRpbmcgdG8gZmFsc2Ug YW5kIG1heFBhcnRpYWxUZXh0dXJlVXBkYXRlcyB0bworICAgICAgICBzdGQ6Om51bWVyaWNfbGlt aXRzPHNpemVfdD46Om1heCgpLgorCisgICAgICAgICogc3JjL1dlYkxheWVyVHJlZVZpZXcuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJMYXllclRyZWVWaWV3OjpTZXR0aW5nczo6b3BlcmF0b3Ig Q0NTZXR0aW5ncyk6CisKIDIwMTItMDItMTMgIFlvc2lmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gVXNlIGVudW0gaW5zdGVhZCBvZiBib29sIGZvciBI VE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJMYXllclRyZWVWaWV3LmNwcAppbmRleCBhOTI1YjYwZDYzMzQ4NDI5NzIxMjMxYzA2NDA2 M2U5MTYxY2JlZjA1Li5jNDdlMjg0ZDQ3OWYxNzFlMmI3YWE4NWEyMjkyZDkwOTYxZGRlYmM2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNwcApA QCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgInBsYXRmb3JtL1dlYlJlY3QuaCIKICNpbmNsdWRl ICJwbGF0Zm9ybS9XZWJTaXplLmgiCiAKK3VzaW5nIG5hbWVzcGFjZSBzdGQ7CiB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC00NSw5ICs0NiwxMSBAQCBX ZWJMYXllclRyZWVWaWV3OjpTZXR0aW5nczo6b3BlcmF0b3IgQ0NTZXR0aW5ncygpIGNvbnN0CiAg ICAgc2V0dGluZ3MucmVmcmVzaFJhdGUgPSByZWZyZXNoUmF0ZTsKICAgICBzZXR0aW5ncy5wYXJ0 aWFsU3dhcEVuYWJsZWQgPSBwYXJ0aWFsU3dhcEVuYWJsZWQ7CiAKLSAgICAvLyBGSVhNRTogc2hv d0ZQU0NvdW50ZXIgLyBzaG93UGxhdGZvcm1MYXllclRyZWUgYXJlbid0IHN1cHBvcnRlZCBjdXJy ZW50bHkuCisgICAgLy8gRklYTUU6IHNob3dGUFNDb3VudGVyIC8gc2hvd1BsYXRmb3JtTGF5ZXJU cmVlIC8gcGVyVGlsZVBhaW50aW5nIC8gbWF4UGFydGlhbFRleHR1cmVVcGRhdGVzIGFyZW4ndCBz dXBwb3J0ZWQgY3VycmVudGx5LgogICAgIHNldHRpbmdzLnNob3dGUFNDb3VudGVyID0gZmFsc2U7 CiAgICAgc2V0dGluZ3Muc2hvd1BsYXRmb3JtTGF5ZXJUcmVlID0gZmFsc2U7CisgICAgc2V0dGlu Z3MucGVyVGlsZVBhaW50aW5nID0gZmFsc2U7CisgICAgc2V0dGluZ3MubWF4UGFydGlhbFRleHR1 cmVVcGRhdGVzID0gbnVtZXJpY19saW1pdHM8c2l6ZV90Pjo6bWF4KCk7CiAgICAgcmV0dXJuIHNl dHRpbmdzOwogfQogCg== 126903 2012-02-13 21:28:46 -0800 2012-02-14 02:36:14 -0800 Patch bug-76927-20120214002844.patch text/plain 1679 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI4ZTIxY2JkMDQ4MDQyY2Y5MzU0YmJhZjJkZmE5MDYwODZlMDA5NzguLjcxYTU0OTUwM2MzNTFj NTA0MjEzM2ZjNDY5Nzg4NjMxNTc5ZGY1ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMTMgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluY29uc2lzdGVudCBpbml0aWFsaXphdGlv biBvZiBDQ1NldHRpbmdzIGluIFdlYkxheWVyVHJlZVZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjkyNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBpbml0aWFsaXph dGlvbiBhbmQgaW5jbHVkZSBtYXhQYXJ0aWFsVGV4dHVyZVVwZGF0ZXMKKyAgICAgICAgaW4gRklY TUUgY29tbWVudC4KKworICAgICAgICAqIHNyYy9XZWJMYXllclRyZWVWaWV3LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlVmlldzo6U2V0dGluZ3M6Om9wZXJhdG9yIENDU2V0dGlu Z3MpOgorCiAyMDEyLTAyLTEzICBZb3NpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbRm9ybXNdIFVzZSBlbnVtIGluc3RlYWQgb2YgYm9vbCBmb3IgSFRNTElucHV0 RWxlbWVudDo6c2V0VmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkxheWVyVHJlZVZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5 ZXJUcmVlVmlldy5jcHAKaW5kZXggYTkyNWI2MGQ2MzM0ODQyOTcyMTIzMWMwNjQwNjNlOTE2MWNi ZWYwNS4uMmRhZTA1YjllNmQ1NDIyODViNDQwZDkyNTJjMDIzODE0ZmRmNjY3ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAKQEAgLTQ1LDkg KzQ1LDcgQEAgV2ViTGF5ZXJUcmVlVmlldzo6U2V0dGluZ3M6Om9wZXJhdG9yIENDU2V0dGluZ3Mo KSBjb25zdAogICAgIHNldHRpbmdzLnJlZnJlc2hSYXRlID0gcmVmcmVzaFJhdGU7CiAgICAgc2V0 dGluZ3MucGFydGlhbFN3YXBFbmFibGVkID0gcGFydGlhbFN3YXBFbmFibGVkOwogCi0gICAgLy8g RklYTUU6IHNob3dGUFNDb3VudGVyIC8gc2hvd1BsYXRmb3JtTGF5ZXJUcmVlIGFyZW4ndCBzdXBw b3J0ZWQgY3VycmVudGx5LgotICAgIHNldHRpbmdzLnNob3dGUFNDb3VudGVyID0gZmFsc2U7Ci0g ICAgc2V0dGluZ3Muc2hvd1BsYXRmb3JtTGF5ZXJUcmVlID0gZmFsc2U7CisgICAgLy8gRklYTUU6 IHNob3dGUFNDb3VudGVyIC8gc2hvd1BsYXRmb3JtTGF5ZXJUcmVlIC8gcGVyVGlsZVBhaW50aW5n IC8gbWF4UGFydGlhbFRleHR1cmVVcGRhdGVzIGFyZW4ndCBzdXBwb3J0ZWQgY3VycmVudGx5Lgog ICAgIHJldHVybiBzZXR0aW5nczsKIH0KIAo=