76925 2012-01-24 10:40:41 -0800 dropzone does not normalize type strings 2012-01-24 13:54:06 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76218 76598 1 dcheng dcheng tony yael oldest_to_newest 541463 0 dcheng 2012-01-24 10:40:41 -0800 Per http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute, the types are supposed to be normalized by lowercasing (with NO special conversion from text->text/plain and url->text/uri-list, but since dropzone checks against the types() collection directly, the type normalization that ports generally do in getData()/setData(), etc is ignored. 541500 1 123775 dcheng 2012-01-24 11:16:26 -0800 Created attachment 123775 Patch 541530 2 123775 tony 2012-01-24 11:47:44 -0800 Comment on attachment 123775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123775&action=review > Source/WebCore/ChangeLog:11 > + Covered by existing tests. I would say that you changed/added a test case in fast/events/dropzone-002.html. > LayoutTests/ChangeLog:10 > + * fast/events/dropzone-002.html: Update layout test to check case normalization as well. > + Also fixes the test to use text/uri-list, since no URL->text/uri-list special casing is > + defined for new drag and drop APIs. Does no special casing of URL->text/uri-list defined mean that string:url should fail? It seems bad to lose test coverage for that case: we should test both string:url and string:text/uri-list. 541570 3 123785 dcheng 2012-01-24 12:44:59 -0800 Created attachment 123785 Patch 541577 4 123775 dcheng 2012-01-24 12:52:19 -0800 Comment on attachment 123775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123775&action=review >> Source/WebCore/ChangeLog:11 >> + Covered by existing tests. > > I would say that you changed/added a test case in fast/events/dropzone-002.html. Done. >> LayoutTests/ChangeLog:10 >> + defined for new drag and drop APIs. > > Does no special casing of URL->text/uri-list defined mean that string:url should fail? It seems bad to lose test coverage for that case: we should test both string:url and string:text/uri-list. I'm not sure how I should check this. I could add a new dropzone test and set the expectation that no drop should happen? I looked around the existing dropzone tests and it doesn't seem like there's a 'negative' dropzone test that checks for things that shouldn't match. Perhaps I could add one in a separate patch, as that's not directly related to fixing the normalization of type strings. 541581 5 tony 2012-01-24 12:56:17 -0800 (In reply to comment #4) > > Does no special casing of URL->text/uri-list defined mean that string:url should fail? It seems bad to lose test coverage for that case: we should test both string:url and string:text/uri-list. > > I'm not sure how I should check this. I could add a new dropzone test and set the expectation that no drop should happen? I looked around the existing dropzone tests and it doesn't seem like there's a 'negative' dropzone test that checks for things that shouldn't match. Perhaps I could add one in a separate patch, as that's not directly related to fixing the normalization of type strings. I actually think it's OK for URL->text/uri-list to happen, although we should ask for the spec to be clear about this. My main point was that we should not remove the test case that covers this behavior regardless of what the result is. Layout tests are primarily for regression coverage. 541605 6 123790 dcheng 2012-01-24 13:20:11 -0800 Created attachment 123790 Patch 541626 7 123790 dcheng 2012-01-24 13:32:50 -0800 Comment on attachment 123790 Patch Clearing flags on attachment: 123790 Committed r105800: <http://trac.webkit.org/changeset/105800> 541627 8 dcheng 2012-01-24 13:32:54 -0800 All reviewed patches have been landed. Closing bug. 541645 9 123790 yael 2012-01-24 13:50:41 -0800 Comment on attachment 123790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123790&action=review > Source/WebCore/dom/Clipboard.cpp:217 > - return hasFileOfType(keyword.substring(5)); > - > + return hasFileOfType(keyword.substring(5).lower()); > + > if (keyword.startsWith("string:")) > - return hasStringOfType(keyword.substring(7)); > + return hasStringOfType(keyword.substring(7).lower()); The dropZone attribute is converted to lowercase in findDropZone(), before this is called. Why was this change needed? 541651 10 dcheng 2012-01-24 13:54:06 -0800 (In reply to comment #9) > (From update of attachment 123790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123790&action=review > > > Source/WebCore/dom/Clipboard.cpp:217 > > - return hasFileOfType(keyword.substring(5)); > > - > > + return hasFileOfType(keyword.substring(5).lower()); > > + > > if (keyword.startsWith("string:")) > > - return hasStringOfType(keyword.substring(7)); > > + return hasStringOfType(keyword.substring(7).lower()); > > The dropZone attribute is converted to lowercase in findDropZone(), before this is called. > Why was this change needed? The original intent was to address url->text/uri-list normalization as well but that's been deferred to a separate patch. The layout test change is still valuable; I should revert the code change though. Sorry about missing that. 123775 2012-01-24 11:16:26 -0800 2012-01-24 12:52:19 -0800 Patch bug-76925-20120124111625.patch text/plain 3074 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQzYzVkZDRlNTBkYjkx NjRiYTExOTEyYTUxMjc0NDRmNWFhMGUyNC4uNmJiZDcwOTUyYjY0MzZiOTU1YTcxOGIyZmRjMTFm Njc1ODNmYjNlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI0ICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGRyb3B6b25lIGRvZXMg bm90IG5vcm1hbGl6ZSB0eXBlIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc2OTI1CisKKyAgICAgICAgUGVyIHRoZSBIVE1MIHNwZWMsIHdl IGFyZSBzdXBwb3NlZCB0byBub3JtYWxpemUgdHlwZXMgZHVyaW5nIGRyb3B6b25lIHByb2Nlc3Np bmcgYnkKKyAgICAgICAgbG93ZXJjYXNpbmcgdGhlbS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogZG9tL0NsaXBib2FyZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmQ6 Omhhc0Ryb3Bab25lVHlwZSk6CisKIDIwMTItMDEtMjMgIERhdmlkIExldmluICA8bGV2aW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFt3aW5kb3dzXSBDb252ZXJ0IHVzYWdlcyBvZiBHZXREQyB0 byBIV25kREMgUGFydCAxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2Fy ZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAppbmRleCBlNzlhMjY4YTAx Y2EwYzBkNjk2NjExZTQ2YjkxZjk0ZDZjMjk1ZjU3Li44OWE1NWVlMjk2MTlmZmY2MTljYTE1MGJj MzI2OGRmYWVjM2RlODljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJk LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcApAQCAtMjExLDEwICsy MTEsMTAgQEAgU3RyaW5nIGNvbnZlcnREcmFnT3BlcmF0aW9uVG9Ecm9wWm9uZU9wZXJhdGlvbihE cmFnT3BlcmF0aW9uIG9wZXJhdGlvbikKIGJvb2wgQ2xpcGJvYXJkOjpoYXNEcm9wWm9uZVR5cGUo Y29uc3QgU3RyaW5nJiBrZXl3b3JkKQogewogICAgIGlmIChrZXl3b3JkLnN0YXJ0c1dpdGgoImZp bGU6IikpCi0gICAgICAgIHJldHVybiBoYXNGaWxlT2ZUeXBlKGtleXdvcmQuc3Vic3RyaW5nKDUp KTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCisgICAgICAgIHJldHVybiBoYXNGaWxl T2ZUeXBlKGtleXdvcmQuc3Vic3RyaW5nKDUpLmxvd2VyKCkpOworCiAgICAgaWYgKGtleXdvcmQu c3RhcnRzV2l0aCgic3RyaW5nOiIpKQotICAgICAgICByZXR1cm4gaGFzU3RyaW5nT2ZUeXBlKGtl eXdvcmQuc3Vic3RyaW5nKDcpKTsKKyAgICAgICAgcmV0dXJuIGhhc1N0cmluZ09mVHlwZShrZXl3 b3JkLnN1YnN0cmluZyg3KS5sb3dlcigpKTsKIAogICAgIHJldHVybiBmYWxzZTsKIH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBiZjZhMTY5YmM3Yzg0MTUyNThkZWRlOWY4YjY4Y2NhYjJmNDc4ODA0Li43YWJkY2MzODRkMDY3 M2E4ZDRmZTY2MTkyOTBmYjE5YTBhZWFlNmIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTIt MDEtMjQgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZHJv cHpvbmUgZG9lcyBub3Qgbm9ybWFsaXplIHR5cGUgc3RyaW5ncworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY5MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5o dG1sOiBVcGRhdGUgbGF5b3V0IHRlc3QgdG8gY2hlY2sgY2FzZSBub3JtYWxpemF0aW9uIGFzIHdl bGwuCisgICAgICAgIEFsc28gZml4ZXMgdGhlIHRlc3QgdG8gdXNlIHRleHQvdXJpLWxpc3QsIHNp bmNlIG5vIFVSTC0+dGV4dC91cmktbGlzdCBzcGVjaWFsIGNhc2luZyBpcworICAgICAgICBkZWZp bmVkIGZvciBuZXcgZHJhZyBhbmQgZHJvcCBBUElzLgorCiAyMDEyLTAxLTIzICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEwNTM5Nik6IGRy YWcgc3RhdGUgaXMgbm90IGNsZWFyZWQgYWZ0ZXIgZWFjaCBkcmFnCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCmluZGV4IGZmZTQ4NTA4MjM1ZDA2ZjNkMWM4NmQwMzNh YWMzMGVlMjc5NzExOGMuLjA5NDAwOWFkMDkwMzk0MmQyOWRmZmRjNzNhOTU4ZTRjOGQ4MDdjNjEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCkBAIC0zMiw3ICsz Miw3IEBAIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5nZURyb3Ba b25lKCkKIHsKLSAgICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCAi IFN0UmluRzp0ZXh0L3BsYWluIHNUcklORzp1cmwgIiArIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNb ZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUpOworICAgIGRyb3BUYXJnZXQuc2V0 QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsICIgU3RSaW5HOnRFeFQvcExhSW4gc1RySU5HOlRl WHQvVXJJLUxpU3QgIiArIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2Vs ZWN0ZWRJbmRleF0udmFsdWUpOwogfQogCiBmdW5jdGlvbiBwcmludERyb3BFdmVudChlKQo= 123785 2012-01-24 12:44:59 -0800 2012-01-24 13:20:08 -0800 Patch bug-76925-20120124124458.patch text/plain 3084 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQzYzVkZDRlNTBkYjkx NjRiYTExOTEyYTUxMjc0NDRmNWFhMGUyNC4uMmI3N2E4YTVlZTNhYmQxMThiZDYxNDk1ZGM4YTY3 NWFiMmI1MzZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI0ICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGRyb3B6b25lIGRvZXMg bm90IG5vcm1hbGl6ZSB0eXBlIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc2OTI1CisKKyAgICAgICAgUGVyIHRoZSBIVE1MIHNwZWMsIHdl IGFyZSBzdXBwb3NlZCB0byBub3JtYWxpemUgdHlwZXMgZHVyaW5nIGRyb3B6b25lIHByb2Nlc3Np bmcgYnkKKyAgICAgICAgbG93ZXJjYXNpbmcgdGhlbS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0czogZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAy Lmh0bWwKKworICAgICAgICAqIGRvbS9DbGlwYm9hcmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2xpcGJvYXJkOjpoYXNEcm9wWm9uZVR5cGUpOgorCiAyMDEyLTAxLTIzICBEYXZpZCBMZXZpbiAg PGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbd2luZG93c10gQ29udmVydCB1c2FnZXMg b2YgR2V0REMgdG8gSFduZERDIFBhcnQgMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9DbGlwYm9hcmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKaW5kZXgg ZTc5YTI2OGEwMWNhMGMwZDY5NjYxMWU0NmI5MWY5NGQ2YzI5NWY1Ny4uODlhNTVlZTI5NjE5ZmZm NjE5Y2ExNTBiYzMyNjhkZmFlYzNkZTg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0NsaXBib2FyZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKQEAg LTIxMSwxMCArMjExLDEwIEBAIFN0cmluZyBjb252ZXJ0RHJhZ09wZXJhdGlvblRvRHJvcFpvbmVP cGVyYXRpb24oRHJhZ09wZXJhdGlvbiBvcGVyYXRpb24pCiBib29sIENsaXBib2FyZDo6aGFzRHJv cFpvbmVUeXBlKGNvbnN0IFN0cmluZyYga2V5d29yZCkKIHsKICAgICBpZiAoa2V5d29yZC5zdGFy dHNXaXRoKCJmaWxlOiIpKQotICAgICAgICByZXR1cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1 YnN0cmluZyg1KSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorICAgICAgICByZXR1 cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg1KS5sb3dlcigpKTsKKwogICAgIGlm IChrZXl3b3JkLnN0YXJ0c1dpdGgoInN0cmluZzoiKSkKLSAgICAgICAgcmV0dXJuIGhhc1N0cmlu Z09mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg3KSk7CisgICAgICAgIHJldHVybiBoYXNTdHJpbmdP ZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNykubG93ZXIoKSk7CiAKICAgICByZXR1cm4gZmFsc2U7 CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggYmY2YTE2OWJjN2M4NDE1MjU4ZGVkZTlmOGI2OGNjYWIyZjQ3ODgwNC4uN2Fi ZGNjMzg0ZDA2NzNhOGQ0ZmU2NjE5MjkwZmIxOWEwYWVhZTZiMSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTI0ICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGRyb3B6b25lIGRvZXMgbm90IG5vcm1hbGl6ZSB0eXBlIHN0cmluZ3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2OTI1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcm9w em9uZS0wMDIuaHRtbDogVXBkYXRlIGxheW91dCB0ZXN0IHRvIGNoZWNrIGNhc2Ugbm9ybWFsaXph dGlvbiBhcyB3ZWxsLgorICAgICAgICBBbHNvIGZpeGVzIHRoZSB0ZXN0IHRvIHVzZSB0ZXh0L3Vy aS1saXN0LCBzaW5jZSBubyBVUkwtPnRleHQvdXJpLWxpc3Qgc3BlY2lhbCBjYXNpbmcgaXMKKyAg ICAgICAgZGVmaW5lZCBmb3IgbmV3IGRyYWcgYW5kIGRyb3AgQVBJcy4KKwogMjAxMi0wMS0yMyAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIx MDUzOTYpOiBkcmFnIHN0YXRlIGlzIG5vdCBjbGVhcmVkIGFmdGVyIGVhY2ggZHJhZwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAyLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbAppbmRleCBmZmU0ODUwODIzNWQwNmYz ZDFjODZkMDMzYWFjMzBlZTI3OTcxMThjLi4wOTQwMDlhZDA5MDM5NDJkMjlkZmZkYzczYTk1OGU0 YzhkODA3YzYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0w MDIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbApA QCAtMzIsNyArMzIsNyBAQCB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQogCiBmdW5jdGlvbiBj aGFuZ2VEcm9wWm9uZSgpCiB7Ci0gICAgZHJvcFRhcmdldC5zZXRBdHRyaWJ1dGUoIndlYmtpdGRy b3B6b25lIiwgIiBTdFJpbkc6dGV4dC9wbGFpbiBzVHJJTkc6dXJsICIgKyBkcm9wRWZmZWN0RWxl bS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlKTsKKyAgICBkcm9w VGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCAiIFN0UmluRzp0RXhUL3BMYUlu IHNUcklORzpUZVh0L1VySS1MaVN0ICIgKyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZl Y3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlKTsKIH0KIAogZnVuY3Rpb24gcHJpbnREcm9wRXZl bnQoZSkK 123790 2012-01-24 13:20:11 -0800 2012-01-24 13:50:41 -0800 Patch bug-76925-20120124132010.patch text/plain 2932 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQzYzVkZDRlNTBkYjkx NjRiYTExOTEyYTUxMjc0NDRmNWFhMGUyNC4uMmI3N2E4YTVlZTNhYmQxMThiZDYxNDk1ZGM4YTY3 NWFiMmI1MzZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI0ICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGRyb3B6b25lIGRvZXMg bm90IG5vcm1hbGl6ZSB0eXBlIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc2OTI1CisKKyAgICAgICAgUGVyIHRoZSBIVE1MIHNwZWMsIHdl IGFyZSBzdXBwb3NlZCB0byBub3JtYWxpemUgdHlwZXMgZHVyaW5nIGRyb3B6b25lIHByb2Nlc3Np bmcgYnkKKyAgICAgICAgbG93ZXJjYXNpbmcgdGhlbS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0czogZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAy Lmh0bWwKKworICAgICAgICAqIGRvbS9DbGlwYm9hcmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2xpcGJvYXJkOjpoYXNEcm9wWm9uZVR5cGUpOgorCiAyMDEyLTAxLTIzICBEYXZpZCBMZXZpbiAg PGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbd2luZG93c10gQ29udmVydCB1c2FnZXMg b2YgR2V0REMgdG8gSFduZERDIFBhcnQgMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9DbGlwYm9hcmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKaW5kZXgg ZTc5YTI2OGEwMWNhMGMwZDY5NjYxMWU0NmI5MWY5NGQ2YzI5NWY1Ny4uODlhNTVlZTI5NjE5ZmZm NjE5Y2ExNTBiYzMyNjhkZmFlYzNkZTg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0NsaXBib2FyZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKQEAg LTIxMSwxMCArMjExLDEwIEBAIFN0cmluZyBjb252ZXJ0RHJhZ09wZXJhdGlvblRvRHJvcFpvbmVP cGVyYXRpb24oRHJhZ09wZXJhdGlvbiBvcGVyYXRpb24pCiBib29sIENsaXBib2FyZDo6aGFzRHJv cFpvbmVUeXBlKGNvbnN0IFN0cmluZyYga2V5d29yZCkKIHsKICAgICBpZiAoa2V5d29yZC5zdGFy dHNXaXRoKCJmaWxlOiIpKQotICAgICAgICByZXR1cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1 YnN0cmluZyg1KSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorICAgICAgICByZXR1 cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg1KS5sb3dlcigpKTsKKwogICAgIGlm IChrZXl3b3JkLnN0YXJ0c1dpdGgoInN0cmluZzoiKSkKLSAgICAgICAgcmV0dXJuIGhhc1N0cmlu Z09mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg3KSk7CisgICAgICAgIHJldHVybiBoYXNTdHJpbmdP ZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNykubG93ZXIoKSk7CiAKICAgICByZXR1cm4gZmFsc2U7 CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggYmY2YTE2OWJjN2M4NDE1MjU4ZGVkZTlmOGI2OGNjYWIyZjQ3ODgwNC4uMWYx ODljY2VlODc2OTRiNGU3YmFmNmUwMGM5YjZkMjI2YjdhNmI3ZCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTAxLTI0ICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGRyb3B6b25lIGRvZXMgbm90IG5vcm1hbGl6ZSB0eXBlIHN0cmluZ3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2OTI1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcm9w em9uZS0wMDIuaHRtbDogVXBkYXRlIGxheW91dCB0ZXN0IHRvIGNoZWNrIGNhc2Ugbm9ybWFsaXph dGlvbiBhcyB3ZWxsLgorCiAyMDEyLTAxLTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEwNTM5Nik6IGRyYWcgc3RhdGUgaXMgbm90IGNs ZWFyZWQgYWZ0ZXIgZWFjaCBkcmFnCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9kcm9wem9uZS0wMDIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAw Mi5odG1sCmluZGV4IGZmZTQ4NTA4MjM1ZDA2ZjNkMWM4NmQwMzNhYWMzMGVlMjc5NzExOGMuLjg4 YjI3NWYyMmFmYmFkMjQxMDU4MWZiNGFjZGI5OWMyM2MwYjlkOTcgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCkBAIC0zMiw3ICszMiw3IEBAIHdpbmRvdy5vbmxv YWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5nZURyb3Bab25lKCkKIHsKLSAgICBkcm9w VGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCAiIFN0UmluRzp0ZXh0L3BsYWlu IHNUcklORzp1cmwgIiArIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2Vs ZWN0ZWRJbmRleF0udmFsdWUpOworICAgIGRyb3BUYXJnZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRk cm9wem9uZSIsICIgU3RSaW5HOnRFeFQvcExhSW4gc1RySU5HOlVyTCAiICsgZHJvcEVmZmVjdEVs ZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZSk7CiB9CiAKIGZ1 bmN0aW9uIHByaW50RHJvcEV2ZW50KGUpCg==