7692 2006-03-09 21:49:48 -0800 Should use an iterator in CompositeEditCommand::doUnapply() 2006-03-09 23:35:03 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 justin.garcia justin.garcia oldest_to_newest 35671 0 justin.garcia 2006-03-09 21:49:48 -0800 About 25% of the time during an Undo is spent getting the ith EditCommand out of m_cmds: for (int i = m_cmds.count() - 1; i >= 0; --i) m_cmds[i]->unapply(); We should use an iterator. 35674 1 6974 justin.garcia 2006-03-09 21:57:08 -0800 Created attachment 6974 patch 35677 2 6974 adele 2006-03-09 22:38:08 -0800 Comment on attachment 6974 patch Assuming all tests pass, r=me. 6974 2006-03-09 21:57:08 -0800 2006-03-09 22:38:08 -0800 patch 7692.txt text/plain 892 justin.garcia SW5kZXg6IENvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDb21wb3NpdGVF ZGl0Q29tbWFuZC5jcHAJKHJldmlzaW9uIDEzMjI0KQorKysgQ29tcG9zaXRlRWRpdENvbW1hbmQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OCwyMSArNjgsMjAgQEAKIAogdm9pZCBDb21wb3NpdGVF ZGl0Q29tbWFuZDo6ZG9VbmFwcGx5KCkKIHsKLSAgICBpZiAobV9jbWRzLmNvdW50KCkgPT0gMCkg eworICAgIGlmIChtX2NtZHMuY291bnQoKSA9PSAwKQogICAgICAgICByZXR1cm47Ci0gICAgfQog ICAgIAotICAgIGZvciAoaW50IGkgPSBtX2NtZHMuY291bnQoKSAtIDE7IGkgPj0gMDsgLS1pKQot ICAgICAgICBtX2NtZHNbaV0tPnVuYXBwbHkoKTsKKyAgICBRVmFsdWVMaXN0PEVkaXRDb21tYW5k UHRyPjo6Q29uc3RJdGVyYXRvciBlbmQ7CisgICAgZm9yIChRVmFsdWVMaXN0PEVkaXRDb21tYW5k UHRyPjo6Q29uc3RJdGVyYXRvciBpdCA9IG1fY21kcy5mcm9tTGFzdCgpOyBpdCAhPSBlbmQ7IC0t aXQpCisgICAgICAgICgqaXQpLT51bmFwcGx5KCk7CiAKICAgICBzZXRTdGF0ZShOb3RBcHBsaWVk KTsKIH0KIAogdm9pZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6ZG9SZWFwcGx5KCkKIHsKLSAgICBp ZiAobV9jbWRzLmNvdW50KCkgPT0gMCkgeworICAgIGlmIChtX2NtZHMuY291bnQoKSA9PSAwKQog ICAgICAgICByZXR1cm47Ci0gICAgfQogCiAgICAgZm9yIChRVmFsdWVMaXN0PEVkaXRDb21tYW5k UHRyPjo6Q29uc3RJdGVyYXRvciBpdCA9IG1fY21kcy5iZWdpbigpOyBpdCAhPSBtX2NtZHMuZW5k KCk7ICsraXQpCiAgICAgICAgICgqaXQpLT5yZWFwcGx5KCk7Cg==