<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>76919</bug_id>
          
          <creation_ts>2012-01-24 09:29:16 -0800</creation_ts>
          <short_desc>AudioParamTimeline functions should use doubles for time variables</short_desc>
          <delta_ts>2012-12-12 14:35:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>77666</dependson>
          <blocked>78854</blocked>
    
    <blocked>100885</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Raymond Toy">rtoy</reporter>
          <assigned_to name="Raymond Toy">rtoy</assigned_to>
          <cc>crogers</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>541389</commentid>
    <comment_count>0</comment_count>
    <who name="Raymond Toy">rtoy</who>
    <bug_when>2012-01-24 09:29:16 -0800</bug_when>
    <thetext>Many of the functions in the AudioParamTimeline class take floats for the time variables.  They should probably take doubles to minimize round-off issues.  See, for example, bug 76073 and bug 76659.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>559888</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2012-02-19 01:07:47 -0800</bug_when>
    <thetext>Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>560942</commentid>
    <comment_count>2</comment_count>
    <who name="Raymond Toy">rtoy</who>
    <bug_when>2012-02-21 09:16:20 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.

Do you mean only in the IDL or the IDL in addition to the c++ code? It would be best to use doubles in the c++ code and the IDL.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561068</commentid>
    <comment_count>3</comment_count>
    <who name="Raymond Toy">rtoy</who>
    <bug_when>2012-02-21 11:22:02 -0800</bug_when>
    <thetext>It would be best to do this after bug 77666 which adds tests for AudioParam.  Then we can see what impact this change will have.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>789927</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2012-12-12 14:35:18 -0800</bug_when>
    <thetext>Fixed in:
http://trac.webkit.org/changeset/133365</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>