76915 2012-01-24 07:58:54 -0800 [WK2] [GTK] TestDownloads hitting an assertion in Debug builds 2012-01-24 10:03:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar cgarcia svillar oldest_to_newest 541328 0 svillar 2012-01-24 07:58:54 -0800 This is the assertion ASSERTION FAILED: m_downloadClient (DownloadSoup.cpp:135) 541330 1 123735 svillar 2012-01-24 08:02:03 -0800 Created attachment 123735 Patch 541336 2 123735 cgarcia 2012-01-24 08:11:12 -0800 Comment on attachment 123735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145 > - ASSERT(m_downloadClient); > + ASSERT(!m_downloadClient); > ASSERT(m_resourceHandle); This should be !m_resourceHandle, since it's assigned to resourceHandle below 541338 3 svillar 2012-01-24 08:13:23 -0800 (In reply to comment #2) > (From update of attachment 123735 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review > > Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle > > > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145 > > - ASSERT(m_downloadClient); > > + ASSERT(!m_downloadClient); > > ASSERT(m_resourceHandle); > > This should be !m_resourceHandle, since it's assigned to resourceHandle below Yeah I overlooked it, I thought the ASSERT was checking the function argument 541359 4 123735 mrobinson 2012-01-24 08:48:20 -0800 Comment on attachment 123735 Patch Please land with cgarcia's suggested fix. 541419 5 svillar 2012-01-24 10:03:39 -0800 Committed r105746: <http://trac.webkit.org/changeset/105746> 123735 2012-01-24 08:02:03 -0800 2012-01-24 08:48:20 -0800 Patch bug-76915-20120124170201.patch text/plain 1971 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWZhYWFlMTcxZGRhMzIx ODg5ZWRhY2Y0YTBmYWQ4MDVhNzc5YTgyMS4uOTQwNGE2ZTU0MTk5YTNkYzQyOGJhNTc0MDRlYzQ2 MmQwNjUzNDZhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTI0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIFtH VEtdIFRlc3REb3dubG9hZHMgaGl0dGluZyBhbiBhc3NlcnRpb24gaW4gRGVidWcgYnVpbGRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjkxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyByZXF1aXJlZCBhcyBpdCBmaXhlcyBzb21lIGFzc2VydGlvbnMgaW4gYSB1bml0IHRlc3QuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL0Rvd25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkRvd25sb2FkOjpzdGFydCk6CisgICAgICAgIChXZWJLaXQ6OkRvd25s b2FkOjpzdGFydFdpdGhIYW5kbGUpOgorCiAyMDEyLTAxLTI0ICBaZW5vIEFsYmlzc2VyICA8emVu b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBBcHBsaWNhdGlvbiBVUkwgc2NoZW1l cyBjYXVzZSBhc3NlcnRzIHdoZW4gdXNpbmcgZGVidWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHAKaW5kZXgg ZTQzZjdhNGY3M2UyZDUyMzgyY2JkYWVhZTI5ZDQzOTllNjNmZjExNy4uZGY4MzBmZjc4OGVkOWEz M2RhMjAwNzRhNTdkZDgwZDIzNDNlNDc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcApAQCAtMTMyLDgg KzEzMiw4IEBAIHB1YmxpYzoKIAogdm9pZCBEb3dubG9hZDo6c3RhcnQoV2ViUGFnZSogaW5pdGlh dGluZ1dlYlBhZ2UpCiB7Ci0gICAgQVNTRVJUKG1fZG93bmxvYWRDbGllbnQpOwotICAgIEFTU0VS VChtX3Jlc291cmNlSGFuZGxlKTsKKyAgICBBU1NFUlQoIW1fZG93bmxvYWRDbGllbnQpOworICAg IEFTU0VSVCghbV9yZXNvdXJjZUhhbmRsZSk7CiAgICAgbV9kb3dubG9hZENsaWVudCA9IGFkb3B0 UHRyKG5ldyBEb3dubG9hZENsaWVudCh0aGlzKSk7CiAgICAgbV9yZXNvdXJjZUhhbmRsZSA9IFJl c291cmNlSGFuZGxlOjpjcmVhdGUoMCwgbV9yZXF1ZXN0LCBtX2Rvd25sb2FkQ2xpZW50LmdldCgp LCBmYWxzZSwgZmFsc2UpOwogICAgIGRpZFN0YXJ0KCk7CkBAIC0xNDEsNyArMTQxLDcgQEAgdm9p ZCBEb3dubG9hZDo6c3RhcnQoV2ViUGFnZSogaW5pdGlhdGluZ1dlYlBhZ2UpCiAKIHZvaWQgRG93 bmxvYWQ6OnN0YXJ0V2l0aEhhbmRsZShXZWJQYWdlKiBpbml0aWF0aW5nUGFnZSwgUmVzb3VyY2VI YW5kbGUqIHJlc291cmNlSGFuZGxlLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJikKIHsKLSAgICBB U1NFUlQobV9kb3dubG9hZENsaWVudCk7CisgICAgQVNTRVJUKCFtX2Rvd25sb2FkQ2xpZW50KTsK ICAgICBBU1NFUlQobV9yZXNvdXJjZUhhbmRsZSk7CiAgICAgbV9kb3dubG9hZENsaWVudCA9IGFk b3B0UHRyKG5ldyBEb3dubG9hZENsaWVudCh0aGlzKSk7CiAgICAgcmVzb3VyY2VIYW5kbGUtPnNl dENsaWVudChtX2Rvd25sb2FkQ2xpZW50LmdldCgpKTsK