76909 2012-01-24 06:12:32 -0800 Remove unnecessary baseURL member variable from PluginView 2012-01-25 09:18:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 kaustubh.ra webkit-unassigned abarth andersca aroben eric kaustubh.ra webkit.review.bot oldest_to_newest 541281 0 kaustubh.ra 2012-01-24 06:12:32 -0800 With reference to earlier bug - https://bugs.webkit.org/show_bug.cgi?id=62818, There was a fixme added to remove the unnecessary m_baseURL member variable. Adding bug for the same. This will reduce the PluginView object memory footprint. Will upload fix soon. 541290 1 123724 kaustubh.ra 2012-01-24 06:36:24 -0800 Created attachment 123724 Patch 541458 2 123724 eric 2012-01-24 10:36:11 -0800 Comment on attachment 123724 Patch Is m_parentFrame ever null? I don't believe a Frame can ever have a null document, thankfully. :) 542198 3 kaustubh.ra 2012-01-25 04:54:13 -0800 (In reply to comment #2) > (From update of attachment 123724 [details]) > Is m_parentFrame ever null? I don't believe a Frame can ever have a null document, thankfully. :) No, m_parentFrame can not be null and so as the document :) 542342 4 123724 webkit.review.bot 2012-01-25 09:18:50 -0800 Comment on attachment 123724 Patch Clearing flags on attachment: 123724 Committed r105883: <http://trac.webkit.org/changeset/105883> 542343 5 webkit.review.bot 2012-01-25 09:18:54 -0800 All reviewed patches have been landed. Closing bug. 123724 2012-01-24 06:36:24 -0800 2012-01-25 09:18:50 -0800 Patch 76909.patch text/plain 4071 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTczNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAxLTI0ICBLYXVzdHVi aCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAgICAgIFJlbW92ZSB1 bm5lY2Vzc2FyeSBtZW1iZXIgdmFyaWFibGUgZnJvbSBQbHVnaW5WaWV3LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY5MDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgor CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBs dWdpblZpZXc6OmdldFVSTE5vdGlmeSk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojpn ZXRVUkwpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CisgICAg ICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVQb3N0KToKKyAgICAgICAgKFdlYkNvcmU6 OlBsdWdpblZpZXc6OmdldFZhbHVlRm9yVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZp ZXc6OnNldFZhbHVlRm9yVVJMKToKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuaDoKKwog MjAxMi0wMS0yNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtSZWZhY3RvcmluZ10gTWFrZSBmaW5pc2goKSBvZiBDb2RlR2VuZXJhdG9ySlMucG0gZW1w dHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCShyZXZpc2lvbiAxMDU3Mjkp CisrKyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaAkod29ya2luZyBjb3B5KQpA QCAtMzAzLDcgKzMwMyw2IEBACiAgICAgICAgIEVsZW1lbnQqIG1fZWxlbWVudDsKICAgICAgICAg Ym9vbCBtX2lzU3RhcnRlZDsKICAgICAgICAgS1VSTCBtX3VybDsKLSAgICAgICAgS1VSTCBtX2Jh c2VVUkw7CiAgICAgICAgIFBsdWdpblN0YXR1cyBtX3N0YXR1czsKICAgICAgICAgVmVjdG9yPElu dFJlY3Q+IG1faW52YWxpZFJlY3RzOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu Vmlldy5jcHAJKHJldmlzaW9uIDEwNTcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1 Z2luVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2Miw3ICs1NjIsNyBAQAogCiAgICAgZnJh bWVMb2FkUmVxdWVzdC5zZXRGcmFtZU5hbWUodGFyZ2V0KTsKICAgICBmcmFtZUxvYWRSZXF1ZXN0 LnJlc291cmNlUmVxdWVzdCgpLnNldEhUVFBNZXRob2QoIkdFVCIpOwotICAgIGZyYW1lTG9hZFJl cXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0VVJMKG1ha2VVUkwobV9iYXNlVVJMLCB1cmwpKTsK KyAgICBmcmFtZUxvYWRSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnNldFVSTChtYWtlVVJMKG1f cGFyZW50RnJhbWUtPmRvY3VtZW50KCktPmJhc2VVUkwoKSwgdXJsKSk7CiAKICAgICByZXR1cm4g bG9hZChmcmFtZUxvYWRSZXF1ZXN0LCB0cnVlLCBub3RpZnlEYXRhKTsKIH0KQEAgLTU3Myw3ICs1 NzMsNyBAQAogCiAgICAgZnJhbWVMb2FkUmVxdWVzdC5zZXRGcmFtZU5hbWUodGFyZ2V0KTsKICAg ICBmcmFtZUxvYWRSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnNldEhUVFBNZXRob2QoIkdFVCIp OwotICAgIGZyYW1lTG9hZFJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0VVJMKG1ha2VVUkwo bV9iYXNlVVJMLCB1cmwpKTsKKyAgICBmcmFtZUxvYWRSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgp LnNldFVSTChtYWtlVVJMKG1fcGFyZW50RnJhbWUtPmRvY3VtZW50KCktPmJhc2VVUkwoKSwgdXJs KSk7CiAKICAgICByZXR1cm4gbG9hZChmcmFtZUxvYWRSZXF1ZXN0LCBmYWxzZSwgMCk7CiB9CkBA IC04MTksNyArODE5LDYgQEAKICAgICAsIG1fZWxlbWVudChlbGVtZW50KQogICAgICwgbV9pc1N0 YXJ0ZWQoZmFsc2UpCiAgICAgLCBtX3VybCh1cmwpCi0gICAgLCBtX2Jhc2VVUkwobV9wYXJlbnRG cmFtZS0+ZG9jdW1lbnQoKS0+YmFzZVVSTCgpKSAvLyBGSVhNRTogTm8gbmVlZCBmb3IgdGhpcyBt ZW1iZXIgdmFyaWFibGUhCiAgICAgLCBtX3N0YXR1cyhQbHVnaW5TdGF0dXNMb2FkZWRTdWNjZXNz ZnVsbHkpCiAgICAgLCBtX3JlcXVlc3RUaW1lcih0aGlzLCAmUGx1Z2luVmlldzo6cmVxdWVzdFRp bWVyRmlyZWQpCiAgICAgLCBtX2ludmFsaWRhdGVUaW1lcih0aGlzLCAmUGx1Z2luVmlldzo6aW52 YWxpZGF0ZVRpbWVyRmlyZWQpCkBAIC0xMjAwLDcgKzExOTksNyBAQAogICAgIH0KIAogICAgIGZy YW1lTG9hZFJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0SFRUUE1ldGhvZCgiUE9TVCIpOwot ICAgIGZyYW1lTG9hZFJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkuc2V0VVJMKG1ha2VVUkwobV9i YXNlVVJMLCB1cmwpKTsKKyAgICBmcmFtZUxvYWRSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnNl dFVSTChtYWtlVVJMKG1fcGFyZW50RnJhbWUtPmRvY3VtZW50KCktPmJhc2VVUkwoKSwgdXJsKSk7 CiAgICAgZnJhbWVMb2FkUmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS5hZGRIVFRQSGVhZGVyRmll bGRzKGhlYWRlckZpZWxkcyk7CiAgICAgZnJhbWVMb2FkUmVxdWVzdC5yZXNvdXJjZVJlcXVlc3Qo KS5zZXRIVFRQQm9keShGb3JtRGF0YTo6Y3JlYXRlKHBvc3REYXRhLCBwb3N0RGF0YUxlbmd0aCkp OwogICAgIGZyYW1lTG9hZFJlcXVlc3Quc2V0RnJhbWVOYW1lKHRhcmdldCk7CkBAIC0xMzk1LDcg KzEzOTQsNyBAQAogCiAgICAgc3dpdGNoICh2YXJpYWJsZSkgewogICAgIGNhc2UgTlBOVVJMVkNv b2tpZTogewotICAgICAgICBLVVJMIHUobV9iYXNlVVJMLCB1cmwpOworICAgICAgICBLVVJMIHUo bV9wYXJlbnRGcmFtZS0+ZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCB1cmwpOwogICAgICAgICBpZiAo dS5pc1ZhbGlkKCkpIHsKICAgICAgICAgICAgIEZyYW1lKiBmcmFtZSA9IGdldEZyYW1lKHBhcmVu dEZyYW1lKCksIG1fZWxlbWVudCk7CiAgICAgICAgICAgICBpZiAoZnJhbWUpIHsKQEAgLTE0MTcs NyArMTQxNiw3IEBACiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIE5QTlVSTFZQcm94 eTogewotICAgICAgICBLVVJMIHUobV9iYXNlVVJMLCB1cmwpOworICAgICAgICBLVVJMIHUobV9w YXJlbnRGcmFtZS0+ZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCB1cmwpOwogICAgICAgICBpZiAodS5p c1ZhbGlkKCkpIHsKICAgICAgICAgICAgIEZyYW1lKiBmcmFtZSA9IGdldEZyYW1lKHBhcmVudEZy YW1lKCksIG1fZWxlbWVudCk7CiAgICAgICAgICAgICBjb25zdCBGcmFtZUxvYWRlciogZnJhbWVM b2FkZXIgPSBmcmFtZSA/IGZyYW1lLT5sb2FkZXIoKSA6IDA7CkBAIC0xNDU2LDcgKzE0NTUsNyBA QAogCiAgICAgc3dpdGNoICh2YXJpYWJsZSkgewogICAgIGNhc2UgTlBOVVJMVkNvb2tpZTogewot ICAgICAgICBLVVJMIHUobV9iYXNlVVJMLCB1cmwpOworICAgICAgICBLVVJMIHUobV9wYXJlbnRG cmFtZS0+ZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCB1cmwpOwogICAgICAgICBpZiAodS5pc1ZhbGlk KCkpIHsKICAgICAgICAgICAgIGNvbnN0IFN0cmluZyBjb29raWVTdHIgPSBTdHJpbmc6OmZyb21V VEY4KHZhbHVlLCBsZW4pOwogICAgICAgICAgICAgRnJhbWUqIGZyYW1lID0gZ2V0RnJhbWUocGFy ZW50RnJhbWUoKSwgbV9lbGVtZW50KTsK