76898 2012-01-24 02:29:50 -0800 [GTK] Fix /webkit2/WebKitWebView/reload after r105688 2012-01-24 03:50:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned alex gustavo webkit.review.bot oldest_to_newest 541192 0 cgarcia 2012-01-24 02:29:50 -0800 ERROR:../Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:60:void assertNormalLoadHappened(WTF::Vector<LoadTrackingTest::LoadEvents>&): assertion failed (events.size() == 3): (6 == 3) FAIL 541193 1 123707 cgarcia 2012-01-24 02:32:19 -0800 Created attachment 123707 Patch 541196 2 webkit.review.bot 2012-01-24 02:39:08 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 541204 3 123707 alex 2012-01-24 03:00:51 -0800 Comment on attachment 123707 Patch LGTM 541226 4 cgarcia 2012-01-24 03:50:06 -0800 Committed r105723: <http://trac.webkit.org/changeset/105723> 123707 2012-01-24 02:32:19 -0800 2012-01-24 03:00:51 -0800 Patch wk2-reload-api-test.diff text/plain 3106 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YjliM2NkLi5mNzQ0NTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMDEtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEZpeCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L3JlbG9hZCBhZnRl ciByMTA1Njg4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03Njg5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvTG9hZFRyYWNraW5nVGVzdC5jcHA6CisgICAgICAg IChMb2FkVHJhY2tpbmdUZXN0OjpyZWxvYWQpOiBBZGQgcmVsb2FkIG1ldGhvZCB0aGF0IGNsZWFy cyBldmVudHMKKyAgICAgICAgYW5kIGluaXRpYWxpemVzIHByb2dyZXNzLgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL0xvYWRUcmFja2luZ1Rlc3QuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAg ICAgKHRlc3RXZWJWaWV3UmVsb2FkKTogVXNlIExvYWRUcmFja2luZ1Rlc3Q6OnJlbG9hZCgpIGlu c3RlYWQgb2YKKyAgICAgICAgd2Via2l0X3dlYl92aWV3X3JlbG9hZCgpLgorCisyMDEyLTAxLTI0 ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBb R1RLXSBJbXBsZW1lbnQgRG93bmxvYWRDbGllbnQgaW4gV2ViS2l0MiBHVEsrIEFQSQogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI5NTIKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvTG9hZFRyYWNraW5n VGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9Mb2FkVHJh Y2tpbmdUZXN0LmNwcAppbmRleCA4ODRhOWY0Li45ZWIwODU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9Mb2FkVHJhY2tpbmdUZXN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9Mb2FkVHJhY2tpbmdUZXN0 LmNwcApAQCAtMTY1LDMgKzE2NSwxMCBAQCB2b2lkIExvYWRUcmFja2luZ1Rlc3Q6OmxvYWRSZXF1 ZXN0KFdlYktpdFVSSVJlcXVlc3QqIHJlcXVlc3QpCiAgICAgbV9lc3RpbWF0ZWRQcm9ncmVzcyA9 IDA7CiAgICAgV2ViVmlld1Rlc3Q6OmxvYWRSZXF1ZXN0KHJlcXVlc3QpOwogfQorCit2b2lkIExv YWRUcmFja2luZ1Rlc3Q6OnJlbG9hZCgpCit7CisgICAgbV9sb2FkRXZlbnRzLmNsZWFyKCk7Cisg ICAgbV9lc3RpbWF0ZWRQcm9ncmVzcyA9IDA7CisgICAgd2Via2l0X3dlYl92aWV3X3JlbG9hZCht X3dlYlZpZXcpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvdGVzdHMvTG9hZFRyYWNraW5nVGVzdC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvdGVzdHMvTG9hZFRyYWNraW5nVGVzdC5oCmluZGV4IDUyOTIwZWEuLjJkOTVjNDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL0xvYWRUcmFj a2luZ1Rlc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9M b2FkVHJhY2tpbmdUZXN0LmgKQEAgLTQzLDYgKzQzLDcgQEAgcHVibGljOgogICAgIHZvaWQgbG9h ZEh0bWwoY29uc3QgY2hhciogaHRtbCwgY29uc3QgY2hhciogYmFzZVVSSSk7CiAgICAgdm9pZCBs b2FkUGxhaW5UZXh0KGNvbnN0IGNoYXIqIHBsYWluVGV4dCk7CiAgICAgdm9pZCBsb2FkUmVxdWVz dChXZWJLaXRVUklSZXF1ZXN0Kik7CisgICAgdm9pZCByZWxvYWQoKTsKIAogICAgIHZvaWQgc2V0 UmVkaXJlY3RVUkkoY29uc3QgY2hhciogdXJpKSB7IG1fcmVkaXJlY3RVUkkgPSB1cmk7IH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdl YktpdFdlYkxvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay90ZXN0cy9UZXN0V2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcAppbmRleCA0NWJiNjEyLi5kMmQw Y2ZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9U ZXN0V2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcApAQCAtMTI1LDE0 ICsxMjUsMTQgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdUaXRsZShMb2FkVHJhY2tpbmdUZXN0 KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdSZWxvYWQoTG9h ZFRyYWNraW5nVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKIHsKICAgICAvLyBDaGVjayB0aGF0 IG5vdGhpbmcgaGFwcGVucyB3aGVuIHRoZXJlJ3Mgbm90aGluZyB0byByZWxvYWQuCi0gICAgd2Vi a2l0X3dlYl92aWV3X3JlbG9hZCh0ZXN0LT5tX3dlYlZpZXcpOworICAgIHRlc3QtPnJlbG9hZCgp OwogICAgIHRlc3QtPndhaXQoMC4yNSk7IC8vIFdhaXQgZm9yIGEgcXVhcnRlciBvZiBhIHNlY29u ZC4KIAogICAgIHRlc3QtPmxvYWRVUkkoa1NlcnZlci0+Z2V0VVJJRm9yUGF0aCgiL25vcm1hbCIp LmRhdGEoKSk7CiAgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAgICAgYXNzZXJ0 Tm9ybWFsTG9hZEhhcHBlbmVkKHRlc3QtPm1fbG9hZEV2ZW50cyk7CiAKLSAgICB3ZWJraXRfd2Vi X3ZpZXdfcmVsb2FkKHRlc3QtPm1fd2ViVmlldyk7CisgICAgdGVzdC0+cmVsb2FkKCk7CiAgICAg dGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAgICAgYXNzZXJ0Tm9ybWFsTG9hZEhhcHBl bmVkKHRlc3QtPm1fbG9hZEV2ZW50cyk7CiB9Cg==