76853 2012-01-23 12:43:18 -0800 [chromium] Clean up old WebSharedWorker::startWorkerContext() method. 2012-01-23 20:38:48 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 tsepez tsepez abarth fishd webkit.review.bot oldest_to_newest 540748 0 tsepez 2012-01-23 12:43:18 -0800 Follow-on task from https://bugs.webkit.org/show_bug.cgi?id=75660 Make the new WebSharedWorker::startWorkerContext() method a pure virtual one [instead of a bridge calling back into the old method], and remove the old method entirely from the webkit side. 540773 1 123606 tsepez 2012-01-23 13:07:41 -0800 Created attachment 123606 Patch 540778 2 tsepez 2012-01-23 13:11:52 -0800 [Manually copying patch over to the chromium side to confirm build is still OK] 540783 3 123606 tsepez 2012-01-23 13:27:11 -0800 Comment on attachment 123606 Patch Darin, please review. This should be straightforward since I am merely removing code now that the chromium side has caught up and no longer needs this. 540785 4 webkit.review.bot 2012-01-23 13:29:17 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 541101 5 123606 webkit.review.bot 2012-01-23 20:38:44 -0800 Comment on attachment 123606 Patch Clearing flags on attachment: 123606 Committed r105687: <http://trac.webkit.org/changeset/105687> 541102 6 webkit.review.bot 2012-01-23 20:38:48 -0800 All reviewed patches have been landed. Closing bug. 123606 2012-01-23 13:07:41 -0800 2012-01-23 20:38:44 -0800 Patch patch_76853.txt text/plain 4358 tsepez SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDU2MzUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTIzICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtjaHJvbWl1bV0gQ2xlYW4gdXAgb2xkIFdlYlNoYXJlZFdvcmtlcjo6c3RhcnRXb3JrZXJD b250ZXh0KCkgbWV0aG9kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzY4NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHB1YmxpYy9XZWJTaGFyZWRXb3JrZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViU2hh cmVkV29ya2VySW1wbC5jcHA6CisgICAgICAgICogc3JjL1dlYlNoYXJlZFdvcmtlckltcGwuaDoK KwogMjAxMi0wMS0yMyAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEJhc2ljIGVuaGFuY2VtZW50cyB0byBTdHJpbmdCdWlsZGVyCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTaGFyZWRXb3JrZXIuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTaGFyZWRXb3JrZXIuaAkocmV2aXNp b24gMTA1NjM0KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2hhcmVkV29y a2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDI1ICs1OCwxMyBAQCBwdWJsaWM6CiAgICAgLy8g RklYTUUoYXR3aWxzb24pOiBSZW1vdmUgdGhpcyB3aGVuIHdlIG1vdmUgdGhlIGluaXRpYWwgc2Ny aXB0IGxvYWRpbmcgaW50byB0aGUgd29ya2VyIHByb2Nlc3MuCiAgICAgdmlydHVhbCBib29sIGlz U3RhcnRlZCgpID0gMDsKIAotICAgIC8vIEFQSSBpcyB0cmFuc2l0aW9uaW5nIGZyb20gZmlyc3Qg Zm9ybSB0byB0aGUgc2Vjb25kLiBUaGlzIGZ1bmN0aW9uIG11c3Qgc3RheSB2aXJ0dWFsIGZvciBu b3cgdG8gcHJldmVudCBicmVha2luZyBjaHJvbWUgb24gd2Via2l0IHJvbGwuCi0gICAgLy8gREVQ UkVDQVRFRAotICAgIHZpcnR1YWwgdm9pZCBzdGFydFdvcmtlckNvbnRleHQoY29uc3QgV2ViVVJM JiBzY3JpcHRVUkwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBX ZWJTdHJpbmcmIG5hbWUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBXZWJTdHJpbmcmIHVzZXJBZ2VudCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnN0IFdlYlN0cmluZyYgc291cmNlQ29kZSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxvbmcgbG9uZyBzY3JpcHRSZXNvdXJjZUFwcENhY2hlSUQpID0gMDsKLQot ICAgIC8vIENocm9taXVtIHdpbGwgbmVlZCB0byBmYWxsYmFjayB0byB0aGlzIG1ldGhvZCB0byBh dm9pZCBicmVha2luZyBkdXJpbmcgdGhlIG5leHQgd2Via2l0IHJvbGwuCi0gICAgLy8gSXQgd2ls bCBiZWNvbWUgYSBwdXJlIHZpcnR1YWwgbWV0aG9kIG9uY2UgdGhlIGNocm9taXVtIHNpZGUgaXMg dXBkYXRlZC4KICAgICB2aXJ0dWFsIHZvaWQgc3RhcnRXb3JrZXJDb250ZXh0KGNvbnN0IFdlYlVS TCYgc2NyaXB0VVJMLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg V2ViU3RyaW5nJiBuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgV2ViU3RyaW5nJiB1c2VyQWdlbnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBXZWJTdHJpbmcmIHNvdXJjZUNvZGUsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIGNvbnRlbnRTZWN1cml0eVBvbGljeSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYkNvbnRlbnRTZWN1cml0eVBvbGlj eVR5cGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb25nIGxvbmcgc2Ny aXB0UmVzb3VyY2VBcHBDYWNoZUlEKSB7Ci0gICAgICAgIHN0YXJ0V29ya2VyQ29udGV4dChzY3Jp cHRVUkwsIG5hbWUsIHVzZXJBZ2VudCwgc291cmNlQ29kZSwgc2NyaXB0UmVzb3VyY2VBcHBDYWNo ZUlEKTsKLSAgICB9CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb25nIGxv bmcgc2NyaXB0UmVzb3VyY2VBcHBDYWNoZUlEKSA9IDA7CiAKICAgICBjbGFzcyBDb25uZWN0TGlz dGVuZXIgewogICAgIHB1YmxpYzoKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlNoYXJlZFdvcmtlckltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNoYXJlZFdvcmtlckltcGwuY3BwCShyZXZpc2lvbiAxMDU2MzQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTaGFyZWRXb3JrZXJJbXBsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzYxLDExICszNjEsNiBAQCB2b2lkIFdlYlNoYXJlZFdvcmtlckltcGw6OmNvbm5l Y3RUYXNrKFNjCiAgICAgd29ya2VyQ29udGV4dC0+ZGlzcGF0Y2hFdmVudChjcmVhdGVDb25uZWN0 RXZlbnQocG9ydCkpOwogfQogCi12b2lkIFdlYlNoYXJlZFdvcmtlckltcGw6OnN0YXJ0V29ya2Vy Q29udGV4dChjb25zdCBXZWJVUkwmIHVybCwgY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBjb25zdCBX ZWJTdHJpbmcmIHVzZXJBZ2VudCwgY29uc3QgV2ViU3RyaW5nJiBzb3VyY2VDb2RlLCBsb25nIGxv bmcgY2FjaGVJZCkKLXsKLSAgICBzdGFydFdvcmtlckNvbnRleHQodXJsLCBuYW1lLCB1c2VyQWdl bnQsIHNvdXJjZUNvZGUsICIiLCBXZWJDb250ZW50U2VjdXJpdHlQb2xpY3lUeXBlUmVwb3J0T25s eSwgY2FjaGVJZCk7Ci19Ci0KIHZvaWQgV2ViU2hhcmVkV29ya2VySW1wbDo6c3RhcnRXb3JrZXJD b250ZXh0KGNvbnN0IFdlYlVSTCYgdXJsLCBjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdl YlN0cmluZyYgdXNlckFnZW50LCBjb25zdCBXZWJTdHJpbmcmIHNvdXJjZUNvZGUsIGNvbnN0IFdl YlN0cmluZyYgY29udGVudFNlY3VyaXR5UG9saWN5LCBXZWJDb250ZW50U2VjdXJpdHlQb2xpY3lU eXBlIHBvbGljeVR5cGUsIGxvbmcgbG9uZykKIHsKICAgICBpbml0aWFsaXplTG9hZGVyKHVybCk7 CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTaGFyZWRXb3JrZXJJbXBsLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2hhcmVkV29ya2Vy SW1wbC5oCShyZXZpc2lvbiAxMDU2MzQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJTaGFyZWRXb3JrZXJJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTk3LDggKzk3LDYgQEAgcHVi bGljOgogICAgIC8vIFdlYlNoYXJlZFdvcmtlciBtZXRob2RzOgogICAgIHZpcnR1YWwgYm9vbCBp c1N0YXJ0ZWQoKTsKIAotICAgIC8vIEFQSSBpcyB0cmFuc2l0aW9uaW5nIGZyb20gZmlyc3QgZm9y bSB0byBzZWNvbmQgZm9ybS4gVGhlIG1ldGhvZHMgbXVzdCByZW1haW4gdmlydHVhbCB0byBhdm9p ZCBicmVha2luZyBjaHJvbWl1bSBvbiB0aGUgbmV4dCB3ZWJraXQgcm9sbC4KLSAgICB2aXJ0dWFs IHZvaWQgc3RhcnRXb3JrZXJDb250ZXh0KGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYg bmFtZSwgY29uc3QgV2ViU3RyaW5nJiB1c2VyQWdlbnQsIGNvbnN0IFdlYlN0cmluZyYgc291cmNl Q29kZSwgbG9uZyBsb25nKTsKICAgICB2aXJ0dWFsIHZvaWQgc3RhcnRXb3JrZXJDb250ZXh0KGNv bnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYgbmFtZSwgY29uc3QgV2ViU3RyaW5nJiB1c2Vy QWdlbnQsIGNvbnN0IFdlYlN0cmluZyYgc291cmNlQ29kZSwgY29uc3QgV2ViU3RyaW5nJiBjb250 ZW50U2VjdXJpdHlQb2xpY3ksIFdlYkNvbnRlbnRTZWN1cml0eVBvbGljeVR5cGUsIGxvbmcgbG9u ZyBjYWNoZUlkKTsKIAogICAgIHZpcnR1YWwgdm9pZCBjb25uZWN0KFdlYk1lc3NhZ2VQb3J0Q2hh bm5lbCosIENvbm5lY3RMaXN0ZW5lciopOwo=