76836 2012-01-23 09:10:37 -0800 [meta] Stop rebuilding .h/.cpp files generated by unchanged IDLs 2013-06-17 16:10:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 76841 76846 76874 76918 76920 76922 76923 76926 76970 1 haraken haraken abarth achristensen darin morrita oldest_to_newest 540592 0 haraken 2012-01-23 09:10:37 -0800 Currently, if *any* of IDL files is updated, then generate-bindings.pl runs for *all* IDL files, and all .h/.cpp files are re-generated and rebuilt. We can stop the redundant rebuilding by having CodeGenerators write the output .h/.cpp file to a temp file and then overwrite the .h/.cpp only if the bytes differ. 540611 1 haraken 2012-01-23 09:38:47 -0800 I'll get things done in the following steps: [1] Remove finish() from CodeGeneratorV8.pm. [2] Remove finish() from CodeGeneratorJS.pm. [3] Remove finish() from CodeGenerator{ObjC,GObject,CPP}.pm and CodeGenerator.pm. [4] Make a change on CodeGeneratorV8.pm and CodeGenerator.pm to overwrite .h/.cpp files only when the bytes differ. [5] Make similar changes on CodeGeneratorJS.pm. [6] Make similar changes on CodeGenerator{ObjC,GObject,CPP}.pm. 540711 2 abarth 2012-01-23 11:45:30 -0800 Sounds like a good idea. 540786 3 darin 2012-01-23 13:29:45 -0800 Can we change this so code is shared while doing the work 6 times? 540788 4 haraken 2012-01-23 13:31:28 -0800 (In reply to comment #3) > Can we change this so code is shared while doing the work 6 times? Sure. I'll make UpdateFileIfChanged() in CodeGenerator.pm and use it from all CodeGenerators. 901194 5 ap 2013-06-17 16:10:58 -0700 *** Bug 117708 has been marked as a duplicate of this bug. ***