76832 2012-01-23 08:20:49 -0800 [Qt] Build fix when using force_static_libs_as_shared 2012-02-24 00:19:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abecsi hausmann webkit.review.bot zoltan oldest_to_newest 540549 0 yael 2012-01-23 08:20:49 -0800 When building a debug build on Linux with 32 bit machines, we must use force_static_libs_as_shared or we cannot link. When WebKit2 and WebCore are built as a shared library, we must add QT+=widgets for them to link. 540555 1 123560 yael 2012-01-23 08:23:26 -0800 Created attachment 123560 Patch. 541209 2 123560 hausmann 2012-01-24 03:06:10 -0800 Comment on attachment 123560 Patch. I think the dependency is correct, but I don't think that it should be guarded with force_static_libs_as_shared. It is a _real_ dependency and it should IMHO be expressed as such, i.e. without the force_static_libs_as_shared scope. 541481 3 123770 yael 2012-01-24 10:56:25 -0800 Created attachment 123770 Patch. Removed the flag, as suggested by Simon. 542330 4 123770 webkit.review.bot 2012-01-25 09:10:08 -0800 Comment on attachment 123770 Patch. Clearing flags on attachment: 123770 Committed r105881: <http://trac.webkit.org/changeset/105881> 542331 5 webkit.review.bot 2012-01-25 09:10:13 -0800 All reviewed patches have been landed. Closing bug. 561513 6 yael 2012-02-21 19:43:50 -0800 This got broken again by r108328 561810 7 abecsi 2012-02-22 03:20:21 -0800 The build with --qmakearg="CONFIG+=force_static_libs_as_shared" works for me. What build options do you use? You need a clean build after this change, since the build system has some problems with changing module dependency settings in project files. 561854 8 abecsi 2012-02-22 05:00:01 -0800 (In reply to comment #6) > This got broken again by r108328 Looks like the option actually broke because of r108359. The inclusion order resulted in some defines being undeffed by the new header. The fixed patch was landed in http://trac.webkit.org/changeset/108483. 561870 9 yael 2012-02-22 05:17:01 -0800 (In reply to comment #8) > The fixed patch was landed in http://trac.webkit.org/changeset/108483. Thanks for fixing it :) 563742 10 yael 2012-02-23 17:33:21 -0800 (In reply to comment #8) > (In reply to comment #6) > > This got broken again by r108328 > > Looks like the option actually broke because of r108359. > The inclusion order resulted in some defines being undeffed by the new header. > > The fixed patch was landed in http://trac.webkit.org/changeset/108483. This is still broken. WebKit2 is still using QWidgets such as QFileDialog etc. When building with force_static_libs_as_shared, WebKit2 is a self contained dll and it needs to have QT+=widgets. This problem has nothing to do with http://trac.webkit.org/changeset/108483 , and is indeed regression from 108328, which removed QT+=widgets . Clean build with default flags, not specifying any flags on the command line is currently failing. (with latest Qt5). 564028 11 hausmann 2012-02-24 00:19:33 -0800 (In reply to comment #10) > (In reply to comment #8) > > (In reply to comment #6) > > > This got broken again by r108328 > > > > Looks like the option actually broke because of r108359. > > The inclusion order resulted in some defines being undeffed by the new header. > > > > The fixed patch was landed in http://trac.webkit.org/changeset/108483. > > This is still broken. WebKit2 is still using QWidgets such as QFileDialog etc. > When building with force_static_libs_as_shared, WebKit2 is a self contained dll and it needs to have QT+=widgets. > > This problem has nothing to do with http://trac.webkit.org/changeset/108483 , and is indeed regression from 108328, which removed QT+=widgets . > > Clean build with default flags, not specifying any flags on the command line is currently failing. (with latest Qt5). Yael, you're right. I've filed bug #79458 for this. 123560 2012-01-23 08:23:26 -0800 2012-01-24 10:56:25 -0800 Patch. 76832.patch text/plain 2468 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTYyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTIzICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1aWxkIGZpeCB3 aGVuIHVzaW5nIGZvcmNlX3N0YXRpY19saWJzX2FzX3NoYXJlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGJ1aWxkaW5nIG9uIExpbnV4IHdpdGgg MzIgYml0IG1hY2hpbmVzLCB3ZSBtdXN0IHVzZSBmb3JjZV9zdGF0aWNfbGlic19hc19zaGFyZWQK KyAgICAgICAgb3Igd2UgY2Fubm90IGxpbmsuCisgICAgICAgIFdoZW4gV2ViQ29yZSBpcyBidWls dCBhcyBhIHNoYXJlZCBsaWJyYXJ5LCB3ZSBtdXN0IGFkZCBRVCs9d2lkZ2V0cyB0byBpdC4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgYSBidWlsZCBmaXguCisKKyAgICAgICAgKiBU YXJnZXQucHJpOgorCiAyMDEyLTAxLTIzICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluZGV4ZWREQk1vZGVsIHNob3VsZCBr ZWVwIHRyYWNrIG9mIHJlcXVlc3RzIHNlbnQgdG8gdGhlIGJhY2tlbmQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9UYXJnZXQucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1RhcmdldC5w cmkJKHJldmlzaW9uIDEwNTQ3MCkKKysrIFNvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkJKHdvcmtp bmcgY29weSkKQEAgLTE2LDYgKzE2LDggQEAgQ09ORklHICs9IHN0YXRpY2xpYgogCiBERUZJTkVT ICs9IFFUX01BS0VETEwKIAorZm9yY2Vfc3RhdGljX2xpYnNfYXNfc2hhcmVkOiBRVCArPSB3aWRn ZXRzCisKIGhhdmVRdCg1KSB7CiAgICAgIyBBZGQgYSBRdFNjcmlwdCBkZXBlbmRlbmN5IGZvciB0 aGUgdGltZSBiZWluZywgaW4gb3JkZXIgdG8gcHVsbCBpbiB0aGUgaW5jbHVkZQogICAgICMgcGF0 aCBmb3IgUXRTY3JpcHQgd2hlbiBpdCdzIGJ1aWx0IGFzIGEgc3RhbmRhbG9uZSBtb2R1bGUKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTYyMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTIzICBZYWVsIEFoYXJv biAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1aWxkIGZpeCB3aGVu IHVzaW5nIGZvcmNlX3N0YXRpY19saWJzX2FzX3NoYXJlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGJ1aWxkaW5nIG9uIExpbnV4IHdpdGggMzIg Yml0IG1hY2hpbmVzLCB3ZSBtdXN0IHVzZSBmb3JjZV9zdGF0aWNfbGlic19hc19zaGFyZWQKKyAg ICAgICAgb3Igd2UgY2Fubm90IGxpbmsuCisgICAgICAgIFdoZW4gV2ViS2l0MiBpcyBidWlsdCBh cyBhIHNoYXJlZCBsaWJyYXJ5LCB3ZSBtdXN0IGFkZCBRVCs9d2lkZ2V0cyB0byBpdC4KKworICAg ICAgICAqIFRhcmdldC5wcmk6CisKIDIwMTItMDEtMjEgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90 aHlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV2ViS2l0MiByZW1lbWJlciB0aGUgaGVpZ2h0 IG9mIHRoZSBXZWIgSW5zcGVjdG9yIHdoZW4gaXQgaXMgZG9ja2VkLgpJbmRleDogU291cmNlL1dl YktpdDIvVGFyZ2V0LnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJp CShyZXZpc2lvbiAxMDU0NzApCisrKyBTb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJpCSh3b3JraW5n IGNvcHkpCkBAIC0xNCw2ICsxNCw4IEBAIGluY2x1ZGUoV2ViS2l0Mi5wcmkpCiBXRUJLSVQgKz0g d3RmIGphdmFzY3JpcHRjb3JlIHdlYmNvcmUKIFFUICs9IGRlY2xhcmF0aXZlCiAKK2ZvcmNlX3N0 YXRpY19saWJzX2FzX3NoYXJlZDogUVQgKz0gd2lkZ2V0cworCiBDT05GSUcgKz0gc3RhdGljbGli CiAKIEhFQURFUlMgKz0gXAo= 123770 2012-01-24 10:56:25 -0800 2012-01-25 09:10:08 -0800 Patch. 76832.patch text/plain 2195 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTYyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTIzICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1aWxkIGZpeCB3 aGVuIHVzaW5nIGZvcmNlX3N0YXRpY19saWJzX2FzX3NoYXJlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBkZXBlbmRlbmN5IG9uIFF0V2lkZ2V0 cywgd2hlbiBjb21waWxpbmcgYWdhaW5zdCBRdDUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBU aGlzIGlzIGEgYnVpbGQgZml4LgorCisgICAgICAgICogVGFyZ2V0LnByaToKKwogMjAxMi0wMS0y MyAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBJbmRleGVkREJNb2RlbCBzaG91bGQga2VlcCB0cmFjayBvZiByZXF1ZXN0cyBz ZW50IHRvIHRoZSBiYWNrZW5kLgpJbmRleDogU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCShyZXZpc2lvbiAxMDU0NzApCisr KyBTb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0xOSw3ICsxOSw3 IEBAIERFRklORVMgKz0gUVRfTUFLRURMTAogaGF2ZVF0KDUpIHsKICAgICAjIEFkZCBhIFF0U2Ny aXB0IGRlcGVuZGVuY3kgZm9yIHRoZSB0aW1lIGJlaW5nLCBpbiBvcmRlciB0byBwdWxsIGluIHRo ZSBpbmNsdWRlCiAgICAgIyBwYXRoIGZvciBRdFNjcmlwdCB3aGVuIGl0J3MgYnVpbHQgYXMgYSBz dGFuZGFsb25lIG1vZHVsZQotICAgIFFUICs9IHNjcmlwdAorICAgIFFUICs9IHNjcmlwdCB3aWRn ZXRzCiB9IGVsc2UgewogICAgIElOQ0xVREVQQVRIICs9ICQkUFdELy4uL0phdmFTY3JpcHRDb3Jl L3d0Zi9xdC9jb21wYXQKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTYyMikKKysrIFNv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDEyLTAxLTIzICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAg ICBbUXRdIEJ1aWxkIGZpeCB3aGVuIHVzaW5nIGZvcmNlX3N0YXRpY19saWJzX2FzX3NoYXJlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4MzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBkZXBl bmRlbmN5IG9uIFF0V2lkZ2V0cy4KKworICAgICAgICAqIFRhcmdldC5wcmk6CisKIDIwMTItMDEt MjEgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ug V2ViS2l0MiByZW1lbWJlciB0aGUgaGVpZ2h0IG9mIHRoZSBXZWIgSW5zcGVjdG9yIHdoZW4gaXQg aXMgZG9ja2VkLgpJbmRleDogU291cmNlL1dlYktpdDIvVGFyZ2V0LnByaQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9UYXJnZXQucHJpCShyZXZpc2lvbiAxMDU0NzApCisrKyBTb3VyY2Uv V2ViS2l0Mi9UYXJnZXQucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0xMiw3ICsxMiw3IEBAIGxvYWQo ZmVhdHVyZXMpCiBpbmNsdWRlKFdlYktpdDIucHJpKQogCiBXRUJLSVQgKz0gd3RmIGphdmFzY3Jp cHRjb3JlIHdlYmNvcmUKLVFUICs9IGRlY2xhcmF0aXZlCitRVCArPSBkZWNsYXJhdGl2ZSB3aWRn ZXRzCiAKIENPTkZJRyArPSBzdGF0aWNsaWIKIAo=