76808 2012-01-22 22:41:11 -0800 Web Inspector: Inspecting an element inside an iframe no longer works 2024-11-26 19:01:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://www.iframehtml.com/ P2 Normal --- 0 priyajeet.hora pfeldman apavlov bweinstein izma143 joepeck keishi loislo pfeldman pmuellr priyajeet.hora rik timothy yurys oldest_to_newest 540390 0 priyajeet.hora 2012-01-22 22:41:11 -0800 On a page with an iframe, for example http://www.iframehtml.com/ try to right click and inspect some dom element inside the iframe. Web inspector fails to drill down to the element. Same thing can be noticed if using the magnifying/search glass icon. This seems a regression, possibly related to #document change https://bugs.webkit.org/show_bug.cgi?id=76550 If you manually open the iframe in web inspector and try right clicking the element on the page and inspecting again, it will then properly drill down to the element in the inspector. 540522 1 123553 pfeldman 2012-01-23 06:52:58 -0800 Created attachment 123553 Patch 540526 2 123553 timothy 2012-01-23 06:56:23 -0800 Comment on attachment 123553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123553&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:243 > } > - > DOMAgent.requestChildNodes(this.id, mycallback.bind(this)); I prefer empty lines line this. Otherwise it feels too crowded. > Source/WebCore/inspector/front-end/DOMAgent.js:402 > + if (this._contentDocument) > + return; Maybe this deserves a comment? It needs to be this way because the children are set in the constructor? 540528 3 pfeldman 2012-01-23 07:08:41 -0800 (In reply to comment #2) > (From update of attachment 123553 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123553&action=review > > > Source/WebCore/inspector/front-end/DOMAgent.js:243 > > } > > - > > DOMAgent.requestChildNodes(this.id, mycallback.bind(this)); > > I prefer empty lines line this. Otherwise it feels too crowded. > Done. > > Source/WebCore/inspector/front-end/DOMAgent.js:402 > > + if (this._contentDocument) > > + return; > > Maybe this deserves a comment? It needs to be this way because the children are set in the constructor? Done. 540529 4 pfeldman 2012-01-23 07:10:21 -0800 Committed r105620: <http://trac.webkit.org/changeset/105620> 123553 2012-01-23 06:52:58 -0800 2012-01-23 06:56:23 -0800 Patch bug-76808-20120123185256.patch text/plain 6480 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZiNDI0ZDk3NmNhYzcw YTU2NTQ0NzIxYTEwZWE4ODMxOTM2OWU0Yy4uZjI4OWU3YzcyMzA0MTdhMGY1MjFjNzFhOWY3M2Jk NmQxYzkyM2U4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAxLTIzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbnNwZWN0aW5nIGFuIGVsZW1lbnQgaW5zaWRlIGFuIGlmcmFtZSBubyBsb25nZXIgd29ya3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2ODA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaHR0 cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdC1lbGVtZW50Lmh0bWwKKworICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JE T01BZ2VudDo6aW5uZXJQYXJlbnROb2RlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L0RPTUFnZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5vZGUucHJvdG90eXBlLmdl dENoaWxkTm9kZXMubXljYWxsYmFjayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZS5w cm90b3R5cGUuZ2V0Q2hpbGROb2Rlcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZS5w cm90b3R5cGUuX3NldENoaWxkcmVuUGF5bG9hZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1l bnRzVHJlZU91dGxpbmUucHJvdG90eXBlLl9zZWxlY3RlZE5vZGVDaGFuZ2VkKToKKwogMjAxMi0w MS0yMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gQVRLIHRleHQtY2FyZXQtbW92ZWQgYW5kIHRleHQtc2VsZWN0aW9uLWNoYW5nZWQg ZXZlbnRzIG5vdCBiZWluZyBlbWl0dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmNwcAppbmRleCBkOTk0MWRkNGY4MWYyYjQ0MWVmMjBmMzFjN2NlM2Ji MDU2ZWI2YzYyLi4wY2QzMjNmNDQ2NGIzNjc2YjMwMzBlODNjNTU4NTI0MzQ0MDJmODRjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKQEAgLTEy NTEsNiArMTI1MSwxMCBAQCB1bnNpZ25lZCBJbnNwZWN0b3JET01BZ2VudDo6aW5uZXJDaGlsZE5v ZGVDb3VudChOb2RlKiBub2RlKQogCiBOb2RlKiBJbnNwZWN0b3JET01BZ2VudDo6aW5uZXJQYXJl bnROb2RlKE5vZGUqIG5vZGUpCiB7CisgICAgaWYgKG5vZGUtPmlzRG9jdW1lbnROb2RlKCkpIHsK KyAgICAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gc3RhdGljX2Nhc3Q8RG9jdW1lbnQqPihub2Rl KTsKKyAgICAgICAgcmV0dXJuIGRvY3VtZW50LT5vd25lckVsZW1lbnQoKTsKKyAgICB9CiAgICAg cmV0dXJuIG5vZGUtPnBhcmVudE5vZGUoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKaW5kZXggZjcxZTgyZjkyYTBhMjlhMzZmYmMzNzFm OTU4NTMxOWI2ZGVkM2QyYS4uNGI2NjY1NjdmMjIzYWE2YmEyYTcyYWU1NjBiZDY5MGMwMzdiYzYy ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2Vu dC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50Lmpz CkBAIC0yNDAsNyArMjQwLDYgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUucHJvdG90eXBlID0gewog ICAgICAgICAgICAgaWYgKCFlcnJvciAmJiBjYWxsYmFjaykKICAgICAgICAgICAgICAgICBjYWxs YmFjayh0aGlzLmNoaWxkcmVuKTsKICAgICAgICAgfQotCiAgICAgICAgIERPTUFnZW50LnJlcXVl c3RDaGlsZE5vZGVzKHRoaXMuaWQsIG15Y2FsbGJhY2suYmluZCh0aGlzKSk7CiAgICAgfSwKIApA QCAtMzk5LDYgKzM5OCw4IEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlLnByb3RvdHlwZSA9IHsKICAg ICAgKi8KICAgICBfc2V0Q2hpbGRyZW5QYXlsb2FkOiBmdW5jdGlvbihwYXlsb2FkcykKICAgICB7 CisgICAgICAgIGlmICh0aGlzLl9jb250ZW50RG9jdW1lbnQpCisgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIHRoaXMuY2hpbGRyZW4gPSBbXTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBwYXlsb2Fkcy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHBheWxvYWQgPSBwYXls b2Fkc1tpXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwppbmRleCA4Y2UwMTRkMjMwMDY1NzZkNWIwMzMzZTgx NDQ4NTQ5NTMxOGI5OTQ1Li5iNWE1ZTkwOGM2MWQ1OGJlYWM3NTdlNmNjNmI3OTZkNTEwOTZmODBj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz VHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC0xODQsNyArMTg0LDcgQEAgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzVHJlZU91dGxpbmUucHJvdG90eXBlID0gewogCiAgICAgX3NlbGVjdGVkTm9kZUNoYW5n ZWQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2V2ZW50U3VwcG9ydC5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUuRXZlbnRz LlNlbGVjdGVkTm9kZUNoYW5nZWQpOworICAgICAgICB0aGlzLl9ldmVudFN1cHBvcnQuZGlzcGF0 Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLkV2ZW50 cy5TZWxlY3RlZE5vZGVDaGFuZ2VkLCB0aGlzLl9zZWxlY3RlZERPTU5vZGUpOwogICAgIH0sCiAK ICAgICBmaW5kVHJlZUVsZW1lbnQ6IGZ1bmN0aW9uKG5vZGUpCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGU0YjM1NTRjM2Q4 M2VjZWVmN2ExMDAwNWFlYzUyYWZhYzNiZjA3YS4uZWM4ZmFhNGJiODg2M2Q3NGVmNWYzMDE3OGM1 YTEzZDY0MWExMDhlMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTIzICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJ bnNwZWN0aW5nIGFuIGVsZW1lbnQgaW5zaWRlIGFuIGlmcmFtZSBubyBsb25nZXIgd29ya3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2ODA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L2luc3BlY3Rvci9pbnNwZWN0LWVsZW1lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBodHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0LWVsZW1lbnQuaHRtbDogQWRkZWQuCisgICAg ICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3QtZWxlbWVudC1pZnJh bWUuaHRtbDogQWRkZWQuCisKIDIwMTItMDEtMjIgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1t ZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBGaXggdHlwbywgd2hpY2gg bWFrZXMgdGhlIHN0eWxlIGJvdCB3YXJuIG9uIGV2ZXJ5IHBhdGNoLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdC1lbGVtZW50LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3QtZWxlbWVudC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMDEyMDI3OWYzNzhiYzI4ZjI2YjEzMmMzYjQ3ZTBmNTY0OWZj YTcyMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L2luc3BlY3QtZWxlbWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitUZXN0cyB0aGF0 IGluc3BlY3QgZWxlbWVudCBhY3Rpb24gd29ya3MgZm9yIGlmcmFtZSBjaGlsZHJlbiAoaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2ODA4KS4KKworCitkaXYjZGl2CisK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3QtZWxl bWVudC5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdC1lbGVt ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYzg3YmFhNWRkMWYwZTBiNTQ3NjA4ODg1YzQ4NGFiOGZjN2Iy ZGUwOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L2luc3BlY3QtZWxlbWVudC5odG1sCkBAIC0wLDAgKzEsMzMgQEAKKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0iaW5zcGVjdG9yLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9ImVs ZW1lbnRzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZnVuY3Rpb24gdGVzdCgpCit7 CisgICAgV2ViSW5zcGVjdG9yLmluc3BlY3RvclZpZXcuc2V0Q3VycmVudFBhbmVsKFdlYkluc3Bl Y3Rvci5wYW5lbHMuZWxlbWVudHMpOworICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuZWxlbWVudHMu dHJlZU91dGxpbmUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0 bGluZS5FdmVudHMuU2VsZWN0ZWROb2RlQ2hhbmdlZCwgc2VsZWN0ZWROb2RlQ2hhbmdlZCwgdGhp cyk7CisgICAgZnVuY3Rpb24gc2VsZWN0ZWROb2RlQ2hhbmdlZChldmVudCkKKyAgICB7CisgICAg ICAgIHZhciBub2RlID0gZXZlbnQuZGF0YTsKKyAgICAgICAgaWYgKG5vZGUuZ2V0QXR0cmlidXRl KCJpZCIpID09ICJkaXYiKSB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdChu b2RlLmFwcHJvcHJpYXRlU2VsZWN0b3JGb3IoKSk7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0 LmNvbXBsZXRlVGVzdCgpOworICAgICAgICB9CisgICAgfQorICAgIEluc3BlY3RvclRlc3QuZXZh bHVhdGVJbkNvbnNvbGUoImluc3BlY3QoaWZyYW1lRGl2RWxlbWVudCkiKTsKK30KKworPC9zY3Jp cHQ+Cis8L2hlYWQ+CisKKzxib2R5PgorPHA+CitUZXN0cyB0aGF0IGluc3BlY3QgZWxlbWVudCBh Y3Rpb24gd29ya3MgZm9yIGlmcmFtZSBjaGlsZHJlbiAoaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc2ODA4KS4KKzwvcD4KKworPGlmcmFtZSBzcmM9InJlc291cmNlcy9p bnNwZWN0LWVsZW1lbnQtaWZyYW1lLmh0bWwiIG9ubG9hZD0icnVuVGVzdCgpIj48L2lmcmFtZT4K KworPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9p bnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3QtZWxlbWVudC1pZnJhbWUuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlcy9pbnNwZWN0LWVsZW1lbnQtaWZyYW1l Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uMmRmYjU0MTc1NjczZTZiY2Y1NGYwZWZmMDRiMTc5MDNjN2YzNGZj MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jl c291cmNlcy9pbnNwZWN0LWVsZW1lbnQtaWZyYW1lLmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPGh0 bWw+CisKKzxib2R5PgorPGRpdiBpZD0iZGl2Ij5FbGVtZW50IHRvIGluc3BlY3Q8L2Rpdj4KKzwv Ym9keT4KKworPHNjcmlwdD4KK3RvcC5pZnJhbWVEaXZFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImRpdiIpOworPC9zY3JpcHQ+CisKKzwvaHRtbD4K