76779 2012-01-21 00:31:35 -0800 [BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension. 2012-02-06 05:55:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 charles.wei webkit-unassigned rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 540091 0 charles.wei 2012-01-21 00:31:35 -0800 If the url file doesn't have an extension, like http://domain/noextension, we should try to append the extension of the mime type to the suggested file. like if it happen to be a text file indicated by the MIME, we should suggest the file name as : noextension.txt 549869 1 125606 charles.wei 2012-02-06 02:55:07 -0800 Created attachment 125606 Patch 549928 2 125606 rwlbuis 2012-02-06 05:45:44 -0800 Comment on attachment 125606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614 > + // fill it in from the url and sniffed mime type;Skip this for data and about URLs, the Skip section seems untidy. Needs a space and no need for capital S. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625 > + suggestedFilename = String("Untitled") + "." + mimeExtension; This could be done differently: suggestedFilename = String("Untitled"); if (!mimeExtension.isEmpty()) // No extension found for the mimeType. suggestedFilename = "." + mimeExtension; > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630 > + suggestedFilename = urlFilename; Ditto. 549933 3 125606 webkit.review.bot 2012-02-06 05:55:28 -0800 Comment on attachment 125606 Patch Clearing flags on attachment: 125606 Committed r106802: <http://trac.webkit.org/changeset/106802> 549934 4 webkit.review.bot 2012-02-06 05:55:32 -0800 All reviewed patches have been landed. Closing bug. 125606 2012-02-06 02:55:07 -0800 2012-02-06 05:55:27 -0800 Patch bug-76779-20120206185839.patch text/plain 2810 charles.wei SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjc5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA2ICBDaGFybGVz IFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tC ZXJyeV1Vc2UgZXh0ZW5zaW9uIGZvciBhIG1pbWV0eXBlIGFzIHRoZSBzdWdnZXN0ZWQgZXh0ZW5z aW9uCisgICAgICAgIGlmIHRoZSB1cmwgZmlsZSBkb2Vzbid0IGhhdmUgYW4gZXh0ZW5zaW9uLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY3NzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQp OgorCiAyMDEyLTAyLTA2ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBBZGQgPHNoYWRvdz4gZWxlbWVudCwgd2hpY2ggaXMgZ3VhcmRlZCBieSBTSEFET1dfRE9N IGZsYWcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkv TmV0d29ya0pvYi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCShyZXZpc2lvbiAxMDY3NzQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTYxMCwxMiArNjEwLDI2IEBAIHZvaWQgTmV0d29ya0pvYjo6c2VuZFJl c3BvbnNlSWZOZWVkZWQoKQogICAgIGlmICghY29udGVudExlbmd0aC5pc051bGwoKSkKICAgICAg ICAgbV9yZXNwb25zZS5zZXRFeHBlY3RlZENvbnRlbnRMZW5ndGgoY29udGVudExlbmd0aC50b0lu dDY0KCkpOwogCi0gICAgLy8gU2V0IHN1Z2dlc3RlZCBmaWxlbmFtZSBmb3IgZG93bmxvYWRzIGZy b20gdGhlIENvbnRlbnQtRGlzcG9zaXRpb24gaGVhZGVyOyBpZiB0aGlzIGZhaWxzLCBmaWxsIGl0 IGluIGZyb20gdGhlIHVybAotICAgIC8vIHNraXAgdGhpcyBmb3IgZGF0YSB1cmwncywgYmVjYXVz ZSB0aGV5IGhhdmUgbm8gQ29udGVudC1EaXNwb3NpdGlvbiBoZWFkZXIgYW5kIHRoZSBmb3JtYXQg aXMgd3JvbmcgdG8gYmUgYSBmaWxlbmFtZS4KKyAgICAvLyBTZXQgc3VnZ2VzdGVkIGZpbGVuYW1l IGZvciBkb3dubG9hZHMgZnJvbSB0aGUgQ29udGVudC1EaXNwb3NpdGlvbiBoZWFkZXI7IGlmIHRo aXMgZmFpbHMsCisgICAgLy8gZmlsbCBpdCBpbiBmcm9tIHRoZSB1cmwgYW5kIHNuaWZmZWQgbWlt ZSB0eXBlO1NraXAgdGhpcyBmb3IgZGF0YSBhbmQgYWJvdXQgVVJMcywKKyAgICAvLyBiZWNhdXNl IHRoZXkgaGF2ZSBubyBDb250ZW50LURpc3Bvc2l0aW9uIGhlYWRlciBhbmQgdGhlIGZvcm1hdCBp cyB3cm9uZyB0byBiZSBhIGZpbGVuYW1lLgogICAgIGlmICghbV9pc0RhdGEgJiYgIW1faXNBYm91 dCkgewogICAgICAgICBTdHJpbmcgc3VnZ2VzdGVkRmlsZW5hbWUgPSBmaWxlbmFtZUZyb21IVFRQ Q29udGVudERpc3Bvc2l0aW9uKG1fY29udGVudERpc3Bvc2l0aW9uKTsKLSAgICAgICAgaWYgKHN1 Z2dlc3RlZEZpbGVuYW1lLmlzTnVsbCgpKQotICAgICAgICAgICAgc3VnZ2VzdGVkRmlsZW5hbWUg PSB1cmxGaWxlbmFtZTsKKyAgICAgICAgaWYgKHN1Z2dlc3RlZEZpbGVuYW1lLmlzRW1wdHkoKSkg eworICAgICAgICAgICAgLy8gQ2hlY2sgYW5kIHNlZSBpZiBhbiBleHRlbnNpb24gYWxyZWFkeSBl eGlzdHMuCisgICAgICAgICAgICBTdHJpbmcgbWltZUV4dGVuc2lvbiA9IE1JTUVUeXBlUmVnaXN0 cnk6OmdldFByZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBlKG1pbWVUeXBlKTsKKyAgICAgICAg ICAgIGlmICh1cmxGaWxlbmFtZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgICAgICBpZiAobWlt ZUV4dGVuc2lvbi5pc0VtcHR5KCkpIC8vIE5vIGV4dGVuc2lvbiBmb3VuZCBmb3IgdGhlIG1pbWVU eXBlLgorICAgICAgICAgICAgICAgICAgICBzdWdnZXN0ZWRGaWxlbmFtZSA9IFN0cmluZygiVW50 aXRsZWQiKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIHN1Z2dl c3RlZEZpbGVuYW1lID0gU3RyaW5nKCJVbnRpdGxlZCIpICsgIi4iICsgbWltZUV4dGVuc2lvbjsK KyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgaWYgKHVybEZpbGVuYW1lLnJl dmVyc2VGaW5kKCcuJykgPT0gbm90Rm91bmQgJiYgIW1pbWVFeHRlbnNpb24uaXNFbXB0eSgpKQor ICAgICAgICAgICAgICAgICAgIHN1Z2dlc3RlZEZpbGVuYW1lID0gdXJsRmlsZW5hbWUgKyAnLicg KyBtaW1lRXh0ZW5zaW9uOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAg ICBzdWdnZXN0ZWRGaWxlbmFtZSA9IHVybEZpbGVuYW1lOworICAgICAgICAgICAgfQorICAgICAg ICB9CiAgICAgICAgIG1fcmVzcG9uc2Uuc2V0U3VnZ2VzdGVkRmlsZW5hbWUoc3VnZ2VzdGVkRmls ZW5hbWUpOwogICAgIH0KIAo=