76771 2012-01-20 22:37:20 -0800 PopupMenuClient::multiple() should be const 2012-01-21 00:17:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 benjamin benjamin ddkilzer kling tkent webkit.review.bot oldest_to_newest 540060 0 benjamin 2012-01-20 22:37:20 -0800 It is an accessor, no reason to have it modify the RenderObject. 540061 1 123432 benjamin 2012-01-20 22:43:45 -0800 Created attachment 123432 Patch 540062 2 123432 tkent 2012-01-20 22:49:07 -0800 Comment on attachment 123432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123432&action=review > Source/WebCore/rendering/RenderMenuList.h:110 > + virtual bool multiple() const; I recommend adding OVERRIDE to this line. 540067 3 benjamin 2012-01-20 23:01:04 -0800 > I recommend adding OVERRIDE to this line. Yeah, I considered that. But I think I should modify the whole interface on one patch instead of a single method. 540068 4 123432 tkent 2012-01-20 23:06:26 -0800 Comment on attachment 123432 Patch ok 540086 5 123432 webkit.review.bot 2012-01-21 00:17:43 -0800 Comment on attachment 123432 Patch Clearing flags on attachment: 123432 Committed r105570: <http://trac.webkit.org/changeset/105570> 540087 6 webkit.review.bot 2012-01-21 00:17:47 -0800 All reviewed patches have been landed. Closing bug. 123432 2012-01-20 22:43:45 -0800 2012-01-21 00:17:43 -0800 Patch bug-76771-20120120224344.patch text/plain 2816 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWI5MjAxMjFmMjRkMmEx M2E4MDlhZTIxZDAyNDVlMDNhYjk2NmI5My4uOThiODQ3MzQwY2MxNzYxMTY1ZWVkOWE0ZGU5MDUw ZmQwYzM4OWY3MiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTIwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFBvcHVwTWVudUNs aWVudDo6bXVsdGlwbGUoKSBzaG91bGQgYmUgY29uc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Qb3B1cE1lbnVDbGllbnQuaDoKKyAg ICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudUNsaWVudDo6bXVsdGlwbGUpOgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNZW51 TGlzdDo6bXVsdGlwbGUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oOgor CiAyMDEyLTAxLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYkNvcmUgc2hvdWxkIG5vdCBzZW5kIGludmFsaWQgVVJMcyB0byBjbGllbnQgY3JlYXRl V2luZG93IG1ldGhvZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Qb3B1 cE1lbnVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BvcHVwTWVudUNsaWVudC5o CmluZGV4IDdjMmI0YTliNDk4Y2ZiOGZjZTFmNzFkZTI2ZGFlOGRkYmE5MGUwMGYuLjRhYmUzMzc5 Y2E0NDM3MzUwY2M1ZjU2YmMyZjM5MGE2NGIyZDBiZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1BvcHVwTWVudUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1BvcHVwTWVudUNsaWVudC5oCkBAIC02NCw3ICs2NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0 dWFsIHZvaWQgc2V0VGV4dEZyb21JdGVtKHVuc2lnbmVkIGxpc3RJbmRleCkgPSAwOwogCiAgICAg dmlydHVhbCB2b2lkIGxpc3RCb3hTZWxlY3RJdGVtKGludCAvKmxpc3RJbmRleCovLCBib29sIC8q YWxsb3dNdWx0aXBseVNlbGVjdGlvbnMqLywgYm9vbCAvKnNoaWZ0Ki8sIGJvb2wgLypmaXJlT25D aGFuZ2VOb3cqLyA9IHRydWUpIHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KLSAgICB2aXJ0dWFs IGJvb2wgbXVsdGlwbGUoKQorICAgIHZpcnR1YWwgYm9vbCBtdWx0aXBsZSgpIGNvbnN0CiAgICAg ewogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAKaW5kZXggZDk4ZGNk MTU4ZDk2OWExMGI3ZmFlZDg5MWRmZTVhM2I5MTBhYTRlZi4uM2Y3YWMzMDgxNmZmNmRhNzY0M2Y3 YzI3MmJlOTBjNTdmOTBlZTJjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck1lbnVMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TWVudUxpc3QuY3BwCkBAIC0zMzYsNyArMzM2LDcgQEAgdm9pZCBSZW5kZXJNZW51TGlzdDo6bGlz dEJveFNlbGVjdEl0ZW0oaW50IGxpc3RJbmRleCwgYm9vbCBhbGxvd011bHRpcGx5U2VsZWN0aW8K ICAgICB0b0hUTUxTZWxlY3RFbGVtZW50KG5vZGUoKSktPmxpc3RCb3hTZWxlY3RJdGVtKGxpc3RJ bmRleCwgYWxsb3dNdWx0aXBseVNlbGVjdGlvbnMsIHNoaWZ0LCBmaXJlT25DaGFuZ2VOb3cpOwog fQogCi1ib29sIFJlbmRlck1lbnVMaXN0OjptdWx0aXBsZSgpCitib29sIFJlbmRlck1lbnVMaXN0 OjptdWx0aXBsZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIHRvSFRNTFNlbGVjdEVsZW1lbnQobm9k ZSgpKS0+bXVsdGlwbGUoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNZW51TGlzdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVM aXN0LmgKaW5kZXggMmY3NzFjM2MyOGI2ZDk3MjFlODY3ZTZlZjczMWFhNmE2MjU4MzU0Ni4uNzBi OWEyNTk0MjU5YTkyZGFiNDRmNDgyYTI0MGUwMTNjNDA2MTZkZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmgKQEAgLTEwNyw3ICsxMDcsNyBAQCBwcml2YXRlOgog ICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxTY3JvbGxiYXI+IGNyZWF0ZVNjcm9sbGJhcihTY3JvbGxh YmxlQXJlYSosIFNjcm9sbGJhck9yaWVudGF0aW9uLCBTY3JvbGxiYXJDb250cm9sU2l6ZSk7CiAK ICAgICB2aXJ0dWFsIHZvaWQgbGlzdEJveFNlbGVjdEl0ZW0oaW50IGxpc3RJbmRleCwgYm9vbCBh bGxvd011bHRpcGx5U2VsZWN0aW9ucywgYm9vbCBzaGlmdCwgYm9vbCBmaXJlT25DaGFuZ2VOb3cg PSB0cnVlKTsKLSAgICB2aXJ0dWFsIGJvb2wgbXVsdGlwbGUoKTsKKyAgICB2aXJ0dWFsIGJvb2wg bXVsdGlwbGUoKSBjb25zdDsKIAogICAgIHZpcnR1YWwgYm9vbCBoYXNMaW5lSWZFbXB0eSgpIGNv bnN0IHsgcmV0dXJuIHRydWU7IH0KIAo=