76754 2012-01-20 16:30:23 -0800 Fine tune Web Intents Chromium API 2012-01-23 19:20:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75123 1 gbillock gbillock fishd webkit.review.bot oldest_to_newest 539907 0 gbillock 2012-01-20 16:30:23 -0800 Fine tune Web Intents Chromium API 539909 1 123406 gbillock 2012-01-20 16:31:53 -0800 Created attachment 123406 Patch 539914 2 gbillock 2012-01-20 16:34:45 -0800 Removes identifier() method from Web Intent, adds webkit constructor for WebIntentServiceInfo. This shouldn't be merged until after the Chromium code using the removed API lands (http://codereview.chromium.org/9186021/) 539915 3 webkit.review.bot 2012-01-20 16:36:28 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 540043 4 123406 fishd 2012-01-20 20:45:27 -0800 Comment on attachment 123406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review > Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36 > +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action, nit: please list functions in the .cpp file in the same order as they appear in the .h file. 540646 5 123406 gbillock 2012-01-23 10:30:16 -0800 Comment on attachment 123406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review >> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36 >> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action, > > nit: please list functions in the .cpp file in the same order as they appear in the .h file. Done. 540647 6 123573 gbillock 2012-01-23 10:31:22 -0800 Created attachment 123573 Patch 541078 7 123573 webkit.review.bot 2012-01-23 19:20:24 -0800 Comment on attachment 123573 Patch Clearing flags on attachment: 123573 Committed r105681: <http://trac.webkit.org/changeset/105681> 541079 8 webkit.review.bot 2012-01-23 19:20:29 -0800 All reviewed patches have been landed. Closing bug. 123406 2012-01-20 16:31:53 -0800 2012-01-23 10:31:19 -0800 Patch bug-76754-20120120163152.patch text/plain 3473 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdjY2IwY2Q3MjI1ZjI1ZTBlZDllNmRmY2Y5ZjU3OTQwNWViYzhlNWIuLmVjZjllNjliNDMxZjc1 ZWExZDE2ZjBlMWY3MzJmYjA0NzU3YTQ0ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDEtMjAgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRmluZSB0dW5lIFdlYiBJbnRlbnRzIENocm9taXVtIEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY3NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJJ bnRlbnQuaDoKKyAgICAgICAgKiBwdWJsaWMvV2ViSW50ZW50U2VydmljZUluZm8uaDoKKyAgICAg ICAgKiBzcmMvV2ViSW50ZW50LmNwcDoKKyAgICAgICAgKiBzcmMvV2ViSW50ZW50U2VydmljZUlu Zm8uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnRlbnRTZXJ2aWNlSW5mbzo6V2ViSW50ZW50 U2VydmljZUluZm8pOgorCiAyMDEyLTAxLTE5ICBBbGV4YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29v Z2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIERyYXcgZ3V0dGVyIHF1YWRzIG91dHNpZGUg cm9vdCBjb250ZW50IGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnRlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkludGVu dC5oCmluZGV4IGE2NGU3ZWU5NmQ3ODk1MjRlYjkzYmNlNzBiOTY3YjI1MGQzMmY5ZTguLmQwMTA5 OGZlNTVjOTI3NmMzM2RlYmU3MjdlZGRiMGEwNDk4N2UyODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkludGVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkludGVudC5oCkBAIC02Miw5ICs2Miw2IEBAIHB1YmxpYzoKICAgICBX RUJLSVRfRVhQT1JUIFdlYlN0cmluZyB0eXBlKCkgY29uc3Q7CiAgICAgV0VCS0lUX0VYUE9SVCBX ZWJTdHJpbmcgZGF0YSgpIGNvbnN0OwogCi0gICAgLy8gRklYTUU6IGRlbGV0ZSB0aGlzLgotICAg IFdFQktJVF9FWFBPUlQgaW50IGlkZW50aWZpZXIoKSBjb25zdDsKLQogI2lmIFdFQktJVF9JTVBM RU1FTlRBVElPTgogICAgIFdlYkludGVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6 SW50ZW50PiYpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSW50ZW50U2VydmljZUluZm8uaAppbmRleCA1ODc5YmU4YWFjMWQzZGI5N2NjZjFhZTZj MTc2OGIxYjgxZWE4NWUwLi5iMjk2Y2E0NmUwYWQ1NGQyZmQ3Mjc1YTQzYTgwOWFmNGZhZTk1NzI0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2 aWNlSW5mby5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkludGVudFNl cnZpY2VJbmZvLmgKQEAgLTY3LDYgKzY3LDExIEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JU IFdlYlN0cmluZyBkaXNwb3NpdGlvbigpIGNvbnN0OwogICAgIFdFQktJVF9FWFBPUlQgdm9pZCBz ZXREaXNwb3NpdGlvbihjb25zdCBXZWJTdHJpbmcmKTsKIAorI2lmIFdFQktJVF9JTVBMRU1FTlRB VElPTgorICAgIFdlYkludGVudFNlcnZpY2VJbmZvKGNvbnN0IFdlYlN0cmluZyYgYWN0aW9uLCBj b25zdCBXZWJTdHJpbmcmIHR5cGUsIGNvbnN0IFdlYlVSTCYgaHJlZiwKKyAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHRpdGxlLCBjb25zdCBXZWJTdHJpbmcmIGRpc3Bv c2l0aW9uKTsKKyNlbmRpZgorCiBwcml2YXRlOgogICAgIFdlYlN0cmluZyBtX2FjdGlvbjsKICAg ICBXZWJTdHJpbmcgbV90eXBlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViSW50ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkludGVudC5j cHAKaW5kZXggMjM1OGJmYTZhMDBjZTUxMTA1NDRmMmM5MGE3Y2FiMTkxNTA0MTZiMy4uNzdkNzY2 ZDc2MzczODhmNjM4Y2UyNzk3ODRhNjNjNGRkYWQ0NTQxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViSW50ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnRlbnQuY3BwCkBAIC0xMDIsOSArMTAyLDQgQEAgV2ViU3RyaW5nIFdlYklu dGVudDo6ZGF0YSgpIGNvbnN0CiAjZW5kaWYKIH0KIAotaW50IFdlYkludGVudDo6aWRlbnRpZmll cigpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIDA7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYktpdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW50ZW50U2VydmljZUlu Zm8uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW50ZW50U2VydmljZUluZm8u Y3BwCmluZGV4IGJkMTk4MzQ4OGNhMWE5NzU5YjM1N2I2ZTJlZDgzYTk0MDllYjI5YTMuLjRkZDQ1 MDk1MWM2NGZmZjQ2N2U2YWQ1M2UyNTRlNzI1YTNlY2ZiMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkludGVudFNlcnZpY2VJbmZvLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5jcHAKQEAgLTMzLDYgKzMz LDE5IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCitXZWJJbnRlbnRTZXJ2aWNlSW5mbzo6V2Vi SW50ZW50U2VydmljZUluZm8oY29uc3QgV2ViU3RyaW5nJiBhY3Rpb24sCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiB0eXBlLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlVSTCYgaHJl ZiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJT dHJpbmcmIHRpdGxlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IFdlYlN0cmluZyYgZGlzcG9zaXRpb24pCisgICAgOiBtX2FjdGlvbihhY3Rpb24pCisg ICAgLCBtX3R5cGUodHlwZSkKKyAgICAsIG1faHJlZihocmVmKQorICAgICwgbV90aXRsZSh0aXRs ZSkKKyAgICAsIG1fZGlzcG9zaXRpb24oZGlzcG9zaXRpb24pCit7Cit9CisKIFdlYlVSTCBXZWJJ bnRlbnRTZXJ2aWNlSW5mbzo6dXJsKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9ocmVmOwo= 123573 2012-01-23 10:31:22 -0800 2012-01-23 19:20:24 -0800 Patch bug-76754-20120123103121.patch text/plain 3526 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFkY2RlODk2MDZkOTU5ZmE4YjA1ZmUyZWY2MWVmMTBhNmU2M2I4YTcuLjIwOTE5OGNlZDc2MDkw MWNhZTgxMWUzMDNhOGFkNjkwM2ExYWIwMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDEtMjAgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRmluZSB0dW5lIFdlYiBJbnRlbnRzIENocm9taXVtIEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY3NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJJ bnRlbnQuaDoKKyAgICAgICAgKiBwdWJsaWMvV2ViSW50ZW50U2VydmljZUluZm8uaDoKKyAgICAg ICAgKiBzcmMvV2ViSW50ZW50LmNwcDoKKyAgICAgICAgKiBzcmMvV2ViSW50ZW50U2VydmljZUlu Zm8uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnRlbnRTZXJ2aWNlSW5mbzo6V2ViSW50ZW50 U2VydmljZUluZm8pOgorCiAyMDEyLTAxLTIwICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29v Z2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQYWdlQWdlbnQub3BlbigpIGRvc2Vu J3QgYmVsb25nIHRvIHRoZSBwcm90b2NvbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkludGVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW50ZW50LmgKaW5kZXggYTY0ZTdlZTk2ZDc4OTUyNGViOTNiY2U3MGI5NjdiMjUwZDMyZjll OC4uZDAxMDk4ZmU1NWM5Mjc2YzMzZGViZTcyN2VkZGIwYTA0OTg3ZTI4NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW50ZW50LmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW50ZW50LmgKQEAgLTYyLDkgKzYyLDYgQEAgcHVibGlj OgogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIHR5cGUoKSBjb25zdDsKICAgICBXRUJLSVRf RVhQT1JUIFdlYlN0cmluZyBkYXRhKCkgY29uc3Q7CiAKLSAgICAvLyBGSVhNRTogZGVsZXRlIHRo aXMuCi0gICAgV0VCS0lUX0VYUE9SVCBpbnQgaWRlbnRpZmllcigpIGNvbnN0OwotCiAjaWYgV0VC S0lUX0lNUExFTUVOVEFUSU9OCiAgICAgV2ViSW50ZW50KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxX ZWJDb3JlOjpJbnRlbnQ+Jik7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkludGVudFNlcnZpY2VJbmZvLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oCmluZGV4IDU4NzliZThhYWMxZDNkYjk3 Y2NmMWFlNmMxNzY4YjFiODFlYTg1ZTAuLmIyOTZjYTQ2ZTBhZDU0ZDJmZDcyNzVhNDNhODA5YWY0 ZmFlOTU3MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklu dGVudFNlcnZpY2VJbmZvLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SW50ZW50U2VydmljZUluZm8uaApAQCAtNjcsNiArNjcsMTEgQEAgcHVibGljOgogICAgIFdFQktJ VF9FWFBPUlQgV2ViU3RyaW5nIGRpc3Bvc2l0aW9uKCkgY29uc3Q7CiAgICAgV0VCS0lUX0VYUE9S VCB2b2lkIHNldERpc3Bvc2l0aW9uKGNvbnN0IFdlYlN0cmluZyYpOwogCisjaWYgV0VCS0lUX0lN UExFTUVOVEFUSU9OCisgICAgV2ViSW50ZW50U2VydmljZUluZm8oY29uc3QgV2ViU3RyaW5nJiBh Y3Rpb24sIGNvbnN0IFdlYlN0cmluZyYgdHlwZSwgY29uc3QgV2ViVVJMJiBocmVmLAorICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgdGl0bGUsIGNvbnN0IFdlYlN0cmlu ZyYgZGlzcG9zaXRpb24pOworI2VuZGlmCisKIHByaXZhdGU6CiAgICAgV2ViU3RyaW5nIG1fYWN0 aW9uOwogICAgIFdlYlN0cmluZyBtX3R5cGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJJbnRlbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi SW50ZW50LmNwcAppbmRleCAyMzU4YmZhNmEwMGNlNTExMDU0NGYyYzkwYTdjYWIxOTE1MDQxNmIz Li43N2Q3NjZkNzYzNzM4OGY2MzhjZTI3OTc4NGE2M2M0ZGRhZDQ1NDE4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnRlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkludGVudC5jcHAKQEAgLTEwMiw5ICsxMDIsNCBAQCBXZWJTdHJp bmcgV2ViSW50ZW50OjpkYXRhKCkgY29uc3QKICNlbmRpZgogfQogCi1pbnQgV2ViSW50ZW50Ojpp ZGVudGlmaWVyKCkgY29uc3QKLXsKLSAgICByZXR1cm4gMDsKLX0KLQogfSAvLyBuYW1lc3BhY2Ug V2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnRlbnRT ZXJ2aWNlSW5mby5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnRlbnRTZXJ2 aWNlSW5mby5jcHAKaW5kZXggYmQxOTgzNDg4Y2ExYTk3NTliMzU3YjZlMmVkODNhOTQwOWViMjlh My4uZjA4YWI0ODg1NmQ5M2UwNTNiMTI1OTI4ODg2ODhiZDExNjgyNTIyNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW50ZW50U2VydmljZUluZm8uY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkludGVudFNlcnZpY2VJbmZvLmNwcApAQCAt ODMsNCArODMsMTcgQEAgdm9pZCBXZWJJbnRlbnRTZXJ2aWNlSW5mbzo6c2V0RGlzcG9zaXRpb24o Y29uc3QgV2ViU3RyaW5nJiBkaXNwb3NpdGlvbikKICAgICBtX2Rpc3Bvc2l0aW9uID0gZGlzcG9z aXRpb247CiB9CiAKK1dlYkludGVudFNlcnZpY2VJbmZvOjpXZWJJbnRlbnRTZXJ2aWNlSW5mbyhj b25zdCBXZWJTdHJpbmcmIGFjdGlvbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHR5cGUsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViVVJMJiBocmVmLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgdGl0bGUsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBk aXNwb3NpdGlvbikKKyAgICA6IG1fYWN0aW9uKGFjdGlvbikKKyAgICAsIG1fdHlwZSh0eXBlKQor ICAgICwgbV9ocmVmKGhyZWYpCisgICAgLCBtX3RpdGxlKHRpdGxlKQorICAgICwgbV9kaXNwb3Np dGlvbihkaXNwb3NpdGlvbikKK3sKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==