76752 2012-01-20 16:28:13 -0800 The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives. 2012-01-23 16:01:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin abarth aroben eric hamaji ojan webkit.review.bot oldest_to_newest 539900 0 levin 2012-01-20 16:28:13 -0800 The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives. 539903 1 123405 levin 2012-01-20 16:28:32 -0800 Created attachment 123405 Patch 539905 2 levin 2012-01-20 16:29:29 -0800 For example, many of these warnings are false positives: https://bugs.webkit.org/show_bug.cgi?id=76750#c2 539916 3 levin 2012-01-20 16:37:38 -0800 Anyone is welcome to review :). (If no one takes me on this, I'll find someone more directly.) 539931 4 123405 eric 2012-01-20 16:50:08 -0800 Comment on attachment 123405 Patch rs=me. 540020 5 123405 webkit.review.bot 2012-01-20 19:32:44 -0800 Comment on attachment 123405 Patch Clearing flags on attachment: 123405 Committed r105567: <http://trac.webkit.org/changeset/105567> 540021 6 webkit.review.bot 2012-01-20 19:32:49 -0800 All reviewed patches have been landed. Closing bug. 540922 7 levin 2012-01-23 16:01:23 -0800 *** Bug 76483 has been marked as a duplicate of this bug. *** 123405 2012-01-20 16:28:32 -0800 2012-01-20 19:32:44 -0800 Patch bug-76752-20120120162831.patch text/plain 3668 levin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmFmNjkyNDMzOWUyYmRhNjMzOWI3NTkxYWUxZGNiN2Y1 NTczMWViMC4uZmYxNGNmMGRlMTNhZDI5NGNmNDgwZjMxZDhkOGQ2NGYyNmRlMzgzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAxLTIwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KKworICAg ICAgICBUaGUgbGVha3kgREMgY2hlY2sgc2hvdWxkIHVzZSBhZG9wdFB0ciBhcyBhIHNpZ25hbCBp bnN0ZWFkIG9mIE93blB0ciB0byBnZXQgbGVzcyBmYWxzZSBwb3NpdGl2ZXMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Njc1MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19mb3JfbGVha3lfcGF0dGVybnMp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5OgorICAgICAgICAoTGVha3lQYXR0ZXJuVGVzdC50ZXN0X2NyZWF0ZV9kYyk6CisgICAgICAg IChMZWFreVBhdHRlcm5UZXN0LnRlc3RfY3JlYXRlX2NvbXBhdGlibGVfZGMpOgorCiAyMDEyLTAx LTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgcnVuLXdlYmtp dC10ZXN0cyAtLWxpbnQtdGVzdC1maWxlcyBjcmF3bHMgdGhlIHdob2xlIExheW91dFRlc3RzIHN1 YnRyZWUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5k ZXggOWZhOWZmNWFjMWRjZjVhOGVkZmM3OTNlNzFmY2M3MmFlZTQ5YjMzYi4uMDM5ZmM3NjVmNjMw YjM5Y2QzNDEyNzI0YzlmMDliNTA0NGY0ODAwOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTEsNyArMSw3IEBACiAjIS91c3IvYmluL3B5dGhv bgogIyAtKi0gY29kaW5nOiB1dGYtOCAtKi0KICMKLSMgQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEw IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAwOSwg MjAxMCwgMjAxMiBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIyBDb3B5cmlnaHQg KEMpIDIwMDkgVG9yY2ggTW9iaWxlIEluYy4KICMgQ29weXJpZ2h0IChDKSAyMDA5IEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0IChDKSAyMDEwIENocmlzIEplcmRv bmVrIChjamVyZG9uZWtAd2Via2l0Lm9yZykKQEAgLTE2ODAsMTAgKzE2ODAsMTAgQEAgZGVmIGNo ZWNrX2Zvcl9sZWFreV9wYXR0ZXJucyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZ1bmN0aW9u X3N0YXRlLCBlcnJvcik6CiAgICAgICAgICAgICAgICdtZW1vcnkgbGVha3MuJyAlIG1hdGNoZWRf Z2V0X2RjLmdyb3VwKCdmdW5jdGlvbl9uYW1lJykpCiAKICAgICBtYXRjaGVkX2NyZWF0ZV9kYyA9 IHNlYXJjaChyJ1xiKD9QPGZ1bmN0aW9uX25hbWU+Q3JlYXRlKENvbXBhdGlibGUpP0RDKVxzKlwo JywgbGluZSkKLSAgICBtYXRjaGVkX293bl9kYyA9IHNlYXJjaChyJ1xiT3duUHRyXDxIRENcPlxz KycsIGxpbmUpCisgICAgbWF0Y2hlZF9vd25fZGMgPSBzZWFyY2gocidcYmFkb3B0UHRyXGInLCBs aW5lKQogICAgIGlmIG1hdGNoZWRfY3JlYXRlX2RjIGFuZCBub3QgbWF0Y2hlZF9vd25fZGM6CiAg ICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS9sZWFreV9wYXR0ZXJuJywgNSwKLSAg ICAgICAgICAgICAgJ1VzZSBPd25QdHI8SERDPiB3aGVuIGNhbGxpbmcgJXMgdG8gYXZvaWQgcG90 ZW50aWFsICcKKyAgICAgICAgICAgICAgJ1VzZSBhZG9wdFB0ciBhbmQgT3duUHRyPEhEQz4gd2hl biBjYWxsaW5nICVzIHRvIGF2b2lkIHBvdGVudGlhbCAnCiAgICAgICAgICAgICAgICdtZW1vcnkg bGVha3MuJyAlIG1hdGNoZWRfY3JlYXRlX2RjLmdyb3VwKCdmdW5jdGlvbl9uYW1lJykpCiAKIApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQppbmRleCAwZTAyZmZiYjUxNGEwZjM0MDk2OTAzYjJhYTFkNzI4Y2QyZjdjNzY4Li42 NWFkMWQ2NjM0OTkxNmM2YzU5NmQ2ZjFiZWNhMmRkMDkxNmEwZTVkIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAt MzM2NSwyMCArMzM2NSwyMCBAQCBjbGFzcyBMZWFreVBhdHRlcm5UZXN0KENwcFN0eWxlVGVzdEJh c2UpOgogICAgIGRlZiB0ZXN0X2NyZWF0ZV9kYyhzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRf bGVha3lfcGF0dGVybl9jaGVjaygKICAgICAgICAgICAgICdIREMgZGMyID0gOjpDcmVhdGVEQygp OycsCi0gICAgICAgICAgICAnVXNlIE93blB0cjxIREM+IHdoZW4gY2FsbGluZyBDcmVhdGVEQyB0 byBhdm9pZCBwb3RlbnRpYWwgJworICAgICAgICAgICAgJ1VzZSBhZG9wdFB0ciBhbmQgT3duUHRy PEhEQz4gd2hlbiBjYWxsaW5nIENyZWF0ZURDIHRvIGF2b2lkIHBvdGVudGlhbCAnCiAgICAgICAg ICAgICAnbWVtb3J5IGxlYWtzLiAgW3J1bnRpbWUvbGVha3lfcGF0dGVybl0gWzVdJykKIAogICAg ICAgICBzZWxmLmFzc2VydF9sZWFreV9wYXR0ZXJuX2NoZWNrKAotICAgICAgICAgICAgJ093blB0 cjxIREM+IGRjMiA9IGFkb3B0UHRyKENyZWF0ZURDKCkpOycsCisgICAgICAgICAgICAnYWRvcHRQ dHIoQ3JlYXRlREMoKSk7JywKICAgICAgICAgICAgICcnKQogCiAgICAgZGVmIHRlc3RfY3JlYXRl X2NvbXBhdGlibGVfZGMoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xlYWt5X3BhdHRlcm5f Y2hlY2soCiAgICAgICAgICAgICAnSERDIGRjMiA9IENyZWF0ZUNvbXBhdGlibGVEQyhkYyk7JywK LSAgICAgICAgICAgICdVc2UgT3duUHRyPEhEQz4gd2hlbiBjYWxsaW5nIENyZWF0ZUNvbXBhdGli bGVEQyB0byBhdm9pZCBwb3RlbnRpYWwgJworICAgICAgICAgICAgJ1VzZSBhZG9wdFB0ciBhbmQg T3duUHRyPEhEQz4gd2hlbiBjYWxsaW5nIENyZWF0ZUNvbXBhdGlibGVEQyB0byBhdm9pZCBwb3Rl bnRpYWwgJwogICAgICAgICAgICAgJ21lbW9yeSBsZWFrcy4gIFtydW50aW1lL2xlYWt5X3BhdHRl cm5dIFs1XScpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xlYWt5X3BhdHRlcm5fY2hlY2soCi0gICAg ICAgICAgICAnT3duUHRyPEhEQz4gZGMyID0gYWRvcHRQdHIoQ3JlYXRlQ29tcGF0aWJsZURDKGRj KSk7JywKKyAgICAgICAgICAgICdhZG9wdFB0cihDcmVhdGVDb21wYXRpYmxlREMoZGMpKTsnLAog ICAgICAgICAgICAgJycpCiAKIAo=