76738 2012-01-20 14:22:37 -0800 Make OwnPtr<HDC> work for the Chromium Windows port. 2012-01-26 13:33:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77073 1 levin levin aestes bfulgham dimich dslomov jianli oldest_to_newest 539789 0 levin 2012-01-20 14:22:37 -0800 Make OwnPtr<HDC> work for the Chromium Windows port. 539790 1 123379 levin 2012-01-20 14:23:56 -0800 Created attachment 123379 Patch 539883 2 123379 dslomov 2012-01-20 16:09:22 -0800 Comment on attachment 123379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123379&action=review Looks good! > Source/JavaScriptCore/ChangeLog:8 > + * JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwPptrWin to the typo 539908 3 123379 jianli 2012-01-20 16:30:36 -0800 Comment on attachment 123379 Patch Looks good. Please fix the typo pointed out by dslomov before committing. 539917 4 levin 2012-01-20 16:38:14 -0800 Committed as http://trac.webkit.org/changeset/105555 542903 5 aestes 2012-01-25 23:52:40 -0800 This broke Apple's Windows port in a subtle way. We define OS(WINDOWS) but not OS(WIN), so the deleteOwnPtr() overloads in OwnPtrCommon.h were stripped by the preprocessor, causing Windows-allocated resources to be deleted by fastmalloc. What's the right fix here? We should agree on either OS(WIN) or OS(WINDOWS). 542912 6 aestes 2012-01-26 00:11:06 -0800 In fact, it looks like this patch was just wrong. Platform.h defines WTF_OS_WINDOWS, so this patch should have had OS(WINDOWS), not OS(WIN). I'll fix this in <https://bugs.webkit.org/show_bug.cgi?id=77073>. 543072 7 levin 2012-01-26 05:13:24 -0800 (In reply to comment #6) > In fact, it looks like this patch was just wrong. Platform.h defines WTF_OS_WINDOWS, so this patch should have had OS(WINDOWS), not OS(WIN). I'll fix this in <https://bugs.webkit.org/show_bug.cgi?id=77073>. Thank you very much. 543385 8 bfulgham 2012-01-26 12:34:18 -0800 This change breaks the WinCairo build. There is no such thing as OS(WIN) (see <JavaScriptCore/Platform.h>) This should have been coded as OS(WINDOWS). 543389 9 levin 2012-01-26 12:37:48 -0800 (In reply to comment #8) > This change breaks the WinCairo build. > > There is no such thing as OS(WIN) (see <JavaScriptCore/Platform.h>) > > This should have been coded as OS(WINDOWS). Yes. It has been fixed. See comment #6. 543436 10 bfulgham 2012-01-26 13:33:28 -0800 Excellent. I just got the change -- thanks for tackling it so quickly :-) 123379 2012-01-20 14:23:56 -0800 2012-01-20 16:30:36 -0800 Patch bug-76738-20120120142354.patch text/plain 2221 levin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy N2E3Yjc5NjVkMzE4MzYxNGY4ZWUwMDNmNWI3N2E3Y2NkNjM2MjRhLi40YWVjNTU2ZmNlNjljZjA5 ZDVjYTQ2OWNkNmQ0ODExMTNkMDM0OTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMS0yMCAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgTWFrZSBPd25QdHI8SERDPiB3b3JrIGZvciB0aGUgQ2hyb21pdW0gV2luZG93 cyBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzY3MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXA6IEFkZGVkIE93UHB0cldpbiB0 byB0aGUKKyAgICAgICAgQ2hyb21pdW0gV2luZG93cyBidWlsZC4KKyAgICAgICAgKiB3dGYvT3du UHRyQ29tbW9uLmg6IENoYW5nZWQgZnJvbSBwbGF0Zm9ybSBXSU4gdG8gT1MgV0lOIGZvcgorICAg ICAgICBPd25QdHI8SERDPiBhbmQgc2ltaWxhciBjb25zdHJ1Y3RzLgorCiAyMDEyLTAxLTE3ICBG aWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBiZSBh YmxlIHRvIGRvIEpTIGFuZCBjdXN0b20gZ2V0dGVyIGNhY2hpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5n eXAKaW5kZXggMjU5YmQwOGI0NjAzYjc0MWU5ODI2NmM0OWU1YmY0NDY5NGIyMmYxYS4uMmU5ZDk1 Njc2ZDA5YjQ4YmQxZWJkZTZiNWY1NDRkNDRkZTY5YzFjZiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5n eXAKQEAgLTE3Myw2ICsxNzMsNyBAQAogICAgICAgICAgICAgWydpbmNsdWRlJywgJ1RocmVhZChp bmd8U3BlY2lmaWMpV2luXFwuY3BwJCddLAogICAgICAgICAgICAgWydleGNsdWRlJywgJ09TQWxs b2NhdG9yUG9zaXhcXC5jcHAkJ10sCiAgICAgICAgICAgICBbJ2luY2x1ZGUnLCAnT1NBbGxvY2F0 b3JXaW5cXC5jcHAkJ10sCisgICAgICAgICAgICBbJ2luY2x1ZGUnLCAnd2luL093blB0cldpblxc LmNwcCQnXSwKICAgICAgICAgICBdLAogICAgICAgICAgICdpbmNsdWRlX2RpcnMhJzogWwogICAg ICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdCcsCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaAppbmRleCAxOTI5MGMzZDkzZDIwN2FhMzg0MzIy MDQzN2U3MDU1NjllOWVjNDZiLi5iOGI3OGEyOTY3YmRjZjk0ZGMyYTlkNDRkYjk3ZDg5MWE1N2Nh NzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmgKQEAgLTI4LDcg KzI4LDcgQEAKICNpZm5kZWYgV1RGX093blB0ckNvbW1vbl9oCiAjZGVmaW5lIFdURl9Pd25QdHJD b21tb25faAogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIE9TKFdJTikKIHR5cGVkZWYgc3RydWN0 IEhCSVRNQVBfXyogSEJJVE1BUDsKIHR5cGVkZWYgc3RydWN0IEhCUlVTSF9fKiBIQlJVU0g7CiB0 eXBlZGVmIHN0cnVjdCBIRENfXyogSERDOwpAQCAtNTQsNyArNTQsNyBAQCBuYW1lc3BhY2UgV1RG IHsKICAgICAgICAgICAgIGRlbGV0ZSBwdHI7CiAgICAgfQogCi0jaWYgUExBVEZPUk0oV0lOKQor I2lmIE9TKFdJTikKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEhCSVRNQVApOwogICAgIHZvaWQg ZGVsZXRlT3duZWRQdHIoSEJSVVNIKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEhEQyk7Cg==