76728 2012-01-20 12:39:08 -0800 [chromium] Plumb damage from accelerated canvas 2D. 2012-01-20 16:11:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 backer backer abarth cc-bugs jamesr ojan webkit.review.bot oldest_to_newest 539713 0 backer 2012-01-20 12:39:08 -0800 [chromium] Plumb damage from accelerated canvas 2D. 539715 1 123363 backer 2012-01-20 12:39:38 -0800 Created attachment 123363 Patch 539719 2 123363 shawnsingh 2012-01-20 12:44:14 -0800 Comment on attachment 123363 Patch Thanks for this, LGTM. Somehow this line of code disappeared since I had added it a few months ago. And the new placement of this line seems good, too, but perhaps jamesr should take a look and verify. 539758 3 123363 enne 2012-01-20 13:41:15 -0800 Comment on attachment 123363 Patch LGTM. 539760 4 123363 kbr 2012-01-20 13:42:47 -0800 Comment on attachment 123363 Patch rs=me based on enne's review. 539808 5 123363 webkit.review.bot 2012-01-20 14:50:05 -0800 Comment on attachment 123363 Patch Clearing flags on attachment: 123363 Committed r105544: <http://trac.webkit.org/changeset/105544> 539809 6 webkit.review.bot 2012-01-20 14:50:10 -0800 All reviewed patches have been landed. Closing bug. 539890 7 jamesr 2012-01-20 16:11:58 -0800 This is fine, but in the future if somebody wants to tighten up the bounds you can take a look at propagating the dirtyRect from CanvasRenderingContext2D::didDraw() through to this logic rather than considering the whole canvas dirty. 123363 2012-01-20 12:39:38 -0800 2012-01-20 14:50:05 -0800 Patch bug-76728-20120120153937.patch text/plain 1323 backer U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE3Y2E3ZTNjNTViMjIy Nzk2NTdmYzNiYTI1MTY1ZmJkZDVkM2U5MC4uOWVhYWFhZWZiM2JkMjNjZTIzMWNkNGVhMDQxYzA5 YTNhOWYzYjA0NyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTIwICBKb25h dGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g UGx1bWIgZGFtYWdlIGZyb20gYWNjZWxlcmF0ZWQgY2FudmFzIDJELgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY3MjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXMy RExheWVyQ2hyb21pdW06OmNvbnRlbnRDaGFuZ2VkKToKKwogMjAxMi0wMS0xOCAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgUnVuTG9vcCB0byBXZWJDb3JlL3Bs YXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRMYXllckNocm9taXVtLmNwcAppbmRleCBiMjcwZjVm NmYxMDhmMzViOTI0MzA3YTExMWFiZWM0YjkwMDk5MzlhLi4xNTA1YWRhYzI0M2UwNzY2NWQyZGRh YjI4ZjQ3MDNmZjhlZjViOTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTgxLDYgKzgxLDcgQEAgdm9pZCBDYW52YXMyRExheWVyQ2hyb21pdW06OmNvbnRlbnRD aGFuZ2VkKCkKICAgICBpZiAobGF5ZXJUcmVlSG9zdCgpKQogICAgICAgICBsYXllclRyZWVIb3N0 KCktPnN0YXJ0UmF0ZUxpbWl0ZXIobV9jb250ZXh0KTsKIAorICAgIG1fdXBkYXRlUmVjdCA9IEZs b2F0UmVjdChGbG9hdFBvaW50KCksIGNvbnRlbnRCb3VuZHMoKSk7CiAgICAgc2V0TmVlZHNEaXNw bGF5KCk7CiB9CiAK