76722 2012-01-20 11:36:25 -0800 Garden-o-matic should tell me which revisions have been checked by all the bots 2012-01-29 18:18:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth aroben dglazkov oldest_to_newest 539651 0 abarth 2012-01-20 11:36:25 -0800 Garden-o-matic should tell me which revisions have been checked by all the bots 539653 1 123349 abarth 2012-01-20 11:37:12 -0800 Created attachment 123349 Patch 539657 2 abarth 2012-01-20 11:44:20 -0800 Committed r105530: <http://trac.webkit.org/changeset/105530> 539717 3 123349 aroben 2012-01-20 12:42:35 -0800 Comment on attachment 123349 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123349&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:148 > + var revision = 0; > + Object.keys(model.state.resultsByBuilder).forEach(function(builderName) { > + var results = model.state.resultsByBuilder[builderName]; > + var testedRevision = parseInt(results.revision); > + revision = revision ? Math.min(revision, testedRevision) : testedRevision; > + }); > + return revision; Aww, so close to total functional goodness! var revisions = Object.keys(model.state.resultsByBuilder).map(function(builderName) { var results = model.state.resultsByBuilder[builderName]; var testedRevision = parseInt(results.revision); return revision ? revision : 1e100; }); return Math.min.apply(Math, revisions); :-) 539718 4 aroben 2012-01-20 12:43:30 -0800 Or you could use Array.prototype.filter to get rid of the non-revisions instead of substituting a large number for them… </bikeshed> 539725 5 abarth 2012-01-20 12:54:21 -0800 :-) 123349 2012-01-20 11:37:12 -0800 2012-01-29 18:18:46 -0800 Patch bug-76722-20120120113711.patch text/plain 4630 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNTUyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTAxLTIwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgR2FyZGVuLW8tbWF0aWMgc2hvdWxkIHRlbGwgbWUgd2hpY2ggcmV2aXNpb25zIGhh dmUgYmVlbiBjaGVja2VkIGJ5IGFsbCB0aGUgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY3MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGluZm9ybWF0aW9uIGhlbHBzIG1lIGtub3cgd2hl biBpdCdzIHNhZmUgZm9yIG1lIHRvIHJvbGwgYQorICAgICAgICBjYW5kaWRhdGUgcmV2aXNpb24u CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9nYXJkZW4tby1tYXRpYy5qczoKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9tb2RlbC5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy9tb2RlbF91bml0dGVzdHMuanM6CisKIDIwMTItMDEtMjAgIFRvciBBcm5lIFZlc3Riw7gg IDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIGJ1aWxkLXdlYmtpdDogRG9u J3Qgc3BpdCBvdXQgY29uZ3JhdHVsYXRpb25zIG1lc3NhZ2Ugb24gQ3RybCtDCkluZGV4OiBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy9nYXJkZW4tby1tYXRpYy5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy9nYXJkZW4tby1tYXRpYy5qcwkocmV2aXNpb24gMTA1NTI0KQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvZ2FyZGVuLW8tbWF0aWMuanMJKHdvcmtpbmcgY29w eSkKQEAgLTI2LDYgKzI2LDcgQEAKIChmdW5jdGlvbigpIHsKIAogdmFyIGdfaW5mbyA9IG51bGw7 Cit2YXIgZ19yZXZpc2lvbkhpbnQgPSBudWxsOwogCiB2YXIgZ191cGRhdGVUaW1lcklkID0gMDsK IHZhciBnX2J1aWxkZXJzRmFpbGluZyA9IG51bGw7CkBAIC0zNiw2ICszNyw5IEBAIHZhciBnX2xv c2luZ1Rlc3RDb3ZlcmFnZUJ1aWxkZXJzID0gbnVsbDsKIAogZnVuY3Rpb24gdXBkYXRlKCkKIHsK KyAgICBpZiAoZ19yZXZpc2lvbkhpbnQpCisgICAgICAgIGdfcmV2aXNpb25IaW50LmRpc21pc3Mo KTsKKwogICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBhIGJ1dHRvbiB3aXRoIGEgcHJvZ3Jl c3MgZWxlbWVudC4KICAgICB2YXIgbnVtYmVyT2ZUZXN0c0FuYWx5emVkID0gMDsKICAgICB2YXIg dXBkYXRpbmcgPSBuZXcgdWkubm90aWZpY2F0aW9ucy5JbmZvKCdMb2FkaW5nIGNvbW1pdCBkYXRh IC4uLicpOwpAQCAtNDUsNiArNDksNyBAQCBmdW5jdGlvbiB1cGRhdGUoKQogICAgIGJ1aWxkZXJz LmJ1aWxkZXJzRmFpbGluZ1N0ZXBSZXF1cmVkRm9yVGVzdENvdmVyYWdlKGdfbG9zaW5nVGVzdENv dmVyYWdlQnVpbGRlcnMudXBkYXRlLmJpbmQoZ19sb3NpbmdUZXN0Q292ZXJhZ2VCdWlsZGVycykp OwogCiAgICAgYmFzZS5jYWxsSW5QYXJhbGxlbChbbW9kZWwudXBkYXRlUmVjZW50Q29tbWl0cywg bW9kZWwudXBkYXRlUmVzdWx0c0J5QnVpbGRlcl0sIGZ1bmN0aW9uKCkgeworCiAgICAgICAgIHVw ZGF0aW5nLnVwZGF0ZSgnQW5hbHl6aW5nIHRlc3QgZmFpbHVyZXMgLi4uJyk7CiAKICAgICAgICAg bW9kZWwuYW5hbHl6ZVVuZXhwZWN0ZWRGYWlsdXJlcyhmdW5jdGlvbihmYWlsdXJlQW5hbHlzaXMp IHsKQEAgLTU2LDcgKzYxLDExIEBAIGZ1bmN0aW9uIHVwZGF0ZSgpCiAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgJCgnI29uZWJhcicpLnJlbW92ZUNsYXNzKCdwYXJ0eXRpbWUnKTsK ICAgICAgICAgICAgIGdfdW5leHBlY3RlZEZhaWx1cmVzQ29udHJvbGxlci5wdXJnZSgpOworCiAg ICAgICAgICAgICB1cGRhdGluZy5kaXNtaXNzKCk7CisKKyAgICAgICAgICAgIGdfcmV2aXNpb25I aW50ID0gbmV3IHVpLm5vdGlmaWNhdGlvbnMuSW5mbygnTGF0ZXN0IHJldmlzaW9uIHByb2Nlc3Nl ZCBieSBldmVyeSBib3Q6ICcgKyBtb2RlbC5sYXRlc3RSZXZpc2lvbldpdGhOb0J1aWxkZXJzSW5G bGlnaHQoKSk7CisgICAgICAgICAgICBnX2luZm8uYWRkKGdfcmV2aXNpb25IaW50KTsKICAgICAg ICAgfSk7CiAgICAgfSk7CiB9CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9tb2RlbC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9tb2RlbC5qcwkocmV2aXNp b24gMTA1NTI0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvbW9kZWwuanMJKHdvcmtpbmcg Y29weSkKQEAgLTEzNyw2ICsxMzcsMTcgQEAgbW9kZWwuYnVpbGRlcnNJbkZsaWdodEZvclJldmlz aW9uID0gZnVuYwogICAgIHJldHVybiBidWlsZGVyczsKIH07CiAKK21vZGVsLmxhdGVzdFJldmlz aW9uV2l0aE5vQnVpbGRlcnNJbkZsaWdodCA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgcmV2aXNp b24gPSAwOworICAgIE9iamVjdC5rZXlzKG1vZGVsLnN0YXRlLnJlc3VsdHNCeUJ1aWxkZXIpLmZv ckVhY2goZnVuY3Rpb24oYnVpbGRlck5hbWUpIHsKKyAgICAgICAgdmFyIHJlc3VsdHMgPSBtb2Rl bC5zdGF0ZS5yZXN1bHRzQnlCdWlsZGVyW2J1aWxkZXJOYW1lXTsKKyAgICAgICAgdmFyIHRlc3Rl ZFJldmlzaW9uID0gcGFyc2VJbnQocmVzdWx0cy5yZXZpc2lvbik7CisgICAgICAgIHJldmlzaW9u ID0gcmV2aXNpb24gPyBNYXRoLm1pbihyZXZpc2lvbiwgdGVzdGVkUmV2aXNpb24pIDogdGVzdGVk UmV2aXNpb247CisgICAgfSk7CisgICAgcmV0dXJuIHJldmlzaW9uOworfQorCiBtb2RlbC51cGRh dGVSZXN1bHRzQnlCdWlsZGVyID0gZnVuY3Rpb24oY2FsbGJhY2spCiB7CiAgICAgcmVzdWx0cy5m ZXRjaFJlc3VsdHNCeUJ1aWxkZXIoT2JqZWN0LmtleXMoY29uZmlnLmtCdWlsZGVycyksIGZ1bmN0 aW9uKHJlc3VsdHNCeUJ1aWxkZXIpIHsKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL21v ZGVsX3VuaXR0ZXN0cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9t b2RlbF91bml0dGVzdHMuanMJKHJldmlzaW9uIDEwNTUyNCkKKysrIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL21vZGVsX3VuaXR0ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMjM5LDQgKzIzOSwx NiBAQCB0ZXN0KCJidWlsZGVyc0luRmxpZ2h0Rm9yUmV2aXNpb24iLCAzLCBmCiAgICAgbW9kZWwu c3RhdGUucmVzdWx0c0J5QnVpbGRlciA9IHVubW9jazsKIH0pOwogCit0ZXN0KCJsYXRlc3RSZXZp c2lvbldpdGhOb0J1aWxkZXJzSW5GbGlnaHQiLCAxLCBmdW5jdGlvbigpIHsKKyAgICB2YXIgdW5t b2NrID0gbW9kZWwuc3RhdGUucmVzdWx0c0J5QnVpbGRlcjsKKyAgICBtb2RlbC5zdGF0ZS5yZXN1 bHRzQnlCdWlsZGVyID0geworICAgICAgICAnTXIuIEJlYXNsZXknOiB7cmV2aXNpb246ICc1J30s CisgICAgICAgICdNciBEaXhvbic6IHtyZXZpc2lvbjogJzInfSwKKyAgICAgICAgJ01yLiBTYWJh dGluaSc6IHtyZXZpc2lvbjogJzQnfSwKKyAgICAgICAgJ0JvYic6IHtyZXZpc2lvbjogJzYnfQor ICAgIH07CisgICAgZXF1YWxzKG1vZGVsLmxhdGVzdFJldmlzaW9uV2l0aE5vQnVpbGRlcnNJbkZs aWdodCgpLCAyKTsKKyAgICBtb2RlbC5zdGF0ZS5yZXN1bHRzQnlCdWlsZGVyID0gdW5tb2NrOwor fSk7CisKIH0pKCk7Cg==