76703 2012-01-20 05:38:15 -0800 [MicroData] Compilation error while building Webkit with --microdata. 2012-01-23 16:26:58 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 arko webkit-unassigned abarth kling rniwa webkit.review.bot oldest_to_newest 539436 0 arko 2012-01-20 05:38:15 -0800 MICRODATA enabled build is now failing with below errors : 1. Due to changes http://trac.webkit.org/changeset/102834. MicroDataItemList should be derived from DynamicSubtreeNodeList instead of DynamicNodeList. In file included from Source/WebCore/dom/Document.cpp:199:0: Source/WebCore/dom/MicroDataItemList.h: In static member function ‘static WTF::PassRefPtr<WebCore::MicroDataItemList> WebCore::MicroDataItemList::create(WTF::PassRefPtr<WebCore::Node>, const WTF::String&)’: Source/WebCore/dom/MicroDataItemList.h:41:66: error: cannot allocate an object of abstract type ‘WebCore::MicroDataItemList’ Source/WebCore/dom/MicroDataItemList.h:37:50: note: because the following virtual functions are pure within ‘WebCore::MicroDataItemList’: Source/WebCore/dom/DynamicNodeList.h:44:22: note: virtual unsigned int WebCore::DynamicNodeList::length() const Source/WebCore/dom/DynamicNodeList.h:45:19: note: virtual WebCore::Node* WebCore::DynamicNodeList::item(unsigned int) const In file included from Source/WebCore/dom/Document.cpp:200:0: Source/WebCore/dom/NodeRareData.h: In member function ‘WebCore::HTMLPropertiesCollection* WebCore::NodeRareData::properties(WebCore::Node*)’: Source/WebCore/dom/NodeRareData.h:223:75: error: no matching function for call to ‘adoptPtr(WTF::PassOwnPtr<WebCore::HTMLPropertiesCollection>)’ CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/EventException.o CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/EventListenerMap.o CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/EventNames.o In file included from Source/WebCore/dom/NodeRareData.h:42:0, from Source/WebCore/dom/ElementRareData.h:29, from Source/WebCore/dom/Element.cpp:41: Source/WebCore/dom/MicroDataItemList.h: In static member function ‘static WTF::PassRefPtr<WebCore::MicroDataItemList> WebCore::MicroDataItemList::create(WTF::PassRefPtr<WebCore::Node>, const WTF::String&)’: Source/WebCore/dom/MicroDataItemList.h:41:66: error: cannot allocate an object of abstract type ‘WebCore::MicroDataItemList’ Source/WebCore/dom/MicroDataItemList.h:37:50: note: because the following virtual functions are pure within ‘WebCore::MicroDataItemList’: Source/WebCore/dom/DynamicNodeList.h:44:22: note: virtual unsigned int WebCore::DynamicNodeList::length() const Source/WebCore/dom/DynamicNodeList.h:45:19: note: virtual WebCore::Node* WebCore::DynamicNodeList::item(unsigned int) const CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/EventTarget.o In file included from Source/WebCore/dom/ElementRareData.h:29:0, from Source/WebCore/dom/Element.cpp:41: Source/WebCore/dom/NodeRareData.h: In member function ‘WebCore::HTMLPropertiesCollection* WebCore::NodeRareData::properties(WebCore::Node*)’: Source/WebCore/dom/NodeRareData.h:223:75: error: no matching function for call to ‘adoptPtr(WTF::PassOwnPtr<WebCore::HTMLPropertiesCollection>)’ CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/ExceptionBase.o CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/ExceptionCodePlaceholder.o CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/IconURL.o cc1plus: warnings being treated as errors Source/WebCore/dom/MicroDataItemList.h: In static member function ‘static WTF::PassRefPtr<WebCore::MicroDataItemList> WebCore::MicroDataItemList::create(WTF::PassRefPtr<WebCore::Node>, const WTF::String&)’: Source/WebCore/dom/MicroDataItemList.h:42:5: error: control reaches end of non-void function CXX(target) out/Release/obj.target/webcore_dom/Source/WebCore/dom/KeyboardEvent.o make: *** [out/Release/obj.target/webcore_dom/Source/WebCore/dom/Document.o] Error 1 make: *** Waiting for unfinished jobs.... make: *** [out/Release/obj.target/webcore_dom/Source/WebCore/dom/Element.o] Error 1 2. Due to changes in http://trac.webkit.org/changeset/103883. The signature of 'WebCore::HTMLCollection::HTMLCollection()' is changed. Now it takes Node* as first parameter, hence resulting the error. Source/WebCore/html/HTMLPropertiesCollection.cpp: In constructor ‘WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection(WTF::PassRefPtr<WebCore::Node>)’: Source/WebCore/html/HTMLPropertiesCollection.cpp:59:46: error: no matching function for call to ‘WebCore::HTMLCollection::HTMLCollection(WTF::PassRefPtr<WebCore::Node>&, WebCore::CollectionType)’ Source/WebCore/html/HTMLCollection.h:65:5: note: candidates are: WebCore::HTMLCollection::HTMLCollection(WebCore::Node*, WebCore::CollectionType) Source/WebCore/html/HTMLCollection.h:39:22: note: WebCore::HTMLCollection::HTMLCollection(const WebCore::HTMLCollection&) make: *** [out/Release/obj.target/webcore_html/Source/WebCore/html/HTMLPropertiesCollection.o] Error 1 make: *** Waiting for unfinished jobs.... 539444 1 123298 arko 2012-01-20 05:54:49 -0800 Created attachment 123298 Patch 540947 2 123298 webkit.review.bot 2012-01-23 16:26:53 -0800 Comment on attachment 123298 Patch Clearing flags on attachment: 123298 Committed r105655: <http://trac.webkit.org/changeset/105655> 540949 3 webkit.review.bot 2012-01-23 16:26:58 -0800 All reviewed patches have been landed. Closing bug. 123298 2012-01-20 05:54:49 -0800 2012-01-23 16:26:53 -0800 Patch 76703.diff text/plain 4826 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTUwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAxLTIwICBBcmtvIFNh aGEgIDxuZ2hxMzZAbW90b3JvbGEuY29tPgorCisgICAgICAgIE1pY3JvRGF0YTogQ29tcGlsYXRp b24gZXJyb3Igd2hpbGUgYnVpbGRpbmcgV2Via2l0IHdpdGggLS1taWNyb2RhdGEuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjcwMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL01pY3JvRGF0YUl0 ZW1MaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1pY3JvRGF0YUl0ZW1MaXN0OjpNaWNyb0Rh dGFJdGVtTGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpNaWNyb0RhdGFJdGVtTGlzdDo6fk1pY3Jv RGF0YUl0ZW1MaXN0KToKKyAgICAgICAgKiBkb20vTWljcm9EYXRhSXRlbUxpc3QuaDoKKyAgICAg ICAgKiBkb20vTm9kZVJhcmVEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpOb2RlUmFyZURhdGE6 OnByb3BlcnRpZXMpOgorICAgICAgICAqIGh0bWwvSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbjo6Y3JlYXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbjo6SFRNTFByb3BlcnRp ZXNDb2xsZWN0aW9uKToKKyAgICAgICAgKiBodG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5o OgorCiAyMDEyLTAxLTIwICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGQgRGF0YVRyYW5zZmVySXRlbXMgc3VwcG9ydCBmb3IgZHJhZy1hbmQtZHJvcCdl ZCBmaWxlcyBhbmQgdGV4dHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9NaWNyb0RhdGFJdGVt TGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL01pY3JvRGF0YUl0ZW1M aXN0LmNwcAkocmV2aXNpb24gMTA1NTA4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL01pY3JvRGF0 YUl0ZW1MaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgsMTUgKzM4LDE1IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKIE1pY3JvRGF0YUl0ZW1M aXN0OjpNaWNyb0RhdGFJdGVtTGlzdChQYXNzUmVmUHRyPE5vZGU+IHJvb3ROb2RlLCBjb25zdCBT dHJpbmcmIHR5cGVOYW1lcykKLSAgICA6IER5bmFtaWNOb2RlTGlzdChyb290Tm9kZSkKLSAgICAs IG1fdHlwZU5hbWVzKHR5cGVOYW1lcywgbV9yb290Tm9kZS0+ZG9jdW1lbnQoKS0+aW5RdWlya3NN b2RlKCkpCisgICAgOiBEeW5hbWljU3VidHJlZU5vZGVMaXN0KHJvb3ROb2RlKQorICAgICwgbV90 eXBlTmFtZXModHlwZU5hbWVzLCBub2RlKCktPmRvY3VtZW50KCktPmluUXVpcmtzTW9kZSgpKQog ICAgICwgbV9vcmlnaW5hbFR5cGVOYW1lcyh0eXBlTmFtZXMpCiB7CiB9CiAKIE1pY3JvRGF0YUl0 ZW1MaXN0Ojp+TWljcm9EYXRhSXRlbUxpc3QoKQogewotICAgIG1fcm9vdE5vZGUtPmRvY3VtZW50 KCktPnJlbW92ZUNhY2hlZE1pY3JvRGF0YUl0ZW1MaXN0KHRoaXMsIG1fb3JpZ2luYWxUeXBlTmFt ZXMpOworICAgIHJvb3ROb2RlKCktPmRvY3VtZW50KCktPnJlbW92ZUNhY2hlZE1pY3JvRGF0YUl0 ZW1MaXN0KHRoaXMsIG1fb3JpZ2luYWxUeXBlTmFtZXMpOwogfQogCiBib29sIE1pY3JvRGF0YUl0 ZW1MaXN0Ojpub2RlTWF0Y2hlcyhFbGVtZW50KiB0ZXN0Tm9kZSkgY29uc3QKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9NaWNyb0RhdGFJdGVtTGlzdC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2RvbS9NaWNyb0RhdGFJdGVtTGlzdC5oCShyZXZpc2lvbiAxMDU1MDgpCisrKyBTb3Vy Y2UvV2ViQ29yZS9kb20vTWljcm9EYXRhSXRlbUxpc3QuaAkod29ya2luZyBjb3B5KQpAQCAtMzQs NyArMzQsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIE1pY3JvRGF0YUl0ZW1M aXN0IDogcHVibGljIER5bmFtaWNOb2RlTGlzdCB7CitjbGFzcyBNaWNyb0RhdGFJdGVtTGlzdCA6 IHB1YmxpYyBEeW5hbWljU3VidHJlZU5vZGVMaXN0IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFz c1JlZlB0cjxNaWNyb0RhdGFJdGVtTGlzdD4gY3JlYXRlKFBhc3NSZWZQdHI8Tm9kZT4gcm9vdE5v ZGUsIGNvbnN0IFN0cmluZyYgdHlwZU5hbWVzKQogICAgIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2RvbS9Ob2RlUmFyZURhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9k ZVJhcmVEYXRhLmgJKHJldmlzaW9uIDEwNTUwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl UmFyZURhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtMjIwLDcgKzIyMCw3IEBAIHB1YmxpYzoKICAg ICBIVE1MUHJvcGVydGllc0NvbGxlY3Rpb24qIHByb3BlcnRpZXMoTm9kZSogbm9kZSkKICAgICB7 CiAgICAgICAgIGlmICghbV9wcm9wZXJ0aWVzKQotICAgICAgICAgICAgbV9wcm9wZXJ0aWVzID0g YWRvcHRQdHIoSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uOjpjcmVhdGUobm9kZSkpOworICAgICAg ICAgICAgbV9wcm9wZXJ0aWVzID0gSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uOjpjcmVhdGUobm9k ZSk7CiAKICAgICAgICAgcmV0dXJuIG1fcHJvcGVydGllcy5nZXQoKTsKICAgICB9CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvcGVydGllc0NvbGxlY3Rpb24uY3BwCShy ZXZpc2lvbiAxMDU1MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9wZXJ0aWVzQ29s bGVjdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDEyICs0OSwxMiBAQCBzdGF0aWMgaW5s aW5lIGJvb2wgY29tcGFyZVRyZWVPcmRlcihOb2RlCiAgICAgcmV0dXJuIChub2RlMi0+Y29tcGFy ZURvY3VtZW50UG9zaXRpb24obm9kZTEpICYgKE5vZGU6OkRPQ1VNRU5UX1BPU0lUSU9OX1BSRUNF RElORyB8IE5vZGU6OkRPQ1VNRU5UX1BPU0lUSU9OX0RJU0NPTk5FQ1RFRCkpID09IE5vZGU6OkRP Q1VNRU5UX1BPU0lUSU9OX1BSRUNFRElORzsKIH0KIAotUGFzc093blB0cjxIVE1MUHJvcGVydGll c0NvbGxlY3Rpb24+IEhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbjo6Y3JlYXRlKFBhc3NSZWZQdHI8 Tm9kZT4gaXRlbU5vZGUpCitQYXNzT3duUHRyPEhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbj4gSFRN TFByb3BlcnRpZXNDb2xsZWN0aW9uOjpjcmVhdGUoTm9kZSogaXRlbU5vZGUpCiB7CiAgICAgcmV0 dXJuIGFkb3B0UHRyKG5ldyBIVE1MUHJvcGVydGllc0NvbGxlY3Rpb24oaXRlbU5vZGUpKTsKIH0K IAotSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uOjpIVE1MUHJvcGVydGllc0NvbGxlY3Rpb24oUGFz c1JlZlB0cjxOb2RlPiBpdGVtTm9kZSkKK0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbjo6SFRNTFBy b3BlcnRpZXNDb2xsZWN0aW9uKE5vZGUqIGl0ZW1Ob2RlKQogICAgIDogSFRNTENvbGxlY3Rpb24o aXRlbU5vZGUsIEl0ZW1Qcm9wZXJ0aWVzKQogICAgICwgbV9wcm9wZXJ0eU5hbWVzKERPTVN0cmlu Z0xpc3Q6OmNyZWF0ZSgpKQogewpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvcGVy dGllc0NvbGxlY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQ cm9wZXJ0aWVzQ29sbGVjdGlvbi5oCShyZXZpc2lvbiAxMDU1MDgpCisrKyBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3 ICs0MSw3IEBAIGNsYXNzIERPTVN0cmluZ0xpc3Q7CiAKIGNsYXNzIEhUTUxQcm9wZXJ0aWVzQ29s bGVjdGlvbiA6IHB1YmxpYyBIVE1MQ29sbGVjdGlvbiB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBh c3NPd25QdHI8SFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uPiBjcmVhdGUoUGFzc1JlZlB0cjxOb2Rl Pik7CisgICAgc3RhdGljIFBhc3NPd25QdHI8SFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uPiBjcmVh dGUoTm9kZSopOwogICAgIHZpcnR1YWwgfkhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbigpOwogCiAg ICAgdW5zaWduZWQgbGVuZ3RoKCkgY29uc3QgT1ZFUlJJREU7CkBAIC01MSw3ICs1MSw3IEBAIHB1 YmxpYzoKICAgICBQYXNzUmVmUHRyPERPTVN0cmluZ0xpc3Q+IG5hbWVzKCkgY29uc3Q7CiAKIHBy aXZhdGU6Ci0gICAgSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uKFBhc3NSZWZQdHI8Tm9kZT4pOwor ICAgIEhUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbihOb2RlKik7CiAKICAgICB2b2lkIGZpbmRQcm9w ZXRpZXNPZkFuSXRlbShOb2RlKiBjdXJyZW50KSBjb25zdDsKIAo=