76691 2012-01-20 02:36:20 -0800 [GTK] Allow extra jhbuild modulesets 2012-01-20 08:50:06 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand gustavo xan.lopez oldest_to_newest 539369 0 pnormand 2012-01-20 02:36:20 -0800 It'd be nice if we could add new modulesets and modules easily using env variables. My main use-case is to include my gst-0.11 moduleset :=) 539372 1 123277 pnormand 2012-01-20 02:40:55 -0800 Created attachment 123277 Patch 539380 2 123277 gustavo 2012-01-20 03:16:39 -0800 Comment on attachment 123277 Patch Attachment 123277 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11297056 539383 3 123279 pnormand 2012-01-20 03:27:16 -0800 Created attachment 123279 Patch 539407 4 123279 gustavo 2012-01-20 04:19:50 -0800 Comment on attachment 123279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you? > Tools/gtk/jhbuildrc:26 > +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules') s/module/moduleset/ for consistency would be good 539416 5 pnormand 2012-01-20 04:29:41 -0800 (In reply to comment #4) > (From update of attachment 123279 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review > > This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you? > I say good idea indeed :) > > Tools/gtk/jhbuildrc:26 > > +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules') > > s/module/moduleset/ for consistency would be good Yup! Will send a new patch! 539421 6 123291 pnormand 2012-01-20 04:32:07 -0800 Created attachment 123291 Patch 539491 7 123291 gustavo 2012-01-20 07:23:17 -0800 Comment on attachment 123291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123291&action=review > Tools/ChangeLog:11 > + * gtk/jhbuildrc: Extra modulesets and modules can be added in > + JHBuild using the EXTRA_MODULESETS and EXTRA_MODULES env variables > + respectively. Use comma-separated values. Example: > + EXTRA_MODULES=file:///path/to/module.set,file:///other/path. LIES =) the variables changed names 539544 8 pnormand 2012-01-20 08:50:06 -0800 Committed r105519: <http://trac.webkit.org/changeset/105519> 123277 2012-01-20 02:40:55 -0800 2012-01-20 03:27:07 -0800 Patch bug-76691-20120120114051.patch text/plain 1811 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzUyZjlhNjljMTVlNjE4ZmZkNWFlNDU2NGJlMTk2NmNm OTM1MzE4NS4uMGQ1NjU3N2ZmNGEyYjM4ODY5MGQxZmJmMjBkZTUzMDRiMTBmMmZjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBBbGxvdyBleHRyYSBqaGJ1aWxkIG1vZHVsZXNldHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvamhidWlsZHJjOiBF eHRyYSBtb2R1bGVzZXRzIGFuZCBtb2R1bGVzIGNhbiBiZSBhZGRlZCBpbgorICAgICAgICBKSEJ1 aWxkIHVzaW5nIHRoZSBFWFRSQV9NT0RVTEVTRVRTIGFuZCBFWFRSQV9NT0RVTEVTIGVudiB2YXJp YWJsZXMKKyAgICAgICAgcmVzcGVjdGl2ZWx5LiBVc2UgY29tbWEtc2VwYXJhdGVkIHZhbHVlcy4g RXhhbXBsZToKKyAgICAgICAgRVhUUkFfTU9EVUxFUz1maWxlOi8vL3BhdGgvdG8vbW9kdWxlLnNl dCxmaWxlOi8vL290aGVyL3BhdGguCisKIDIwMTItMDEtMTkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIFdyb25n IHZhcmlhYmxlIGJlaW5nIHVzZWQgYXMgdGhlIGN3ZCBmb3IgZ2l0CmRpZmYgLS1naXQgYS9Ub29s cy9ndGsvamhidWlsZHJjIGIvVG9vbHMvZ3RrL2poYnVpbGRyYwppbmRleCBiMGE4Y2NhNmZjMTQz NTM2ZTgyY2E3OGFlMDBkNTljNjhhN2I2Zjk5Li5jMzZjNmZmNjI4MTZiZWUxYmQ3NWI0NjNlYmI5 MDMzM2JlMGU4ZTg3IDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZHJjCisrKyBiL1Rvb2xz L2d0ay9qaGJ1aWxkcmMKQEAgLTIzLDEwICsyMywxMyBAQCBpbXBvcnQgY29tbW9uCiAKIGJ1aWxk X3BvbGljeSA9ICd1cGRhdGVkJwogCi1fX21vZHVsZV9maWxlX3BhdGggPSBvcy5wYXRoLmpvaW4o X19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1bGVzJykKLW1vZHVsZXNldCA9ICdm aWxlOi8vJyArIF9fbW9kdWxlX2ZpbGVfcGF0aAorX19tb2R1bGVfZmlsZV91cmkgPSAnZmlsZTov LycgKyBvcy5wYXRoLmpvaW4oX19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1bGVz JykKK19fZXh0cmFfbW9kdWxlc2V0cyA9IG9zLmVudmlyb24uZ2V0KCJFWFRSQV9NT0RVTEVTRVRT IiwgIiIpLnNwbGl0KCIsIikKK21vZHVsZXNldCA9IFsgX19tb2R1bGVfZmlsZV91cmksIF0gKyBf X2V4dHJhX21vZHVsZXNldHMKKworX19leHRyYV9tb2R1bGVzID0gb3MuZW52aXJvbi5nZXQoIkVY VFJBX01PRFVMRVMiLCAiIikuc3BsaXQoIiwiKQorbW9kdWxlcyA9IFsgJ3dlYmtpdGd0ay10ZXN0 aW5nLWRlcGVuZGVuY2llcycgXSArIF9fZXh0cmFfbW9kdWxlcwogCi1tb2R1bGVzID0gWyAnd2Vi a2l0Z3RrLXRlc3RpbmctZGVwZW5kZW5jaWVzJyBdCiBjaGVja291dHJvb3QgPSBvcy5wYXRoLmFi c3BhdGgoY29tbW9uLnRvcF9sZXZlbF9wYXRoKCdXZWJLaXRCdWlsZCcsJ0RlcGVuZGVuY2llcycs ICdTb3VyY2UnKSkKIHByZWZpeCA9IG9zLnBhdGguYWJzcGF0aChjb21tb24udG9wX2xldmVsX3Bh dGgoJ1dlYktpdEJ1aWxkJywnRGVwZW5kZW5jaWVzJywgJ1Jvb3QnKSkKIAo= 123279 2012-01-20 03:27:16 -0800 2012-01-20 04:32:00 -0800 Patch bug-76691-20120120122714.patch text/plain 1913 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzUyZjlhNjljMTVlNjE4ZmZkNWFlNDU2NGJlMTk2NmNm OTM1MzE4NS4uMGQ1NjU3N2ZmNGEyYjM4ODY5MGQxZmJmMjBkZTUzMDRiMTBmMmZjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBBbGxvdyBleHRyYSBqaGJ1aWxkIG1vZHVsZXNldHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvamhidWlsZHJjOiBF eHRyYSBtb2R1bGVzZXRzIGFuZCBtb2R1bGVzIGNhbiBiZSBhZGRlZCBpbgorICAgICAgICBKSEJ1 aWxkIHVzaW5nIHRoZSBFWFRSQV9NT0RVTEVTRVRTIGFuZCBFWFRSQV9NT0RVTEVTIGVudiB2YXJp YWJsZXMKKyAgICAgICAgcmVzcGVjdGl2ZWx5LiBVc2UgY29tbWEtc2VwYXJhdGVkIHZhbHVlcy4g RXhhbXBsZToKKyAgICAgICAgRVhUUkFfTU9EVUxFUz1maWxlOi8vL3BhdGgvdG8vbW9kdWxlLnNl dCxmaWxlOi8vL290aGVyL3BhdGguCisKIDIwMTItMDEtMTkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIFdyb25n IHZhcmlhYmxlIGJlaW5nIHVzZWQgYXMgdGhlIGN3ZCBmb3IgZ2l0CmRpZmYgLS1naXQgYS9Ub29s cy9ndGsvamhidWlsZHJjIGIvVG9vbHMvZ3RrL2poYnVpbGRyYwppbmRleCBiMGE4Y2NhNmZjMTQz NTM2ZTgyY2E3OGFlMDBkNTljNjhhN2I2Zjk5Li40OWNmNjE3ZWNkYTI0ZGY5MmNlZmVjZjkxYTc3 ZmVjNzRiNzY0MWU0IDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZHJjCisrKyBiL1Rvb2xz L2d0ay9qaGJ1aWxkcmMKQEAgLTIzLDEwICsyMywxNyBAQCBpbXBvcnQgY29tbW9uCiAKIGJ1aWxk X3BvbGljeSA9ICd1cGRhdGVkJwogCi1fX21vZHVsZV9maWxlX3BhdGggPSBvcy5wYXRoLmpvaW4o X19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1bGVzJykKLW1vZHVsZXNldCA9ICdm aWxlOi8vJyArIF9fbW9kdWxlX2ZpbGVfcGF0aAorX19tb2R1bGVfZmlsZV91cmkgPSAnZmlsZTov LycgKyBvcy5wYXRoLmpvaW4oX19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1bGVz JykKK19fZXh0cmFfbW9kdWxlc2V0cyA9IG9zLmVudmlyb24uZ2V0KCJFWFRSQV9NT0RVTEVTRVRT IiwgIiIpLnNwbGl0KCIsIikKK21vZHVsZXNldCA9IFsgX19tb2R1bGVfZmlsZV91cmksIF0KK2lm IF9fZXh0cmFfbW9kdWxlc2V0cyAhPSBbJyddOgorICAgIG1vZHVsZXNldC5leHRlbmQoX19leHRy YV9tb2R1bGVzZXRzKQorCitfX2V4dHJhX21vZHVsZXMgPSBvcy5lbnZpcm9uLmdldCgiRVhUUkFf TU9EVUxFUyIsICIiKS5zcGxpdCgiLCIpCittb2R1bGVzID0gWyAnd2Via2l0Z3RrLXRlc3Rpbmct ZGVwZW5kZW5jaWVzJywgXQoraWYgX19leHRyYV9tb2R1bGVzICE9IFsnJ106CisgICAgbW9kdWxl cy5leHRlbmQoX19leHRyYV9tb2R1bGVzKQogCi1tb2R1bGVzID0gWyAnd2Via2l0Z3RrLXRlc3Rp bmctZGVwZW5kZW5jaWVzJyBdCiBjaGVja291dHJvb3QgPSBvcy5wYXRoLmFic3BhdGgoY29tbW9u LnRvcF9sZXZlbF9wYXRoKCdXZWJLaXRCdWlsZCcsJ0RlcGVuZGVuY2llcycsICdTb3VyY2UnKSkK IHByZWZpeCA9IG9zLnBhdGguYWJzcGF0aChjb21tb24udG9wX2xldmVsX3BhdGgoJ1dlYktpdEJ1 aWxkJywnRGVwZW5kZW5jaWVzJywgJ1Jvb3QnKSkKIAo= 123291 2012-01-20 04:32:07 -0800 2012-01-20 07:23:17 -0800 Patch bug-76691-20120120133205.patch text/plain 1933 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzUyZjlhNjljMTVlNjE4ZmZkNWFlNDU2NGJlMTk2NmNm OTM1MzE4NS4uMGQ1NjU3N2ZmNGEyYjM4ODY5MGQxZmJmMjBkZTUzMDRiMTBmMmZjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAxLTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBBbGxvdyBleHRyYSBqaGJ1aWxkIG1vZHVsZXNldHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvamhidWlsZHJjOiBF eHRyYSBtb2R1bGVzZXRzIGFuZCBtb2R1bGVzIGNhbiBiZSBhZGRlZCBpbgorICAgICAgICBKSEJ1 aWxkIHVzaW5nIHRoZSBFWFRSQV9NT0RVTEVTRVRTIGFuZCBFWFRSQV9NT0RVTEVTIGVudiB2YXJp YWJsZXMKKyAgICAgICAgcmVzcGVjdGl2ZWx5LiBVc2UgY29tbWEtc2VwYXJhdGVkIHZhbHVlcy4g RXhhbXBsZToKKyAgICAgICAgRVhUUkFfTU9EVUxFUz1maWxlOi8vL3BhdGgvdG8vbW9kdWxlLnNl dCxmaWxlOi8vL290aGVyL3BhdGguCisKIDIwMTItMDEtMTkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIFdyb25n IHZhcmlhYmxlIGJlaW5nIHVzZWQgYXMgdGhlIGN3ZCBmb3IgZ2l0CmRpZmYgLS1naXQgYS9Ub29s cy9ndGsvamhidWlsZHJjIGIvVG9vbHMvZ3RrL2poYnVpbGRyYwppbmRleCBiMGE4Y2NhNmZjMTQz NTM2ZTgyY2E3OGFlMDBkNTljNjhhN2I2Zjk5Li4yZmRlMzk5NmMxM2U5OWRiZTIxOTFlZjdkMWFl YzcwZjA5NTMyNDgzIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZHJjCisrKyBiL1Rvb2xz L2d0ay9qaGJ1aWxkcmMKQEAgLTIzLDEwICsyMywxNyBAQCBpbXBvcnQgY29tbW9uCiAKIGJ1aWxk X3BvbGljeSA9ICd1cGRhdGVkJwogCi1fX21vZHVsZV9maWxlX3BhdGggPSBvcy5wYXRoLmpvaW4o X19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1bGVzJykKLW1vZHVsZXNldCA9ICdm aWxlOi8vJyArIF9fbW9kdWxlX2ZpbGVfcGF0aAorX19tb2R1bGVzZXRfZmlsZV91cmkgPSAnZmls ZTovLycgKyBvcy5wYXRoLmpvaW4oX19ndGtfdG9vbHNfZGlyZWN0b3J5LCAnamhidWlsZC5tb2R1 bGVzJykKK19fZXh0cmFfbW9kdWxlc2V0cyA9IG9zLmVudmlyb24uZ2V0KCJXRUJLSVRfRVhUUkFf TU9EVUxFU0VUUyIsICIiKS5zcGxpdCgiLCIpCittb2R1bGVzZXQgPSBbIF9fbW9kdWxlc2V0X2Zp bGVfdXJpLCBdCitpZiBfX2V4dHJhX21vZHVsZXNldHMgIT0gWycnXToKKyAgICBtb2R1bGVzZXQu ZXh0ZW5kKF9fZXh0cmFfbW9kdWxlc2V0cykKKworX19leHRyYV9tb2R1bGVzID0gb3MuZW52aXJv bi5nZXQoIldFQktJVF9FWFRSQV9NT0RVTEVTIiwgIiIpLnNwbGl0KCIsIikKK21vZHVsZXMgPSBb ICd3ZWJraXRndGstdGVzdGluZy1kZXBlbmRlbmNpZXMnLCBdCitpZiBfX2V4dHJhX21vZHVsZXMg IT0gWycnXToKKyAgICBtb2R1bGVzLmV4dGVuZChfX2V4dHJhX21vZHVsZXMpCiAKLW1vZHVsZXMg PSBbICd3ZWJraXRndGstdGVzdGluZy1kZXBlbmRlbmNpZXMnIF0KIGNoZWNrb3V0cm9vdCA9IG9z LnBhdGguYWJzcGF0aChjb21tb24udG9wX2xldmVsX3BhdGgoJ1dlYktpdEJ1aWxkJywnRGVwZW5k ZW5jaWVzJywgJ1NvdXJjZScpKQogcHJlZml4ID0gb3MucGF0aC5hYnNwYXRoKGNvbW1vbi50b3Bf bGV2ZWxfcGF0aCgnV2ViS2l0QnVpbGQnLCdEZXBlbmRlbmNpZXMnLCAnUm9vdCcpKQogCg==