76674 2012-01-19 16:57:32 -0800 [Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible 2012-01-20 19:04:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 76661 1 ostap73 webkit-unassigned webkit.review.bot zoltan oldest_to_newest 539161 0 ostap73 2012-01-19 16:57:32 -0800 When running WK2 API test sometimes getting division by zero in QtViewportInteractionEngine::setItemRectVisible on this line: qreal itemScale = m_viewport->width() / itemRect.width(); This happens when webview not yet resized to the window size. 539164 1 123224 ostap73 2012-01-19 17:02:46 -0800 Created attachment 123224 Patch 539877 2 123399 ostap73 2012-01-20 16:02:32 -0800 Created attachment 123399 Add reviewed by. 540011 3 123399 webkit.review.bot 2012-01-20 19:04:14 -0800 Comment on attachment 123399 Add reviewed by. Clearing flags on attachment: 123399 Committed r105565: <http://trac.webkit.org/changeset/105565> 540012 4 webkit.review.bot 2012-01-20 19:04:19 -0800 All reviewed patches have been landed. Closing bug. 123224 2012-01-19 17:02:46 -0800 2012-01-20 16:02:32 -0800 Patch emptyItemRect_01.diff text/plain 1336 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOWE0MmEzLi40MGQwMjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDEtMTkgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBEaXZpc2lvbiBieSB6ZXJvIGVy cm9yIGluIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6c2V0SXRlbVJlY3RWaXNpYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjY3NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0 aGF0IGl0ZW1SZWN0IGlzIG5vdCBlbXB0eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZp ZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmU6OnNldEl0ZW1SZWN0VmlzaWJsZSk6CisKIDIwMTItMDEtMTggIEFk YSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTmVlZCBhIFdlYktpdDIgQVBJ IGZvciBzZXR0aW5nIG1lZGlhIHZvbHVtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAppbmRleCBkMTJl YjBiLi44N2NiOWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRW aWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcApAQCAtMTczLDYgKzE3Myw5IEBA IHFyZWFsIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6b3V0ZXJCb3VuZGVkQ1NTU2NhbGUo cXJlYWwgY3NzU2NhbGUpCiAKIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpzZXRJ dGVtUmVjdFZpc2libGUoY29uc3QgUVJlY3RGJiBpdGVtUmVjdCkKIHsKKyAgICBpZiAoaXRlbVJl Y3QuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBWaWV3cG9ydFVwZGF0ZURlZmVy cmVyIGd1YXJkKHRoaXMpOwogCiAgICAgcXJlYWwgaXRlbVNjYWxlID0gbV92aWV3cG9ydC0+d2lk dGgoKSAvIGl0ZW1SZWN0LndpZHRoKCk7Cg== 123399 2012-01-20 16:02:32 -0800 2012-01-20 19:04:14 -0800 Add reviewed by. emptyItemRect_02.diff text/plain 1348 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOWE0MmEzLi40MGQwMjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDEtMTkgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBEaXZpc2lvbiBieSB6ZXJvIGVy cm9yIGluIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6c2V0SXRlbVJlY3RWaXNpYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjY3NAorCisg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAg IE1ha2Ugc3VyZSB0aGF0IGl0ZW1SZWN0IGlzIG5vdCBlbXB0eS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0 OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnNldEl0ZW1SZWN0VmlzaWJsZSk6CisKIDIw MTItMDEtMTggIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTmVlZCBh IFdlYktpdDIgQVBJIGZvciBzZXR0aW5nIG1lZGlhIHZvbHVtZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNw cAppbmRleCBkMTJlYjBiLi44N2NiOWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcApAQCAtMTcz LDYgKzE3Myw5IEBAIHFyZWFsIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6b3V0ZXJCb3Vu ZGVkQ1NTU2NhbGUocXJlYWwgY3NzU2NhbGUpCiAKIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9u RW5naW5lOjpzZXRJdGVtUmVjdFZpc2libGUoY29uc3QgUVJlY3RGJiBpdGVtUmVjdCkKIHsKKyAg ICBpZiAoaXRlbVJlY3QuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBWaWV3cG9y dFVwZGF0ZURlZmVycmVyIGd1YXJkKHRoaXMpOwogCiAgICAgcXJlYWwgaXRlbVNjYWxlID0gbV92 aWV3cG9ydC0+d2lkdGgoKSAvIGl0ZW1SZWN0LndpZHRoKCk7Cg==