76672 2012-01-19 16:02:11 -0800 Node.cpp shouldn't duplicate QualifiedName parsing logic 2012-01-25 15:31:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth darin dglazkov oldest_to_newest 539127 0 webkit.review.bot 2012-01-19 16:02:11 -0800 Move isValidNameStart and friends to QualifiedName.cpp Requested by abarth on #webkit. 542123 1 123906 abarth 2012-01-25 02:52:09 -0800 Created attachment 123906 Patch 542204 2 123906 webkit.review.bot 2012-01-25 05:09:06 -0800 Comment on attachment 123906 Patch Rejecting attachment 123906 from commit-queue. New failing tests: fast/dom/node-prefix-setter-namespace-exception.html fast/dom/element-attribute-js-null.html Full output: http://queues.webkit.org/results/11242763 542241 3 123906 webkit.review.bot 2012-01-25 07:13:52 -0800 Comment on attachment 123906 Patch Attachment 123906 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11159531 New failing tests: fast/dom/node-prefix-setter-namespace-exception.html fast/dom/element-attribute-js-null.html 542637 4 124014 abarth 2012-01-25 14:37:23 -0800 Created attachment 124014 Patch for landing 542699 5 124014 webkit.review.bot 2012-01-25 15:31:43 -0800 Comment on attachment 124014 Patch for landing Clearing flags on attachment: 124014 Committed r105933: <http://trac.webkit.org/changeset/105933> 542700 6 webkit.review.bot 2012-01-25 15:31:48 -0800 All reviewed patches have been landed. Closing bug. 123906 2012-01-25 02:52:09 -0800 2012-01-25 14:37:19 -0800 Patch bug-76672-20120125025208.patch text/plain 3621 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTg1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI1ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTm9kZS5jcHAgc2hvdWxkbid0IGR1 cGxpY2F0ZSBRdWFsaWZpZWROYW1lIHBhcnNpbmcgbG9naWMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBhZGRlZCB0aGlzIGNvZGUgb3V0IG9mIGlnbm9y YW5jZSB0aGF0IHRoaXMgbG9naWMgYWxyZWFkeSBleGlzdGVkIGluCisgICAgICAgIERvY3VtZW50 LmNwcC4gIEluIGEgZnV0dXJlIHBhdGNoLCB3ZSBzaG91bGQgY29uc2lkZXIgbW92aW5nIGl0IHRv CisgICAgICAgIFF1YWxpZmllZE5hbWUuY3BwLgorCisgICAgICAgICogZG9tL05vZGUuY3BwOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpjaGVja1NldFByZWZp eCk6CisKIDIwMTItMDEtMjUgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgPHN0eWxlIHNjb3BlZD46IEltcGxlbWVudCByZWdpc3RlcmluZyBv ZiA8c3R5bGUgc2NvcGVkPiB3aXRoIHRoZSBzY29waW5nIGVsZW1lbnQKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9Ob2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9k ZS5jcHAJKHJldmlzaW9uIDEwNTg1NSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTI4LDYyICsxMjgsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKLS8vIGh0dHA6Ly93d3cudzMub3JnL1RSLzIw MDgvUkVDLXhtbC0yMDA4MTEyNi8jTlQtTmFtZVN0YXJ0Q2hhcgotc3RhdGljIGJvb2wgaXNWYWxp ZE5hbWVTdGFydENoYXJhY3RlcihVQ2hhciBjKQotewotICAgIHJldHVybiBpc0FTQ0lJQWxwaGEo YykKLSAgICAgICAgfHwgYyA9PSAnOicKLSAgICAgICAgfHwgYyA9PSAnXycKLSAgICAgICAgfHwg KGMgPj0gMHhDMCAmJiBjIDw9IDB4RDYpCi0gICAgICAgIHx8IChjID49IDB4RDggJiYgYyA8PSAw eEY2KQotICAgICAgICB8fCAoYyA+PSAweEY4ICYmIGMgPD0gMHgyRkYpCi0gICAgICAgIHx8IChj ID49IDB4MzcwICYmIGMgPD0gMHgzN0QpCi0gICAgICAgIHx8IChjID49IDB4MzdGICYmIGMgPD0g MHgxRkZGKQotICAgICAgICB8fCAoYyA+PSAweDIwMEMgJiYgYyA8PSAweDIwMEQpCi0gICAgICAg IHx8IChjID49IDB4MjA3MCAmJiBjIDw9IDB4MjE4RikKLSAgICAgICAgfHwgKGMgPj0gMHgyQzAw ICYmIGMgPD0gMHgyRkVGKQotICAgICAgICB8fCAoYyA+PSAweDMwMDEgJiYgYyA8PSAweEQ3RkYp Ci0gICAgICAgIHx8IChjID49IDB4RjkwMCAmJiBjIDw9IDB4RkRDRikKLSAgICAgICAgfHwgKGMg Pj0gMHhGREYwICYmIGMgPD0gMHhGRkZEKQotICAgICAgICAvLyBXZSdyZSBzdXBwb3NlZCB0byBh bGxvdyBjaGFyYWN0ZXJzIGluIHRoZSByYW5nZSBVKzEwMDAwLVUrRUZGRkYsCi0gICAgICAgIC8v IGJ1dCBkb2luZyBzbyBwcmVjaXNlbHkgcmVxdWlyZXMgZGVjb2RpbmcgVVRGLTE2IHN1cnJvZ2F0 ZXMuCi0gICAgICAgIC8vIEluc3RlYWQsIHdlIGp1c3QgYWxsb3cgYWxsIG5vbi1CTVAgY2hhcmFj dGVycy4gVGhpcyBpcyBjb25zaXN0ZW50Ci0gICAgICAgIC8vIHdpdGggdGhlIHBoaWxvc3BoeSAo aWYgbm90IHRoZSBsZXR0ZXIpIG9mIHRoZSBYTUwgc3BlY2lmaWNhdGlvbjoKLSAgICAgICAgLy8g ICAiVGhlIGludGVudGlvbiBpcyB0byBiZSBpbmNsdXNpdmUgcmF0aGVyIHRoYW4gZXhjbHVzaXZl LCBzbyB0aGF0Ci0gICAgICAgIC8vICAgd3JpdGluZyBzeXN0ZW1zIG5vdCB5ZXQgZW5jb2RlZCBp biBVbmljb2RlIGNhbiBiZSB1c2VkIGluIFhNTCBuYW1lcy4iCi0gICAgICAgIC8vCi0gICAgICAg IC8vIEZJWE1FOiBWYWxpZGF0ZSBub24tQk1QIGNoYXJhY3RlcnMgY29ycmVjdGx5LgotICAgICAg ICB8fCAoYyA+PSAweEQ4MDAgJiYgYyA8PSAweERGRkYpOwotfQotCi0vLyBodHRwOi8vd3d3Lncz Lm9yZy9UUi8yMDA4L1JFQy14bWwtMjAwODExMjYvI05ULU5hbWVDaGFyCi1zdGF0aWMgYm9vbCBp c1ZhbGlkTmFtZUNoYXJhY3RlcihVQ2hhciBjKQotewotICAgIHJldHVybiBpc1ZhbGlkTmFtZVN0 YXJ0Q2hhcmFjdGVyKGMpCi0gICAgICAgIHx8IGlzQVNDSUlEaWdpdChjKQotICAgICAgICB8fCBj ID09ICctJwotICAgICAgICB8fCBjID09ICcuJwotICAgICAgICB8fCBjID09IDB4QjcKLSAgICAg ICAgfHwgKGMgPj0gMHgwMzAwICYmIGMgPD0gMHgwMzZGKQotICAgICAgICB8fCAoYyA+PSAweDIw M0YgJiYgYyA8PSAweDIwNDApOwotfQotCi0vLyBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDA4L1JF Qy14bWwtMjAwODExMjYvI05ULU5hbWUKLXN0YXRpYyBib29sIGhhc0ludmFsaWRWYWxpZE5hbWVD aGFyYWN0ZXJzKGNvbnN0IEF0b21pY1N0cmluZyYgcHJlZml4KQotewotICAgIGNvbnN0IFVDaGFy KiBjaGFyYWN0ZXJzID0gcHJlZml4LmNoYXJhY3RlcnMoKTsKLSAgICBzaXplX3QgbGVuZ3RoID0g cHJlZml4Lmxlbmd0aCgpOwotICAgIGlmICghbGVuZ3RoKQotICAgICAgICByZXR1cm4gZmFsc2U7 Ci0gICAgaWYgKCFpc1ZhbGlkTmFtZVN0YXJ0Q2hhcmFjdGVyKGNoYXJhY3RlcnNbMF0pKQotICAg ICAgICByZXR1cm4gdHJ1ZTsKLSAgICBmb3IgKHNpemVfdCBpID0gMTsgaSA8IGxlbmd0aDsgKytp KSB7Ci0gICAgICAgIGlmICghaXNWYWxpZE5hbWVDaGFyYWN0ZXIoY2hhcmFjdGVyc1tpXSkpCi0g ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCiBi b29sIE5vZGU6OmlzU3VwcG9ydGVkKGNvbnN0IFN0cmluZyYgZmVhdHVyZSwgY29uc3QgU3RyaW5n JiB2ZXJzaW9uKQogewogICAgIHJldHVybiBET01JbXBsZW1lbnRhdGlvbjo6aGFzRmVhdHVyZShm ZWF0dXJlLCB2ZXJzaW9uKTsKQEAgLTEyNDQsNyArMTE4OCw3IEBAIHZvaWQgTm9kZTo6Y2hlY2tT ZXRQcmVmaXgoY29uc3QgQXRvbWljU3QKICAgICAvLyBQZXJmb3JtIGVycm9yIGNoZWNraW5nIGFz IHJlcXVpcmVkIGJ5IHNwZWMgZm9yIHNldHRpbmcgTm9kZS5wcmVmaXguIFVzZWQgYnkKICAgICAv LyBFbGVtZW50OjpzZXRQcmVmaXgoKSBhbmQgQXR0cjo6c2V0UHJlZml4KCkKIAotICAgIGlmICho YXNJbnZhbGlkVmFsaWROYW1lQ2hhcmFjdGVycyhwcmVmaXgpKSB7CisgICAgaWYgKCFEb2N1bWVu dDo6aXNWYWxpZE5hbWUocHJlZml4KSkgewogICAgICAgICBlYyA9IElOVkFMSURfQ0hBUkFDVEVS X0VSUjsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 124014 2012-01-25 14:37:23 -0800 2012-01-25 15:31:43 -0800 Patch for landing bug-76672-20120125143722.patch text/plain 3617 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTkyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI1ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTm9kZS5jcHAgc2hvdWxkbid0IGR1 cGxpY2F0ZSBRdWFsaWZpZWROYW1lIHBhcnNpbmcgbG9naWMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCisKKyAgICAgICAgSSBhZGRlZCB0aGlzIGNvZGUgb3V0IG9mIGlnbm9yYW5j ZSB0aGF0IHRoaXMgbG9naWMgYWxyZWFkeSBleGlzdGVkIGluCisgICAgICAgIERvY3VtZW50LmNw cC4gIEluIGEgZnV0dXJlIHBhdGNoLCB3ZSBzaG91bGQgY29uc2lkZXIgbW92aW5nIGl0IHRvCisg ICAgICAgIFF1YWxpZmllZE5hbWUuY3BwLgorCisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpjaGVja1NldFByZWZpeCk6 CisKIDIwMTItMDEtMjUgIEhhamltZSBNb3JpdGEgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAg ICAgICAgRU5BQkxFX1NIQURPV19ET00gc2hvdWxkIGJlIGF2YWlsYWJsZSB2aWEgYnVpbGQtd2Vi a2l0IC0tc2hhZG93LWRvbQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAkocmV2aXNpb24gMTA1OTIyKQor KysgU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNjIg KzEyOCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1l czsKIAotLy8gaHR0cDovL3d3dy53My5vcmcvVFIvMjAwOC9SRUMteG1sLTIwMDgxMTI2LyNOVC1O YW1lU3RhcnRDaGFyCi1zdGF0aWMgYm9vbCBpc1ZhbGlkTmFtZVN0YXJ0Q2hhcmFjdGVyKFVDaGFy IGMpCi17Ci0gICAgcmV0dXJuIGlzQVNDSUlBbHBoYShjKQotICAgICAgICB8fCBjID09ICc6Jwot ICAgICAgICB8fCBjID09ICdfJwotICAgICAgICB8fCAoYyA+PSAweEMwICYmIGMgPD0gMHhENikK LSAgICAgICAgfHwgKGMgPj0gMHhEOCAmJiBjIDw9IDB4RjYpCi0gICAgICAgIHx8IChjID49IDB4 RjggJiYgYyA8PSAweDJGRikKLSAgICAgICAgfHwgKGMgPj0gMHgzNzAgJiYgYyA8PSAweDM3RCkK LSAgICAgICAgfHwgKGMgPj0gMHgzN0YgJiYgYyA8PSAweDFGRkYpCi0gICAgICAgIHx8IChjID49 IDB4MjAwQyAmJiBjIDw9IDB4MjAwRCkKLSAgICAgICAgfHwgKGMgPj0gMHgyMDcwICYmIGMgPD0g MHgyMThGKQotICAgICAgICB8fCAoYyA+PSAweDJDMDAgJiYgYyA8PSAweDJGRUYpCi0gICAgICAg IHx8IChjID49IDB4MzAwMSAmJiBjIDw9IDB4RDdGRikKLSAgICAgICAgfHwgKGMgPj0gMHhGOTAw ICYmIGMgPD0gMHhGRENGKQotICAgICAgICB8fCAoYyA+PSAweEZERjAgJiYgYyA8PSAweEZGRkQp Ci0gICAgICAgIC8vIFdlJ3JlIHN1cHBvc2VkIHRvIGFsbG93IGNoYXJhY3RlcnMgaW4gdGhlIHJh bmdlIFUrMTAwMDAtVStFRkZGRiwKLSAgICAgICAgLy8gYnV0IGRvaW5nIHNvIHByZWNpc2VseSBy ZXF1aXJlcyBkZWNvZGluZyBVVEYtMTYgc3Vycm9nYXRlcy4KLSAgICAgICAgLy8gSW5zdGVhZCwg d2UganVzdCBhbGxvdyBhbGwgbm9uLUJNUCBjaGFyYWN0ZXJzLiBUaGlzIGlzIGNvbnNpc3RlbnQK LSAgICAgICAgLy8gd2l0aCB0aGUgcGhpbG9zcGh5IChpZiBub3QgdGhlIGxldHRlcikgb2YgdGhl IFhNTCBzcGVjaWZpY2F0aW9uOgotICAgICAgICAvLyAgICJUaGUgaW50ZW50aW9uIGlzIHRvIGJl IGluY2x1c2l2ZSByYXRoZXIgdGhhbiBleGNsdXNpdmUsIHNvIHRoYXQKLSAgICAgICAgLy8gICB3 cml0aW5nIHN5c3RlbXMgbm90IHlldCBlbmNvZGVkIGluIFVuaWNvZGUgY2FuIGJlIHVzZWQgaW4g WE1MIG5hbWVzLiIKLSAgICAgICAgLy8KLSAgICAgICAgLy8gRklYTUU6IFZhbGlkYXRlIG5vbi1C TVAgY2hhcmFjdGVycyBjb3JyZWN0bHkuCi0gICAgICAgIHx8IChjID49IDB4RDgwMCAmJiBjIDw9 IDB4REZGRik7Ci19Ci0KLS8vIGh0dHA6Ly93d3cudzMub3JnL1RSLzIwMDgvUkVDLXhtbC0yMDA4 MTEyNi8jTlQtTmFtZUNoYXIKLXN0YXRpYyBib29sIGlzVmFsaWROYW1lQ2hhcmFjdGVyKFVDaGFy IGMpCi17Ci0gICAgcmV0dXJuIGlzVmFsaWROYW1lU3RhcnRDaGFyYWN0ZXIoYykKLSAgICAgICAg fHwgaXNBU0NJSURpZ2l0KGMpCi0gICAgICAgIHx8IGMgPT0gJy0nCi0gICAgICAgIHx8IGMgPT0g Jy4nCi0gICAgICAgIHx8IGMgPT0gMHhCNwotICAgICAgICB8fCAoYyA+PSAweDAzMDAgJiYgYyA8 PSAweDAzNkYpCi0gICAgICAgIHx8IChjID49IDB4MjAzRiAmJiBjIDw9IDB4MjA0MCk7Ci19Ci0K LS8vIGh0dHA6Ly93d3cudzMub3JnL1RSLzIwMDgvUkVDLXhtbC0yMDA4MTEyNi8jTlQtTmFtZQot c3RhdGljIGJvb2wgaGFzSW52YWxpZFZhbGlkTmFtZUNoYXJhY3RlcnMoY29uc3QgQXRvbWljU3Ry aW5nJiBwcmVmaXgpCi17Ci0gICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMgPSBwcmVmaXguY2hh cmFjdGVycygpOwotICAgIHNpemVfdCBsZW5ndGggPSBwcmVmaXgubGVuZ3RoKCk7Ci0gICAgaWYg KCFsZW5ndGgpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAoIWlzVmFsaWROYW1lU3Rh cnRDaGFyYWN0ZXIoY2hhcmFjdGVyc1swXSkpCi0gICAgICAgIHJldHVybiB0cnVlOwotICAgIGZv ciAoc2l6ZV90IGkgPSAxOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAgICAgICAgaWYgKCFpc1ZhbGlk TmFtZUNoYXJhY3RlcihjaGFyYWN0ZXJzW2ldKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwot ICAgIH0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KIGJvb2wgTm9kZTo6aXNTdXBwb3J0ZWQoY29u c3QgU3RyaW5nJiBmZWF0dXJlLCBjb25zdCBTdHJpbmcmIHZlcnNpb24pCiB7CiAgICAgcmV0dXJu IERPTUltcGxlbWVudGF0aW9uOjpoYXNGZWF0dXJlKGZlYXR1cmUsIHZlcnNpb24pOwpAQCAtMTI0 NCw3ICsxMTg4LDcgQEAgdm9pZCBOb2RlOjpjaGVja1NldFByZWZpeChjb25zdCBBdG9taWNTdAog ICAgIC8vIFBlcmZvcm0gZXJyb3IgY2hlY2tpbmcgYXMgcmVxdWlyZWQgYnkgc3BlYyBmb3Igc2V0 dGluZyBOb2RlLnByZWZpeC4gVXNlZCBieQogICAgIC8vIEVsZW1lbnQ6OnNldFByZWZpeCgpIGFu ZCBBdHRyOjpzZXRQcmVmaXgoKQogCi0gICAgaWYgKGhhc0ludmFsaWRWYWxpZE5hbWVDaGFyYWN0 ZXJzKHByZWZpeCkpIHsKKyAgICBpZiAoIXByZWZpeC5pc0VtcHR5KCkgJiYgIURvY3VtZW50Ojpp c1ZhbGlkTmFtZShwcmVmaXgpKSB7CiAgICAgICAgIGVjID0gSU5WQUxJRF9DSEFSQUNURVJfRVJS OwogICAgICAgICByZXR1cm47CiAgICAgfQo=