76666 2012-01-19 14:47:31 -0800 [Chromium] Ganesh's Texture Cache is too small 2012-01-27 15:42:24 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 twiz twiz bsalomon mdelaney7 nduca senorblanco vangelis webkit.review.bot oldest_to_newest 539053 0 twiz 2012-01-19 14:47:31 -0800 The current Ganesh texture cache is initialized to cache no more than 50 Mb of texture data. For some demos this is too constrained. See parallel tracking issue: crbug.com/110468 539056 1 123201 twiz 2012-01-19 14:52:13 -0800 Created attachment 123201 Patch 539277 2 123201 vangelis 2012-01-19 22:27:12 -0800 Comment on attachment 123201 Patch I would feel more comfortable increasing the cache size if we were able to clear the cache when a tab is hidden like we do for the compositor. In order to do that we may need to switch to using a shared graphics context per webview instead of renderer process or track how many tabs the renderer is dealing with and flush the cache when they are all hidden. Alternatively, would it be possible to age textures in the cache so that we only evict ones that haven't been used for a while and use this texture limit as a soft limit that can be exceeded if more space is needed to keep the contents of a single frame? Longer term we need to have a better strategy for doing global tracking of memory like nduca@ suggests. 539450 3 bsalomon 2012-01-20 05:59:05 -0800 (In reply to comment #2) > (From update of attachment 123201 [details]) > I would feel more comfortable increasing the cache size if we were able to clear the cache when a tab is hidden like we do for the compositor. In order to do that we may need to switch to using a shared graphics context per webview instead of renderer process or track how many tabs the renderer is dealing with and flush the cache when they are all hidden. > > Alternatively, would it be possible to age textures in the cache so that we only evict ones that haven't been used for a while and use this texture limit as a soft limit that can be exceeded if more space is needed to keep the contents of a single frame? > > Longer term we need to have a better strategy for doing global tracking of memory like nduca@ suggests. We could make the cache size be a hard limit but periodically walk the cache and purge anything that hasn't been used in a while even when we are under-budget. 541738 4 123201 twiz 2012-01-24 14:56:53 -0800 Comment on attachment 123201 Patch From the discussion we had offline today, I think we should let this patch through. The plan is to introduce the capability of explicitly purging the Ganesh texture cache when all of the tabs associated with a render process have been backgrounded/hidden. 544363 5 twiz 2012-01-27 14:24:32 -0800 Can a reviewer please have a look at this change, and mark it cq+? 544427 6 123201 senorblanco 2012-01-27 15:21:47 -0800 Comment on attachment 123201 Patch OK. r=me 544455 7 123201 webkit.review.bot 2012-01-27 15:42:19 -0800 Comment on attachment 123201 Patch Clearing flags on attachment: 123201 Committed r106164: <http://trac.webkit.org/changeset/106164> 544456 8 webkit.review.bot 2012-01-27 15:42:24 -0800 All reviewed patches have been landed. Closing bug. 123201 2012-01-19 14:52:13 -0800 2012-01-27 15:42:19 -0800 Patch bug-76666-20120119175211.patch text/plain 1628 twiz SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDU0NDgpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAxLTE5ICBKZWZmIFRpbWFudXMgIDx0d2l6QGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIEluY3JlYXNlIHRoZSBzaXplIG9mIHRoZSBHYW5lc2ggdGV4dHVyZSBj YWNoZSB0byBwcmV2ZW50IHBlcmZvcm1hbmNlIHByb2JsZW1zIG9uIGFkdmFuY2VkIENhbnZhczJE IHBhZ2VzLgorICAgICAgICBUaGUgY2FjaGUgd2FzIHByZXZpb3VzbHkgNTAgTUI7IGl0IGlzIG5v dyA5NiBNQi4KKworICAgICAgICBCdWcgNzY2NjYgLSBHYW5lc2gncyBUZXh0dXJlIENhY2hlIGlz IHRvbyBzbWFsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzY2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHNyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Z3JDb250ZXh0KToKKwogMjAxMi0wMS0xOSAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBS b2xsIERFUFMgdG8gbW9zdCByZWNlbnQgTEtHUiAoMTE4MjkxKS4KSW5kZXg6IFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0u Y3BwCShyZXZpc2lvbiAxMDU0NDcpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFw aGljc0NvbnRleHQzRENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEwLDcgKzIxMCw3 IEBAIEdyQ29udGV4dCogR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpnckMKICAgICAvLyBMaW1p dCB0aGUgbnVtYmVyIG9mIHRleHR1cmVzIHdlIGhvbGQgaW4gdGhlIGJpdG1hcC0+dGV4dHVyZSBj YWNoZS4KICAgICBzdGF0aWMgY29uc3QgaW50IG1heFRleHR1cmVDYWNoZUNvdW50ID0gNTEyOwog ICAgIC8vIExpbWl0IHRoZSBieXRlcyBhbGxvY2F0ZWQgdG93YXJkIHRleHR1cmVzIGluIHRoZSBi aXRtYXAtPnRleHR1cmUgY2FjaGUuCi0gICAgc3RhdGljIGNvbnN0IHNpemVfdCBtYXhUZXh0dXJl Q2FjaGVCeXRlcyA9IDUwICogMTAyNCAqIDEwMjQ7CisgICAgc3RhdGljIGNvbnN0IHNpemVfdCBt YXhUZXh0dXJlQ2FjaGVCeXRlcyA9IDk2ICogMTAyNCAqIDEwMjQ7CiAKICAgICBpZiAoIW1fZ3JD b250ZXh0KSB7CiAgICAgICAgIFNrQXV0b1RVbnJlZjxHckdMSW50ZXJmYWNlPiBpbnRlcmZhY2Uo bV9pbXBsLT5jcmVhdGVHckdMSW50ZXJmYWNlKCkpOwo=