76652 2012-01-19 11:46:15 -0800 CaseFoldingHash::hash() doesn't handle 8 bit strings directly 2012-01-30 11:09:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 538870 0 msaboff 2012-01-19 11:46:15 -0800 CaseFoldingHash::hash(StringImpl* str) should have a path for 8 bit strings. 539066 1 123205 msaboff 2012-01-19 15:10:38 -0800 Created attachment 123205 Patch 539082 2 123205 kling 2012-01-19 15:29:48 -0800 Comment on attachment 123205 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review r=me, just one little thing: > Source/JavaScriptCore/wtf/text/StringHash.h:105 > return hash(str->characters(), str->length()); You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters(). 539084 3 msaboff 2012-01-19 15:31:13 -0800 (In reply to comment #2) > (From update of attachment 123205 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review > > r=me, just one little thing: > > > Source/JavaScriptCore/wtf/text/StringHash.h:105 > > return hash(str->characters(), str->length()); > > You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters(). Thanks for catching that. I'll make the change before checking in. 545224 4 msaboff 2012-01-30 11:09:39 -0800 Committed r106260: <http://trac.webkit.org/changeset/106260> 123205 2012-01-19 15:10:38 -0800 2012-01-19 15:29:48 -0800 Patch 76652.patch text/plain 1206 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA1NDUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENhc2VGb2xkaW5nSGFzaDo6aGFzaCgpIGRvZXNuJ3QgaGFuZGxlIDggYml0IHN0cmluZ3Mg ZGlyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2NjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvdGV4dC9TdHJpbmdIYXNoLmg6CisgICAgICAgIChXVEY6OkNhc2VGb2xkaW5nSGFzaDo6 aGFzaCk6IEFkZGVkIDggYml0IHN0cmluZyBjb2RlIHBhdGguCisKIDIwMTItMDEtMTkgIEdlb2Zm cmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsaWNpdCBjcmVhdGlv biBvZiBhIHJlZ3VsYXIgZXhwcmVzc2lvbiBzaG91bGQgZWFnZXJseSBjaGVjayBmb3Igc3ludGF4 IGVycm9ycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0hhc2gu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSGFz aC5oCShyZXZpc2lvbiAxMDU0MTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQv U3RyaW5nSGFzaC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNiArMTAwLDggQEAgbmFtZXNwYWNl IFdURiB7CiAKICAgICAgICAgc3RhdGljIHVuc2lnbmVkIGhhc2goU3RyaW5nSW1wbCogc3RyKQog ICAgICAgICB7CisgICAgICAgICAgICBpZiAoc3RyLT5pczhCaXQoKSkKKyAgICAgICAgICAgICAg ICByZXR1cm4gaGFzaChzdHItPmNoYXJhY3RlcnM4KCksIHN0ci0+bGVuZ3RoKCkpOwogICAgICAg ICAgICAgcmV0dXJuIGhhc2goc3RyLT5jaGFyYWN0ZXJzKCksIHN0ci0+bGVuZ3RoKCkpOwogICAg ICAgICB9CiAK