76651 2012-01-19 11:43:16 -0800 stringProtoFuncReplace converts 8 bit strings to 16 bit during replacement 2012-01-30 10:52:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 538865 0 msaboff 2012-01-19 11:43:16 -0800 stringProtoFuncReplace() ends up calling substituteBackRef() in the same file which converts 8 bit strings to 16 bit strings creating a 16 bit result. This was found running the dromaeo tests. 539062 1 123204 msaboff 2012-01-19 15:04:44 -0800 Created attachment 123204 Patch 539076 2 123204 ggaren 2012-01-19 15:23:55 -0800 Comment on attachment 123204 Patch r=me 545210 3 msaboff 2012-01-30 10:52:02 -0800 Committed r106257: <http://trac.webkit.org/changeset/106257> 123204 2012-01-19 15:04:44 -0800 2012-01-19 15:23:55 -0800 Patch 76651.patch text/plain 5436 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA1NDUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIHN0cmluZ1Byb3RvRnVuY1JlcGxhY2UgY29udmVydHMgOCBiaXQgc3RyaW5ncyB0byAxNiBi aXQgZHVyaW5nIHJlcGxhY2VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03NjY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1hZGUgbG9jYWwgZnVuY3Rpb24gc3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2Vz U2xvdyBhIHRlbXBsYXRlIGZ1bmN0aW9uCisgICAgICAgIGJhc2VkIG9uIGNoYXJhY3RlciB3aWR0 aC4gIENsZWFuZWQgdXAgZ2V0Q2hhcmFjdGVycygpIGluIGJvdGggVVN0cmluZworICAgICAgICBh bmQgU3RyaW5nSW1wbC4gIENoYW5nZWQgZ2V0Q2hhcmFjdGVyczxVQ2hhcj4gdG8gdXAgY29udmVy dCBhbiA4IGJpdAorICAgICAgICBzdHJpbmcgdG8gMTYgYml0cyBpZiBuZWNlc3NhcnkuCisKKyAg ICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnN1YnN0 aXR1dGVCYWNrcmVmZXJlbmNlc1Nsb3cpOgorICAgICAgICAoSlNDOjpzdWJzdGl0dXRlQmFja3Jl ZmVyZW5jZXMpOgorICAgICAgICAqIHJ1bnRpbWUvVVN0cmluZy5oOgorICAgICAgICAoSlNDOjpM Q2hhcik6CisgICAgICAgIChKU0M6OlVDaGFyKToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJ bXBsLmg6CisgICAgICAgIChXVEY6OlVDaGFyKToKKwogMjAxMi0wMS0xOSAgR2VvZmZyZXkgR2Fy ZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxpY2l0IGNyZWF0aW9uIG9mIGEg cmVndWxhciBleHByZXNzaW9uIHNob3VsZCBlYWdlcmx5IGNoZWNrIGZvciBzeW50YXggZXJyb3Jz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3Rv dHlwZS5jcHAJKHJldmlzaW9uIDEwNTQxNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MCw5ICsxNzAsMTAg QEAgc3RhdGljIGlubGluZSBKU1N0cmluZyoganNTdHJpbmdXaXRoUmV1cwogICAgIHJldHVybiBq c1N0cmluZyhleGVjLCBzdHJpbmcpOwogfQogCit0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhclR5cGU+ CiBzdGF0aWMgTkVWRVJfSU5MSU5FIFVTdHJpbmcgc3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2VzU2xv dyhjb25zdCBVU3RyaW5nJiByZXBsYWNlbWVudCwgY29uc3QgVVN0cmluZyYgc291cmNlLCBjb25z dCBpbnQqIG92ZWN0b3IsIFJlZ0V4cCogcmVnLCBzaXplX3QgaSkKIHsKLSAgICBWZWN0b3I8VUNo YXI+IHN1YnN0aXR1dGVkUmVwbGFjZW1lbnQ7CisgICAgVmVjdG9yPENoYXJUeXBlPiBzdWJzdGl0 dXRlZFJlcGxhY2VtZW50OwogICAgIGludCBvZmZzZXQgPSAwOwogICAgIGRvIHsKICAgICAgICAg aWYgKGkgKyAxID09IHJlcGxhY2VtZW50Lmxlbmd0aCgpKQpAQCAtMTgyLDcgKzE4Myw3IEBAIHN0 YXRpYyBORVZFUl9JTkxJTkUgVVN0cmluZyBzdWJzdGl0dXRlQmEKICAgICAgICAgaWYgKHJlZiA9 PSAnJCcpIHsKICAgICAgICAgICAgIC8vICIkJCIgLT4gIiQiCiAgICAgICAgICAgICArK2k7Ci0g ICAgICAgICAgICBzdWJzdGl0dXRlZFJlcGxhY2VtZW50LmFwcGVuZChyZXBsYWNlbWVudC5jaGFy YWN0ZXJzKCkgKyBvZmZzZXQsIGkgLSBvZmZzZXQpOworICAgICAgICAgICAgc3Vic3RpdHV0ZWRS ZXBsYWNlbWVudC5hcHBlbmQocmVwbGFjZW1lbnQuZ2V0Q2hhcmFjdGVyczxDaGFyVHlwZT4oKSAr IG9mZnNldCwgaSAtIG9mZnNldCk7CiAgICAgICAgICAgICBvZmZzZXQgPSBpICsgMTsKICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CkBAIC0yMjIsMTUgKzIyMywxNSBAQCBzdGF0aWMg TkVWRVJfSU5MSU5FIFVTdHJpbmcgc3Vic3RpdHV0ZUJhCiAgICAgICAgICAgICBjb250aW51ZTsK IAogICAgICAgICBpZiAoaSAtIG9mZnNldCkKLSAgICAgICAgICAgIHN1YnN0aXR1dGVkUmVwbGFj ZW1lbnQuYXBwZW5kKHJlcGxhY2VtZW50LmNoYXJhY3RlcnMoKSArIG9mZnNldCwgaSAtIG9mZnNl dCk7CisgICAgICAgICAgICBzdWJzdGl0dXRlZFJlcGxhY2VtZW50LmFwcGVuZChyZXBsYWNlbWVu dC5nZXRDaGFyYWN0ZXJzPENoYXJUeXBlPigpICsgb2Zmc2V0LCBpIC0gb2Zmc2V0KTsKICAgICAg ICAgaSArPSAxICsgYWR2YW5jZTsKICAgICAgICAgb2Zmc2V0ID0gaSArIDE7CiAgICAgICAgIGlm IChiYWNrcmVmU3RhcnQgPj0gMCkKLSAgICAgICAgICAgIHN1YnN0aXR1dGVkUmVwbGFjZW1lbnQu YXBwZW5kKHNvdXJjZS5jaGFyYWN0ZXJzKCkgKyBiYWNrcmVmU3RhcnQsIGJhY2tyZWZMZW5ndGgp OworICAgICAgICAgICAgc3Vic3RpdHV0ZWRSZXBsYWNlbWVudC5hcHBlbmQoc291cmNlLmdldENo YXJhY3RlcnM8Q2hhclR5cGU+KCkgKyBiYWNrcmVmU3RhcnQsIGJhY2tyZWZMZW5ndGgpOwogICAg IH0gd2hpbGUgKChpID0gcmVwbGFjZW1lbnQuZmluZCgnJCcsIGkgKyAxKSkgIT0gbm90Rm91bmQp OwogCiAgICAgaWYgKHJlcGxhY2VtZW50Lmxlbmd0aCgpIC0gb2Zmc2V0KQotICAgICAgICBzdWJz dGl0dXRlZFJlcGxhY2VtZW50LmFwcGVuZChyZXBsYWNlbWVudC5jaGFyYWN0ZXJzKCkgKyBvZmZz ZXQsIHJlcGxhY2VtZW50Lmxlbmd0aCgpIC0gb2Zmc2V0KTsKKyAgICAgICAgc3Vic3RpdHV0ZWRS ZXBsYWNlbWVudC5hcHBlbmQocmVwbGFjZW1lbnQuZ2V0Q2hhcmFjdGVyczxDaGFyVHlwZT4oKSAr IG9mZnNldCwgcmVwbGFjZW1lbnQubGVuZ3RoKCkgLSBvZmZzZXQpOwogCiAgICAgc3Vic3RpdHV0 ZWRSZXBsYWNlbWVudC5zaHJpbmtUb0ZpdCgpOwogICAgIHJldHVybiBVU3RyaW5nOjphZG9wdChz dWJzdGl0dXRlZFJlcGxhY2VtZW50KTsKQEAgLTIzOSw4ICsyNDAsMTEgQEAgc3RhdGljIE5FVkVS X0lOTElORSBVU3RyaW5nIHN1YnN0aXR1dGVCYQogc3RhdGljIGlubGluZSBVU3RyaW5nIHN1YnN0 aXR1dGVCYWNrcmVmZXJlbmNlcyhjb25zdCBVU3RyaW5nJiByZXBsYWNlbWVudCwgY29uc3QgVVN0 cmluZyYgc291cmNlLCBjb25zdCBpbnQqIG92ZWN0b3IsIFJlZ0V4cCogcmVnKQogewogICAgIHNp emVfdCBpID0gcmVwbGFjZW1lbnQuZmluZCgnJCcsIDApOwotICAgIGlmIChVTkxJS0VMWShpICE9 IG5vdEZvdW5kKSkKLSAgICAgICAgcmV0dXJuIHN1YnN0aXR1dGVCYWNrcmVmZXJlbmNlc1Nsb3co cmVwbGFjZW1lbnQsIHNvdXJjZSwgb3ZlY3RvciwgcmVnLCBpKTsKKyAgICBpZiAoVU5MSUtFTFko aSAhPSBub3RGb3VuZCkpIHsKKyAgICAgICAgaWYgKHJlcGxhY2VtZW50LmlzOEJpdCgpICYmIHNv dXJjZS5pczhCaXQoKSkKKyAgICAgICAgICAgIHJldHVybiBzdWJzdGl0dXRlQmFja3JlZmVyZW5j ZXNTbG93PExDaGFyPihyZXBsYWNlbWVudCwgc291cmNlLCBvdmVjdG9yLCByZWcsIGkpOworICAg ICAgICByZXR1cm4gc3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2VzU2xvdzxVQ2hhcj4ocmVwbGFjZW1l bnQsIHNvdXJjZSwgb3ZlY3RvciwgcmVnLCBpKTsKKyAgICB9CiAgICAgcmV0dXJuIHJlcGxhY2Vt ZW50OwogfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCShy ZXZpc2lvbiAxMDU0MTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5n LmgJKHdvcmtpbmcgY29weSkKQEAgLTEzOSwxOCArMTM5LDEwIEBAIHByaXZhdGU6CiB9OwogCiB0 ZW1wbGF0ZTw+Ci1pbmxpbmUgY29uc3QgTENoYXIqIFVTdHJpbmc6OmdldENoYXJhY3RlcnM8TENo YXI+KCkgY29uc3QKLXsKLSAgICBBU1NFUlQoaXM4Qml0KCkpOwotICAgIHJldHVybiBjaGFyYWN0 ZXJzOCgpOwotfQoraW5saW5lIGNvbnN0IExDaGFyKiBVU3RyaW5nOjpnZXRDaGFyYWN0ZXJzPExD aGFyPigpIGNvbnN0IHsgcmV0dXJuIGNoYXJhY3RlcnM4KCk7IH0KIAogdGVtcGxhdGU8PgotaW5s aW5lIGNvbnN0IFVDaGFyKiBVU3RyaW5nOjpnZXRDaGFyYWN0ZXJzPFVDaGFyPigpIGNvbnN0Ci17 Ci0gICAgQVNTRVJUKCFpczhCaXQoKSk7Ci0gICAgcmV0dXJuIGNoYXJhY3RlcnMxNigpOwotfQor aW5saW5lIGNvbnN0IFVDaGFyKiBVU3RyaW5nOjpnZXRDaGFyYWN0ZXJzPFVDaGFyPigpIGNvbnN0 IHsgcmV0dXJuIGNoYXJhY3RlcnMoKTsgfQogCiBORVZFUl9JTkxJTkUgYm9vbCBlcXVhbFNsb3dD YXNlKGNvbnN0IFVTdHJpbmcmIHMxLCBjb25zdCBVU3RyaW5nJiBzMik7CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gMTA1NDE1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTQ4LDcgKzU0OCw3IEBAIHRlbXBsYXRlIDw+CiBBTFdBWVNfSU5MSU5FIGNv bnN0IExDaGFyKiBTdHJpbmdJbXBsOjpnZXRDaGFyYWN0ZXJzPExDaGFyPigpIGNvbnN0IHsgcmV0 dXJuIGNoYXJhY3RlcnM4KCk7IH0KIAogdGVtcGxhdGUgPD4KLUFMV0FZU19JTkxJTkUgY29uc3Qg VUNoYXIqIFN0cmluZ0ltcGw6OmdldENoYXJhY3RlcnM8VUNoYXI+KCkgY29uc3QgeyByZXR1cm4g Y2hhcmFjdGVyczE2KCk7IH0KK0FMV0FZU19JTkxJTkUgY29uc3QgVUNoYXIqIFN0cmluZ0ltcGw6 OmdldENoYXJhY3RlcnM8VUNoYXI+KCkgY29uc3QgeyByZXR1cm4gY2hhcmFjdGVycygpOyB9CiAK IFdURl9FWFBPUlRfUFJJVkFURSBib29sIGVxdWFsKGNvbnN0IFN0cmluZ0ltcGwqLCBjb25zdCBT dHJpbmdJbXBsKik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJ bXBsKiwgY29uc3QgTENoYXIqKTsK