76650 2012-01-19 11:40:36 -0800 check-webkit-style whitespace/operators triggers on overloaded division operator 2012-01-23 16:01:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 eae eae abarth levin ojan webkit.review.bot oldest_to_newest 538862 0 eae 2012-01-19 11:40:36 -0800 + inline float operator*(const float a, const AppUnit& b) Source/WebCore/platform/AppUnit.h:330: Missing spaces around / [whitespace/operators] [3] The whitespace/operators check triggers on declaration of overloaded operators. It should probably by modified to special case operators immediately preceded by the keyword operator. See bug 76571 for an example. 540897 1 eae 2012-01-23 15:42:34 -0800 This only happens for the division operator, all other ones seems fine. 540899 2 123640 eae 2012-01-23 15:45:23 -0800 Created attachment 123640 Patch 540924 3 123640 eae 2012-01-23 16:01:26 -0800 Comment on attachment 123640 Patch Clearing flags on attachment: 123640 Committed r105652: <http://trac.webkit.org/changeset/105652> 540925 4 eae 2012-01-23 16:01:29 -0800 All reviewed patches have been landed. Closing bug. 123640 2012-01-23 15:45:23 -0800 2012-01-23 16:01:26 -0800 Patch bug-76650-20120123154521.patch text/plain 2357 eae SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNTY0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAxLTIzICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4K KworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgd2hpdGVzcGFjZS9vcGVyYXRvcnMgdHJpZ2dl cnMgb24gb3ZlcmxvYWRlZCBkaXZpc2lvbiBvcGVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY2NTAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfc3BhY2luZyk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChDcHBTdHls ZVRlc3QudGVzdF9vcGVyYXRvcl9tZXRob2RzKToKKwogMjAxMi0wMS0yMiAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBydW4tcGVyZi10ZXN0cyBpZ25vcmUgU2tp cHBlZCBsaXN0IG9uIGNocm9taXVtCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQkocmV2aXNpb24gMTA1NjQ1KQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4MDgsNyAr MTgwOCw3IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl8KICAgICBs aW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXSAgIyBnZXQgcmlkIG9mIGNvbW1l bnRzIGFuZCBzdHJpbmdzCiAKICAgICAjIERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNrcyBm b3Igb3BlcmF0b3IgbWV0aG9kcwotICAgIGxpbmUgPSBzdWIocidvcGVyYXRvcig9PXwhPXw8fDw8 fDw9fD49fD4+fD58XCs9fC09fFwqPXwvPXwlPXwmPXxcfD18Xj18PDw9fD4+PSlcKCcsICdvcGVy YXRvclwoJywgbGluZSkKKyAgICBsaW5lID0gc3ViKHInb3BlcmF0b3IoPT18IT18PHw8PHw8PXw+ PXw+Pnw+fFwrPXwtPXxcKj18Lz18JT18Jj18XHw9fF49fDw8PXw+Pj18LylcKCcsICdvcGVyYXRv clwoJywgbGluZSkKICAgICAjIERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNrcyBmb3IgI2lu Y2x1ZGUgb3IgI2ltcG9ydCBzdGF0ZW1lbnRzIGF0CiAgICAgIyBtaW5pbXVtIGJlY2F1c2UgaXQg bWVzc2VzIHVwIGNoZWNrcyBmb3Igc3BhY2luZyBhcm91bmQgLwogICAgIGlmIG1hdGNoKHInXHMq I1xzKig/OmluY2x1ZGV8aW1wb3J0KScsIGxpbmUpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkJKHJldmlzaW9u IDEwNTY0NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNzE1LDYgKzE3MTUsNyBAQCBjbGFzcyBDcHBT dHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAKICAgICBkZWYgdGVzdF9vcGVyYXRvcl9tZXRo b2RzKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdTdHJpbmcgb3BlcmF0b3IrKGNv bnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9s aW50KCdTdHJpbmcgb3BlcmF0b3IvKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpOycsICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdib29sIG9wZXJhdG9yPT0oY29uc3QgU3RyaW5n JiwgY29uc3QgU3RyaW5nJik7JywgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1N0cmlu ZyYgb3BlcmF0b3ItPShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykKICAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRvcis9KGNvbnN0IFN0cmluZyYsIGNv bnN0IFN0cmluZyYpOycsICcnKQo=