76649 2012-01-19 11:39:12 -0800 Dromaeo tests call parseSimpleLengthValue() on 8 bit strings 2012-01-30 10:30:49 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff macpherson webkit.review.bot oldest_to_newest 538858 0 msaboff 2012-01-19 11:39:12 -0800 Dromaeo tests cause parseSimpleLengthValue() on 8 bit strings to be converted to 16 bit strings. This routine should have an 8 bit path. 539058 1 123203 msaboff 2012-01-19 14:52:55 -0800 Created attachment 123203 Patch Added 8 bit path. 539114 2 123203 ggaren 2012-01-19 15:56:41 -0800 Comment on attachment 123203 Patch For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary. 545194 3 msaboff 2012-01-30 10:28:19 -0800 (In reply to comment #2) > (From update of attachment 123203 [details]) > For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary. We still need the appropriate character pointer to call charactersToDouble(). 545196 4 msaboff 2012-01-30 10:30:49 -0800 Committed r106254: <http://trac.webkit.org/changeset/106254> 123203 2012-01-19 14:52:55 -0800 2012-01-19 15:56:41 -0800 Patch 76649.patch text/plain 5238 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA1NDQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIERyb21hZW8gdGVzdHMgY2FsbCBwYXJzZVNpbXBsZUxlbmd0aFZhbHVlKCkgb24gOCBiaXQg c3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzY2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLmV4cDogQWRkZWQgZXhwb3J0IGZvciBjaGFyYWN0ZXJzVG9Eb3VibGUu CisKIDIwMTItMDEtMTkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBJbXBsaWNpdCBjcmVhdGlvbiBvZiBhIHJlZ3VsYXIgZXhwcmVzc2lvbiBzaG91bGQgZWFn ZXJseSBjaGVjayBmb3Igc3ludGF4IGVycm9ycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdENvcmUuZXhwCShyZXZpc2lvbiAxMDU0MTUpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC00NTEsNiArNDUxLDcg QEAgX19aTjNXVEYxN2VxdWFsSWdub3JpbmdDYXNlRVBOU18xMFN0cmluZwogX19aTjNXVEYxN2Vx dWFsSWdub3JpbmdDYXNlRVBOU18xMFN0cmluZ0ltcGxFUzFfCiBfX1pOM1dURjE4Y2FsY3VsYXRl RFNUT2Zmc2V0RWRkCiBfX1pOM1dURjE4Y2FsY3VsYXRlVVRDT2Zmc2V0RXYKK19fWk4zV1RGMThj aGFyYWN0ZXJzVG9Eb3VibGVFUEtobVBiUzJfCiBfX1pOM1dURjE4Y2hhcmFjdGVyc1RvRG91Ymxl RVBLdG1QYlMyXwogX19aTjNXVEYxOGRhdGVUb0RheXNGcm9tMTk3MEVpaWkKIF9fWk4zV1RGMTht b250aEZyb21EYXlJblllYXJFaWIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTQ0OSkKKysr IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIERyb21hZW8gdGVzdHMgY2FsbCBwYXJzZVNpbXBsZUxlbmd0aFZhbHVlKCkgb24gOCBiaXQg c3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzY2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBmdW5jdGlvbmFsaXR5IGNoYW5nZSwgdGhlcmVmb3JlIG5vIG5ldyB0ZXN0cy4KKworICAgICAg ICBBZGRlZCA4IGJpdCBwYXRjaCBmb3IgcGFyc2VTaW1wbGVMZW5ndGhWYWx1ZSgpLgorCisgICAg ICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZVNpbXBsZUxl bmd0aFZhbHVlKToKKwogMjAxMi0wMS0xOSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdA YXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBhIG5ldyBhbGxvY2F0b3IgZm9yIGJhY2tp bmcgc3RvcmVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkocmV2aXNpb24gMTA1NDE1 KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQxMywyOCArNDEzLDU4IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc1NpbXBsZUxlbmd0aFByb3Bl cnQKIAogc3RhdGljIGJvb2wgcGFyc2VTaW1wbGVMZW5ndGhWYWx1ZShDU1NNdXRhYmxlU3R5bGVE ZWNsYXJhdGlvbiogZGVjbGFyYXRpb24sIGludCBwcm9wZXJ0eUlkLCBjb25zdCBTdHJpbmcmIHN0 cmluZywgYm9vbCBpbXBvcnRhbnQsIGJvb2wgc3RyaWN0LCBDU1NTdHlsZVNoZWV0KiBjb250ZXh0 U3R5bGVTaGVldCA9IDApCiB7Ci0gICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMgPSBzdHJpbmcu Y2hhcmFjdGVycygpOwotICAgIHVuc2lnbmVkIGxlbmd0aCA9IHN0cmluZy5sZW5ndGgoKTsKLSAg ICBpZiAoIWNoYXJhY3RlcnMgfHwgIWxlbmd0aCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IGJvb2wgYWNjZXB0c05lZ2F0aXZlTnVtYmVyczsKLSAgICBpZiAoIWlzU2ltcGxlTGVuZ3RoUHJv cGVydHlJRChwcm9wZXJ0eUlkLCBhY2NlcHRzTmVnYXRpdmVOdW1iZXJzKSkKKyAgICB1bnNpZ25l ZCBsZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7CisKKyAgICBpZiAoIWxlbmd0aCkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCisgICAgZG91YmxlIG51bWJlcjsKKyAgICBib29sIG9rOwogICAgIENT U1ByaW1pdGl2ZVZhbHVlOjpVbml0VHlwZXMgdW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf TlVNQkVSOwotICAgIGlmIChsZW5ndGggPiAyICYmIChjaGFyYWN0ZXJzW2xlbmd0aCAtIDJdIHwg MHgyMCkgPT0gJ3AnICYmIChjaGFyYWN0ZXJzW2xlbmd0aCAtIDFdIHwgMHgyMCkgPT0gJ3gnKSB7 Ci0gICAgICAgIGxlbmd0aCAtPSAyOwotICAgICAgICB1bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6 OkNTU19QWDsKLSAgICB9IGVsc2UgaWYgKGxlbmd0aCA+IDEgJiYgY2hhcmFjdGVyc1tsZW5ndGgg LSAxXSA9PSAnJScpIHsKLSAgICAgICAgbGVuZ3RoIC09IDE7Ci0gICAgICAgIHVuaXQgPSBDU1NQ cmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRBR0U7CisgICAgCisgICAgaWYgKHN0cmluZy5pczhC aXQoKSkgeworICAgICAgICBjb25zdCBMQ2hhciogY2hhcmFjdGVyczggPSBzdHJpbmcuY2hhcmFj dGVyczgoKTsKKyAgICAgICAgaWYgKCFjaGFyYWN0ZXJzOCkKKyAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgICAgICBpZiAoIWlzU2ltcGxlTGVuZ3RoUHJvcGVydHlJRChwcm9wZXJ0eUlk LCBhY2NlcHRzTmVnYXRpdmVOdW1iZXJzKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwor ICAgICAgICBpZiAobGVuZ3RoID4gMiAmJiAoY2hhcmFjdGVyczhbbGVuZ3RoIC0gMl0gfCAweDIw KSA9PSAncCcgJiYgKGNoYXJhY3RlcnM4W2xlbmd0aCAtIDFdIHwgMHgyMCkgPT0gJ3gnKSB7Cisg ICAgICAgICAgICBsZW5ndGggLT0gMjsKKyAgICAgICAgICAgIHVuaXQgPSBDU1NQcmltaXRpdmVW YWx1ZTo6Q1NTX1BYOworICAgICAgICB9IGVsc2UgaWYgKGxlbmd0aCA+IDEgJiYgY2hhcmFjdGVy czhbbGVuZ3RoIC0gMV0gPT0gJyUnKSB7CisgICAgICAgICAgICBsZW5ndGggLT0gMTsKKyAgICAg ICAgICAgIHVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRBR0U7CisgICAgICAg IH0KKworICAgICAgICAvLyBXZSByZWx5IG9uIGNoYXJhY3RlcnNUb0RvdWJsZSBmb3IgdmFsaWRh dGlvbiBhcyB3ZWxsLiBUaGUgZnVuY3Rpb24KKyAgICAgICAgLy8gd2lsbCBzZXQgIm9rIiB0byAi ZmFsc2UiIGlmIHRoZSBlbnRpcmUgcGFzc2VkLWluIGNoYXJhY3RlciByYW5nZSBkb2VzCisgICAg ICAgIC8vIG5vdCByZXByZXNlbnQgYSBkb3VibGUuCisgICAgICAgIG51bWJlciA9IGNoYXJhY3Rl cnNUb0RvdWJsZShjaGFyYWN0ZXJzOCwgbGVuZ3RoLCAmb2spOworICAgIH0gZWxzZSB7CisgICAg ICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzMTYgPSBzdHJpbmcuY2hhcmFjdGVyczE2KCk7Cisg ICAgICAgIGlmICghY2hhcmFjdGVyczE2KQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgICAgIGlmICghaXNTaW1wbGVMZW5ndGhQcm9wZXJ0eUlEKHByb3BlcnR5SWQsIGFjY2VwdHNO ZWdhdGl2ZU51bWJlcnMpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIGlm IChsZW5ndGggPiAyICYmIChjaGFyYWN0ZXJzMTZbbGVuZ3RoIC0gMl0gfCAweDIwKSA9PSAncCcg JiYgKGNoYXJhY3RlcnMxNltsZW5ndGggLSAxXSB8IDB4MjApID09ICd4JykgeworICAgICAgICAg ICAgbGVuZ3RoIC09IDI7CisgICAgICAgICAgICB1bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNT U19QWDsKKyAgICAgICAgfSBlbHNlIGlmIChsZW5ndGggPiAxICYmIGNoYXJhY3RlcnMxNltsZW5n dGggLSAxXSA9PSAnJScpIHsKKyAgICAgICAgICAgIGxlbmd0aCAtPSAxOworICAgICAgICAgICAg dW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUEVSQ0VOVEFHRTsKKyAgICAgICAgfQorCisg ICAgICAgIC8vIFdlIHJlbHkgb24gY2hhcmFjdGVyc1RvRG91YmxlIGZvciB2YWxpZGF0aW9uIGFz IHdlbGwuIFRoZSBmdW5jdGlvbgorICAgICAgICAvLyB3aWxsIHNldCAib2siIHRvICJmYWxzZSIg aWYgdGhlIGVudGlyZSBwYXNzZWQtaW4gY2hhcmFjdGVyIHJhbmdlIGRvZXMKKyAgICAgICAgLy8g bm90IHJlcHJlc2VudCBhIGRvdWJsZS4KKyAgICAgICAgbnVtYmVyID0gY2hhcmFjdGVyc1RvRG91 YmxlKGNoYXJhY3RlcnMxNiwgbGVuZ3RoLCAmb2spOwogICAgIH0KIAotICAgIC8vIFdlIHJlbHkg b24gY2hhcmFjdGVyc1RvRG91YmxlIGZvciB2YWxpZGF0aW9uIGFzIHdlbGwuIFRoZSBmdW5jdGlv bgotICAgIC8vIHdpbGwgc2V0ICJvayIgdG8gImZhbHNlIiBpZiB0aGUgZW50aXJlIHBhc3NlZC1p biBjaGFyYWN0ZXIgcmFuZ2UgZG9lcwotICAgIC8vIG5vdCByZXByZXNlbnQgYSBkb3VibGUuCi0g ICAgYm9vbCBvazsKLSAgICBkb3VibGUgbnVtYmVyID0gY2hhcmFjdGVyc1RvRG91YmxlKGNoYXJh Y3RlcnMsIGxlbmd0aCwgJm9rKTsKICAgICBpZiAoIW9rKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgaWYgKHVuaXQgPT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpIHsK