76648 2012-01-19 11:30:23 -0800 WebCore decodeEscapeSequences unnecessarily converts 8 bit strings to 16 bit when decoding. 2012-01-30 10:10:58 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 538849 0 msaboff 2012-01-19 11:30:23 -0800 This was found while tuning dromaeo tests. When decoding 8 bit strings, they are converted to 16 bits due to calls to characters(). 539046 1 123198 msaboff 2012-01-19 14:40:22 -0800 Created attachment 123198 Patch 539116 2 123198 ggaren 2012-01-19 15:57:09 -0800 Comment on attachment 123198 Patch r=me 545185 3 msaboff 2012-01-30 10:10:58 -0800 Committed r106253: <http://trac.webkit.org/changeset/106253> 123198 2012-01-19 14:40:22 -0800 2012-01-19 15:57:09 -0800 Patch 76648.patch text/plain 3411 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA1NDQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFdlYkNvcmUgZGVjb2RlRXNjYXBlU2VxdWVuY2VzIHVubmVjZXNzYXJpbHkgY29udmVydHMg OCBiaXQgc3RyaW5ncyB0byAxNiBiaXQgd2hlbiBkZWNvZGluZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBuZXcgb3ZlcmxvYWRlZCBhcHBl bmQgbWVtYmVyIHRoYXQgdGFrZXMgYSBTdHJpbmcmIGFyZ3VtZW50LCBhbiBvZmZlc3QKKyAgICAg ICAgYW5kIGEgbGVuZ3RoIHRvIGRvIGRpcmVjdCBzdWIgc3RyaW5nIGFwcGVuZGluZyB0byBhIFN0 cmluZ0J1aWxkZXIuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg6CisgICAg ICAgIChXVEY6OlN0cmluZ0J1aWxkZXI6OmFwcGVuZCk6CisKIDIwMTItMDEtMTkgIEdlb2ZmcmV5 IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsaWNpdCBjcmVhdGlvbiBv ZiBhIHJlZ3VsYXIgZXhwcmVzc2lvbiBzaG91bGQgZWFnZXJseSBjaGVjayBmb3Igc3ludGF4IGVy cm9ycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nQnVp bGRlci5oCShyZXZpc2lvbiAxMDU0MTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3Rl eHQvU3RyaW5nQnVpbGRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2NywyMCBAQCBwdWJs aWM6CiAgICAgICAgICAgICBhcHBlbmQoc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBzdHJpbmcubGVu Z3RoKCkpOwogICAgIH0KIAorICAgIHZvaWQgYXBwZW5kKGNvbnN0IFN0cmluZyYgc3RyaW5nLCB1 bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkKKyAgICB7CisgICAgICAgIGlmICghc3Ry aW5nLmxlbmd0aCgpKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmICgob2Zmc2V0 ICsgbGVuZ3RoKSA+IHN0cmluZy5sZW5ndGgoKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAg ICAgICBpZiAoc3RyaW5nLmlzOEJpdCgpKQorICAgICAgICAgICAgYXBwZW5kKHN0cmluZy5jaGFy YWN0ZXJzOCgpICsgb2Zmc2V0LCBsZW5ndGgpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBh cHBlbmQoc3RyaW5nLmNoYXJhY3RlcnMxNigpICsgb2Zmc2V0LCBsZW5ndGgpOworICAgIH0KKwog ICAgIHZvaWQgYXBwZW5kKGNvbnN0IGNoYXIqIGNoYXJhY3RlcnMpCiAgICAgewogICAgICAgICBp ZiAoY2hhcmFjdGVycykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTQ0NykKKysrIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEy LTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFdl YkNvcmUgZGVjb2RlRXNjYXBlU2VxdWVuY2VzIHVubmVjZXNzYXJpbHkgY29udmVydHMgOCBiaXQg c3RyaW5ncyB0byAxNiBiaXQgd2hlbiBkZWNvZGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXNpbmcgbmV3IG92ZXJsb2FkZWQgYXBwZW5kKFN0cmlu ZyYsIG9mZnNldCwgbGVuZ3RoKSAgbWVtYmVyIHRvIGJ1aWxkIHJlc3VsdCBzdHJpbmcuCisgICAg ICAgIFRoZSBuZXcgbWVtYmVyIHByb3Blcmx5IGhhbmRsZXMgOC8xNiBiaXQtbmVzcyBvZiBzdHJp bmdzLgorCisgICAgICAgIEZ1bmN0aW9uYWxpdHkgbm90IGNoYW5nZWQsIHRoZXJlZm9yZSBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0RlY29kZUVzY2FwZVNlcXVlbmNl cy5oOgorICAgICAgICAoV2ViQ29yZTo6ZGVjb2RlRXNjYXBlU2VxdWVuY2VzKToKKwogMjAxMi0w MS0xOSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAg IEltcGxlbWVudCBhIG5ldyBhbGxvY2F0b3IgZm9yIGJhY2tpbmcgc3RvcmVzCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RlY29kZUVzY2FwZVNlcXVlbmNlcy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGVjb2RlRXNjYXBlU2VxdWVuY2Vz LmgJKHJldmlzaW9uIDEwNTQxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGVj b2RlRXNjYXBlU2VxdWVuY2VzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOCwxMSArMTA4LDExIEBA IFN0cmluZyBkZWNvZGVFc2NhcGVTZXF1ZW5jZXMoY29uc3QgU3RyaW4KICAgICAgICAgaWYgKGRl Y29kZWQuaXNFbXB0eSgpKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgcmVzdWx0 LmFwcGVuZChzdHJpbmcuY2hhcmFjdGVycygpICsgZGVjb2RlZFBvc2l0aW9uLCBlbmNvZGVkUnVu UG9zaXRpb24gLSBkZWNvZGVkUG9zaXRpb24pOworICAgICAgICByZXN1bHQuYXBwZW5kKHN0cmlu ZywgZGVjb2RlZFBvc2l0aW9uLCBlbmNvZGVkUnVuUG9zaXRpb24gLSBkZWNvZGVkUG9zaXRpb24p OwogICAgICAgICByZXN1bHQuYXBwZW5kKGRlY29kZWQpOwogICAgICAgICBkZWNvZGVkUG9zaXRp b24gPSBlbmNvZGVkUnVuRW5kOwogICAgIH0KLSAgICByZXN1bHQuYXBwZW5kKHN0cmluZy5jaGFy YWN0ZXJzKCkgKyBkZWNvZGVkUG9zaXRpb24sIGxlbmd0aCAtIGRlY29kZWRQb3NpdGlvbik7Cisg ICAgcmVzdWx0LmFwcGVuZChzdHJpbmcsIGRlY29kZWRQb3NpdGlvbiwgbGVuZ3RoIC0gZGVjb2Rl ZFBvc2l0aW9uKTsKICAgICByZXR1cm4gcmVzdWx0LnRvU3RyaW5nKCk7CiB9CiAK