76645 2012-01-19 11:14:02 -0800 Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions 2012-01-26 11:24:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 538835 0 msaboff 2012-01-19 11:14:02 -0800 Many of the dromaeo tests end up using StringImpl::find() and ::reverseFind() including the IgnoreCase varieties. These methods don't have 8 bit string paths. 538877 1 123163 msaboff 2012-01-19 11:58:26 -0800 Created attachment 123163 Patch This appears to be neutral to slightly positive to sun spider and v8 performance. 539122 2 123163 ggaren 2012-01-19 15:59:10 -0800 Comment on attachment 123163 Patch I think you should factor out the shared hash-search code into a static helper function template, to avoid code duplication. 543318 3 msaboff 2012-01-26 11:24:11 -0800 Committed r106019: <http://trac.webkit.org/changeset/106019> 123163 2012-01-19 11:58:26 -0800 2012-01-19 15:59:10 -0800 Patch 76645.patch text/plain 5938 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA1NDMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTAxLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIERyb21hZW8gdGVzdHMgdXNhZ2Ugb2YgU3RyaW5nSW1wbCBmaW5kIHJvdXRpbmVzIGNhdXNl IDgtPjE2IGJpdCBjb252ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzY2NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAoV1RGOjpl cXVhbElnbm9yaW5nQ2FzZSk6IE5ldyBMQ2hhciB2ZXJzaW9uLgorICAgICAgICAoV1RGOjpTdHJp bmdJbXBsOjpmaW5kKTogQWRkZWQgOCBiaXQgcGF0aC4KKyAgICAgICAgKFdURjo6U3RyaW5nSW1w bDo6cmV2ZXJzZUZpbmQpOiBBZGRlZCA4IGJpdCBwYXRoLgorICAgICAgICAoV1RGOjpTdHJpbmdJ bXBsOjpyZXZlcnNlRmluZElnbm9yaW5nQ2FzZSk6IEFkZGVkIDggYml0IHBhdGguCisgICAgICAg ICogd3RmL3RleHQvU3RyaW5nSW1wbC5oOgorCiAyMDEyLTAxLTE5ICBKb2kgU2lndXJkc3NvbiAg PGpvaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRW5hYmxlIHVzZSBvZiBwcmVjb21waWxlZCBo ZWFkZXJzIGluIENocm9taXVtIHBvcnQgb24gV2luZG93cy4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAJKHJldmlzaW9uIDEwNTQxNSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzE1LDYgKzcxNSwxNiBAQCBmbG9hdCBTdHJpbmdJbXBsOjp0b0Zsb2F0KGJvb2wq IG9rLCBib29sCiAgICAgcmV0dXJuIGNoYXJhY3RlcnNUb0Zsb2F0KGNoYXJhY3RlcnMxNigpLCBt X2xlbmd0aCwgb2ssIGRpZFJlYWROdW1iZXIpOwogfQogCitib29sIGVxdWFsSWdub3JpbmdDYXNl KGNvbnN0IExDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQoreworICAg IHdoaWxlIChsZW5ndGgtLSkgeworICAgICAgICBMQ2hhciBiYyA9ICpiKys7CisgICAgICAgIGlm IChmb2xkQ2FzZSgqYSsrKSAhPSBmb2xkQ2FzZShiYykpCisgICAgICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgfQorICAgIHJldHVybiB0cnVlOworfQorCiBib29sIGVxdWFsSWdub3JpbmdDYXNl KGNvbnN0IFVDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQogewogICAg IHdoaWxlIChsZW5ndGgtLSkgewpAQCAtODc0LDYgKzg4NCwzMSBAQCBzaXplX3QgU3RyaW5nSW1w bDo6ZmluZChTdHJpbmdJbXBsKiBtYXRjCiAgICAgLy8gZGVsdGEgaXMgdGhlIG51bWJlciBvZiBh ZGRpdGlvbmFsIHRpbWVzIHRvIHRlc3Q7IGRlbHRhID09IDAgbWVhbnMgdGVzdCBvbmx5IG9uY2Uu CiAgICAgdW5zaWduZWQgZGVsdGEgPSBzZWFyY2hMZW5ndGggLSBtYXRjaExlbmd0aDsKIAorICAg IGlmIChpczhCaXQoKSAmJiBtYXRjaFN0cmluZy0+aXM4Qml0KCkpIHsKKyAgICAgICAgY29uc3Qg TENoYXIqIHNlYXJjaENoYXJhY3RlcnMgPSBjaGFyYWN0ZXJzOCgpICsgaW5kZXg7CisgICAgICAg IGNvbnN0IExDaGFyKiBtYXRjaENoYXJhY3RlcnMgPSBtYXRjaFN0cmluZy0+Y2hhcmFjdGVyczgo KTsKKworICAgICAgICAvLyBPcHRpbWl6YXRpb24gMjoga2VlcCBhIHJ1bm5pbmcgaGFzaCBvZiB0 aGUgc3RyaW5ncywKKyAgICAgICAgLy8gb25seSBjYWxsIG1lbWNtcCBpZiB0aGUgaGFzaGVzIG1h dGNoLgorICAgICAgICB1bnNpZ25lZCBzZWFyY2hIYXNoID0gMDsKKyAgICAgICAgdW5zaWduZWQg bWF0Y2hIYXNoID0gMDsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1hdGNoTGVu Z3RoOyArK2kpIHsKKyAgICAgICAgICAgIHNlYXJjaEhhc2ggKz0gc2VhcmNoQ2hhcmFjdGVyc1tp XTsKKyAgICAgICAgICAgIG1hdGNoSGFzaCArPSBtYXRjaENoYXJhY3RlcnNbaV07CisgICAgICAg IH0KKyAKKyAgICAgICAgdW5zaWduZWQgaSA9IDA7CisgICAgICAgIC8vIGtlZXAgbG9vcGluZyB1 bnRpbCB3ZSBtYXRjaAorICAgICAgICB3aGlsZSAoc2VhcmNoSGFzaCAhPSBtYXRjaEhhc2ggfHwg bWVtY21wKHNlYXJjaENoYXJhY3RlcnMgKyBpLCBtYXRjaENoYXJhY3RlcnMsIG1hdGNoTGVuZ3Ro ICogc2l6ZW9mKExDaGFyKSkpIHsKKyAgICAgICAgICAgIGlmIChpID09IGRlbHRhKQorICAgICAg ICAgICAgICAgIHJldHVybiBub3RGb3VuZDsKKyAgICAgICAgICAgIHNlYXJjaEhhc2ggKz0gc2Vh cmNoQ2hhcmFjdGVyc1tpICsgbWF0Y2hMZW5ndGhdOworICAgICAgICAgICAgc2VhcmNoSGFzaCAt PSBzZWFyY2hDaGFyYWN0ZXJzW2ldOworICAgICAgICAgICAgKytpOworICAgICAgICB9CisgICAg ICAgIHJldHVybiBpbmRleCArIGk7ICAgICAgICAKKyAgICB9CisKICAgICBjb25zdCBVQ2hhciog c2VhcmNoQ2hhcmFjdGVycyA9IGNoYXJhY3RlcnMoKSArIGluZGV4OwogICAgIGNvbnN0IFVDaGFy KiBtYXRjaENoYXJhY3RlcnMgPSBtYXRjaFN0cmluZy0+Y2hhcmFjdGVycygpOwogCkBAIC05NTgs NiArOTkzLDMwIEBAIHNpemVfdCBTdHJpbmdJbXBsOjpyZXZlcnNlRmluZChTdHJpbmdJbXAKICAg ICAvLyBkZWx0YSBpcyB0aGUgbnVtYmVyIG9mIGFkZGl0aW9uYWwgdGltZXMgdG8gdGVzdDsgZGVs dGEgPT0gMCBtZWFucyB0ZXN0IG9ubHkgb25jZS4KICAgICB1bnNpZ25lZCBkZWx0YSA9IG1pbihp bmRleCwgbGVuZ3RoKCkgLSBtYXRjaExlbmd0aCk7CiAKKyAgICBpZiAoaXM4Qml0KCkgJiYgbWF0 Y2hTdHJpbmctPmlzOEJpdCgpKSB7CisgICAgICAgIGNvbnN0IExDaGFyICpzZWFyY2hDaGFyYWN0 ZXJzID0gY2hhcmFjdGVyczgoKTsKKyAgICAgICAgY29uc3QgTENoYXIgKm1hdGNoQ2hhcmFjdGVy cyA9IG1hdGNoU3RyaW5nLT5jaGFyYWN0ZXJzOCgpOworCisgICAgICAgIC8vIE9wdGltaXphdGlv biAyOiBrZWVwIGEgcnVubmluZyBoYXNoIG9mIHRoZSBzdHJpbmdzLAorICAgICAgICAvLyBvbmx5 IGNhbGwgbWVtY21wIGlmIHRoZSBoYXNoZXMgbWF0Y2guCisgICAgICAgIHVuc2lnbmVkIHNlYXJj aEhhc2ggPSAwOworICAgICAgICB1bnNpZ25lZCBtYXRjaEhhc2ggPSAwOworICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgbWF0Y2hMZW5ndGg7ICsraSkgeworICAgICAgICAgICAgc2Vh cmNoSGFzaCArPSBzZWFyY2hDaGFyYWN0ZXJzW2RlbHRhICsgaV07CisgICAgICAgICAgICBtYXRj aEhhc2ggKz0gbWF0Y2hDaGFyYWN0ZXJzW2ldOworICAgICAgICB9CisKKyAgICAgICAgLy8ga2Vl cCBsb29waW5nIHVudGlsIHdlIG1hdGNoCisgICAgICAgIHdoaWxlIChzZWFyY2hIYXNoICE9IG1h dGNoSGFzaCB8fCBtZW1jbXAoc2VhcmNoQ2hhcmFjdGVycyArIGRlbHRhLCBtYXRjaENoYXJhY3Rl cnMsIG1hdGNoTGVuZ3RoICogc2l6ZW9mKExDaGFyKSkpIHsKKyAgICAgICAgICAgIGlmICghZGVs dGEpCisgICAgICAgICAgICAgICAgcmV0dXJuIG5vdEZvdW5kOworICAgICAgICAgICAgZGVsdGEt LTsKKyAgICAgICAgICAgIHNlYXJjaEhhc2ggLT0gc2VhcmNoQ2hhcmFjdGVyc1tkZWx0YSArIG1h dGNoTGVuZ3RoXTsKKyAgICAgICAgICAgIHNlYXJjaEhhc2ggKz0gc2VhcmNoQ2hhcmFjdGVyc1tk ZWx0YV07CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIGRlbHRhOworICAgIH0KKwogICAgIGNv bnN0IFVDaGFyICpzZWFyY2hDaGFyYWN0ZXJzID0gY2hhcmFjdGVycygpOwogICAgIGNvbnN0IFVD aGFyICptYXRjaENoYXJhY3RlcnMgPSBtYXRjaFN0cmluZy0+Y2hhcmFjdGVycygpOwogCkBAIC05 OTUsNyArMTA1NCwyMCBAQCBzaXplX3QgU3RyaW5nSW1wbDo6cmV2ZXJzZUZpbmRJZ25vcmluZ0Nh CiAgICAgICAgIHJldHVybiBub3RGb3VuZDsKICAgICAvLyBkZWx0YSBpcyB0aGUgbnVtYmVyIG9m IGFkZGl0aW9uYWwgdGltZXMgdG8gdGVzdDsgZGVsdGEgPT0gMCBtZWFucyB0ZXN0IG9ubHkgb25j ZS4KICAgICB1bnNpZ25lZCBkZWx0YSA9IG1pbihpbmRleCwgbGVuZ3RoKCkgLSBtYXRjaExlbmd0 aCk7Ci0gICAgCisKKyAgICBpZiAoaXM4Qml0KCkgJiYgbWF0Y2hTdHJpbmctPmlzOEJpdCgpKSB7 CisgICAgICAgIGNvbnN0IExDaGFyICpzZWFyY2hDaGFyYWN0ZXJzID0gY2hhcmFjdGVyczgoKTsK KyAgICAgICAgY29uc3QgTENoYXIgKm1hdGNoQ2hhcmFjdGVycyA9IG1hdGNoU3RyaW5nLT5jaGFy YWN0ZXJzOCgpOworCisgICAgICAgIC8vIGtlZXAgbG9vcGluZyB1bnRpbCB3ZSBtYXRjaAorICAg ICAgICB3aGlsZSAoIWVxdWFsSWdub3JpbmdDYXNlKHNlYXJjaENoYXJhY3RlcnMgKyBkZWx0YSwg bWF0Y2hDaGFyYWN0ZXJzLCBtYXRjaExlbmd0aCkpIHsKKyAgICAgICAgICAgIGlmICghZGVsdGEp CisgICAgICAgICAgICAgICAgcmV0dXJuIG5vdEZvdW5kOworICAgICAgICAgICAgZGVsdGEtLTsK KyAgICAgICAgfQorICAgICAgICByZXR1cm4gZGVsdGE7CisgICAgfQorCiAgICAgY29uc3QgVUNo YXIgKnNlYXJjaENoYXJhY3RlcnMgPSBjaGFyYWN0ZXJzKCk7CiAgICAgY29uc3QgVUNoYXIgKm1h dGNoQ2hhcmFjdGVycyA9IG1hdGNoU3RyaW5nLT5jaGFyYWN0ZXJzKCk7CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gMTA1NDE1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkod29ya2lu ZyBjb3B5KQpAQCAtNzE4LDYgKzcxOCw3IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25z dCBVQ2hhciogYSwKIFdURl9FWFBPUlRfUFJJVkFURSBib29sIGVxdWFsSWdub3JpbmdDYXNlKFN0 cmluZ0ltcGwqLCBTdHJpbmdJbXBsKik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBlcXVhbEln bm9yaW5nQ2FzZShTdHJpbmdJbXBsKiwgY29uc3QgTENoYXIqKTsKIGlubGluZSBib29sIGVxdWFs SWdub3JpbmdDYXNlKGNvbnN0IExDaGFyKiBhLCBTdHJpbmdJbXBsKiBiKSB7IHJldHVybiBlcXVh bElnbm9yaW5nQ2FzZShiLCBhKTsgfQorV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgZXF1YWxJZ25v cmluZ0Nhc2UoY29uc3QgTENoYXIqLCBjb25zdCBMQ2hhciosIHVuc2lnbmVkKTsKIFdURl9FWFBP UlRfUFJJVkFURSBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNvbnN0IFVDaGFyKiwgY29uc3QgTENo YXIqLCB1bnNpZ25lZCk7CiBpbmxpbmUgYm9vbCBlcXVhbElnbm9yaW5nQ2FzZShjb25zdCBVQ2hh ciogYSwgY29uc3QgY2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKSB7IHJldHVybiBlcXVhbElnbm9y aW5nQ2FzZShhLCByZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4oYiksIGxlbmd0aCk7IH0K IGlubGluZSBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNvbnN0IExDaGFyKiBhLCBjb25zdCBVQ2hh ciogYiwgdW5zaWduZWQgbGVuZ3RoKSB7IHJldHVybiBlcXVhbElnbm9yaW5nQ2FzZShiLCBhLCBs ZW5ndGgpOyB9Cg==